fix(core/player): clamp vendor purchase quantity before validation

2026-07-25 08:46:40 -07:00
parent 5af9d71a8f
commit d89d733051
4 changed files with 606 additions and 0 deletions
@@ -0,0 +1,87 @@
+-- ArgusCore DB Error Cleanup
+-- Fixes all HIGH and MEDIUM priority errors from DBErrors.log
+-- Source analysis: logs/database errors/DBErrors.log (44 MB, 13 startup cycles)
+-- No equivalent fix found in LegionCore/SkyFire/TrinityCore-Cata/TrinityCore-master SQL logs.
+
+-- ============================================================
+-- 1. spell_custom_attr — delete entries for non-existent spells
+--    Error: "Table `spell_custom_attr` has wrong spell (entry: 48517/48518), ignored."
+--    Spells 48517 and 48518 do not exist in 7.3.5 DBC.
+-- ============================================================
+
+DELETE FROM `spell_custom_attr` WHERE `entry` IN (48517, 48518);
+
+-- ============================================================
+-- 2. spell_custom_attr — delete entries for spells whose only attribute
+--    is SPELL_ATTR0_CU_SHARE_DAMAGE (0x8) but have no SPELL_EFFECT_SCHOOL_DAMAGE.
+--    Error: "Spell 66765/66809 listed in table `spell_custom_attr` with
+--    SPELL_ATTR0_CU_SHARE_DAMAGE has no SPELL_EFFECT_SCHOOL_DAMAGE, ignored."
+--    Confirmed: both entries have attributes = 8 only (TDB_world_735.26972_2025_05_11.sql).
+--    The flag is invalid for these spells; no other custom attrs are set.
+-- ============================================================
+
+DELETE FROM `spell_custom_attr` WHERE `entry` IN (66765, 66809) AND `attributes` = 8;
+
+-- ============================================================
+-- 3. spell_proc — delete entries for spells that don't exist in 7.3.5 DBC.
+--    Error: "The spell XXXXX listed in `spell_proc` does not exist"
+--    Note: 257506, 342076, 452409 already fixed in earlier ArgusCore updates.
+-- ============================================================
+
+DELETE FROM `spell_proc` WHERE `SpellId` IN (
+    47515,   -- Divine Aegis (removed from DBC in 7.x)
+    132158,
+    135286,
+    135288,
+    255148,
+    255150,
+    255151,
+    255800,
+    258881,
+    260895,
+    265259
+);
+
+-- ============================================================
+-- 4. transports — remove Seething Shore transport ships.
+--    Error: "Table `transports` have transport (GUID: 35/36 Entry: 278407/279254)
+--    with unknown gameobject `entry` set, skipped."
+--    278407 (Sword of Dawn) and 279254 (The Warbringer) are BfA-only BG
+--    transport ships with no GO template in the 7.3.5 DB.
+-- ============================================================
+
+-- Deleting by `entry` (not `guid`) because GUIDs were assigned via @TGUID variable
+-- at insert time (sql/old/7/world/03_2025_05_11/2024_07_10_00_world.sql) and are not stable.
+DELETE FROM `transports` WHERE `entry` IN (278407, 279254);
+
+-- ============================================================
+-- 5. battleground_scripts — remove map IDs that don't exist in 7.3.5.
+--    Error: "BattlegroundMgr::LoadBattlegroundScriptTemplate: bad mapid 2106/2107!"
+--    Map 2106 (new Warsong Gulch) and 2107 (new Arathi Basin) are BfA maps
+--    not present in the 7.3.5 client MapEntry DBC.
+-- ============================================================
+
+DELETE FROM `battleground_scripts` WHERE `MapId` IN (2106, 2107);
+
+-- ============================================================
+-- 6. command — remove entries for debug commands removed from code.
+--    Error: "Table `command` contains data for non-existant command 'debug XXXX'. Skipped."
+-- ============================================================
+
+DELETE FROM `command` WHERE `name` IN (
+    'debug getitemvalue',
+    'debug getvalue',
+    'debug Mod32Value',
+    'debug setbit',
+    'debug setitemvalue',
+    'debug setvalue',
+    'debug update'
+);
+
+-- ============================================================
+-- 7. disables — remove phase 11595 which doesn't exist in Phase.db2.
+--    Error: "Phase entry 11595 from `disables` doesn't exist in dbc, skipped."
+--    sourceType 9 = DISABLE_TYPE_PHASE_AREA (DisableMgr.h:36)
+-- ============================================================
+
+DELETE FROM `disables` WHERE `sourceType` = 9 AND `entry` = 11595;