Синхронизация upstream и оптимизация постобработки MoonWell (#12)
Синхронизация с upstream до e2aeaecf: исправления AccessKit на Windows, прокрутки трекпада на Linux и анимации моделей в меню.
MoonWell: расчёт рассеяния, вторичного освещения и AO перенесён в половинное разрешение с восстановлением по глубине. В контрольной сцене RTX 5070 суммарное время постобработки снизилось с 6,41 до 3,47 мс. При выключенном расширении изображение совпадает с исходным. Добавлен анализатор диагностических логов GPU.
Исправлена подготовка тестов интерфейса и обработка отсутствующих кинороликов в сокращённой установке. Уточнены причины существующих отклонений русского пакета и HD-атласа.
Проверки: 46 тестов графического модуля и сравнения дневных/ночных кадров пройдены; полный цикл scripts/gates.sh пройден: fmt, Clippy workspace и player, reference, тесты с установкой и без неё, документация, каталог сообщений, проверка GPU-проходов и запуск движка с данными и без. Проверки отсутствующих аддонов и четырёх кинороликов явно пропущены. Живой вход/выход на сервер не выполнялся.
This commit was merged in pull request #12.
This commit is contained in:
+13
-13
@@ -76,8 +76,8 @@ Each entry is the first sentence of a `Deviation:` comment, linking to where it
|
||||
#### bindings
|
||||
|
||||
- A press with Super (Cmd) held runs no binding because that way a system chord such as Cmd+Tab or Cmd+Q never acts in game. The reference has no such modifier and runs the bare key's binding: the Mac enqueues the key with Command held and skips only its text (`mac:08a51e`), and Windows hands `VK_LWIN`/`VK_RWIN` to the layout arm (`0x42da39`) like any key. ([`src/bindings.rs:19`](../crates/benilla-app/src/bindings.rs#L19))
|
||||
- A trackpad's `Pixel` deltas are carried until they make a line, and step at most once per event (`crate::ui_script::Record::Wheel`). The reference steps on every `WM_MOUSEWHEEL`, whatever its delta (`0x76c1a9`); the carry is kept because a carried trackpad does not zoom or scroll at its event rate. ([`src/bindings.rs:637`](../crates/benilla-app/src/bindings.rs#L637))
|
||||
- Latches die with the VM that made them, because a latch names a command of that VM's table and releasing it against a new one would run another load's up-half. The reference keeps a held key running through `ReloadUI`; here it re-latches on its next press. The held bits die with it, as the key's Stop would have cleared them. ([`src/bindings.rs:682`](../crates/benilla-app/src/bindings.rs#L682))
|
||||
- A trackpad's `Pixel` deltas are carried until they make a line, and an event steps once per whole line on Wayland and at most once elsewhere (`Self::feed_pixels`). The reference steps on every `WM_MOUSEWHEEL`, whatever its delta (`0x76c1a9`); the carry is kept because a carried trackpad does not zoom or scroll at its event rate, and Wayland takes every whole line because a 10-pixel notch capped per event would lose a fast swipe's travel. ([`src/bindings.rs:642`](../crates/benilla-app/src/bindings.rs#L642))
|
||||
- Latches die with the VM that made them, because a latch names a command of that VM's table and releasing it against a new one would run another load's up-half. The reference keeps a held key running through `ReloadUI`; here it re-latches on its next press. The held bits die with it, as the key's Stop would have cleared them. ([`src/bindings.rs:699`](../crates/benilla-app/src/bindings.rs#L699))
|
||||
- The Z key is named `Z` on a Mac too, because the Mac client uppercases only `a`-`y` (`mac:08a3df`) and so names it `z`, which no binding can press; that fault would leave a binding to `Z`, the stock `TOGGLESHEATH` key, unreachable there. ([`src/bindings/chord.rs:111`](../crates/benilla-app/src/bindings/chord.rs#L111))
|
||||
- The Windows key table stops at `VK_F12` and drops later F-keys; they are named here because that way a stored `F13`-`F24` can be pressed. ([`src/bindings/chord.rs:171`](../crates/benilla-app/src/bindings/chord.rs#L171))
|
||||
- On the Mac and Linux a key its platform reports no character for keeps its US name too, where the Mac reference drops it (`mac:08a4aa`), and a Linux dead key not yet pressed bare stays bindable. ([`src/bindings/layout.rs:116`](../crates/benilla-app/src/bindings/layout.rs#L116))
|
||||
@@ -225,7 +225,7 @@ Each entry is the first sentence of a `Deviation:` comment, linking to where it
|
||||
- Only the four party slots hand over, capped at `Self::CAP`, instead of every portrait until `ClientDestroyGame` (`0x401ee0`), because a general cache would pay a texture per unit ever seen. ([`src/portrait/mod.rs:265`](../crates/benilla-app/src/portrait/mod.rs#L265))
|
||||
- This reads the window's aspect, not `gxResolution`'s, because the window here takes any shape a drag gives it, where the reference's keeps `gxResolution`'s (`0x5989d7`). In fullscreen the window is the screen in logical pixels and `gxResolution` the screen in device pixels, so their aspects agree and their sizes need not. ([`src/portrait/mod.rs:694`](../crates/benilla-app/src/portrait/mod.rs#L694))
|
||||
- `boothHalfRate` is benilla's own CVar, because the reference draws its doll in the main pass and has no second view; a full-rate pass costs up to 7.6 ms a frame at 4K. ([`src/portrait/mod.rs:733`](../crates/benilla-app/src/portrait/mod.rs#L733))
|
||||
- The reference widget draws only its model; a body pane clears to near-black, the chosen look where nothing sits behind the pane. ([`src/portrait/mod.rs:991`](../crates/benilla-app/src/portrait/mod.rs#L991))
|
||||
- The reference widget draws only its model; a body pane clears to near-black, the chosen look where nothing sits behind the pane. ([`src/portrait/mod.rs:999`](../crates/benilla-app/src/portrait/mod.rs#L999))
|
||||
|
||||
#### quest_markers
|
||||
|
||||
@@ -501,7 +501,7 @@ Each entry is the first sentence of a `Deviation:` comment, linking to where it
|
||||
|
||||
- `gxWindow "0"` is borderless fullscreen, not 1.12's exclusive mode-set at `gxResolution`, because Wayland has no client mode-setting (winit ignores `Fullscreen::Exclusive` there), and X11's XRandR changes the desktop's mode and a crash leaves it changed. Bevy's `WindowMode::Fullscreen` also panics on a live change that cannot resolve a monitor (`bevy_winit::winit_windows:91`, `system.rs:333`). ([`src/video.rs:5`](../crates/benilla-app/src/video.rs#L5))
|
||||
- On Windows, NVIDIA's Vulkan driver (610.88 seen) crashes inside `vkQueuePresentKHR` on the first present after any swapchain resize while the present mode is `Fifo`, `FifoRelaxed` or `AutoVsync` (a maximize is a resize). The fault is in the driver's own DXGI present (`d3d11.dll`): it stays with `VK_LAYER_NV_present` disabled, and the validation layer reports nothing before it. `Mailbox`, `AutoNoVsync` and DX12 survive, so there "vsync on" is `AutoNoVsync` paced to the monitor's refresh rate (`present_choice`) because that keeps the synced look without the crash. `$WOW_PRESENT=fifo` restores plain `Fifo`. ([`src/video.rs:17`](../crates/benilla-app/src/video.rs#L17))
|
||||
- Sizes are logical px, because the windowed `gxResolution` is a logical inner size here. Read at each verb (`DisplayLive`), so the list follows the display and `widescreen`; the reference builds its list once and never invalidates it. ([`src/video.rs:619`](../crates/benilla-app/src/video.rs#L619))
|
||||
- Sizes are logical px, because the windowed `gxResolution` is a logical inner size here. Read at each verb (`DisplayLive`), so the list follows the display and `widescreen`; the reference builds its list once and never invalidates it. ([`src/video.rs:639`](../crates/benilla-app/src/video.rs#L639))
|
||||
|
||||
#### vplates
|
||||
|
||||
@@ -554,14 +554,14 @@ Each entry is the first sentence of a `Deviation:` comment, linking to where it
|
||||
#### chain
|
||||
|
||||
- An archive that fails to open is an error. In 1.12.1 a failed base archive is fatal (Error #134: `0x4038ea` → `0x64d0e0` → `0x64cfa0` → `0x64cc80`, `ExitProcess`) and only a failing patch archive is skipped, silently; benilla fails on that too, because a skipped corrupt archive surfaces only as missing files far downstream. ([`src/chain.rs:122`](../crates/benilla-formats/src/chain.rs#L122))
|
||||
- `$WOW_LOCALE` or an installed `Data/ruRU` selects a language pack (`crate::ClientLocale::for_install`); without one the stock `Wow.ini` locale stands. ([`src/chain.rs:193`](../crates/benilla-formats/src/chain.rs#L193))
|
||||
- The community ruRU pack's archives mount after the base chain, from `Data/ruRU`, which 1.12.1 never reads. ([`src/chain.rs:204`](../crates/benilla-formats/src/chain.rs#L204))
|
||||
- A last line with no CR or LF after it is passed too, because `0x648fb0` ends at the buffer's end without a flush (`0x64907f`) and drops it, a bug that loses a listfile's last name when it lacks a newline. ([`src/chain.rs:342`](../crates/benilla-formats/src/chain.rs#L342))
|
||||
- `$WOW_LOCALE` or an installed `Data/ruRU` selects a language pack (`crate::ClientLocale::for_install`); without one the stock `Wow.ini` locale stands, because MoonWell supports the community language pack alongside stock data. ([`src/chain.rs:193`](../crates/benilla-formats/src/chain.rs#L193))
|
||||
- The community ruRU pack's archives mount after the base chain, from `Data/ruRU`, because that community pack keeps its localized overrides there instead of in the stock chain. ([`src/chain.rs:204`](../crates/benilla-formats/src/chain.rs#L204))
|
||||
- A last line with no CR or LF after it is passed too, because `0x648fb0` ends at the buffer's end without a flush (`0x64907f`) and drops it, a bug that loses a listfile's last name when it lacks a newline. ([`src/chain.rs:343`](../crates/benilla-formats/src/chain.rs#L343))
|
||||
|
||||
#### characters
|
||||
|
||||
- Blends in 8-bit RGBA, not the client's RGB565 with 2-bit coverage, because that format only saves texture memory and loses precision. ([`src/characters/sections.rs:308`](../crates/benilla-formats/src/characters/sections.rs#L308))
|
||||
- The reference composites at 256² only; VanillaHelpers' `ResizeCharacterSkin` convention scales it for high-resolution texture packs. ([`src/characters/sections.rs:328`](../crates/benilla-formats/src/characters/sections.rs#L328))
|
||||
- The reference composites at 256² only; VanillaHelpers' `ResizeCharacterSkin` convention scales it because high-resolution texture packs would otherwise lose their detail when composited onto the stock atlas. ([`src/characters/sections.rs:328`](../crates/benilla-formats/src/characters/sections.rs#L328))
|
||||
|
||||
#### creature_families
|
||||
|
||||
@@ -582,11 +582,11 @@ Each entry is the first sentence of a `Deviation:` comment, linking to where it
|
||||
|
||||
#### language_pack
|
||||
|
||||
- The community 1.12 ruRU pack lives in `Data/ruRU` and overlays the vanilla chain. Its DBCs keep the 1.12 layout and put Russian strings in slot zero, like the base tables. ([`src/language_pack.rs:3`](../crates/benilla-formats/src/language_pack.rs#L3))
|
||||
- The community 1.12 ruRU pack lives in `Data/ruRU` and overlays the vanilla chain. It mounts because MoonWell supports that community pack alongside the stock install. Its DBCs keep the 1.12 layout and put Russian strings in slot zero, like the base tables. ([`src/language_pack.rs:3`](../crates/benilla-formats/src/language_pack.rs#L3))
|
||||
|
||||
#### locale
|
||||
|
||||
- A ruRU tag, any case, names itself. The community ruRU pack (`crate::ClientLocale`) keeps its Russian strings in column 0, the index the table's lack of ruRU leaves, but its interface asks `GetLocale` for "ruRU". ([`src/locale.rs:56`](../crates/benilla-formats/src/locale.rs#L56))
|
||||
- A ruRU tag, any case, names itself. The community ruRU pack (`crate::ClientLocale`) keeps its Russian strings in column 0, the index the table's lack of ruRU leaves, but its interface asks `GetLocale` for "ruRU", because its localized UI branches on that name. ([`src/locale.rs:56`](../crates/benilla-formats/src/locale.rs#L56))
|
||||
|
||||
#### loose
|
||||
|
||||
@@ -754,13 +754,13 @@ Each entry is the first sentence of a `Deviation:` comment, linking to where it
|
||||
- The slot is read before the handler, where the reference reads it after (`[esi+0x4dc]`), because reading first keeps the borrow simple and no stock handler re-slots its row. Shift, ctrl or alt suppresses the take (`0x4c183a`/`0x4c1848`/ `0x4c1856`). ([`src/script/button.rs:1213`](../crates/benilla-ui/src/script/button.rs#L1213))
|
||||
- The reference's only bound is `luaD_call`'s count of 200 nested calls (`0x6f65ae`), past which it raises `C stack overflow` (`0x6f65bf`); eight here, because each level keeps an apply's frame on the Rust stack. ([`src/script/calls.rs:701`](../crates/benilla-ui/src/script/calls.rs#L701))
|
||||
- The reference composes the Shortcut with `GetRealZoneText` alone (`0x49efe8`), so in a capital `/leave Trade` sends `Trade - Stormwind City` and leaves nothing; ours uses the join's city-aware name, because the reference's form cannot leave the channel it joined. The slot is freed app-side when the server's `YOU_LEFT` arrives. ([`src/script/channel.rs:535`](../crates/benilla-ui/src/script/channel.rs#L535))
|
||||
- The community ruRU pack accepts Russian names up to twelve letters, while retaining the stock Latin alternative. The server remains the naming-policy authority. ([`src/script/char_name.rs:139`](../crates/benilla-ui/src/script/char_name.rs#L139))
|
||||
- The community ruRU pack accepts Russian names up to twelve letters, while retaining the stock Latin alternative, because its users need to enter Cyrillic character names. The server remains the naming-policy authority. ([`src/script/char_name.rs:139`](../crates/benilla-ui/src/script/char_name.rs#L139))
|
||||
- The frame's bottom-left origin is snapped onto the device grid because that way the border art blits 1:1; the reference ceils the anchor point itself onto it (`0x7666a0`, `0x766750`). ([`src/script/chat_bubble.rs:482`](../crates/benilla-ui/src/script/chat_bubble.rs#L482))
|
||||
- No truncation at 255 characters (`0x49f604`), because vmangos refuses a longer line itself (`Chat.cpp:2177`): it is dropped where the reference sends its first 255. The server throttles in both. ([`src/script/chat_send.rs:26`](../crates/benilla-ui/src/script/chat_send.rs#L26))
|
||||
- A value outside 0..1 clamps, where the reference keeps the low byte (alpha 2.0 stores 254, -1.0 stores 1), because no FrameXML or addon caller passes one. ([`src/script/chat_window.rs:17`](../crates/benilla-ui/src/script/chat_window.rs#L17))
|
||||
- An id outside the seven built windows raises, where the reference serves ten records and silently ignores any other id (`0x4a0be1`), because benilla keeps only the seven and every caller loops `1, NUM_CHAT_WINDOWS`. ([`src/script/chat_window.rs:221`](../crates/benilla-ui/src/script/chat_window.rs#L221))
|
||||
- One past `i32::MAX` clamps where the reference keeps the low 32 bits, for the colours' reason. ([`src/script/chat_window.rs:481`](../crates/benilla-ui/src/script/chat_window.rs#L481))
|
||||
- ruRU is a community overlay over DBC column zero, outside the stock table. ([`src/script/client.rs:379`](../crates/benilla-ui/src/script/client.rs#L379))
|
||||
- ruRU is a community overlay over DBC column zero, because the supported community pack supplies Russian strings there rather than in a stock locale slot. ([`src/script/client.rs:379`](../crates/benilla-ui/src/script/client.rs#L379))
|
||||
- The reference reads the clock live at each call (`0x42c010`); ours is the session clock the tick advances by the paced frame step, one value per frame, because that way `GetTime()` deltas and the `elapsed` handed to OnUpdate agree, as FrameXML (CastingBarFrame and kin) assumes. ([`src/script/clock.rs:64`](../crates/benilla-ui/src/script/clock.rs#L64))
|
||||
- With no wheel it scales by the strip's, because the reference reads the missing wheel unguarded. ([`src/script/colorselect.rs:379`](../crates/benilla-ui/src/script/colorselect.rs#L379))
|
||||
- The reference's `set` registers an unknown name as a new category-5 record (`0x63d569`-`0x63d582`); benilla refuses it, because nothing would read the row and `config.toml` keeps an unknown key anyway. ([`src/script/console_exec.rs:123`](../crates/benilla-ui/src/script/console_exec.rs#L123))
|
||||
@@ -805,7 +805,7 @@ Each entry is the first sentence of a `Deviation:` comment, linking to where it
|
||||
- The `/cast` argument is trimmed, because the reference binds `/cast Fireball` (two spaces) to a name that never resolves. ([`src/script/macros/bind.rs:63`](../crates/benilla-ui/src/script/macros/bind.rs#L63))
|
||||
- The client's Lua has no such bound, as nothing sets a hook (`lua_sethook`, `0x6fba40`, has no caller and no pointer to it), so a load that never ends hangs it; benilla bounds it because a hung load would otherwise freeze the loading screen instead of reporting. ([`src/script/mod.rs:959`](../crates/benilla-ui/src/script/mod.rs#L959))
|
||||
- The reference sets the cells only when glue or the interface is built, `0x41ad10` from `0x46a828` (`0x46a7b0`) and `0x48fe2b` (`0x48fbf0`), and a resize reaches them only through the rebuild it asks for. In glue `0x46abe0` sets the rebuild flag `0xb41d8c` when the aspect moves by 0.01 or more (`fcomp` at `0x46ac66`); in game `0x492e90` reloads the interface (`0x491380`) past 0.001 (`0x492f26`, `0x492f31`). The gate and the rebuild both take the aspect from `gxResolution` (`0x46ab40`, `0x4901e0`; 4/3 while `widescreen` is off), never the live window. Here every resize sets the cells from the window, because the UI is kept live across a resize. A dragged frame with no layout-cache row (unnamed, or `SetUserPlaced(false)`) keeps its drag pin in layout units, where the rebuild would put it back where its script places it. ([`src/script/mod.rs:1048`](../crates/benilla-ui/src/script/mod.rs#L1048))
|
||||
- The community ruRU pack reads column zero but names its own language. ([`src/script/model.rs:727`](../crates/benilla-ui/src/script/model.rs#L727))
|
||||
- The community ruRU pack reads column zero but names its own language, because its interface branches on `GetLocale` returning "ruRU". ([`src/script/model.rs:727`](../crates/benilla-ui/src/script/model.rs#L727))
|
||||
- A path that does not resolve is stored, where the reference raises `Invalid model file: %s` (`0x878b44`), because the file loads asynchronously here and the call cannot know yet. ([`src/script/modelframe.rs:333`](../crates/benilla-ui/src/script/modelframe.rs#L333))
|
||||
- The reference's free list is FIFO (`0x6087f0`, `0x608a5a`); either keeps every index stable, all an addon can observe of the pool's order. ([`src/script/nameplate.rs:807`](../crates/benilla-ui/src/script/nameplate.rs#L807))
|
||||
- The reference adds this rim over the bar; we brighten the bar (`LIT_BOOST`), because the rim reads as hard edge lines in our linear-blending pipeline. The art has no alpha and is mostly black, so as BLEND it would be an opaque box. ([`src/script/nameplate.rs:1430`](../crates/benilla-ui/src/script/nameplate.rs#L1430))
|
||||
|
||||
+2
-1
@@ -197,7 +197,7 @@
|
||||
- `WOW_BOOTH_LOG` — benilla-app/src/portrait/mod.rs
|
||||
- `WOW_CAM_CHANGED` — benilla-app/src/perf/mod.rs
|
||||
- `WOW_CAM_DUMP` — benilla-app/src/player/camera.rs
|
||||
- `WOW_CAPTURE` — benilla-app/src/account_data/sections.rs, benilla-app/src/account_data/tests.rs, benilla-app/src/bindings.rs, benilla-app/src/capture/mod.rs, benilla-app/src/capture/scenarios.rs, benilla-app/src/cvars/mod.rs, benilla-app/src/glue_session/login.rs, benilla-app/src/glue_session/roster.rs, benilla-app/src/lanes/account_data_live_tests.rs, benilla-app/src/lanes/action_live_tests.rs, benilla-app/src/lib.rs, benilla-app/src/local_state.rs, benilla-app/src/net.rs, benilla-app/src/net/apply.rs, benilla-app/src/player/camera_saved.rs, benilla-app/src/run_mode.rs, benilla-app/src/sound/mod.rs, benilla-app/src/ui_chat/settings.rs, benilla-app/src/ui_chat/tests.rs, benilla-app/src/ui_logout.rs, benilla-app/src/ui_macro/tests.rs, benilla-app/src/ui_saved.rs, benilla-app/src/ui_script/addons.rs, benilla-app/src/ui_script/layer_tests.rs, benilla-app/src/ui_script/lifecycle.rs, benilla-app/src/ui_script/mod.rs, benilla-app/src/ui_script/world_entry_tests.rs, benilla-app/src/video.rs, benilla-app/src/wdb/tests.rs, benilla-world/src/bgwin.rs, benilla-world/src/clouds/mod.rs, benilla-world/src/dev_state.rs, moonwell-gfx/src/map_data.rs, moonwell/src/voice.rs
|
||||
- `WOW_CAPTURE` — benilla-app/src/account_data/sections.rs, benilla-app/src/account_data/tests.rs, benilla-app/src/bindings.rs, benilla-app/src/capture/mod.rs, benilla-app/src/capture/scenarios.rs, benilla-app/src/cvars/mod.rs, benilla-app/src/glue_session/login.rs, benilla-app/src/glue_session/roster.rs, benilla-app/src/lanes/account_data_live_tests.rs, benilla-app/src/lanes/action_live_tests.rs, benilla-app/src/lib.rs, benilla-app/src/local_state.rs, benilla-app/src/net.rs, benilla-app/src/net/apply.rs, benilla-app/src/player/camera_saved.rs, benilla-app/src/run_mode.rs, benilla-app/src/sound/mod.rs, benilla-app/src/ui_chat/settings.rs, benilla-app/src/ui_chat/tests.rs, benilla-app/src/ui_logout.rs, benilla-app/src/ui_macro/tests.rs, benilla-app/src/ui_saved.rs, benilla-app/src/ui_script/addons.rs, benilla-app/src/ui_script/layer_tests.rs, benilla-app/src/ui_script/lifecycle.rs, benilla-app/src/ui_script/mod.rs, benilla-app/src/ui_script/world_entry_tests.rs, benilla-app/src/video.rs, benilla-app/src/wdb/tests.rs, benilla-world/src/bgwin.rs, benilla-world/src/clouds/mod.rs, benilla-world/src/dev_state.rs, moonwell-gfx/src/map_data.rs, moonwell-gfx/src/post.rs, moonwell/src/voice.rs
|
||||
- `WOW_CAPTURE_AGE` — benilla-app/src/capture/mod.rs
|
||||
- `WOW_CAPTURE_DEADLINE` — benilla-app/src/capture/mod.rs
|
||||
- `WOW_CAPTURE_OUT` — benilla-app/src/capture/mod.rs
|
||||
@@ -550,6 +550,7 @@
|
||||
|
||||
## Scripts (`scripts/`)
|
||||
|
||||
- `analyze-gfx-diagnostics.py` — Summarize GPU readback means by session and settings epoch, without mixing toggles.
|
||||
- `doc-links.py` — Fail on a doc link whose target is declared nowhere in the workspace.
|
||||
- `gen-message-catalog.py` — Generate `crates/benilla-ui/src/messages/catalog.rs` from `reference/messages.tsv`.
|
||||
- `journal-report.py` — Summarise an FPS journal recording, split wherever its tags change.
|
||||
|
||||
Reference in New Issue
Block a user