A player-clippy gate lints the shipped player build (#1471)

No gate built the shipped player graph outside tests. The player-tests gate compiles with `cfg(test)`, and clippy ran only on the dev feature set, so the player build's own warnings landed unseen: four unused re-exports that only dev probes used.

A new `player-clippy` gate runs `cargo clippy -p benilla -p benilla-app --no-default-features -- -D warnings` in `scripts/gates.sh`, in CI, and in `scripts/check.sh` when it reaches those crates. `docs/METHOD.md` names it.

The four re-exports are deleted: `ground_derived`, `GroundClamped`, `BodyPartsDesc` and `ATTACH_SLOT_NAMES`. Their dev users import them from the defining modules, with no `allow` left.

Test: an unused import added to `net.rs` fails the new gate.

Fixes #1465

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Sam Sung
2026-10-16 20:03:00 +07:00
committed by GitHub
parent 5d577c277c
commit c50db9bfc0
12 changed files with 37 additions and 29 deletions
+2
View File
@@ -60,5 +60,7 @@ jobs:
run: scripts/sync-reference.py benilla-re --check
- name: pass-span-lint
run: scripts/pass-span-lint.py
- name: player-clippy
run: cargo clippy -p benilla -p benilla-app --no-default-features -- -D warnings
- name: player-tests
run: cargo test -p benilla-formats -p benilla-app --no-default-features --lib