Integrate MoonWell launcher and deployment tools #1

2026-10-08T12:13:52+03:00

sindoring commented

2026-10-08 12:13:52 +03:00

MoonWell gets its own launcher with Windows title/icon/version resources, macOS packaging, and the existing deployment tooling for MPQ packages, manifests, and S3 uploads. Place the shipped icon at the path consumed by the launcher, resource builder, and deployment script. This also brings the fork main to the upstream baseline already present in the local main (d0d1b5de).

Make the existing source-inspection and Lua tests portable to Windows paths and CRLF. Classify startup native-window access used only for launcher icons in the existing input gate. Regenerate docs/MAP.md with scripts/genmap.sh.

Validation on Windows:

scripts/gates.sh: ALL GATES GREEN (987 s): fmt, clippy with warnings denied, workspace tests with and without data, doc links, render-pass lint, tests without dev, and engine boots with and without data.
cargo build -p moonwell --release --no-default-features --locked passed; Windows product metadata identifies MoonWell.exe.
moonwell-deploy: 12 tests passed; deployment PowerShell and macOS packaging Python syntax checked.

Data checks used a temporary reference chain built from the install's base MPQs plus patch.MPQ and patch-2.MPQ, excluding the custom patch-3.MPQ that changes stock globals/fonts. The install was not modified. In each data-enabled rung, 31 addon-corpus tests skipped because vanilla addons and Quiver are absent. Native macOS/Linux builds and live login smoke were not run; this checkout has no declared test account. No game data or credentials are included.

MoonWell gets its own launcher with Windows title/icon/version resources, macOS packaging, and the existing deployment tooling for MPQ packages, manifests, and S3 uploads. Place the shipped icon at the path consumed by the launcher, resource builder, and deployment script. This also brings the fork main to the upstream baseline already present in the local main (d0d1b5de). Make the existing source-inspection and Lua tests portable to Windows paths and CRLF. Classify startup native-window access used only for launcher icons in the existing input gate. Regenerate docs/MAP.md with scripts/genmap.sh. Validation on Windows: - scripts/gates.sh: ALL GATES GREEN (987 s): fmt, clippy with warnings denied, workspace tests with and without data, doc links, render-pass lint, tests without dev, and engine boots with and without data. - cargo build -p moonwell --release --no-default-features --locked passed; Windows product metadata identifies MoonWell.exe. - moonwell-deploy: 12 tests passed; deployment PowerShell and macOS packaging Python syntax checked. Data checks used a temporary reference chain built from the install's base MPQs plus patch.MPQ and patch-2.MPQ, excluding the custom patch-3.MPQ that changes stock globals/fonts. The install was not modified. In each data-enabled rung, 31 addon-corpus tests skipped because vanilla addons and Quiver are absent. Native macOS/Linux builds and live login smoke were not run; this checkout has no declared test account. No game data or credentials are included.

sindoring added 18 commits 2026-10-08 12:13:55 +03:00

fix: close a loot window that opens while you move, as 1.12.1 does (#786 ) cf891dc375

- A loot window that opens while you move closes, as in 1.12.1 (#782)
- Set auto_loot in the LootConfig initializer (clippy field_reassign_with_default)
- Close a window opened on the move in the feed's pass, so it never paints

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

fix: spell text $g takes the player's gender, as 1.12.1 does (#787 ) 9bc7276dd8

- spell text: $g/$G take the active player's gender and the chosen form is space-trimmed, so a female character reads "her" (0x508180, 0x508214)
- spell text: trim the $g docs, drop the colon-less $g pin
- spell tooltips: $g reads the view's player store; nets cover gender
- item tooltips: re-substitute $-texts when the gender byte moves
- tests: share one real-spells loader beside Spells

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

fix: ignore a loot right-click while moving, as 1.12.1 does (#790 ) 4a389add47

- A loot right-click while moving does nothing, as in 1.12.1 (#760)
- loot gate: name the emitter's drain and write the landing deviation

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

fix: level-up gains read signed, so a loss prints -2, as 1.12.1 does (#791 ) aa103d5a65

- Change `LevelUpInfo` to signed to match vanilla behavior
- Add parse test for negative values in SMSG_LEVELUP_INFO, update comments
- grammar
- level-up gains: cite the %d fire and vmangos's wrapped deltas; pin the reported line

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

fix: overhead names carry the player's PvP title, as 1.12.1 does (#792 ) 622e1c3e7a

- capture: a name-rank scenario shoots a ranked player's overhead name line
- Overhead names carry the player's PvP title under UnitNamePlayerPVPTitle, as 1.12.1 does (#550)
- review: bundle the rank-title inputs; doc the snapshot and rank-19 limits
- nameplates: read rank strings per VM; test the composed name line
- pvp: correct the rank-title docs; convert the credit team without a cast
- Fix the titles row comment; name-rank reuses WOLF_POS, cites :900
- rank strings: the honor feed reads them off the VM; nameplates only reads the value

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

fix: TargetUnit("npc") selects the interaction NPC, as 1.12.1 does (#800 ) ab909df6d9

`TargetUnit("npc")`, `AssistUnit("npc")` and `SpellTargetUnit("npc")` did nothing with a merchant, gossip or quest window open: the app's unit-token resolver answered nobody for `npc`.

In 1.12.1 the resolver (`0x515970`) matches `npc` as a whole token (`0x515bec`, an unbounded compare, so `npctarget` stays unknown) and takes the interaction NPC's guid `[0xb4e2d0]`, which `0x4930d0` writes when the window opens.

`npc` now resolves to the held unit `InteractNpc` names. Tests cover the three verbs, a closed window and a streamed-out NPC, and `/script TargetUnit("npc")` typed into the stock chat box.

Fixes #707

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Unit tooltips title the unit with its PvP name, as 1.12.1 does (#802 ) bb84f1f1fb

A unit tooltip's title read the bare name where 1.12.1 decorates it.

The tooltip calls the name builder `0x609370` itself (`0x52a1ab`, or `0x52a1db` when there is no second part) with the decoration flag a literal `1`, the same call `UnitPVPName` makes, so no CVar gates it. With the flag on, a ranked player reads `UNIT_PVP_NAME` of the gendered `PVP_RANK_<rank>_<team>` and the name, a city protector's `PVP_MEDAL<n>` follows on a second line (`0x6093ef`), and a civilian kill (`0x612550`) reads the `PVP_RANK_CIVILIAN` prefix (`0x609461`).

The title now runs the builder `UnitPVPName` already uses. The test covers rank, gender, medal, civilian, an unranked player and a creature; an on-demand `ui-tooltip-rank` capture shows a ranked player's tooltip.

Fixes #794

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

World-enter queries wait for the player's create, as 1.12.1 sends them (#801 ) ffdc206ac2

At login benilla sent `CMSG_SET_ACTIVE_MOVER`, `CMSG_QUERY_TIME`, `MSG_QUERY_NEXT_MAIL_TIME` and `CMSG_BATTLEFIELD_STATUS` right after `CMSG_PLAYER_LOGIN`, before the server had seated the player. cmangos drops them; after a worldport or `/reload` the time and mail queries never went again.

In 1.12.1 all four follow the local player's own create (`0x5dea50`): `SetActiveMover` (`0x6006e0`), then the world-enter cascade (`0x5deb60 call 0x4908c0`), whose inits send `0x1CE`, `0x284` and `0x2D3` in that order. A cross-map worldport re-creates the player and takes the same route; `/reload` re-enters the cascade alone (`0x490168`).

The four now ride the self create, in that order, and `/reload` re-sends the three. Tests cover login, the create, a worldport, the schedule order and the reload; a live trace shows the order at login, after `.tele` and on `ReloadUI()`.

Fixes #789
Fixes #100

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Elias Miettinen <eliaspmiettinen@gmail.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

The out trace logs every world send, the login handshake's included (#806 ) f8493febb0

The `out` trace tag logged only what the long-lived writer sent, drained after each command. Everything the session sends before the reader and writer split never reached it: `CMSG_AUTH_SESSION`, `CMSG_CHAR_ENUM`, `CMSG_PLAYER_LOGIN`, character create and delete, the cinematic ack and logout. So a login trace could not show where `CMSG_PLAYER_LOGIN` sits against `SMSG_LOGIN_VERIFY_WORLD`, which wire-timing work needs.

The world socket has one write path, `send_packet`. It now reports each packet to an observer right after the write, and the app installs the trace there only when the `out` tag is on. The writer's sent-log and its drains are gone; the line format is unchanged.

A protocol test over the fake server checks that the handshake, a pre-split send and a writer send are all observed, in order. A live login trace now opens with `CMSG_AUTH_SESSION`, `CMSG_CHAR_ENUM` and `CMSG_PLAYER_LOGIN`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A crate on top finds its own benilla-config/ through config_dir (#809 ) 85980939f5

A crate built on benilla through `run_with` has its own `benilla-config/`, but could not ask where it is: `local_state::home` is crate-private. A crate that ships an addon has to write it into that folder's `AddOns/`, where benilla discovers addons and resolves their art and fonts, so without the path it needed a fork.

- `benilla_app::config_dir()` answers `local_state::home()`, asked from `run_with` on, since a dev build resolves it from the launcher's folder set there.
- CONTRIBUTING's "Building on top" says a crate's files and addons go there, and names `run_with` and this folder as the two seams opened for crates alone.
- The example launcher logs its `AddOns/` folder through it, so the example, which clippy and the tests build, is the outside caller that keeps it public.

No 1.12.1 behaviour changes.

Fixes #807

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The meeting-stone query runs at every world entry, as 1.12.1 sends it (#810 ) 2e82d34c1b

The meeting-stone status query (`CMSG 0x296`) and its text reset ran once per UI VM, and the text drop only on leaving the world. So after a cross-map worldport benilla kept the old text and never asked again.

In 1.12.1 the world-enter cascade's meeting-stone init (`0x490a14` → `0x4c9f40`) resets the text to `UNKNOWN` and sends `0x296`, right after the battlefield init, on every pass: login, every cross-map worldport and every `/reload`. The leave-world sweep `0x490a80` drops the text (`0x490b2f` → `0x4c9f80`) on a worldport, a `/reload` and leaving the world.

The enter leg now runs on the world-enter cascade after the battlefield status. The sweep is one edge, written whenever its latch is spent, and the drop reads it. Tests cover the cascade, a worldport, a reload and the schedule order; a live trace shows `0x296` after `0x2D3` and its reply at login, on `ReloadUI()` and after `.tele`.

Fixes #99

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix: trainer services show their spell's description, as 1.12.1 does (#803 ) 80b0848628

- capture: trainer scenarios shoot the service description field (#793)
- fix: trainer services show their spell's description, as 1.12.1 does (#793)
- review: reuse the caster closure, cut repeated comments, pin the profession rows
- trainer: the pet's skill value is the tooltip's one helper, not a copy
- trainer: the recipe row's real-data test reads a product that has text

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Sam <samuv.eth@gmail.com>

The quest log counts party members on each quest, as 1.12.1 does (#824 ) 63e917965d

The quest log never showed the `[n]` count of party members on a quest, because `IsUnitOnQuest` was a stub that always answered nil.

1.12.1 (`0x4dfe10`) checks both arguments first. It reads the row's quest id (`0x4df150`; a header or out-of-range row answers nil before the unit is resolved), resolves the token, and admits only you or one of the four party slots, by guid (`0x4e7f70`). It then needs the unit held as a player and scans the 20 `PLAYER_QUEST_LOG` ids for that quest. The answer is 1 or nil. The ids reach party members on the wire. `UNIT_QUEST_LOG_CHANGED` (`0x51bc63` → `0x51bd90`) fires once whenever any slot of a unit's window changes, so an open log recounts.

Unit snapshots now carry the window, the binding follows those steps, and the event fires. Tests cover each path and run the stock `QuestLogFrame.xml` to a `[2]` row; they fail against the stub.

Fixes #818

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Zone names stay uncoloured on PvE realms outside capitals, as in 1.12.1 (#825 ) ea7e0d087a

On a PvE realm, zone names were still coloured friendly, hostile or contested.

In 1.12.1, `GetZonePVPInfo` (`0x48d540`) answers a type only when its display gate is open (`0x48d5c2`/`0x48d5cc`). The gate opens on the realm's PvP flag or in a zone with Flags `0x10`, which is the six capitals. The realm flag is read from `Cfg_Configs.dbc` for the selected realm's type and stored once per world entry (`0x4015de`). A type with no row skips the store. Otherwise the type is nil, so the stock zone splash shows cream and the minimap zone text gold.

benilla now reads `Cfg_Configs.dbc` instead of a transcription that stopped at type 8, so realm type 10 lists as PvP. It latches the realm flag at world entry and applies the gate.

Tests cover the gate, the six capitals and every shipped Cfg_Configs row; each failed before the fix.

Fixes #816

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Escape on the realm list closes only the list, as in 1.12.1 (#827 ) 1c5a568191

Escape on the realm list closed the list and then also quit the game from the login screen, or went back to login from character select.

1.12.1 walks the keyboard frames once per press, strata high to low, and stops at the first handler that takes it (`0x765f10`, leaving at `0x765f64`/`0x765f86`). The realm list is DIALOG strata (`RealmList.xml:246`), so its Escape never reaches the screen beneath, even though it hides itself.

benilla's list and screens read the keys in no fixed order. A screen only checked whether the list was still shown, and the list's own Escape had just hidden it. Who owns a frame's keys is now decided once, before any of them runs (`Realms::owns_input`, set in `PreUpdate`).

Tests run the real list and screen systems in both orders, and fail before the fix with the reported symptoms.

Fixes #817

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Your own name stays blue or green in FFA areas, as in 1.12.1 (#828 ) 208b1e0bb0

In a free-for-all area such as the Gurubashi battle ring, your own overhead name and selection ring turned red.

1.12.1 colours a player's name and ring through `0x605960` by mutual attackability: `CanAttack` (`0x606980`) in both directions. Both true reads red, only theirs soft blue, only yours yellow. Neither splits on PvP: yourself green or blue, a party member pale, others green or blue. `UnitReaction` (`0x6061e0`) answers friendly for a unit toward itself before the FFA rung (`0x606200`), so you can never attack yourself.

benilla stood in a reaction-rank threshold for that matrix, and its reaction lacked the identity rung. The selector is now the reference's four-arm matrix, `CanAttack` runs in both directions, and a unit is friendly to itself. `UnitReaction`, `UnitCanAttack` and the cursor follow for yourself.

Tests pin each arm and yourself in FFA, on the shipped faction templates too; they fail before the fix.

Fixes #814

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

WORLD_MAP_UPDATE fires inside the verb that moves the map, as in 1.12.1 (#829 ) d0d1b5def9

Reopening the world map after zooming out showed the old map for a frame before the current zone.

In 1.12.1, every Lua verb that moves the map selection (`SetMapZoom`, `SetMapToCurrentZone`, a `ProcessMapClick` hit) goes through the setter `0x4a67a0`. The setter stores the selection, rebuilds the landmark list, then fires `WORLD_MAP_UPDATE` in place before returning (`0x4a6ce4`). So `WorldMapFrame`'s OnShow repaints the tiles before the first draw.

benilla queued the event to the next tick, so the first frame painted the previous map. The three verbs now run the setter whole. The landmark list is projected from per-row sources inside the setter, so the new tiles never show the old map's markers. The engine's own pushes still queue, as a narrowed deviation.

Tests replay the report's steps on the stock UI and check the event fires inside the verb with landmarks rebuilt first; they fail before the fix.

Fixes #811

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Integrate MoonWell launcher and deployment tools b6552d687e

Include the branded Windows launcher, macOS packaging and vanilla MPQ/S3
deployment pipeline. Place the embedded icon at the path the launcher and
packaging script use. Use Windows directory symlinks in the addon harness
tests so the workspace check compiles on Windows.

Verified on Windows: workspace fmt and Clippy with warnings denied;
12 moonwell-deploy tests; doc-link and render-pass lints; PowerShell and
macOS packaging script syntax. Full workspace/player gates are in progress.
Native macOS and Linux builds were not run.

sindoring added 1 commit 2026-10-08 12:42:12 +03:00

Make source inspection gates portable to Windows 9af3042ed4

Normalize source line endings before cutting test modules and the NPC session
function, and compare event-source paths by components.

Verified on Windows: workspace fmt and Clippy with warnings denied; both
verb-event gates and the NPC session coverage gate pass. The surface and
font baseline gates pass on the install's stock patch chain without the
custom patch-3.MPQ. Full gates are being retried with limited parallelism.

sindoring marked the pull request as ready for review 2026-10-08 14:00:38 +03:00

sindoring added 1 commit 2026-10-08 14:00:55 +03:00

Complete launcher input classification and Windows test portability a1e41187b2

Classify MoonWell startup window access for icon setup as plumbing. Normalize
source scanner paths on Windows and name the Lua test caller independently
of host source paths so its addon-folder pattern sees only the intended frame.

Verified on Windows: scripts/gates.sh ALL GATES GREEN, including workspace
with and without install, player tests, clippy, docs, and both engine boots.
Used the stock MPQ chain without the user's custom patch-3; 31 corpus tests
skip in each data-enabled rung because vanilla addons and Quiver are absent.
Windows MoonWell release build passed. Native macOS/Linux builds and live
login smoke were not run; no declared test account is available.

sindoring merged commit da72c705f1 into main

2026-10-08 14:01:56 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sindoring/moonwell-client-core#1