sindoring/moonwell-client-core
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases 2 Wiki Activity

Fix Russian character deletion confirmation #9

Merged
sindoring merged 1 commits from fix/ruru-delete-confirmation into main 2026-10-17 23:43:35 +03:00
Conversation 0 Commits 1 Files Changed 2
+93
sindoring commented 2026-10-17 23:42:27 +03:00
Owner
Copy Link
Copy Source

Typing Удалить in the ruRU character deletion dialog left its confirmation button disabled because native 1.12 strupper leaves Cyrillic unchanged. The existing ruRU glue layer now folds Cyrillic case and preserves the stock button, Enter and reset behavior.

Verification: reproduced with actual stock GlueXML and ruRU MPQ; offline checks pass for 9 Russian and 7 English inputs, click/Enter dispatch and dialog reset. Added application regression body passes through the engine-free loader adapter. Formatting and whitespace checks pass. No player account or server deletion used.

Production release requested by maintainer. Full workspace/application gates are not rerun, per the user's instruction; release build and published artifact verification follow.

Typing Удалить in the ruRU character deletion dialog left its confirmation button disabled because native 1.12 strupper leaves Cyrillic unchanged. The existing ruRU glue layer now folds Cyrillic case and preserves the stock button, Enter and reset behavior. Verification: reproduced with actual stock GlueXML and ruRU MPQ; offline checks pass for 9 Russian and 7 English inputs, click/Enter dispatch and dialog reset. Added application regression body passes through the engine-free loader adapter. Formatting and whitespace checks pass. No player account or server deletion used. Production release requested by maintainer. Full workspace/application gates are not rerun, per the user's instruction; release build and published artifact verification follow.
sindoring added 1 commit 2026-10-17 23:42:28 +03:00
Fix Russian character deletion confirmation casing 44542be5e2 
Fold Cyrillic only in the ruRU glue layer so the stock delete confirmation accepts typed mixed case while preserving its button and Enter guards.

Verified on Windows with actual stock GlueXML and the ruRU MPQ: reproduced the rejected title-case confirmation before the fix; engine-free offline checks pass for 9 Russian and 7 English inputs, button/Enter dispatch, and dialog reset. The new application regression body also passes through the engine-free loader adapter. cargo fmt --all -- --check and git diff --check pass. Full workspace/app gates and production build were not run for this change; no player account or server deletion used.
sindoring marked the pull request as ready for review 2026-10-17 23:43:23 +03:00
sindoring merged commit cc4da3cb61 into main 2026-10-17 23:43:35 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sindoring
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sindoring/moonwell-client-core#9
Delete Branch "fix/ruru-delete-confirmation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?