Sam Sung 2019beb7f5 Attack, cast and engine selection signals fire in place, as in 1.12.1 (#2290) ...

More of 1.12.1's signal points fire their events in place, before the packet they precede:
- TryCast's pick (`0x6e4efb`, before `0x6e585a`), and the attack validator's pick, split from its re-read (`0x61305d`-`0x6130c1`), for Attack, the pet bar's Attack (`0x4bd40d`-`0x4bd44c`, possessed units included) and a unit caster;
- the world click, the plate click, a death and a despawn's selection change;
- a deselect outside a call fires `PET_BAR_UPDATE` from the stop (`0x4bd6b4`) before `CMSG_SET_SELECTION`;
- the engine's target writers test the old selection's latches and send ATTACKSTOP as `0x493a08` does;
- chat, channel-join, emote and party refusals show inside their calls (`0x49b9c5`, `0x48a485`);
- the dev capture and probe Lua runs after its turn with the host lent, and the host refuses Lua in place behind a held signal.

Each has a test that fails without it.

Part of #2271
Fixes #2272
Fixes #2282
Fixes #2266
Fixes #2185

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-23 15:36:52 +07:00

..

CONTRIBUTING.md

The addon probe fires events, clicks and runs on the bare interface (#1898)

2026-10-18 15:46:31 +07:00

DEVIATIONS.md

Attack, cast and engine selection signals fire in place, as in 1.12.1 (#2290)

2026-10-23 15:36:52 +07:00

MAP.md

Console commands and CVars follow 1.12.1; Lua's date and time are local (#2257)

2026-10-22 23:28:59 +07:00

METHOD.md

Test gates run under cargo-nextest, doctests beside them (#2036)

2026-10-20 10:27:18 +07:00