Sam Sung 275feba882 Macros sort, hold ids and bind pet spells as 1.12.1's do (#2126) ...

Macros were held by index and kept in creation order:

- A sort or delete moved what a bar slot held.
- `EditMacro` trimmed and capped differently and returned nothing.
- `CastSpellByName` took the wrong quoted span.
- A macro casting a pet spell never bound the pet's book.

Reference: each scope sorts by the CRT `qsort` with `_strnicmp` (`0x73f727`, `0x4f0e10`). Slots hold the macro id, with bit 24 set for a character macro, and `DeleteMacro` clears every slot holding it (`0x4e5d10`). `EditMacro` returns the index after the re-sort. The quoted name ends at the next quote (`0x4efef0`). Names bind the player's book, then the pet's (`0x4b3bc0`).

Changed: the table, the slots, the cursor and the saved files follow these, and tests pin each. Bar slots an earlier build saved for character macros are rewritten once to the new ids.

Fixes #1502
Fixes #1505
Fixes #1187
Fixes #196
Fixes #197

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-21 00:23:45 +07:00

..

CONTRIBUTING.md

The addon probe fires events, clicks and runs on the bare interface (#1898)

2026-10-18 15:46:31 +07:00

DEVIATIONS.md

Macros sort, hold ids and bind pet spells as 1.12.1's do (#2126)

2026-10-21 00:23:45 +07:00

MAP.md

Console commands and CVar defaults follow 1.12.1's registrations (#2104)

2026-10-20 21:51:38 +07:00

METHOD.md

Test gates run under cargo-nextest, doctests beside them (#2036)

2026-10-20 10:27:18 +07:00