Sam Sung f6d2d44df8 Pet casts, CastSpellByName and two chat verbs run as 1.12.1 runs them (#2170) ...

A possessed unit's spell and a pet spell with AttributesEx4 0x20 went out as CMSG_PET_ACTION. `CastSpellByName` never found pet spells and misparsed names. `SendChatMessage` sent `%t` and `%n` unexpanded and passed any `|` escape. `RandomRoll` sent any arguments.

The reference:
- `CastSpellByName` cuts the name and rank at the first `(` and `)` and falls back to the pet's book (0x4b3950).
- A unit caster runs the cast ladder, picking its own target (0x6e4ef4) and ordering Attack after the send (0x6131a0).
- `SendChatMessage` expands the tokens and raises on a bad escape inside its call (0x49f1e0).
- `RandomRoll` checks its arguments first (0x48c7b0).

What changed:
- A `CMSG_PET_CAST_SPELL` writer with byte-exact goldens.
- The unit caster's ladder covers its pick, autoSelfCast and the cursor's binds.
- Both chat verbs now apply inside their calls.
- The channel slots follow every step.

Each fact is tested against its address.

Fixes #639
Fixes #168
Fixes #406
Fixes #1331
Fixes #1332
Fixes #1531

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-21 12:43:31 +07:00

..

CONTRIBUTING.md

The addon probe fires events, clicks and runs on the bare interface (#1898)

2026-10-18 15:46:31 +07:00

DEVIATIONS.md

Pet casts, CastSpellByName and two chat verbs run as 1.12.1 runs them (#2170)

2026-10-21 12:43:31 +07:00

MAP.md

Script calls apply inside their verb, in one ordered VM pass (#2143)

2026-10-21 03:43:48 +07:00

METHOD.md

Test gates run under cargo-nextest, doctests beside them (#2036)

2026-10-20 10:27:18 +07:00