Sam Sung fbc4711d1f NPC windows read the npc token at their show; faction bits shift as shl (#2285) ...

Three fixes for timing and unusual input.

- **NPC windows.** Seven NPC windows could fire their show before the `npc` token was set: gossip, quest, bank, taxi, stable, tabard and registrar. In 1.12.1 the packet handler sets `[0xb4e2d0]` before the show (`0x4e1fa0` → `0x4930d0`, then `0x4e27df`), so a show never draws the book icon with an empty name. All eleven latched window feeds now run after the unit feed, and a schedule test names any that do not.
- **Faction slot.** The faction slot pick shifts a race or class byte as `dec ecx; shl` does (`0x4d5512`): 0 tests bit 31, 33 tests bit 0, and nothing panics.
- **Pet clock.** The pet bar and pet book read cooldowns at the frame clock, so their expiry tests step time instead of sleeping.

Three wrong comments are fixed.

Fixes #2278
Fixes #2048
Fixes #2275
Fixes #1479
Fixes #1227
Fixes #2144

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-23 10:47:52 +07:00

..

CONTRIBUTING.md

The addon probe fires events, clicks and runs on the bare interface (#1898)

2026-10-18 15:46:31 +07:00

DEVIATIONS.md

NPC windows read the npc token at their show; faction bits shift as shl (#2285)

2026-10-23 10:47:52 +07:00

MAP.md

Console commands and CVars follow 1.12.1; Lua's date and time are local (#2257)

2026-10-22 23:28:59 +07:00

METHOD.md

Test gates run under cargo-nextest, doctests beside them (#2036)

2026-10-20 10:27:18 +07:00