Refactor player skills code.
Credit to cmangos https://github.com/cmangos/mangos-classic/commit/e277f221de81c7195f8ea7bbdcf4a9eb0e8f03a2 Fixes https://github.com/vmangos/core/issues/105
This commit is contained in:
@@ -480,7 +480,7 @@ void Player::UpdateBlockPercentage()
|
||||
// Base value
|
||||
value = 5.0f;
|
||||
// Modify value from defense skill
|
||||
value += (int32(GetDefenseSkillValue()) - int32(GetMaxSkillValueForLevel())) * 0.04f;
|
||||
value += (int32(GetDefenseSkillValue()) - int32(GetSkillMaxForLevel())) * 0.04f;
|
||||
// Increase from SPELL_AURA_MOD_BLOCK_PERCENT aura
|
||||
value += GetTotalAuraModifier(SPELL_AURA_MOD_BLOCK_PERCENT);
|
||||
value = value < 0.0f ? 0.0f : value;
|
||||
@@ -531,7 +531,7 @@ void Player::UpdateCritPercentage(WeaponAttackType attType)
|
||||
break;
|
||||
}
|
||||
// Modify crit from weapon skill and maximized defense skill of same level victim difference
|
||||
value += (int32(GetWeaponSkillValue(attType)) - int32(GetMaxSkillValueForLevel())) * 0.04f;
|
||||
value += (int32(GetWeaponSkillValue(attType)) - int32(GetSkillMaxForLevel())) * 0.04f;
|
||||
value = value < 0.0f ? 0.0f : value;
|
||||
SetStatFloatValue(index, value);
|
||||
}
|
||||
@@ -558,7 +558,7 @@ void Player::UpdateParryPercentage()
|
||||
// Base parry
|
||||
value = 5.0f;
|
||||
// Modify value from defense skill
|
||||
value += (int32(GetDefenseSkillValue()) - int32(GetMaxSkillValueForLevel())) * 0.04f;
|
||||
value += (int32(GetDefenseSkillValue()) - int32(GetSkillMaxForLevel())) * 0.04f;
|
||||
// Parry from SPELL_AURA_MOD_PARRY_PERCENT aura
|
||||
value += GetTotalAuraModifier(SPELL_AURA_MOD_PARRY_PERCENT);
|
||||
value = value < 0.0f ? 0.0f : value;
|
||||
@@ -594,7 +594,7 @@ void Player::UpdateDodgePercentage()
|
||||
// Dodge from agility
|
||||
value += GetDodgeFromAgility();
|
||||
// Modify value from defense skill
|
||||
value += (int32(GetDefenseSkillValue()) - int32(GetMaxSkillValueForLevel())) * 0.04f;
|
||||
value += (int32(GetDefenseSkillValue()) - int32(GetSkillMaxForLevel())) * 0.04f;
|
||||
// Dodge from SPELL_AURA_MOD_DODGE_PERCENT aura
|
||||
value += GetTotalAuraModifier(SPELL_AURA_MOD_DODGE_PERCENT);
|
||||
value = value < 0.0f ? 0.0f : value;
|
||||
|
||||
Reference in New Issue
Block a user