sindoring/moonwell-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(Core/Spells): guard m_caster access during Spell destruction chain (#26782)

Browse Source
This commit is contained in:
mpfans
2026-07-25 05:02:29 +08:00
committed by GitHub
parent 653d177503
commit 0dafc681ed
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/game/Spells/Spell.cpp
+3 -1
View File
@@ -4475,7 +4475,9 @@ void Spell::finish(bool ok)
return; return;
m_spellState = SPELL_STATE_FINISHED; m_spellState = SPELL_STATE_FINISHED;
if (Player* modOwner = m_caster->GetSpellModOwner()) // FindMap() check: pending spell events are destroyed after the caster has left the map,
// where resolving a unit-summoned caster's owner through ObjectAccessor would assert
if (Player* modOwner = (m_caster && m_caster->FindMap()) ? m_caster->GetSpellModOwner() : nullptr)
modOwner->SetSpellModTakingSpell(this, false); modOwner->SetSpellModTakingSpell(this, false);
if (m_spellInfo->IsChanneled()) if (m_spellInfo->IsChanneled())