refactor(Core): apply clang-tidy modernize-use-nodiscard (#3835)
This commit is contained in:
@@ -79,9 +79,9 @@ public: // Constructors
|
||||
MailSender(Player* sender);
|
||||
MailSender(uint32 senderEntry);
|
||||
public: // Accessors
|
||||
MailMessageType GetMailMessageType() const { return m_messageType; }
|
||||
uint32 GetSenderId() const { return m_senderId; }
|
||||
MailStationery GetStationery() const { return m_stationery; }
|
||||
[[nodiscard]] MailMessageType GetMailMessageType() const { return m_messageType; }
|
||||
[[nodiscard]] uint32 GetSenderId() const { return m_senderId; }
|
||||
[[nodiscard]] MailStationery GetStationery() const { return m_stationery; }
|
||||
private:
|
||||
MailMessageType m_messageType;
|
||||
uint32 m_senderId; // player low guid or other object entry
|
||||
@@ -95,8 +95,8 @@ public: // Constructors
|
||||
MailReceiver(Player* receiver);
|
||||
MailReceiver(Player* receiver, uint32 receiver_lowguid);
|
||||
public: // Accessors
|
||||
Player* GetPlayer() const { return m_receiver; }
|
||||
uint32 GetPlayerGUIDLow() const { return m_receiver_lowguid; }
|
||||
[[nodiscard]] Player* GetPlayer() const { return m_receiver; }
|
||||
[[nodiscard]] uint32 GetPlayerGUIDLow() const { return m_receiver_lowguid; }
|
||||
private:
|
||||
Player* m_receiver;
|
||||
uint32 m_receiver_lowguid;
|
||||
@@ -113,11 +113,11 @@ public: // Constructors
|
||||
MailDraft(std::string const& subject, std::string const& body)
|
||||
: m_mailTemplateId(0), m_mailTemplateItemsNeed(false), m_subject(subject), m_body(body), m_money(0), m_COD(0) {}
|
||||
public: // Accessors
|
||||
uint16 GetMailTemplateId() const { return m_mailTemplateId; }
|
||||
std::string const& GetSubject() const { return m_subject; }
|
||||
uint32 GetMoney() const { return m_money; }
|
||||
uint32 GetCOD() const { return m_COD; }
|
||||
std::string const& GetBody() const { return m_body; }
|
||||
[[nodiscard]] uint16 GetMailTemplateId() const { return m_mailTemplateId; }
|
||||
[[nodiscard]] std::string const& GetSubject() const { return m_subject; }
|
||||
[[nodiscard]] uint32 GetMoney() const { return m_money; }
|
||||
[[nodiscard]] uint32 GetCOD() const { return m_COD; }
|
||||
[[nodiscard]] std::string const& GetBody() const { return m_body; }
|
||||
|
||||
public: // modifiers
|
||||
MailDraft& AddItem(Item* item);
|
||||
@@ -190,7 +190,7 @@ struct Mail
|
||||
return false;
|
||||
}
|
||||
|
||||
bool HasItems() const { return !items.empty(); }
|
||||
[[nodiscard]] bool HasItems() const { return !items.empty(); }
|
||||
};
|
||||
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user