sindoring/moonwell-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed all unused-parameters warnings

Browse Source 
issue #121

used clang-tidy to achieve this
This commit is contained in:
Yehonal
2017-09-18 14:23:26 +02:00
parent aa87ec685b
commit 2b2e299ccc
229 changed files with 643 additions and 643 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/scripts/Spells/spell_dk.cpp
+5 -5
View File
@@ -390,7 +390,7 @@ class spell_dk_master_of_ghouls : public SpellScriptLoader
{
PrepareAuraScript(spell_dk_master_of_ghouls_AuraScript);
void HandleEffectApply(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/)
void HandleEffectApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
Unit* target = GetTarget();
if (target->GetTypeId() == TYPEID_PLAYER)
@@ -835,7 +835,7 @@ class spell_dk_dancing_rune_weapon_visual : public SpellScriptLoader
{
PrepareAuraScript(spell_dk_dancing_rune_weapon_visual_AuraScript);
void HandleEffectApply(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/)
void HandleEffectApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
PreventDefaultAction();
if (Unit* owner = GetUnitOwner()->ToTempSummon()->GetSummoner())
@@ -926,7 +926,7 @@ class spell_dk_pet_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: dk gargoyle inherits 33% of SP
if (GetUnitOwner()->GetEntry() != NPC_EBON_GARGOYLE)
@@ -948,7 +948,7 @@ class spell_dk_pet_scaling : public SpellScriptLoader
}
}
void CalculateHasteAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateHasteAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: scale haste with owners melee haste
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -1120,7 +1120,7 @@ class spell_dk_anti_magic_shell_self : public SpellScriptLoader
GetTarget()->CastCustomSpell(SPELL_DK_RUNIC_POWER_ENERGIZE, SPELLVALUE_BASE_POINT0, bp, GetTarget(), true, NULL, aurEff);
}
void HandleEffectApply(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/)
void HandleEffectApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
Unit* target = GetTarget();
target->ApplySpellImmune(GetId(), IMMUNITY_ID, 33786, true); // cyclone
src/scripts/Spells/spell_druid.cpp
+5 -5
View File
@@ -100,7 +100,7 @@ class spell_dru_nurturing_instinct : public SpellScriptLoader
{
PrepareAuraScript(spell_dru_nurturing_instinct_AuraScript);
void AfterApply(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/)
void AfterApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
if (Player* player = GetTarget()->ToPlayer())
player->addSpell(GetSpellInfo()->GetRank() == 1 ? SPELL_DRUID_NURTURING_INSTINCT_R1 : SPELL_DRUID_NURTURING_INSTINCT_R2, SPEC_MASK_ALL, false, true);
@@ -204,7 +204,7 @@ class spell_dru_brambles_treant : public SpellScriptLoader
{
PrepareAuraScript(spell_dru_brambles_treant_AuraScript);
bool CheckProc(ProcEventInfo& eventInfo)
bool CheckProc(ProcEventInfo& /*eventInfo*/)
{
if (Player* player = GetUnitOwner()->GetSpellModOwner())
{
@@ -250,7 +250,7 @@ class spell_dru_barkskin : public SpellScriptLoader
{
PrepareAuraScript(spell_dru_barkskin_AuraScript);
void AfterApply(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/)
void AfterApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
if (GetUnitOwner()->HasAura(SPELL_DRUID_GLYPH_OF_BARKSKIN, GetUnitOwner()->GetGUID()))
GetUnitOwner()->CastSpell(GetUnitOwner(), SPELL_DRUID_GLYPH_OF_BARKSKIN_TRIGGER, true);
@@ -304,7 +304,7 @@ class spell_dru_treant_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: treant inherits 105% of SP as AP - 15% of damage increase per hit
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -318,7 +318,7 @@ class spell_dru_treant_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: treant inherits 15% of SP
if (Unit* owner = GetUnitOwner()->GetOwner())
src/scripts/Spells/spell_generic.cpp
+10 -10
View File
@@ -107,7 +107,7 @@ class spell_the_flag_of_ownership : public SpellScriptLoader
return true;
}
void HandleScript(SpellEffIndex effIndex)
void HandleScript(SpellEffIndex /*effIndex*/)
{
Unit* caster = GetCaster();
if (!caster || caster->GetTypeId() != TYPEID_PLAYER)
@@ -216,7 +216,7 @@ class spell_gen_mine_sweeper : public SpellScriptLoader
{
PrepareSpellScript(spell_gen_mine_sweeper_SpellScript);
void HandleSchoolDMG(SpellEffIndex effIndex)
void HandleSchoolDMG(SpellEffIndex /*effIndex*/)
{
Unit* caster = GetCaster();
Player* target = GetHitPlayer();
@@ -227,7 +227,7 @@ class spell_gen_mine_sweeper : public SpellScriptLoader
caster->CastSpell(target, 54402, true);
}
void HandleScriptEffect(SpellEffIndex effIndex)
void HandleScriptEffect(SpellEffIndex /*effIndex*/)
{
if (Unit* target = GetHitPlayer())
if (Aura* aur = target->GetAura(GetSpellInfo()->Id))
@@ -285,7 +285,7 @@ class spell_gen_reduced_above_60 : public SpellScriptLoader
{
PrepareAuraScript(spell_gen_reduced_above_60_AuraScript);
void CalculateAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & canBeRecalculated)
void CalculateAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
if (Unit* owner = GetUnitOwner())
if (owner->getLevel() > 60)
@@ -404,7 +404,7 @@ public:
amplitude = 3*IN_MILLISECONDS;
}
void Update(AuraEffect* effect)
void Update(AuraEffect* /*effect*/)
{
if (Player* player = GetUnitOwner()->GetCharmerOrOwnerPlayerOrPlayerItself())
if (MapEntry const* mapEntry = sMapStore.LookupEntry(player->GetMapId()))
@@ -486,7 +486,7 @@ class spell_pet_hit_expertise_scalling : public SpellScriptLoader
return (hitChance / cap) * maxChance;
}
void CalculateHitAmount(AuraEffect const* aurEff, int32& amount, bool& /*canBeRecalculated*/)
void CalculateHitAmount(AuraEffect const* /*aurEff*/, int32& amount, bool& /*canBeRecalculated*/)
{
if (Player* modOwner = GetUnitOwner()->GetSpellModOwner())
{
@@ -499,7 +499,7 @@ class spell_pet_hit_expertise_scalling : public SpellScriptLoader
}
}
void CalculateSpellHitAmount(AuraEffect const* aurEff, int32& amount, bool& /*canBeRecalculated*/)
void CalculateSpellHitAmount(AuraEffect const* /*aurEff*/, int32& amount, bool& /*canBeRecalculated*/)
{
if (Player* modOwner = GetUnitOwner()->GetSpellModOwner())
{
@@ -512,7 +512,7 @@ class spell_pet_hit_expertise_scalling : public SpellScriptLoader
}
}
void CalculateExpertiseAmount(AuraEffect const* aurEff, int32& amount, bool& /*canBeRecalculated*/)
void CalculateExpertiseAmount(AuraEffect const* /*aurEff*/, int32& amount, bool& /*canBeRecalculated*/)
{
if (Player* modOwner = GetUnitOwner()->GetSpellModOwner())
{
@@ -666,7 +666,7 @@ class spell_gen_disabled_above_63 : public SpellScriptLoader
{
PrepareAuraScript(spell_gen_disabled_above_63_AuraScript);
void CalculateAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & canBeRecalculated)
void CalculateAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
Unit* target = GetUnitOwner();
if (target->getLevel() <= 63)
@@ -1357,7 +1357,7 @@ class spell_gen_flurry_of_claws : public SpellScriptLoader
{
PrepareAuraScript(spell_gen_flurry_of_claws_AuraScript);
void OnPeriodic(AuraEffect const* aurEff)
void OnPeriodic(AuraEffect const* /*aurEff*/)
{
PreventDefaultAction();
if (Unit* target = GetUnitOwner()->SelectNearbyTarget(NULL, 7.0f))
src/scripts/Spells/spell_hunter.cpp
+5 -5
View File
@@ -130,7 +130,7 @@ class spell_hun_wyvern_sting : public SpellScriptLoader
{
PrepareAuraScript(spell_hun_wyvern_sting_AuraScript)
void HandleEffectRemove(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/)
void HandleEffectRemove(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
if (Unit* caster = GetCaster())
caster->CastSpell(GetTarget(), sSpellMgr->GetSpellWithRank(SPELL_HUNTER_WYVERN_STING_DOT, GetSpellInfo()->GetRank()), true);
@@ -157,7 +157,7 @@ class spell_hun_animal_handler : public SpellScriptLoader
{
PrepareAuraScript(spell_hun_animal_handler_AuraScript);
void CalculateAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
amount = 0;
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -212,7 +212,7 @@ class spell_hun_generic_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
if (Unit* owner = GetUnitOwner()->GetOwner())
{
@@ -233,7 +233,7 @@ class spell_hun_generic_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
if (Unit* owner = GetUnitOwner()->GetOwner())
{
@@ -407,7 +407,7 @@ class spell_hun_ascpect_of_the_viper : public SpellScriptLoader
return true;
}
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& eventInfo)
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& /*eventInfo*/)
{
PreventDefaultAction();
src/scripts/Spells/spell_item.cpp
+3 -3
View File
@@ -27,7 +27,7 @@ class spell_item_massive_seaforium_charge : public SpellScriptLoader
{
PrepareSpellScript(spell_item_massive_seaforium_charge_SpellScript);
void HandleItemRemove(SpellEffIndex effIndex)
void HandleItemRemove(SpellEffIndex /*effIndex*/)
{
if (!GetHitUnit() || !GetHitUnit()->ToPlayer())
return;
@@ -443,7 +443,7 @@ class spell_item_lil_phylactery : public SpellScriptLoader
return eventInfo.GetActionTarget() && (eventInfo.GetActionTarget()->GetTypeId() != TYPEID_UNIT || eventInfo.GetActionTarget()->ToCreature()->isWorldBoss());
}
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& eventInfo)
void HandleProc(AuraEffect const* /*aurEff*/, ProcEventInfo& /*eventInfo*/)
{
PreventDefaultAction();
@@ -2386,7 +2386,7 @@ class spell_item_shadows_fate : public SpellScriptLoader
{
PrepareAuraScript(spell_item_shadows_fate_AuraScript);
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& eventInfo)
void HandleProc(AuraEffect const* /*aurEff*/, ProcEventInfo& eventInfo)
{
PreventDefaultAction();
src/scripts/Spells/spell_mage.cpp
+5 -5
View File
@@ -148,7 +148,7 @@ class spell_mage_burning_determination : public SpellScriptLoader
return true;
}
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& eventInfo)
void HandleProc(AuraEffect const* /*aurEff*/, ProcEventInfo& /*eventInfo*/)
{
PreventDefaultAction();
GetUnitOwner()->CastSpell(GetUnitOwner(), 54748, true);
@@ -215,7 +215,7 @@ public:
GetTarget()->CastSpell((Unit*)NULL, GetSpellInfo()->Effects[aurEff->GetEffIndex()].TriggerSpell, true);
}
void CalcPeriodic(AuraEffect const* /*effect*/, bool& isPeriodic, int32& amplitude)
void CalcPeriodic(AuraEffect const* /*effect*/, bool& isPeriodic, int32& /*amplitude*/)
{
isPeriodic = false;
}
@@ -338,12 +338,12 @@ class spell_mage_pet_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & /*amount*/, bool & /*canBeRecalculated*/)
{
// xinef: mage pet inherits 0% AP
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: mage pet inherits 33% of SP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -815,7 +815,7 @@ class spell_mage_ignite : public SpellScriptLoader
return true;
}
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& eventInfo)
void HandleProc(AuraEffect const* /*aurEff*/, ProcEventInfo& eventInfo)
{
PreventDefaultAction();
src/scripts/Spells/spell_priest.cpp
+2 -2
View File
@@ -77,7 +77,7 @@ class spell_pri_shadowfiend_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: shadowfiend inherits 333% of SP as AP - 35.7% of damage increase per hit
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -87,7 +87,7 @@ class spell_pri_shadowfiend_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: shadowfiend inherits 30% of SP
if (Unit* owner = GetUnitOwner()->GetOwner())
src/scripts/Spells/spell_rogue.cpp
+1 -1
View File
@@ -49,7 +49,7 @@ public:
amplitude = 1000;
}
void Update(AuraEffect* auraEffect)
void Update(AuraEffect* /*auraEffect*/)
{
Unit::AuraApplicationMap const& auras = GetUnitOwner()->GetAppliedAuras();
for (Unit::AuraApplicationMap::const_iterator itr = auras.begin(); itr != auras.end(); ++itr)
src/scripts/Spells/spell_shaman.cpp
+7 -7
View File
@@ -166,7 +166,7 @@ class spell_sha_totemic_mastery : public SpellScriptLoader
{
PrepareAuraScript(spell_sha_totemic_mastery_AuraScript);
void HandlePeriodic(AuraEffect const* aurEff)
void HandlePeriodic(AuraEffect const* /*aurEff*/)
{
PreventDefaultAction();
@@ -219,7 +219,7 @@ class spell_sha_feral_spirit_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: by default feral spirit inherits 30% of AP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -232,7 +232,7 @@ class spell_sha_feral_spirit_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: by default feral spirit inherits 30% of AP as SP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -345,7 +345,7 @@ class spell_sha_fire_elemental_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: fire elemental inherits 300% / 150% of SP as AP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -355,7 +355,7 @@ class spell_sha_fire_elemental_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: fire elemental inherits 100% of SP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -671,12 +671,12 @@ class spell_sha_earth_shield : public SpellScriptLoader
}
}
bool CheckProc(ProcEventInfo& eventInfo)
bool CheckProc(ProcEventInfo& /*eventInfo*/)
{
return !GetTarget()->HasSpellCooldown(SPELL_SHAMAN_EARTH_SHIELD_HEAL);
}
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& eventInfo)
void HandleProc(AuraEffect const* aurEff, ProcEventInfo& /*eventInfo*/)
{
PreventDefaultAction();
GetTarget()->CastCustomSpell(SPELL_SHAMAN_EARTH_SHIELD_HEAL, SPELLVALUE_BASE_POINT0, aurEff->GetAmount(), GetTarget(), true, NULL, aurEff, GetCasterGUID());
src/scripts/Spells/spell_warlock.cpp
+5 -5
View File
@@ -191,7 +191,7 @@ class spell_warl_improved_demonic_tactics : public SpellScriptLoader
amplitude = 10*IN_MILLISECONDS;
}
void CalculateAmount(AuraEffect const* aurEff, int32& amount, bool& canBeRecalculated)
void CalculateAmount(AuraEffect const* aurEff, int32& amount, bool& /*canBeRecalculated*/)
{
if (aurEff->GetEffIndex() == EFFECT_0)
amount = CalculatePct<int32, float>(GetUnitOwner()->ToPlayer()->GetFloatValue(PLAYER_SPELL_CRIT_PERCENTAGE1 + SPELL_SCHOOL_FROST), GetSpellInfo()->Effects[EFFECT_0].CalcValue());
@@ -362,7 +362,7 @@ class spell_warl_generic_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: by default warlock pet inherits 57% of max(SP FIRE, SP SHADOW) as AP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -374,7 +374,7 @@ class spell_warl_generic_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: by default warlock pet inherits 15% of max(SP FIRE, SP SHADOW) as SP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -479,7 +479,7 @@ class spell_warl_infernal_scaling : public SpellScriptLoader
}
}
void CalculateAPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateAPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: by default warlock pet inherits 57% of max(SP FIRE, SP SHADOW) as AP
if (Unit* owner = GetUnitOwner()->GetOwner())
@@ -491,7 +491,7 @@ class spell_warl_infernal_scaling : public SpellScriptLoader
}
}
void CalculateSPAmount(AuraEffect const* aurEff, int32 & amount, bool & /*canBeRecalculated*/)
void CalculateSPAmount(AuraEffect const* /*aurEff*/, int32 & amount, bool & /*canBeRecalculated*/)
{
// xinef: by default warlock pet inherits 15% of max(SP FIRE, SP SHADOW) as SP
if (Unit* owner = GetUnitOwner()->GetOwner())
src/scripts/Spells/spell_warrior.cpp
+1 -1
View File
@@ -189,7 +189,7 @@ class spell_warr_improved_spell_reflection_trigger : public SpellScriptLoader
PrepareAuraScript(spell_warr_improved_spell_reflection_trigger_AuraScript);
void HandleRemove(AuraEffect const* /*aurEff*/, AuraEffectHandleModes mode)
void HandleRemove(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
if (!IsExpired())
{