chore(Scripts/Karazhan): rework Opera scripts using TaskScheduler (#16688)

* initial

* removing guids/using creature instance data

* move summontito

* add data for oz adds

* removal of unused stuff + removal of if condition
that makes it get stuck

* fix

* fix and add validators

* some fixes and validators

* attempt to reset

* fix talk + change flags

* debug to see where it is going wrong

* handle despawn on all

* cleanup

* codestyle

* more codestyle

* add tito data + tito despawn

* first steps on romulo and j

* with setdata

* test

* test

* some debug

* no way this was the problem

* add action to resume combat on revive

* leftovers

* remove old check to ensure abilities don't

keep casting. this was preventing the scheduler from updating

* getdata

* camelCase

* restore updatevictim

might make them attack you

* some cleanup

* some cleanup and door

door should now open on wipe

* fix mistake

* fix?

* attempt to fix dead attacking

* fix mistake

* schedule location fix

* fix logic

- Julianne and Romulo now resurrect properly
- fight stops when both die within 10 seconds
- correct lines are being said, I think
- made the script a bit better overall

* fix codestyle?

* remove leftovers

* remove leftovers

* add spaces

src/server/scripts/EasternKingdoms/Karazhan/instance_karazhan.cpp

@@ -35,7 +35,14 @@ const Position OptionalSpawn[] =
 ObjectData const creatureData[] =
 {
     { NPC_ATTUMEN_THE_HUNTSMAN, DATA_ATTUMEN  },
-    { NPC_MIDNIGHT,             DATA_MIDNIGHT }
+    { NPC_MIDNIGHT,             DATA_MIDNIGHT },
+    { NPC_DOROTHEE,             DATA_DOROTHEE },
+    { NPC_TITO,                 DATA_TITO     },
+    { NPC_ROAR,                 DATA_ROAR     },
+    { NPC_STRAWMAN,             DATA_STRAWMAN },
+    { NPC_TINHEAD,              DATA_TINHEAD  },
+    { NPC_ROMULO,               DATA_ROMULO   },
+    { NPC_JULIANNE,             DATA_JULIANNE },
 };
 
 class instance_karazhan : public InstanceMapScript

src/server/scripts/EasternKingdoms/Karazhan/karazhan.h

@@ -67,7 +67,17 @@ enum KZDataTypes
     DATA_CHESS_REINIT_PIECES        = 34,
     DATA_CHESS_GAME_PHASE           = 35,
     DATA_ECHO_OF_MEDIVH             = 36,
-    DATA_DUST_COVERED_CHEST         = 37
+    DATA_DUST_COVERED_CHEST         = 37,
+
+    // Specific Opera Data
+    DATA_DOROTHEE                   = 38,
+    DATA_ROMULO                     = 39,
+    DATA_JULIANNE                   = 40,
+
+    DATA_ROAR                       = 41,
+    DATA_STRAWMAN                   = 42,
+    DATA_TINHEAD                    = 43,
+    DATA_TITO                       = 44
 };
 
 enum KZOperaEvents
@@ -101,6 +111,13 @@ enum KZCreatures
     NPC_KILREK                          = 17229,
     NPC_RELAY                           = 17645,
     NPC_BARNES                          = 16812,
+    NPC_DOROTHEE                        = 17535,
+    NPC_TITO                            = 17548,
+    NPC_ROMULO                          = 17533,
+    NPC_JULIANNE                        = 17534,
+    NPC_ROAR                            = 17546,
+    NPC_STRAWMAN                        = 17543,
+    NPC_TINHEAD                         = 17547,
 
     // Chess Event
     NPC_ECHO_OF_MEDIVH                  = 16816,