fix(Core/Scripts): Fix buffer-overflow errors in scripts. (#21419)

This commit is contained in:
Anton Popovichenko
2025-02-12 20:34:56 +01:00
committed by GitHub
parent 076e32292f
commit 47c524581b
3 changed files with 11 additions and 5 deletions
@@ -62,7 +62,8 @@ enum Texts
MinionData const minionData[] = MinionData const minionData[] =
{ {
{ NPC_CHROMATIC_ELITE_GUARD, DATA_GENERAL_DRAKKISATH } { NPC_CHROMATIC_ELITE_GUARD, DATA_GENERAL_DRAKKISATH },
{ 0, 0, }
}; };
DoorData const doorData[] = DoorData const doorData[] =
@@ -53,8 +53,9 @@ ObjectData const creatureData[] =
ObjectData const objectData[] = ObjectData const objectData[] =
{ {
{ GO_PORTCULLIS_CHROMAGGUS, DATA_GO_CHROMAGGUS_DOOR }, { GO_PORTCULLIS_CHROMAGGUS, DATA_GO_CHROMAGGUS_DOOR },
{ GO_PORTCULLIS_CHROMAGGUS_EXIT, DATA_GO_CHROMAGGUS_DOOR_EXIT } { GO_PORTCULLIS_CHROMAGGUS_EXIT, DATA_GO_CHROMAGGUS_DOOR_EXIT },
{ 0, 0 }
}; };
Position const SummonPosition[8] = Position const SummonPosition[8] =
@@ -80,12 +80,16 @@ float summons[3][4] =
{NPC_PHANTASMAL_CLOUDSCRAPER, NPC_PHANTASMAL_CLOUDSCRAPER, NPC_PHANTASMAL_MAMMOTH, NPC_PHANTASMAL_WOLF} {NPC_PHANTASMAL_CLOUDSCRAPER, NPC_PHANTASMAL_CLOUDSCRAPER, NPC_PHANTASMAL_MAMMOTH, NPC_PHANTASMAL_WOLF}
}; };
float cords[4][4] = float cords[5][4] =
{ {
{1177.47f, 937.722f, 527.405f, 2.21657f}, {1177.47f, 937.722f, 527.405f, 2.21657f},
{968.66f, 1042.53f, 527.32f, 0.077f}, {968.66f, 1042.53f, 527.32f, 0.077f},
{1164.02f, 1170.85f, 527.321f, 3.66f}, {1164.02f, 1170.85f, 527.321f, 3.66f},
{1118.31f, 1080.377f, 508.361f, 4.25f} {1118.31f, 1080.377f, 508.361f, 4.25f},
// There are 4 phases but with the code like this:
// me->SetHomePosition(cords[phase + 1][0], cords[phase + 1][1], cords[phase + 1][2], cords[phase + 1][3]);
// lets provide fallback position.
{1177.47f, 937.722f, 527.405f, 2.21657f}
}; };
class boss_urom : public CreatureScript class boss_urom : public CreatureScript