sindoring/moonwell-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix (core): Final Override to Final (#10731)

Browse Source 
PT2, codefactor was green and then decided to complain about the other final overrides in BG
This commit is contained in:
acidmanifesto
2022-02-18 14:08:11 -05:00
committed by GitHub
parent 15fa9b23fd
commit 881760821e
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/game/Battlegrounds/Zones/BattlegroundAB.h
+2 -2
View File
@@ -280,8 +280,8 @@ protected:
void BuildObjectivesBlock(WorldPacket& data) final; void BuildObjectivesBlock(WorldPacket& data) final;
uint32 GetAttr1() const final override { return BasesAssaulted; } uint32 GetAttr1() const override { return BasesAssaulted; }
uint32 GetAttr2() const final override { return BasesDefended; } uint32 GetAttr2() const override { return BasesDefended; }
uint32 BasesAssaulted = 0; uint32 BasesAssaulted = 0;
uint32 BasesDefended = 0; uint32 BasesDefended = 0;
src/server/game/Battlegrounds/Zones/BattlegroundEY.h
+1 -1
View File
@@ -371,7 +371,7 @@ protected:
void BuildObjectivesBlock(WorldPacket& data) final; void BuildObjectivesBlock(WorldPacket& data) final;
uint32 GetAttr1() const final override { return FlagCaptures; } uint32 GetAttr1() const override { return FlagCaptures; }
uint32 FlagCaptures = 0; uint32 FlagCaptures = 0;
}; };
src/server/game/Battlegrounds/Zones/BattlegroundIC.h
+2 -2
View File
@@ -941,8 +941,8 @@ protected:
void BuildObjectivesBlock(WorldPacket& data) final; void BuildObjectivesBlock(WorldPacket& data) final;
uint32 GetAttr1() const final override { return BasesAssaulted; } uint32 GetAttr1() const override { return BasesAssaulted; }
uint32 GetAttr2() const final override { return BasesDefended; } uint32 GetAttr2() const override { return BasesDefended; }
uint32 BasesAssaulted = 0; uint32 BasesAssaulted = 0;
uint32 BasesDefended = 0; uint32 BasesDefended = 0;
src/server/game/Battlegrounds/Zones/BattlegroundSA.h
+2 -2
View File
@@ -444,8 +444,8 @@ protected:
void BuildObjectivesBlock(WorldPacket& data) final; void BuildObjectivesBlock(WorldPacket& data) final;
uint32 GetAttr1() const final override { return DemolishersDestroyed; } uint32 GetAttr1() const override { return DemolishersDestroyed; }
uint32 GetAttr2() const final override { return GatesDestroyed; } uint32 GetAttr2() const override { return GatesDestroyed; }
uint32 DemolishersDestroyed = 0; uint32 DemolishersDestroyed = 0;
uint32 GatesDestroyed = 0; uint32 GatesDestroyed = 0;
src/server/game/Battlegrounds/Zones/BattlegroundWS.h
+2 -2
View File
@@ -207,8 +207,8 @@ protected:
void BuildObjectivesBlock(WorldPacket& data) final; void BuildObjectivesBlock(WorldPacket& data) final;
uint32 GetAttr1() const final override { return FlagCaptures; } uint32 GetAttr1() const override { return FlagCaptures; }
uint32 GetAttr2() const final override { return FlagReturns; } uint32 GetAttr2() const override { return FlagReturns; }
uint32 FlagCaptures = 0; uint32 FlagCaptures = 0;
uint32 FlagReturns = 0; uint32 FlagReturns = 0;