fix(Core/Spells): Properly remove item dependent passive auras on item unequip (#7944)

src/server/game/Entities/Player/PlayerStorage.cpp

@@ -2905,19 +2905,29 @@ void Player::RemoveItem(uint8 bag, uint8 slot, bool update, bool swap)
                     RemoveItemsSetItem(this, pProto);
 
                 _ApplyItemMods(pItem, slot, false);
+            }
+
+            m_items[slot] = nullptr;
 
             // remove item dependent auras and casts (only weapon and armor slots)
-                if (slot < EQUIPMENT_SLOT_END)
+            if (slot < INVENTORY_SLOT_BAG_END && slot < EQUIPMENT_SLOT_END)
             {
                 // Xinef: Ensure that this function is called for places with swap=true
                 if (!swap)
+                {
                     RemoveItemDependentAurasAndCasts(pItem);
+                }
 
                 // remove held enchantments, update expertise
                 if (slot == EQUIPMENT_SLOT_MAINHAND)
+                {
                     UpdateExpertise(BASE_ATTACK);
+                }
                 else if (slot == EQUIPMENT_SLOT_OFFHAND)
+                {
                     UpdateExpertise(OFF_ATTACK);
+                }
+
                 // update armor penetration - passive auras may need it
                 switch (slot)
                 {
@@ -2929,9 +2939,7 @@ void Player::RemoveItem(uint8 bag, uint8 slot, bool update, bool swap)
                         break;
                 }
             }
-            }
 
-            m_items[slot] = nullptr;
             SetGuidValue(PLAYER_FIELD_INV_SLOT_HEAD + (slot * 2), ObjectGuid::Empty);
 
             if (slot < EQUIPMENT_SLOT_END)