sindoring/moonwell-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(Core/Debugging): Improve SymInitialize fail message (#15424)

Browse Source 
* clarify that this is not the crash error, but an error with the crash report itself
* improve formatting and message boundaries
* warn the reader that this means the call stack symbols may be inaccurate

* Cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/6e37438e5dadd30dc2ce36e468045e0be4d26c83)

Co-authored-by: ihm-tswow <76849026+ihm-tswow@users.noreply.github.com>
This commit is contained in:
Kitzunu
2023-03-17 07:19:03 +01:00
committed by GitHub
parent 08e1a822f5
commit b32d3506de
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/Debugging/WheatyExceptionReport.cpp
+7 -2
View File
@@ -674,8 +674,13 @@ void WheatyExceptionReport::GenerateExceptionReport(
// Initialize DbgHelp // Initialize DbgHelp
if (!SymInitialize(GetCurrentProcess(), 0, TRUE)) if (!SymInitialize(GetCurrentProcess(), 0, TRUE))
{ {
Log(_T("\n\rCRITICAL ERROR.\n\r Couldn't initialize the symbol handler for process.\n\rError [%s].\n\r\n\r"), Log(_T("\r\n"));
ErrorMessage(GetLastError())); Log(_T("----\r\n"));
Log(_T("SYMBOL HANDLER ERROR (THIS IS NOT THE CRASH ERROR)\r\n\r\n"));
Log(_T("Couldn't initialize symbol handler for process when generating crash report\r\n"));
Log(_T("Error: %s\r\n"), ErrorMessage(GetLastError()));
Log(_T("THE BELOW CALL STACKS MIGHT HAVE MISSING OR INACCURATE FILE/FUNCTION NAMES\r\n\r\n"));
Log(_T("----\r\n"));
} }
CONTEXT trashableContext = *pCtx; CONTEXT trashableContext = *pCtx;