refactor(Core): remove unused imports (#9969)

src/common/Collision/DynamicTree.cpp

@@ -18,7 +18,6 @@
 #include "DynamicTree.h"
 #include "BoundingIntervalHierarchyWrapper.h"
 #include "GameObjectModel.h"
-#include "Log.h"
 #include "MapTree.h"
 #include "ModelInstance.h"
 #include "RegularGrid.h"

src/common/Utilities/Util.cpp

@@ -20,7 +20,6 @@
 #include "Containers.h"
 #include "IpAddress.h"
 #include "StringConvert.h"
-#include "StringFormat.h"
 #include "Tokenize.h"
 #include <algorithm>
 #include <boost/core/demangle.hpp>

src/server/authserver/Main.cpp

@@ -26,7 +26,6 @@
 #include "AppenderDB.h"
 #include "AuthSocketMgr.h"
 #include "Banner.h"
-#include "Common.h"
 #include "Config.h"
 #include "DatabaseEnv.h"
 #include "DatabaseLoader.h"

src/server/database/Database/DatabaseWorkerPool.cpp

@@ -17,7 +17,6 @@
 
 #include "DatabaseWorkerPool.h"
 #include "AdhocStatement.h"
-#include "Common.h"
 #include "Errors.h"
 #include "Implementation/CharacterDatabase.h"
 #include "Implementation/LoginDatabase.h"
@@ -175,7 +174,7 @@ bool DatabaseWorkerPool<T>::PrepareStatements()
                     uint32 const paramCount = stmt->GetParameterCount();
 
                     // TC only supports uint8 indices.
-                    ASSERT(paramCount < std::numeric_limits<uint8>::max());
+                    ASSERT(paramCount < (std::numeric_limits<uint8>::max)());
 
                     _preparedStatementSize[i] = static_cast<uint8>(paramCount);
                 }

src/server/database/Database/MySQLConnection.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "MySQLConnection.h"
-#include "Common.h"
 #include "DatabaseWorker.h"
 #include "Log.h"
 #include "MySQLHacks.h"

src/server/game/DungeonFinding/LFGPlayerData.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "LFGPlayerData.h"
-#include "LFGMgr.h"
 
 namespace lfg
 {

src/server/game/Entities/Creature/Creature.cpp

@@ -48,7 +48,6 @@
 #include "WaypointMovementGenerator.h"
 #include "World.h"
 #include "WorldPacket.h"
-#include "Pet.h"
 
 // TODO: this import is not necessary for compilation and marked as unused by the IDE
 //  however, for some reasons removing it would cause a damn linking issue

src/server/game/Entities/Pet/Pet.cpp

@@ -17,7 +17,6 @@
 
 #include "Pet.h"
 #include "ArenaSpectator.h"
-#include "Battleground.h"
 #include "Common.h"
 #include "CreatureAI.h"
 #include "DatabaseEnv.h"

src/server/game/Entities/Player/Player.cpp

@@ -80,7 +80,6 @@
 #include "Util.h"
 #include "Vehicle.h"
 #include "Weather.h"
-#include "WeatherMgr.h"
 #include "World.h"
 #include "WorldPacket.h"
 #include "WorldSession.h"

src/server/game/Handlers/AuctionHouseHandler.cpp

@@ -25,7 +25,6 @@
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "UpdateMask.h"
-#include "Util.h"
 #include "World.h"
 #include "WorldPacket.h"
 #include "WorldSession.h"

src/server/game/Modules/ModuleMgr.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ModuleMgr.h"
-#include "Log.h"
 #include "Tokenize.h"
 
 namespace

src/server/scripts/Commands/cs_bag.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "Chat.h"
-#include "Language.h"
 #include "ObjectMgr.h"
 #include "Player.h"
 #include "ScriptMgr.h"

src/server/scripts/Commands/cs_group.cpp

@@ -20,8 +20,6 @@
 #include "DatabaseEnv.h"
 #include "GroupMgr.h"
 #include "Language.h"
-#include "LFG.h"
-#include "ObjectAccessor.h"
 #include "Player.h"
 
 using namespace Acore::ChatCommands;

src/server/scripts/Commands/cs_pet.cpp

@@ -25,7 +25,6 @@
 #include "SpellMgr.h"
 #include "SpellInfo.h"
 #include "WorldSession.h"
-#include "ObjectMgr.h"
 
 using namespace Acore::ChatCommands;
 

src/server/scripts/Commands/cs_send.cpp

@@ -24,7 +24,6 @@
 #include "ObjectMgr.h"
 #include "Pet.h"
 #include "Player.h"
-#include "WorldSession.h"
 #include "Tokenize.h"
 
 using namespace Acore::ChatCommands;

src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/instance_blackwing_lair.cpp

@@ -21,7 +21,6 @@
 #include "MotionMaster.h"
 #include "Player.h"
 #include "ScriptMgr.h"
-#include "ScriptedCreature.h"
 #include "SpellAuraEffects.h"
 #include "SpellScript.h"
 #include "TemporarySummon.h"

src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/boss_golemagg.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ObjectAccessor.h"
-#include "ObjectMgr.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "molten_core.h"

src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/instance_molten_core.cpp

@@ -18,7 +18,6 @@
 #include "InstanceScript.h"
 #include "ObjectMgr.h"
 #include "ScriptMgr.h"
-#include "ScriptedCreature.h"
 #include "TemporarySummon.h"
 #include "molten_core.h"
 

src/server/scripts/Northrend/AzjolNerub/AzjolNerub/boss_hadronox.cpp

@@ -18,7 +18,6 @@
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
-#include "ScriptedEscortAI.h"
 #include "azjol_nerub.h"
 
 enum Spells

src/server/scripts/OutdoorPvP/OutdoorPvPZM.cpp

@@ -18,7 +18,6 @@
 #include "OutdoorPvPZM.h"
 #include "Creature.h"
 #include "GameGraveyard.h"
-#include "GossipDef.h"
 #include "ObjectAccessor.h"
 #include "ObjectMgr.h"
 #include "OutdoorPvPMgr.h"

src/server/worldserver/ACSoap/ACSoap.cpp

@@ -19,7 +19,6 @@
 #include "AccountMgr.h"
 #include "Log.h"
 #include "World.h"
-#include "soapH.h"
 #include "soapStub.h"
 
 void ACSoapThread(const std::string& host, uint16 port)

src/server/worldserver/CommandLine/CliRunnable.cpp

@@ -20,12 +20,9 @@
 /// \file
 
 #include "CliRunnable.h"
-#include "Common.h"
 #include "Config.h"
 #include "Errors.h"
-#include "Log.h"
 #include "ObjectMgr.h"
-#include "Util.h"
 #include "World.h"
 
 #if AC_PLATFORM != AC_PLATFORM_WINDOWS