refactor(Core): remove unused imports (#9767)

src/common/Cryptography/AES.h

@@ -23,7 +23,7 @@ namespace Acore::Crypto
         using Key = std::array<uint8, KEY_SIZE_BYTES>;
         using Tag = uint8[TAG_SIZE_BYTES];
 
-        AES(bool encrypting);
+        explicit AES(bool encrypting);
         ~AES();
 
         void Init(Key const& key);

src/common/Metric/Metric.cpp

@@ -16,13 +16,11 @@
  */
 
 #include "Metric.h"
-#include "Common.h"
 #include "Config.h"
 #include "DeadlineTimer.h"
 #include "Log.h"
 #include "Strand.h"
 #include "Tokenize.h"
-#include "Util.h"
 #include <boost/algorithm/string/replace.hpp>
 #include <boost/asio/ip/tcp.hpp>
 

src/common/Threading/ProcessPriority.cpp

@@ -16,11 +16,11 @@
  */
 
 #include "ProcessPriority.h"
-#include "Log.h"
 
 #ifdef _WIN32 // Windows
 #include <Windows.h>
 #elif defined(__linux__)
+#include "Log.h"
 #include <sched.h>
 #include <sys/resource.h>
 #define PROCESS_HIGH_PRIORITY -15 // [-20, 19], default is 0

src/server/game/AI/CoreAI/PetAI.cpp

@@ -27,7 +27,6 @@
 #include "SpellInfo.h"
 #include "SpellMgr.h"
 #include "Util.h"
-#include "WorldSession.h"
 
 int PetAI::Permissible(const Creature* creature)
 {

src/server/game/AI/CreatureAI.cpp

@@ -23,7 +23,6 @@
 #include "Log.h"
 #include "MapReference.h"
 #include "Player.h"
-#include "SpellMgr.h"
 #include "Vehicle.h"
 
 class PhasedRespawn : public BasicEvent

src/server/game/AI/SmartScripts/SmartAI.cpp

@@ -16,14 +16,11 @@
  */
 
 #include "SmartAI.h"
-#include "Cell.h"
 #include "CellImpl.h"
-#include "DatabaseEnv.h"
 #include "GridDefines.h"
 #include "GridNotifiers.h"
 #include "GridNotifiersImpl.h"
 #include "Group.h"
-#include "InstanceScript.h"
 #include "ObjectDefines.h"
 #include "ObjectMgr.h"
 #include "ScriptMgr.h"

src/server/game/AI/SmartScripts/SmartScriptMgr.cpp

@@ -16,9 +16,7 @@
  */
 
 #include "SmartScriptMgr.h"
-#include "Cell.h"
 #include "CellImpl.h"
-#include "CreatureTextMgr.h"
 #include "DatabaseEnv.h"
 #include "GameEventMgr.h"
 #include "GridDefines.h"

src/server/game/Addons/AddonMgr.cpp

@@ -77,7 +77,7 @@ namespace AddonMgr
             {
                 Field* fields = result->Fetch();
 
-                BannedAddon addon;
+                BannedAddon addon{};
                 addon.Id = fields[0].GetUInt32() + offset;
                 addon.Timestamp = uint32(fields[3].GetUInt64());
 
@@ -113,11 +113,12 @@ namespace AddonMgr
 
     SavedAddon const* GetAddonInfo(const std::string& name)
     {
-        for (SavedAddonsList::const_iterator it = m_knownAddons.begin(); it != m_knownAddons.end(); ++it)
+        for (auto const& addon : m_knownAddons)
         {
-            SavedAddon const& addon = (*it);
             if (addon.Name == name)
+            {
                 return &addon;
+            }
         }
 
         return nullptr;

src/server/game/AuctionHouse/AuctionHouseMgr.cpp

@@ -29,7 +29,6 @@
 #include "ScriptMgr.h"
 #include "World.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 #include <vector>
 
 constexpr auto AH_MINIMUM_DEPOSIT = 100;

src/server/game/Battlefield/BattlefieldHandler.cpp

@@ -17,8 +17,6 @@
 
 #include "Battlefield.h"
 #include "BattlefieldMgr.h"
-#include "Common.h"
-#include "ObjectAccessor.h"
 #include "ObjectMgr.h"
 #include "Opcodes.h"
 #include "Player.h"

src/server/game/Battlefield/BattlefieldMgr.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "BattlefieldMgr.h"
-#include "ObjectMgr.h"
 #include "Player.h"
 #include "Zones/BattlefieldWG.h"
 

src/server/game/Battlegrounds/BattlegroundMgr.cpp

@@ -37,7 +37,6 @@
 #include "GameEventMgr.h"
 #include "GameGraveyard.h"
 #include "Map.h"
-#include "MapInstanced.h"
 #include "MapMgr.h"
 #include "ObjectMgr.h"
 #include "Opcodes.h"
@@ -45,7 +44,6 @@
 #include "SharedDefines.h"
 #include "World.h"
 #include "WorldPacket.h"
-#include <random>
 #include <unordered_map>
 
 /*********************************************************/

src/server/game/Battlegrounds/Zones/BattlegroundBE.cpp

@@ -18,11 +18,8 @@
 #include "BattlegroundBE.h"
 #include "Language.h"
 #include "Log.h"
-#include "Object.h"
-#include "ObjectMgr.h"
 #include "Player.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 
 BattlegroundBE::BattlegroundBE()
 {

src/server/game/Battlegrounds/Zones/BattlegroundEY.cpp

@@ -20,7 +20,6 @@
 #include "Creature.h"
 #include "GameGraveyard.h"
 #include "Language.h"
-#include "Object.h"
 #include "ObjectMgr.h"
 #include "Player.h"
 #include "Util.h"

src/server/game/Battlegrounds/Zones/BattlegroundNA.cpp

@@ -17,11 +17,9 @@
 
 #include "BattlegroundNA.h"
 #include "Language.h"
-#include "Object.h"
 #include "ObjectMgr.h"
 #include "Player.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 
 BattlegroundNA::BattlegroundNA()
 {

src/server/game/Battlegrounds/Zones/BattlegroundRL.cpp

@@ -20,7 +20,6 @@
 #include "Log.h"
 #include "Player.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 
 BattlegroundRL::BattlegroundRL()
 {

src/server/game/Cache/CharacterCache.cpp

@@ -22,7 +22,6 @@
 #include "Player.h"
 #include "Timer.h"
 #include "World.h"
-#include "WorldPacket.h"
 #include <unordered_map>
 
 namespace

src/server/game/Cache/WhoListCacheMgr.cpp

@@ -18,9 +18,7 @@
 #include "WhoListCacheMgr.h"
 #include "GuildMgr.h"
 #include "ObjectAccessor.h"
-#include "Player.h"
 #include "World.h"
-#include "WorldSession.h"
 
 WhoListCacheMgr* WhoListCacheMgr::instance()
 {

src/server/game/Chat/Chat.cpp

@@ -19,7 +19,6 @@
 #include "AccountMgr.h"
 #include "CellImpl.h"
 #include "Common.h"
-#include "DatabaseEnv.h"
 #include "GridNotifiersImpl.h"
 #include "Language.h"
 #include "Log.h"

src/server/game/Chat/ChatCommands/ChatCommandArgs.cpp

@@ -17,7 +17,6 @@
 
 #include "ChatCommandArgs.h"
 #include "AchievementMgr.h"
-#include "ChatCommand.h"
 #include "ObjectMgr.h"
 #include "SpellMgr.h"
 #include "Util.h"

src/server/game/DataStores/DBCStores.cpp

@@ -26,7 +26,6 @@
 #include "TransportMgr.h"
 #include "World.h"
 #include <fstream>
-#include <iomanip>
 #include <iostream>
 #include <map>
 

src/server/game/DungeonFinding/LFGScripts.cpp

@@ -26,7 +26,6 @@
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "SharedDefines.h"
-#include "WorldSession.h"
 
 namespace lfg
 {

src/server/game/Entities/Creature/Creature.cpp

@@ -52,6 +52,7 @@
 // TODO: this import is not necessary for compilation and marked as unused by the IDE
 //  however, for some reasons removing it would cause a damn linking issue
 //  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
 #include "GridNotifiersImpl.h"
 
 TrainerSpell const* TrainerSpellData::Find(uint32 spell_id) const

src/server/game/Entities/Object/Object.cpp

@@ -20,7 +20,6 @@
 #include "BattlefieldMgr.h"
 #include "CellImpl.h"
 #include "Chat.h"
-#include "Common.h"
 #include "Creature.h"
 #include "DynamicTree.h"
 #include "DynamicVisibility.h"
@@ -53,6 +52,7 @@
 // TODO: this import is not necessary for compilation and marked as unused by the IDE
 //  however, for some reasons removing it would cause a damn linking issue
 //  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
 #include "GridNotifiersImpl.h"
 
 constexpr float VisibilityDistances[AsUnderlyingType(VisibilityDistanceType::Max)] =

src/server/game/Entities/Player/Player.cpp

@@ -28,7 +28,6 @@
 #include "BattlegroundMgr.h"
 #include "CellImpl.h"
 #include "Channel.h"
-#include "ChannelMgr.h"
 #include "CharacterCache.h"
 #include "CharacterDatabaseCleaner.h"
 #include "Chat.h"
@@ -42,10 +41,8 @@
 #include "GameEventMgr.h"
 #include "GameGraveyard.h"
 #include "GameObjectAI.h"
-#include "GitRevision.h"
 #include "GossipDef.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "GroupMgr.h"
 #include "Guild.h"
@@ -56,7 +53,6 @@
 #include "LFGMgr.h"
 #include "Log.h"
 #include "LootItemStorage.h"
-#include "MapInstanced.h"
 #include "MapMgr.h"
 #include "ObjectAccessor.h"
 #include "ObjectMgr.h"
@@ -66,14 +62,12 @@
 #include "Pet.h"
 #include "PetitionMgr.h"
 #include "Player.h"
-#include "PoolMgr.h"
 #include "QuestDef.h"
 #include "QueryHolder.h"
 #include "ReputationMgr.h"
 #include "Realm.h"
 #include "SavingSystem.h"
 #include "ScriptMgr.h"
-#include "SkillDiscovery.h"
 #include "SocialMgr.h"
 #include "Spell.h"
 #include "SpellAuraEffects.h"
@@ -92,6 +86,12 @@
 #include "WorldPacket.h"
 #include "WorldSession.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 enum CharacterFlags
 {
     CHARACTER_FLAG_NONE                 = 0x00000000,

src/server/game/Entities/Player/PlayerStorage.cpp

@@ -74,7 +74,12 @@
 #include "WeatherMgr.h"
 #include "World.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
+
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
 
 /*********************************************************/
 /***                    STORAGE SYSTEM                 ***/

src/server/game/Entities/Player/PlayerUpdates.cpp

@@ -21,7 +21,6 @@
 #include "ChannelMgr.h"
 #include "Formulas.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "Guild.h"
 #include "InstanceScript.h"
@@ -38,6 +37,12 @@
 #include "Vehicle.h"
 #include "WeatherMgr.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 // Zone Interval should be 1 second
 constexpr auto ZONE_UPDATE_INTERVAL = 1000;
 

src/server/game/Entities/Unit/Unit.cpp

@@ -28,7 +28,6 @@
 #include "Common.h"
 #include "ConditionMgr.h"
 #include "Creature.h"
-#include "CreatureAI.h"
 #include "CreatureAIImpl.h"
 #include "CreatureGroups.h"
 #include "DisableMgr.h"
@@ -50,7 +49,6 @@
 #include "Pet.h"
 #include "PetAI.h"
 #include "Player.h"
-#include "QuestDef.h"
 #include "ReputationMgr.h"
 #include "Spell.h"
 #include "SpellAuraEffects.h"
@@ -67,7 +65,6 @@
 #include "Vehicle.h"
 #include "World.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 #include <math.h>
 
 float baseMoveSpeed[MAX_MOVE_TYPE] =

src/server/game/Entities/Vehicle/Vehicle.cpp

@@ -17,7 +17,6 @@
 
 #include "Vehicle.h"
 #include "BattlefieldWG.h"
-#include "Common.h"
 #include "CreatureAI.h"
 #include "Log.h"
 #include "MoveSplineInit.h"
@@ -28,7 +27,6 @@
 #include "TemporarySummon.h"
 #include "Unit.h"
 #include "Util.h"
-#include "WorldPacket.h"
 
 Vehicle::Vehicle(Unit* unit, VehicleEntry const* vehInfo, uint32 creatureEntry) :
     _me(unit), _vehicleInfo(vehInfo), _usableSeatNum(0), _creatureEntry(creatureEntry), _status(STATUS_NONE)

src/server/game/Handlers/AddonHandler.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "AddonHandler.h"
-#include "DatabaseEnv.h"
 #include "Log.h"
 #include "Opcodes.h"
 #include "zlib.h"

src/server/game/Handlers/NPCHandler.cpp

@@ -21,7 +21,6 @@
 #include "DatabaseEnv.h"
 #include "GameGraveyard.h"
 #include "Language.h"
-#include "ObjectAccessor.h"
 #include "ObjectMgr.h"
 #include "Opcodes.h"
 #include "Pet.h"

src/server/game/Handlers/SkillHandler.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "Log.h"
-#include "ObjectAccessor.h"
 #include "Opcodes.h"
 #include "Pet.h"
 #include "Player.h"

src/server/game/Mails/Mail.cpp

@@ -28,7 +28,6 @@
 #include "ScriptMgr.h"
 #include "Unit.h"
 #include "World.h"
-#include "WorldSession.h"
 
 MailSender::MailSender(Object* sender, MailStationery stationery) : m_stationery(stationery)
 {

src/server/game/Misc/AsyncAuctionListing.cpp

@@ -21,7 +21,6 @@
 #include "Opcodes.h"
 #include "Player.h"
 #include "SpellAuraEffects.h"
-#include "WorldSession.h"
 
 uint32 AsyncAuctionListingMgr::auctionListingDiff = 0;
 bool AsyncAuctionListingMgr::auctionListingAllowed = false;

src/server/game/Misc/BanMgr.cpp

@@ -20,7 +20,6 @@
 #include "DatabaseEnv.h"
 #include "Language.h"
 #include "ObjectAccessor.h"
-#include "ObjectMgr.h"
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "World.h"

src/server/game/Motd/ServerMotd.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ServerMotd.h"
-#include "Common.h"
 #include "Opcodes.h"
 #include "ScriptMgr.h"
 #include "Util.h"

src/server/game/Scripting/ScriptDefines/AchievementCriteriaScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 
 bool ScriptMgr::OnCriteriaCheck(uint32 scriptId, Player* source, Unit* target, uint32 criteria_id)
 {

src/server/game/Scripting/ScriptDefines/BattlegroundScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 
 Battleground* ScriptMgr::CreateBattleground(BattlegroundTypeId /*typeId*/)
 {

src/server/game/Scripting/ScriptDefines/CommandScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 #include "Chat.h"
 
 Acore::ChatCommands::ChatCommandTable ScriptMgr::GetChatCommands()

src/server/game/Scripting/ScriptDefines/ConditionScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 
 bool ScriptMgr::OnConditionCheck(Condition* condition, ConditionSourceInfo& sourceInfo)
 {

src/server/game/Scripting/ScriptDefines/DynamicObjectScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 
 void ScriptMgr::OnDynamicObjectUpdate(DynamicObject* dynobj, uint32 diff)
 {

src/server/game/Scripting/ScriptDefines/InstanceMapScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 
 InstanceScript* ScriptMgr::CreateInstanceScript(InstanceMap* map)
 {

src/server/game/Scripting/ScriptDefines/OutdoorPvPScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 #include "OutdoorPvPMgr.h"
 
 OutdoorPvP* ScriptMgr::CreateOutdoorPvP(OutdoorPvPData const* data)

src/server/game/Scripting/ScriptDefines/SpellScriptLoader.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 #include "SpellScript.h"
 
 void ScriptMgr::CreateSpellScripts(uint32 spellId, std::list<SpellScript*>& scriptVector)

src/server/game/Scripting/ScriptDefines/TransportScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 #include "Transport.h"
 
 void ScriptMgr::OnAddPassenger(Transport* transport, Player* player)

src/server/game/Scripting/ScriptDefines/VehicleScript.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "ScriptMgr.h"
-#include "ScriptMgrMacros.h"
 #include "Vehicle.h"
 
 void ScriptMgr::OnInstall(Vehicle* veh)

src/server/game/Scripting/ScriptSystem.cpp

@@ -18,7 +18,6 @@
 #include "ScriptSystem.h"
 #include "DatabaseEnv.h"
 #include "ObjectMgr.h"
-#include "ScriptMgr.h"
 
 ScriptPointVector const SystemMgr::_empty;
 

src/server/game/Spells/Auras/SpellAuraEffects.cpp

@@ -20,9 +20,7 @@
 #include "Battleground.h"
 #include "CellImpl.h"
 #include "Common.h"
-#include "Formulas.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "InstanceScript.h"
 #include "Log.h"
 #include "ObjectAccessor.h"
@@ -40,6 +38,12 @@
 #include "Vehicle.h"
 #include "WorldPacket.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 class Aura;
 //
 // EFFECT HANDLER NOTES

src/server/game/Spells/Auras/SpellAuras.cpp

@@ -18,9 +18,7 @@
 #include "ArenaSpectator.h"
 #include "CellImpl.h"
 #include "Common.h"
-#include "DynamicObject.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Log.h"
 #include "ObjectAccessor.h"
 #include "ObjectMgr.h"
@@ -36,6 +34,12 @@
 #include "Vehicle.h"
 #include "WorldPacket.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 // update aura target map every 500 ms instead of every update - reduce amount of grid searcher calls
 static constexpr int32 UPDATE_TARGET_MAP_INTERVAL = 500;
 

src/server/game/Spells/SpellEffects.cpp

@@ -60,7 +60,12 @@
 #include "Vehicle.h"
 #include "World.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
+
+ // TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
 
 pEffect SpellEffects[TOTAL_SPELL_EFFECTS] =
 {

src/server/game/Spells/SpellInfo.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "SpellInfo.h"
-#include "Battleground.h"
 #include "Chat.h"
 #include "ConditionMgr.h"
 #include "DBCStores.h"

src/server/game/Spells/SpellMgr.cpp

@@ -17,7 +17,6 @@
 
 #include "SpellMgr.h"
 #include "BattlefieldMgr.h"
-#include "BattlefieldWG.h"
 #include "BattlegroundIC.h"
 #include "BattlegroundMgr.h"
 #include "Chat.h"

src/server/scripts/Commands/cs_arena.cpp

@@ -25,7 +25,6 @@ EndScriptData */
 #include "ArenaTeamMgr.h"
 #include "Chat.h"
 #include "Language.h"
-#include "ObjectMgr.h"
 #include "Player.h"
 #include "ScriptMgr.h"
 

src/server/scripts/Commands/cs_guild.cpp

@@ -26,7 +26,6 @@ EndScriptData */
 #include "Guild.h"
 #include "GuildMgr.h"
 #include "Language.h"
-#include "ObjectAccessor.h"
 #include "ScriptMgr.h"
 
 #if AC_COMPILER == AC_COMPILER_GNU

src/server/scripts/Commands/cs_message.cpp

@@ -23,7 +23,6 @@ Category: commandscripts
 EndScriptData */
 
 #include "Channel.h"
-#include "ChannelMgr.h"
 #include "Chat.h"
 #include "DBCStores.h"
 #include "DatabaseEnv.h"

src/server/scripts/Commands/cs_misc.cpp

@@ -23,7 +23,6 @@
 #include "Chat.h"
 #include "GameGraveyard.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "GroupMgr.h"
 #include "GuildMgr.h"
@@ -43,6 +42,12 @@
 #include "TargetedMovementGenerator.h"
 #include "WeatherMgr.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 #if AC_COMPILER == AC_COMPILER_GNU
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #endif

src/server/scripts/Events/hallows_end.cpp

@@ -19,7 +19,6 @@
 #include "GameObjectAI.h"
 #include "GossipDef.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "LFGMgr.h"
 #include "PassiveAI.h"
@@ -29,6 +28,12 @@
 #include "SpellScript.h"
 #include "TaskScheduler.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 ///////////////////////////////////////
 ////// ITEMS FIXES, BASIC STUFF
 ///////////////////////////////////////

src/server/scripts/Kalimdor/CavernsOfTime/EscapeFromDurnholdeKeep/instance_old_hillsbrad.cpp

@@ -18,7 +18,6 @@
 #include "InstanceScript.h"
 #include "Player.h"
 #include "ScriptMgr.h"
-#include "ScriptedCreature.h"
 #include "old_hillsbrad.h"
 
 const Position instancePositions[INSTANCE_POSITIONS_COUNT] =

src/server/scripts/Kalimdor/zone_silithus.cpp

@@ -28,7 +28,6 @@ quest_a_pawn_on_the_eternal_pawn
 EndContentData */
 
 #include "AccountMgr.h"
-#include "BanMgr.h"
 #include "GameObject.h"
 #include "GameObjectAI.h"
 #include "Group.h"
@@ -38,7 +37,6 @@ EndContentData */
 #include "ScriptedGossip.h"
 #include "Spell.h"
 #include "SpellInfo.h"
-#include "WorldSession.h"
 
 /*####
 # quest_a_pawn_on_the_eternal_board (Defines)

src/server/scripts/Northrend/zone_zuldrak.cpp

@@ -15,12 +15,10 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "CombatAI.h"
 #include "PassiveAI.h"
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
-#include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
 #include "SpellAuras.h"
 #include "SpellInfo.h"

src/server/scripts/Outland/HellfireCitadel/MagtheridonsLair/instance_magtheridons_lair.cpp

@@ -17,7 +17,6 @@
 
 #include "InstanceScript.h"
 #include "ScriptMgr.h"
-#include "ScriptedCreature.h"
 #include "magtheridons_lair.h"
 
 DoorData const doorData[] =

src/server/scripts/Outland/zone_blades_edge_mountains.cpp

@@ -31,7 +31,6 @@ EndContentData */
 #include "Cell.h"
 #include "CellImpl.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
@@ -40,6 +39,12 @@ EndContentData */
 #include "SpellInfo.h"
 #include "SpellScript.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 // Ours
 enum deathsdoorfell
 {

src/server/scripts/Outland/zone_shadowmoon_valley.cpp

@@ -44,7 +44,6 @@ EndContentData */
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
 #include "SpellScript.h"
-#include "WorldSession.h"
 
 // Ours
 class spell_q10612_10613_the_fel_and_the_furious : public SpellScriptLoader

src/server/scripts/Outland/zone_shattrath_city.cpp

@@ -36,7 +36,6 @@ EndContentData */
 #include "ScriptedCreature.h"
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 /*######
 ## npc_raliq_the_drunk

src/server/scripts/Outland/zone_terokkar_forest.cpp

@@ -40,7 +40,6 @@ EndContentData */
 #include "ScriptedGossip.h"
 #include "SpellAuras.h"
 #include "SpellScript.h"
-#include "WorldSession.h"
 
 // Ours
 enum fumping

src/server/scripts/Outland/zone_zangarmarsh.cpp

@@ -36,7 +36,6 @@ EndContentData */
 #include "ScriptedCreature.h"
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 // Ours
 enum eNaturalist

src/server/scripts/Pet/pet_dk.cpp

@@ -24,12 +24,17 @@
 #include "CellImpl.h"
 #include "CombatAI.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "PassiveAI.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "SpellAuraEffects.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 enum DeathKnightSpells
 {
     SPELL_DK_SUMMON_GARGOYLE_1      = 49206,

src/server/scripts/Spells/spell_generic.cpp

@@ -45,6 +45,7 @@
 // TODO: this import is not necessary for compilation and marked as unused by the IDE
 //  however, for some reasons removing it would cause a damn linking issue
 //  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
 #include "GridNotifiersImpl.h"
 
 // 46642 - 5,000 Gold

src/server/scripts/Spells/spell_hunter.cpp

@@ -34,6 +34,7 @@
 // TODO: this import is not necessary for compilation and marked as unused by the IDE
 //  however, for some reasons removing it would cause a damn linking issue
 //  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
 #include "GridNotifiersImpl.h"
 
 enum HunterSpells

src/server/scripts/World/boss_emerald_dragons.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "GridNotifiers.h"
-#include "ObjectMgr.h"
 #include "PassiveAI.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"

src/server/scripts/World/npc_innkeeper.cpp

@@ -20,7 +20,6 @@
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 constexpr auto SPELL_TRICK = 24714;
 constexpr auto SPELL_TREAT = 24715;

src/server/scripts/World/npc_professions.cpp

@@ -27,7 +27,6 @@ EndScriptData */
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
 #include "SpellInfo.h"
-#include "WorldSession.h"
 
 /*
 A few notes for future developement:

src/server/scripts/World/npc_taxi.cpp

@@ -27,7 +27,6 @@ EndScriptData
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 #define GOSSIP_NETHER_DRAKE     "I'm ready to fly! Take me up, dragon!"
 #define GOSSIP_IRONWING         "I'd like to take a flight around Stormwind Harbor."

src/server/scripts/World/npcs_special.cpp

@@ -36,7 +36,6 @@ npc_locksmith            75%    list of keys needs to be confirmed
 npc_firework            100%    NPC's summoned by rockets and rocket clusters, for making them cast visual
 EndContentData */
 
-#include "Cell.h"
 #include "CellImpl.h"
 #include "Chat.h"
 #include "CombatAI.h"
@@ -44,8 +43,6 @@ EndContentData */
 #include "DBCStructure.h"
 #include "GameEventMgr.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
-#include "Group.h"
 #include "ObjectMgr.h"
 #include "PassiveAI.h"
 #include "Pet.h"
@@ -58,6 +55,12 @@ EndContentData */
 #include "WaypointMgr.h"
 #include "World.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 enum elderClearwater
 {
     EVENT_CLEARWATER_ANNOUNCE           = 1,

src/tools/map_extractor/System.cpp

@@ -37,7 +37,6 @@
 #include "adt.h"
 #include "wdt.h"
 
-#include "G3D/Plane.h"
 #include <fcntl.h>
 
 #if defined( __GNUC__ )

src/tools/mesh_extractor/Geometry.cpp

@@ -20,7 +20,6 @@
 #include "Constants.h"
 #include "DoodadHandler.h"
 #include "WorldModelHandler.h"
-#include <limits.h>
 
 Geometry::Geometry() : Transform(false)
 {

src/tools/mesh_extractor/ObjectDataHandler.cpp

@@ -17,8 +17,6 @@
 
 #include "ObjectDataHandler.h"
 #include "ADT.h"
-#include "Chunk.h"
-#include "ChunkedData.h"
 
 void ObjectDataHandler::ProcessMapChunk( MapChunk* chunk )
 {

src/tools/vmap4_extractor/vmapexport.cpp

@@ -18,7 +18,6 @@
 #define _CRT_SECURE_NO_DEPRECATE
 #include <cerrno>
 #include <cstdio>
-#include <iostream>
 #include <list>
 #include <map>
 #include <sys/stat.h>

src/tools/vmap4_extractor/wmo.cpp

@@ -22,7 +22,6 @@
 #include <cassert>
 #include <cstdio>
 #include <cstdlib>
-#include <fstream>
 #include <map>
 #include <utility>
 #undef min