chore(Script/Misc): Cleanup some JustDied hooks (#9669)

src/server/scripts/EasternKingdoms/SunwellPlateau/boss_kalecgos.cpp

@@ -196,9 +196,9 @@ public:
             }
         }
 
-        void JustDied(Unit* who) override
+        void JustDied(Unit* killer) override
         {
-            BossAI::JustDied(who);
+            BossAI::JustDied(killer);
         }
 
         void EnterCombat(Unit* who) override

src/server/scripts/Northrend/AzjolNerub/ahnkahet/boss_amanitar.cpp

@@ -123,7 +123,7 @@ struct boss_amanitar : public BossAI
         events.ScheduleEvent(EVENT_RESPAWN, 40000, 60000);
     }
 
-    void JustDied(Unit* /*Killer*/) override
+    void JustDied(Unit* /*killer*/) override
     {
         _JustDied();
         instance->DoRemoveAurasDueToSpellOnPlayers(SPELL_MINI);

src/server/scripts/Northrend/AzjolNerub/ahnkahet/boss_jedoga_shadowseeker.cpp

@@ -336,7 +336,7 @@ struct boss_jedoga_shadowseeker : public BossAI
         Talk(SAY_SLAY);
     }
 
-    void JustDied(Unit* /*Killer*/) override
+    void JustDied(Unit* /*killer*/) override
     {
         _JustDied();
         DespawnOOCSummons();

src/server/scripts/Northrend/Ulduar/Ulduar/boss_auriaya.cpp

@@ -208,7 +208,7 @@ public:
             }
         }
 
-        void JustDied(Unit* /*victim*/) override
+        void JustDied(Unit* /*killer*/) override
         {
             if (m_pInstance)
                 m_pInstance->SetData(TYPE_AURIAYA, DONE);

src/server/scripts/Northrend/Ulduar/Ulduar/boss_flame_leviathan.cpp

@@ -804,10 +804,10 @@ public:
             }
         }
 
-        void JustDied(Unit* who) override
+        void JustDied(Unit* killer) override
         {
-            if (Player* killer = who->ToPlayer())
+            if (Player* player = killer->ToPlayer())
-                killer->UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_GET_KILLING_BLOWS, 1, 0, me);
+                player->UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_GET_KILLING_BLOWS, 1, 0, me);
 
             if (Vehicle* vehicle = me->GetVehicle())
                 if (Unit* device = vehicle->GetPassenger(SEAT_DEVICE))

src/server/scripts/Northrend/Ulduar/Ulduar/boss_ignis.cpp

@@ -309,7 +309,7 @@ public:
             }
         }
 
-        void JustDied(Unit* /*victim*/) override
+        void JustDied(Unit* /*killer*/) override
         {
             me->Yell(TEXT_DEATH, LANG_UNIVERSAL);
             me->PlayDirectSound(SOUND_DEATH);

src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp

@@ -236,7 +236,7 @@ public:
             }
         }
 
-        void JustDied(Unit* /*victim*/) override
+        void JustDied(Unit* /*killer*/) override
         {
             me->Yell("You are bad... Toys... Very... Baaaaad!", LANG_UNIVERSAL);
             me->PlayDirectSound(XT_SOUND_DEATH);
@@ -533,7 +533,7 @@ public:
                 }
         }
 
-        void JustDied(Unit* /*victim*/) override
+        void JustDied(Unit* /*killer*/) override
         {
             me->SetVisible(false);
             if (me->GetInstanceScript())
@@ -591,7 +591,7 @@ public:
         void JustDied(Unit* killer) override
         {
             // Nerf Scrapbots achievement
-            if (killer->GetEntry() == NPC_XE321_BOOMBOT)
+            if (killer && killer->GetEntry() == NPC_XE321_BOOMBOT)
                 if (me->GetInstanceScript())
                 {
                     me->GetInstanceScript()->DoStartTimedAchievement(ACHIEVEMENT_TIMED_TYPE_SPELL_TARGET, 65037);

src/server/scripts/Outland/TempestKeep/Mechanar/boss_mechano_lord_capacitus.cpp

@@ -79,7 +79,7 @@ public:
                 Talk(YELL_KILL);
         }
 
-        void JustDied(Unit* /*victim*/) override
+        void JustDied(Unit* /*killer*/) override
         {
             _JustDied();
             Talk(YELL_DEATH);