feat(CI/Codestyle): added codestyle check (#3668)

.github/workflows/codestyle.yml

@@ -0,0 +1,15 @@
+name: check-codestyle
+on:
+  push:
+  pull_request:
+
+jobs:
+  check-codestyle:
+    strategy:
+      fail-fast: false
+    runs-on: ubuntu-20.04
+    name: check codestyle
+    steps:
+      - uses: actions/checkout@v2
+      - name: Check core codestyle
+        run: source ./apps/ci/ci-codestyle.sh

apps/ci/ci-codestyle.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+set -e
+
+echo "Codestyle check script:"
+echo
+
+declare -A singleLineRegexChecks=(
+    ["[[:blank:]]$"]="Remove whitespace at the end of the lines above"
+    ["\t"]="Replace tabs with 4 spaces in the lines above"
+)
+
+for check in ${!singleLineRegexChecks[@]}; do
+    echo "  Checking RegEx: '${check}'"
+    
+    if grep -P -r -I -n ${check} src; then
+        echo
+        echo "${singleLineRegexChecks[$check]}"
+        exit 1
+    fi
+done
+
+echo
+echo "Everything looks good"

src/cmake/ac_macros.cmake

@@ -29,7 +29,6 @@ MACRO(AC_ADD_SCRIPT_LOADER script_dec include)
         CU_ADD_GLOBAL("AC_ADD_SCRIPTS_LIST" "Add${script_dec}Scripts()\;")
     endif()
 
-
     if (NOT ${include} STREQUAL "")
         CU_GET_GLOBAL("AC_ADD_SCRIPTS_INCLUDE")
         if (NOT ";${AC_ADD_SCRIPTS_INCLUDE};" MATCHES ";${include};")

src/cmake/macros/EnsureVersion.cmake

@@ -58,7 +58,6 @@
 # Redistribution and use is allowed according to the terms of the BSD license.
 # For details see the accompanying COPYING-CMAKE-SCRIPTS file.
 
-
 MACRO(NORMALIZE_VERSION _requested_version _normalized_version)
     STRING(REGEX MATCH "[^0-9]*[0-9]+\\.[0-9]+\\.[0-9]+.*" _threePartMatch "${_requested_version}")
     if (_threePartMatch)

src/cmake/platform/settings.cmake

@@ -2,4 +2,3 @@
 if( PREFIX )
   set(CMAKE_INSTALL_PREFIX "${PREFIX}")
 endif()
-

src/cmake/showoptions.cmake

@@ -145,4 +145,3 @@ else()
 endif()
 
 message("")
-

src/common/Collision/BoundingIntervalHierarchyWrapper.h

@@ -12,7 +12,6 @@
 #include "G3D/Set.h"
 #include "BoundingIntervalHierarchy.h"
 
-
 template<class T, class BoundsFunc = BoundsTrait<T>>
 class BIHWrap
 {

src/common/Collision/Management/MMapFactory.h

@@ -38,4 +38,3 @@ namespace MMAP
 }
 
 #endif
-

src/common/Collision/Management/MMapManager.h

@@ -50,7 +50,6 @@ namespace MMAP
         MMapTileSet mmapLoadedTiles;        // maps [map grid coords] to [dtTile]
     };
 
-
     typedef std::unordered_map<uint32, MMapData*> MMapDataSet;
 
     // singleton class

src/common/Collision/Maps/TileAssembler.cpp

@@ -408,7 +408,6 @@ namespace VMAP
         READ_OR_RETURN(&mogpflags, sizeof(uint32));
         READ_OR_RETURN(&GroupWMOID, sizeof(uint32));
 
-
         Vector3 vec1, vec2;
         READ_OR_RETURN(&vec1, sizeof(Vector3));
 
@@ -482,7 +481,6 @@ namespace VMAP
         return true;
     }
 
-
     GroupModel_Raw::~GroupModel_Raw()
     {
         delete liquid;

src/common/Collision/Maps/TileAssembler.h

@@ -63,7 +63,6 @@ namespace VMAP
         std::vector<G3D::Vector3> vertexArray;
         class WmoLiquid* liquid;
 
-
         GroupModel_Raw() : liquid(nullptr) { }
 
         ~GroupModel_Raw();

src/common/Collision/Models/GameObjectModel.h

@@ -34,7 +34,6 @@ class GameObjectModel /*, public Intersectable*/
     VMAP::WorldModel* iModel;
     GameObject const* owner;
 
-
     GameObjectModel() :  iModel(nullptr), owner(nullptr) { }
     bool initialize(const GameObject& go, const GameObjectDisplayInfoEntry& info);
 

src/common/Collision/RegularGrid.h

@@ -1,7 +1,6 @@
 #ifndef _REGULAR_GRID_H
 #define _REGULAR_GRID_H
 
-
 #include <G3D/Ray.h>
 #include <G3D/Table.h>
 #include <G3D/BoundsTrait.h>
@@ -143,7 +142,6 @@ public:
         bool isValid() const { return x >= 0 && x < CELL_NUMBER && y >= 0 && y < CELL_NUMBER;}
     };
 
-
     Node& getGridFor(float fx, float fy)
     {
         Cell c = Cell::ComputeCell(fx, fy);

src/common/Common.cpp

@@ -35,4 +35,3 @@ void CleanStringForMysqlQuery(std::string& str)
     while ((n = str.find('"')) != str.npos) str.erase(n, 1);
     while ((n = str.find('\'')) != str.npos) str.erase(n, 1);
 }
-

src/common/Cryptography/Authentication/AuthCrypt.cpp

@@ -58,4 +58,3 @@ void AuthCrypt::EncryptSend(uint8* data, size_t len)
 
     _serverEncrypt.UpdateData(len, data);
 }
-

src/common/Cryptography/BigNumber.cpp

@@ -4,7 +4,6 @@
  * Copyright (C) 2005-2009 MaNGOS <http://getmangos.com/>
  */
 
-
 #include "Cryptography/BigNumber.h"
 #include <openssl/bn.h>
 #include <openssl/crypto.h>
@@ -186,4 +185,3 @@ char* BigNumber::AsDecStr() const
 {
     return BN_bn2dec(_bn);
 }
-

src/common/Cryptography/BigNumber.h

@@ -88,4 +88,3 @@ private:
 
 };
 #endif
-

src/common/Cryptography/HMACSHA1.h

@@ -32,4 +32,3 @@ private:
     uint8 m_digest[SHA_DIGEST_LENGTH];
 };
 #endif
-

src/common/Cryptography/SHA1.cpp

@@ -53,4 +53,3 @@ void SHA1Hash::Finalize(void)
 {
     SHA1_Final(mDigest, &mC);
 }
-

src/common/Cryptography/SHA1.h

@@ -35,4 +35,3 @@ private:
     uint8 mDigest[SHA_DIGEST_LENGTH];
 };
 #endif
-

src/common/Database/DatabaseEnv.h

@@ -31,4 +31,3 @@ extern CharacterDatabaseWorkerPool CharacterDatabase;
 extern LoginDatabaseWorkerPool LoginDatabase;
 
 #endif
-

src/common/Database/Field.h

@@ -410,4 +410,3 @@ private:
 };
 
 #endif
-

src/common/Database/PreparedStatement.cpp

@@ -451,7 +451,6 @@ PreparedStatementTask::PreparedStatementTask(PreparedStatement* stmt, PreparedQu
 {
 }
 
-
 PreparedStatementTask::~PreparedStatementTask()
 {
     delete m_stmt;

src/common/Database/QueryResult.h

@@ -99,4 +99,3 @@ private:
 typedef std::shared_ptr<PreparedResultSet> PreparedQueryResult;
 
 #endif
-

src/common/Debugging/WheatyExceptionReport.cpp

@@ -70,7 +70,6 @@ bool WheatyExceptionReport::alreadyCrashed;
 std::mutex WheatyExceptionReport::alreadyCrashedLock;
 WheatyExceptionReport::pRtlGetVersion WheatyExceptionReport::RtlGetVersion;
 
-
 // Declare global instance of class
 WheatyExceptionReport g_WheatyExceptionReport;
 
@@ -1230,7 +1229,6 @@ void WheatyExceptionReport::DumpTypeIndex(
                 dataKind == DataIsStaticMember)
             continue;
 
-
         symbolDetails.top().HasChildren = true;
         if (!logChildren)
         {

src/common/Dynamic/LinkedReference/RefManager.h

@@ -41,4 +41,3 @@ public:
 
 //=====================================================
 #endif
-

src/common/Dynamic/TypeContainer.h

@@ -109,4 +109,3 @@ private:
     ContainerMapList<OBJECT_TYPES> i_elements;
 };
 #endif
-

src/common/Dynamic/TypeContainerFunctions.h

@@ -98,4 +98,3 @@ namespace acore
     //}
 }
 #endif
-

src/common/Dynamic/TypeContainerFunctionsPtr.h

@@ -153,4 +153,3 @@ namespace acore
 
 }
 #endif
-

src/common/Dynamic/TypeContainerVisitor.h

@@ -96,4 +96,3 @@ private:
     VISITOR& i_visitor;
 };
 #endif
-

src/common/Dynamic/TypeList.h

@@ -29,4 +29,3 @@ struct TypeList
 #define TYPELIST_4(T1, T2, T3, T4)      TypeList<T1, TYPELIST_3(T2, T3, T4) >
 #define TYPELIST_5(T1, T2, T3, T4, T5)  TypeList<T1, TYPELIST_4(T2, T3, T4, T5) >
 #endif
-

src/common/Logging/ILog.h

@@ -127,5 +127,4 @@ public:
     virtual bool GetSQLDriverQueryLogging() const = 0;
 };
 
-
 #endif //AZEROTHCORE_ILOG_H

src/common/Logging/Log.cpp

@@ -64,7 +64,6 @@ Log::~Log()
     miscLogFile = NULL;
 }
 
-
 std::unique_ptr<ILog>& getLogInstance()
 {
     static std::unique_ptr<ILog> instance = std::make_unique<Log>();

src/common/Logging/Log.h

@@ -118,4 +118,3 @@ std::unique_ptr<ILog>& getLogInstance();
 #define sLog getLogInstance()
 
 #endif
-

src/common/Threading/Threading.cpp

@@ -117,7 +117,6 @@ void Thread::setPriority(Priority priority)
             break;
     }
 
-
     // remove this ASSERT in case you don't want to know is thread priority change was successful or not
     ASSERT(_ok);
 }

src/common/Utilities/ByteConverter.h

@@ -53,4 +53,3 @@ inline void EndianConvertReverse(uint8&) { }
 inline void EndianConvertReverse( int8&) { }
 
 #endif
-

src/common/Utilities/ServiceWin32.cpp

@@ -249,4 +249,3 @@ bool WinServiceRun()
     return true;
 }
 #endif
-

src/common/Utilities/ServiceWin32.h

@@ -14,4 +14,3 @@ bool WinServiceRun();
 
 #endif                                                      // _WIN32_SERVICE_
 #endif                                                      // _WIN32
-

src/server/authserver/Main.cpp

@@ -113,7 +113,7 @@ extern int main(int argc, char** argv)
     sLog->outString("                                ╚██████╗╚██████╔╝██║  ██║███████╗");
     sLog->outString("                                 ╚═════╝ ╚═════╝ ╚═╝  ╚═╝╚══════╝\n");
 
-    sLog->outString("  	  AzerothCore 3.3.5a  -  www.azerothcore.org\n");
+    sLog->outString("     AzerothCore 3.3.5a  -  www.azerothcore.org\n");
 
     sLog->outString("Using configuration file %s.", configFile);
 

src/server/authserver/Server/AuthSocket.cpp

@@ -580,7 +580,6 @@ bool AuthSocket::_HandleLogonChallenge()
                     for (int i = 0; i < 4; ++i)
                         _localizationName[i] = ch->country[4 - i - 1];
 
-
 #if defined(ENABLE_EXTRAS) && defined(ENABLE_EXTRA_LOGS)
                     sLog->outDebug( LOG_FILTER_NETWORKIO, "'%s:%d' [AuthChallenge] account %s is using '%c%c%c%c' locale (%u)", socket().getRemoteAddress().c_str(), socket().getRemotePort(), _login.c_str (), ch->country[3], ch->country[2], ch->country[1], ch->country[0], GetLocaleByName(_localizationName) );
 #endif

src/server/authserver/authserver.conf.dist

@@ -242,7 +242,6 @@ WrongPass.BanType = 0
 
 WrongPass.Logging = 0
 
-
 #
 ###################################################################################################
 

src/server/game/AI/CoreAI/CombatAI.h

@@ -61,7 +61,6 @@ public:
     void AttackStart(Unit* who) override;
     void UpdateAI(uint32 diff) override;
 
-
     static int Permissible(Creature const* /*creature*/) { return PERMIT_BASE_NO; }
 
 protected:

src/server/game/AI/CoreAI/PassiveAI.h

@@ -74,4 +74,3 @@ public:
 };
 
 #endif
-

src/server/game/AI/CoreAI/TotemAI.h

@@ -47,4 +47,3 @@ protected:
 };
 
 #endif
-

src/server/game/AI/CoreAI/UnitAI.cpp

@@ -296,7 +296,6 @@ bool SpellTargetSelector::operator()(Unit const* target) const
     float max_range = _caster->GetSpellMaxRangeForTarget(target, _spellInfo);
     float min_range = _caster->GetSpellMinRangeForTarget(target, _spellInfo);
 
-
     if (target && target != _caster)
     {
         if (range_type == SPELL_RANGE_MELEE)

src/server/game/AI/CoreAI/UnitAI.h

@@ -111,7 +111,6 @@ struct PowerUsersSelector : public acore::unary_function<Unit*, bool>
     float const _dist;
     bool const _playerOnly;
 
-
     PowerUsersSelector(Unit const* unit, Powers power, float dist, bool playerOnly) : _me(unit), _power(power), _dist(dist), _playerOnly(playerOnly) { }
 
     bool operator()(Unit const* target) const

src/server/game/AI/CreatureAIImpl.h

@@ -55,4 +55,3 @@ struct AISpellInfoType
 AISpellInfoType* GetAISpellInfo(uint32 i);
 
 #endif
-

src/server/game/AI/CreatureAIRegistry.cpp

@@ -44,4 +44,3 @@ namespace AIRegistry
         (new MovementGeneratorFactory<WaypointMovementGenerator<Creature> >(WAYPOINT_MOTION_TYPE))->RegisterSelf();
     }
 }
-

src/server/game/AI/CreatureAIRegistry.h

@@ -12,4 +12,3 @@ namespace AIRegistry
     void Initialize(void);
 }
 #endif
-

src/server/game/AI/CreatureAISelector.cpp

@@ -139,4 +139,3 @@ namespace FactorySelector
         return (ai_factory == NULL ? new NullGameObjectAI(go) : ai_factory->Create(go));
     }
 }
-

src/server/game/AI/CreatureAISelector.h

@@ -20,4 +20,3 @@ namespace FactorySelector
     GameObjectAI* SelectGameObjectAI(GameObject*);
 }
 #endif
-

src/server/game/AI/ScriptedAI/ScriptedEscortAI.h

@@ -126,4 +126,3 @@ private:
     bool HasImmuneToNPCFlags;
 };
 #endif
-

src/server/game/AI/SmartScripts/SmartAI.cpp

@@ -450,7 +450,6 @@ void SmartAI::UpdatePath(const uint32 diff)
     }
 }
 
-
 void SmartAI::CheckConditions(const uint32 diff)
 {
     Vehicle* vehicle = me->GetVehicleKit();

src/server/game/Accounts/AccountMgr.cpp

@@ -121,7 +121,6 @@ namespace AccountMgr
         return AOR_OK;
     }
 
-
     AccountOpResult ChangeUsername(uint32 accountId, std::string newUsername, std::string newPassword)
     {
         // Check if accounts exists

src/server/game/Addons/AddonMgr.h

@@ -56,4 +56,3 @@ namespace AddonMgr
 }
 
 #endif
-

src/server/game/Battlefield/Battlefield.cpp

@@ -189,7 +189,6 @@ bool Battlefield::Update(uint32 diff)
                 objective_changed = true;
     }
 
-
     if (m_LastResurectTimer <= diff)
     {
         for (uint8 i = 0; i < m_GraveyardList.size(); i++)

src/server/game/Battlefield/Battlefield.h

@@ -49,7 +49,6 @@ enum BattlefieldTimers
     BATTLEFIELD_OBJECTIVE_UPDATE_INTERVAL        = 1000
 };
 
-
 const uint32 BattlefieldFactions[BG_TEAMS_COUNT] =
 {
     1732, // Alliance

src/server/game/Battlefield/Zones/BattlefieldWG.cpp

@@ -96,7 +96,6 @@ bool BattlefieldWG::SetupBattlefield()
         m_GraveyardList[i] = graveyard;
     }
 
-
     // Spawn workshop creatures and gameobjects
     for (uint8 i = 0; i < WG_MAX_WORKSHOP; i++)
     {
@@ -223,7 +222,6 @@ void BattlefieldWG::OnBattleStart()
     else
         sLog->outError("WG: Failed to spawn titan relic.");
 
-
     // Update tower visibility and update faction
     for (GuidSet::const_iterator itr = CanonList.begin(); itr != CanonList.end(); ++itr)
     {

src/server/game/Battlefield/Zones/BattlefieldWG.h

@@ -25,14 +25,12 @@ typedef std::set<WGWorkshop*> Workshop;
 typedef std::set<Group*> GroupSet;
 //typedef std::set<WintergraspCapturePoint *> CapturePointSet; unused ?
 
-
 const uint32 VehNumWorldState[2] = { 3680, 3490 };
 const uint32 MaxVehNumWorldState[2] = { 3681, 3491 };
 const uint32 ClockWorldState[2] = { 3781, 4354 };
 const uint32 WintergraspFaction[3] = { 1, 2, 35 };
 float const WintergraspStalkerPos[4]    = { 4948.985f, 2937.789f, 550.5172f, 1.815142f };
 
-
 enum WintergraspSpells
 {
     // Wartime auras

src/server/game/Battlegrounds/ArenaTeam.h

@@ -191,4 +191,3 @@ protected:
     ArenaTeamStats Stats;
 };
 #endif
-

src/server/game/Battlegrounds/ArenaTeamMgr.cpp

@@ -58,7 +58,6 @@ ArenaTeam* ArenaTeamMgr::GetArenaTeamByName(const std::string& arenaTeamName) co
     return nullptr;
 }
 
-
 ArenaTeam* ArenaTeamMgr::GetArenaTeamByName(std::string const& arenaTeamName, const uint32 type) const
 {
     std::string search = arenaTeamName;
@@ -91,7 +90,6 @@ ArenaTeam* ArenaTeamMgr::GetArenaTeamByCaptain(uint64 guid) const
     return nullptr;
 }
 
-
 ArenaTeam* ArenaTeamMgr::GetArenaTeamByCaptain(uint64 guid, const uint32 type) const
 {
     for (ArenaTeamContainer::const_iterator itr = ArenaTeamStore.begin(); itr != ArenaTeamStore.end(); ++itr)

src/server/game/Battlegrounds/Battleground.cpp

@@ -714,7 +714,6 @@ uint32 Battleground::GetRealRepFactionForPlayer(uint32 factionId, Player* player
     return factionId;
 }
 
-
 void Battleground::UpdateWorldState(uint32 Field, uint32 Value)
 {
     WorldPacket data;

src/server/game/Battlegrounds/BattlegroundQueue.cpp

@@ -384,7 +384,6 @@ void BattlegroundQueue::FillPlayersToBG(Battleground* bg, const int32 aliFree, c
     auto Ali_itr = m_QueuedGroups[bracket_id][BG_QUEUE_NORMAL_ALLIANCE].begin();
     for (; Ali_itr != m_QueuedGroups[bracket_id][BG_QUEUE_NORMAL_ALLIANCE].end() && m_SelectionPools[TEAM_ALLIANCE].AddGroup((*Ali_itr), aliFree); ++Ali_itr);
 
-
     // horde: at first fill as much as possible
     auto Horde_itr = m_QueuedGroups[bracket_id][BG_QUEUE_NORMAL_HORDE].begin();
     for (; Horde_itr != m_QueuedGroups[bracket_id][BG_QUEUE_NORMAL_HORDE].end() && m_SelectionPools[TEAM_HORDE].AddGroup((*Horde_itr), hordeFree); ++Horde_itr);

src/server/game/Battlegrounds/Zones/BattlegroundAB.h

@@ -277,4 +277,3 @@ private:
     bool _teamScores500Disadvantage[BG_TEAMS_COUNT] {};
 };
 #endif
-

src/server/game/Battlegrounds/Zones/BattlegroundEY.h

@@ -396,4 +396,3 @@ private:
     uint32 _flagCapturedObject;
 };
 #endif
-

src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp

@@ -795,7 +795,6 @@ GraveyardStruct const* BattlegroundSA::GetClosestGraveyard(Player* player)
     if (!closest && GraveyardStatus[BG_SA_BEACH_GY] == player->GetTeamId())
         return sGraveyard->GetGraveyard(BG_SA_GYEntries[BG_SA_BEACH_GY]);
 
-
     return closest;
 }
 

src/server/game/Battlegrounds/Zones/BattlegroundWS.cpp

@@ -405,7 +405,6 @@ bool BattlegroundWS::SetupBattleground()
     AddObject(BG_WS_OBJECT_DOOR_H_3, BG_OBJECT_DOOR_H_3_WS_ENTRY, 949.9523f, 1422.751f, 344.9273f, 0.0f, 0, 0, 0, 1, RESPAWN_IMMEDIATELY);
     AddObject(BG_WS_OBJECT_DOOR_H_4, BG_OBJECT_DOOR_H_4_WS_ENTRY, 950.7952f, 1459.583f, 342.1523f, 0.05235988f, 0, 0, 0.02617695f, 0.9996573f, RESPAWN_IMMEDIATELY);
 
-
     GraveyardStruct const* sg = sGraveyard->GetGraveyard(WS_GRAVEYARD_MAIN_ALLIANCE);
     AddSpiritGuide(WS_SPIRIT_MAIN_ALLIANCE, sg->x, sg->y, sg->z, 3.124139f, TEAM_ALLIANCE);
 

src/server/game/Battlegrounds/Zones/BattlegroundWS.h

@@ -127,7 +127,6 @@ enum BG_WS_CreatureTypes
     BG_CREATURES_MAX_WS       = 2
 };
 
-
 enum BG_WS_Objectives
 {
     WS_OBJECTIVE_CAPTURE_FLAG   = 42,

src/server/game/Chat/Channels/Channel.h

@@ -333,4 +333,3 @@ private:
     PlayersWatchingContainer playersWatchingStore;
 };
 #endif
-

src/server/game/Chat/Channels/ChannelMgr.cpp

@@ -124,7 +124,6 @@ Channel* ChannelMgr::GetChannel(std::string const& name, Player* player, bool pk
     return i->second;
 }
 
-
 uint32 ChannelMgr::_channelIdMax = 0;
 ChannelMgr::ChannelRightsMap ChannelMgr::channels_rights;
 ChannelRights ChannelMgr::channelRightsEmpty;

src/server/game/Chat/ChatLink.h

@@ -161,5 +161,4 @@ private:
     std::istringstream _iss;
 };
 
-
 #endif

src/server/game/Combat/HostileRefManager.h

@@ -62,4 +62,3 @@ public:
 };
 //=================================================
 #endif
-

src/server/game/Combat/UnitEvents.h

@@ -122,4 +122,3 @@ public:
 
 //==============================================================
 #endif
-

src/server/game/DataStores/DBCStores.cpp

@@ -464,8 +464,6 @@ void LoadDBCStores(const std::string& dataPath)
         if (TaxiPathEntry const* entry = sTaxiPathStore.LookupEntry(i))
             sTaxiPathSetBySource[entry->from][entry->to] = TaxiPathBySourceAndDestination(entry->ID, entry->price);
 
-
-
     // Calculate path nodes count
     uint32 pathCount = sTaxiPathStore.GetNumRows();
     std::vector<uint32> pathLength;

src/server/game/DungeonFinding/LFG.cpp

@@ -95,4 +95,3 @@ namespace lfg
     }
 
 } // namespace lfg
-

src/server/game/DungeonFinding/LFG.h

@@ -188,7 +188,6 @@ namespace lfg
                     guid[2] = guid[1];
                 }
 
-
                 guid[1] = guid[0];
                 guid[0] = g;
 
@@ -479,7 +478,6 @@ namespace lfg
     std::string GetRolesString(uint8 roles);
     std::string GetStateString(LfgState state);
 
-
 } // namespace lfg
 
 #endif

src/server/game/DungeonFinding/LFGMgr.cpp

@@ -424,7 +424,6 @@ namespace lfg
                     lockData = LFG_LOCKSTATUS_MISSING_ITEM;
             }
 
-
             sScriptMgr->OnInitializeLockedDungeons(player, level, lockData);
 
             /* TODO VoA closed if WG is not under team control (LFG_LOCKSTATUS_RAID_LOCKED)

src/server/game/Entities/Creature/Creature.cpp

@@ -615,7 +615,6 @@ void Creature::Update(uint32 diff)
                     m_moveBackwardsMovementTime = MOVE_BACKWARDS_CHECK_INTERVAL;
                 }
 
-
                 if (!IsInEvadeMode() && IsAIEnabled)
                 {
                     // do not allow the AI to be changed during update
@@ -791,7 +790,6 @@ void Creature::RegenerateHealth()
             addvalue = uint32(Spirit * 0.80 * HealthIncreaseRate);
     }
 
-
     // Apply modifiers (if any).
     AuraEffectList const& ModPowerRegenPCTAuras = GetAuraEffectsByType(SPELL_AURA_MOD_HEALTH_REGEN_PERCENT);
     for (AuraEffectList::const_iterator i = ModPowerRegenPCTAuras.begin(); i != ModPowerRegenPCTAuras.end(); ++i)
@@ -1364,7 +1362,6 @@ bool Creature::CreateFromProto(uint32 guidlow, uint32 Entry, uint32 vehId, const
     else
         CreateVehicleKit(vehId, Entry);
 
-
     if (!UpdateEntry(Entry, data))
         return false;
 

src/server/game/Entities/GameObject/GameObject.cpp

@@ -1190,7 +1190,6 @@ GameObject* GameObject::LookupFishingHoleAround(float range)
 {
     GameObject* ok = nullptr;
 
-
     CellCoord p(acore::ComputeCellCoord(GetPositionX(), GetPositionY()));
     Cell cell(p);
     acore::NearestGameObjectFishingHole u_check(*this, range);

src/server/game/Entities/Item/Container/Bag.cpp

@@ -230,4 +230,3 @@ Item* Bag::GetItemByPos(uint8 slot) const
 
     return nullptr;
 }
-

src/server/game/Entities/Item/Container/Bag.h

@@ -59,4 +59,3 @@ inline Item* NewItemOrBag(ItemTemplate const* proto)
     return (proto->InventoryType == INVTYPE_BAG) ? new Bag : new Item;
 }
 #endif
-

src/server/game/Entities/Item/ItemEnchantmentMgr.cpp

@@ -188,4 +188,3 @@ uint32 GenerateEnchSuffixFactor(uint32 item_id)
     }
     return 0;
 }
-

src/server/game/Entities/Item/ItemEnchantmentMgr.h

@@ -13,4 +13,3 @@ void LoadRandomEnchantmentsTable();
 uint32 GetItemEnchantMod(int32 entry);
 uint32 GenerateEnchSuffixFactor(uint32 item_id);
 #endif
-

src/server/game/Entities/Object/Object.cpp

@@ -1845,7 +1845,6 @@ bool WorldObject::CanDetectStealthOf(WorldObject const* obj, bool checkAlert) co
         if (checkAlert)
             visibilityRange += (visibilityRange * 0.08f) + 1.5f;
 
-
         Unit const* targetUnit = obj->ToUnit();
 
         // If checking for alert, and creature's visibility range is greater than aggro distance, No alert
@@ -2623,7 +2622,6 @@ void WorldObject::GetContactPoint(const WorldObject* obj, float& x, float& y, fl
     }
 }
 
-
 void WorldObject::GetChargeContactPoint(const WorldObject* obj, float& x, float& y, float& z, float distance2d) const
 {
     // angle to face `obj` to `this` using distance includes size of `obj`
@@ -2985,7 +2983,6 @@ void WorldObject::PlayDirectSound(uint32 sound_id, Player* target /*= NULL*/)
         SendMessageToSet(&data, true);
 }
 
-
 void WorldObject::PlayDirectMusic(uint32 music_id, Player* target /*= NULL*/)
 {
     WorldPacket data(SMSG_PLAY_MUSIC, 4);

src/server/game/Entities/Object/Object.h

@@ -485,7 +485,6 @@ struct Position
 
     [[nodiscard]] Position GetPosition() const { return *this; }
 
-
     Position::PositionXYZStreamer PositionXYZStream()
     {
         return PositionXYZStreamer(*this);
@@ -593,7 +592,6 @@ ByteBuffer& operator >> (ByteBuffer& buf, Position::PositionXYZStreamer const& s
 ByteBuffer& operator<<(ByteBuffer& buf, Position::PositionXYZOStreamer const& streamer);
 ByteBuffer& operator >> (ByteBuffer& buf, Position::PositionXYZOStreamer const& streamer);
 
-
 struct MovementInfo
 {
     // common

src/server/game/Entities/Object/Updates/UpdateData.cpp

@@ -142,4 +142,3 @@ void UpdateData::Clear()
     m_outOfRangeGUIDs.clear();
     m_blockCount = 0;
 }
-

src/server/game/Entities/Object/Updates/UpdateData.h

@@ -55,4 +55,3 @@ protected:
     void Compress(void* dst, uint32* dst_size, void* src, int src_size);
 };
 #endif
-

src/server/game/Entities/Pet/Pet.cpp

@@ -2155,7 +2155,6 @@ void Pet::HandleAsynchLoadSucceed()
         if (spell->GetSpellInfo()->HasEffect(SPELL_EFFECT_SUMMON_PET))
             CastSpell(this, 32752, true, nullptr, nullptr, GetGUID());
 
-
     if (owner->NeedSendSpectatorData() && GetCreatureTemplate()->family)
     {
         ArenaSpectator::SendCommand_UInt32Value(owner->FindMap(), owner->GetGUID(), "PHP", (uint32)GetHealthPct());

src/server/game/Entities/Pet/Pet.h

@@ -21,7 +21,6 @@ struct PetSpell
     PetSpellType type;
 };
 
-
 class AsynchPetSummon
 {
 public:

src/server/game/Entities/Player/Player.cpp

@@ -7577,7 +7577,6 @@ uint32 Player::GetArenaTeamIdFromStorage(uint32 guid, uint8 slot)
     return 0;
 }
 
-
 void Player::SetArenaTeamInfoField(uint8 slot, ArenaTeamInfoType type, uint32 value)
 {
     if (slot < MAX_ARENA_SLOT)
@@ -8287,7 +8286,6 @@ void Player::_ApplyItemBonuses(ItemTemplate const* proto, uint8 slot, bool apply
     if (CanUseAttackType(attType))
         _ApplyWeaponDamage(slot, proto, ssv, apply);
 
-
     // Druids get feral AP bonus from weapon dps (also use DPS from ScalingStatValue)
     if (getClass() == CLASS_DRUID)
     {
@@ -12645,7 +12643,6 @@ Item* Player::StoreNewItem(ItemPosCountVec const& dest, uint32 item, bool update
         UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM, item, count);
         pItem = StoreItem(dest, pItem, update);
 
-
         if (allowedLooters.size() > 1 && pItem->GetTemplate()->GetMaxStackSize() == 1 && pItem->IsSoulBound())
         {
             pItem->SetSoulboundTradeable(allowedLooters);
@@ -19145,7 +19142,6 @@ void Player::_LoadMail()
             m->stationery = fields[12].GetUInt8();
             m->mailTemplateId = fields[13].GetInt16();
 
-
             if (m->mailTemplateId && !sMailTemplateStore.LookupEntry(m->mailTemplateId))
             {
                 sLog->outError("Player::_LoadMail - Mail (%u) have not existed MailTemplateId (%u), remove at load", m->messageID, m->mailTemplateId);
@@ -21638,7 +21634,6 @@ void Player::LeaveAllArenaTeams(uint64 guid)
     } while (result->NextRow());
 }
 
-
 uint32 Player::GetArenaTeamId(uint8 slot) const
 {
     uint32 rtVal = 0;
@@ -21654,7 +21649,6 @@ uint32 Player::GetArenaTeamId(uint8 slot) const
     return rtVal;
 }
 
-
 uint32 Player::GetArenaPersonalRating(uint8 slot) const
 {
     uint32 rtVal = 0;
@@ -23224,7 +23218,6 @@ void Player::AddComboPoints(Unit* target, int8 count)
     else if (*comboPoints < 0)
         *comboPoints = 0;
 
-
     SendComboPoints();
 }
 
@@ -24730,7 +24723,6 @@ void Player::UpdateUnderwaterState(Map* m, float x, float y, float z)
         _lastLiquid = nullptr;
     }
 
-
     // All liquids type - check under water position
     if (liquid_status.type_flags & (MAP_LIQUID_TYPE_WATER | MAP_LIQUID_TYPE_OCEAN | MAP_LIQUID_TYPE_MAGMA | MAP_LIQUID_TYPE_SLIME))
     {
@@ -25568,7 +25560,6 @@ uint32 Player::GetPhaseMaskForSpawn() const
     if (!phase)
         phase = PHASEMASK_NORMAL;
 
-
     // some aura phases include 1 normal map in addition to phase itself
     uint32 n_phase = phase & ~PHASEMASK_NORMAL;
     if (n_phase > 0)

src/server/game/Entities/Totem/Totem.cpp

@@ -70,7 +70,6 @@ void Totem::InitStats(uint32 duration)
         if (totemSpell->CalcCastTime())   // If spell has cast time -> its an active totem
             m_type = TOTEM_ACTIVE;
 
-
     m_duration = duration;
 }
 

src/server/game/Entities/Unit/StatSystem.cpp

@@ -1101,8 +1101,6 @@ void Creature::CalculateMinMaxDamage(WeaponAttackType attType, bool normalized,
 ########                         ########
 #######################################*/
 
-
-
 bool Guardian::UpdateStats(Stats stat)
 {
     if (stat >= MAX_STATS)

src/server/game/Entities/Unit/Unit.cpp

@@ -1764,7 +1764,6 @@ float Unit::GetEffectiveResistChance(Unit const* owner, SpellSchoolMask schoolMa
     if (owner)
         victimResistance += std::max((float(victim->getLevel()) - float(owner->getLevel())) * 5.0f, 0.0f);
 
-
     static uint32 const BOSS_LEVEL = 83;
     static float const BOSS_RESISTANCE_CONSTANT = 510.0f;
     uint32 level = victim->getLevel();
@@ -9056,7 +9055,6 @@ bool Unit::HandleProcTriggerSpell(Unit* victim, uint32 damage, AuraEffect* trigg
         }
     }
 
-
     // Custom basepoints/target for exist spell
     // dummy basepoints or other customs
     switch (trigger_spell_id)
@@ -9452,7 +9450,6 @@ bool Unit::HandleOverrideClassScriptAuraProc(Unit* victim, uint32 /*damage*/, Au
     return true;
 }
 
-
 void Unit::setPowerType(Powers new_powertype)
 {
     SetByteValue(UNIT_FIELD_BYTES_0, 3, new_powertype);
@@ -9565,7 +9562,6 @@ ReputationRank Unit::GetReactionTo(Unit const* target) const
                 return *repRank;
     }
 
-
     if (HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_PVP_ATTACKABLE))
     {
         if (target->HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_PVP_ATTACKABLE))
@@ -11154,7 +11150,6 @@ uint32 Unit::SpellDamageBonusTaken(Unit* caster, SpellInfo const* spellProto, ui
             if (spellProto->ValidateAttribute6SpellDamageMods(caster, *i, damagetype == DOT))
                 AddPct(TakenTotalMod, (*i)->GetAmount());
 
-
     // .. taken pct: dummy auras
     AuraEffectList const& mDummyAuras = GetAuraEffectsByType(SPELL_AURA_DUMMY);
     for (AuraEffectList::const_iterator i = mDummyAuras.begin(); i != mDummyAuras.end(); ++i)
@@ -14315,7 +14310,6 @@ float Unit::GetSpellMinRangeForTarget(Unit const* target, SpellInfo const* spell
     return spellInfo->GetMinRange(!IsHostileTo(target));
 }
 
-
 uint32 Unit::GetCreatureType() const
 {
     if (GetTypeId() == TYPEID_PLAYER)
@@ -17879,7 +17873,6 @@ bool Unit::IsInRaidWith(Unit const* unit) const
         return false;
 }
 
-
 void Unit::GetPartyMembers(std::list<Unit*>& TagUnitMap)
 {
     Unit* owner = GetCharmerOrOwnerOrSelf();

src/server/game/Events/GameEventMgr.h

@@ -171,4 +171,3 @@ bool IsHolidayActive(HolidayIds id);
 bool IsEventActive(uint16 event_id);
 
 #endif
-

src/server/game/Globals/ObjectAccessor.cpp

@@ -530,7 +530,6 @@ void ObjectAccessor::UnloadAll()
 
 std::map<std::string, Player*> ObjectAccessor::playerNameToPlayerPointer;
 
-
 /// Global definitions for the hashmap storage
 
 template class HashMapHolder<Player>;

src/server/game/Globals/ObjectMgr.cpp

@@ -492,7 +492,6 @@ void ObjectMgr::LoadCreatureTemplates()
 
         uint32 entry = fields[0].GetUInt32();
 
-
         CreatureTemplate& creatureTemplate = _creatureTemplateStore[entry];
 
         creatureTemplate.Entry = entry;

src/server/game/Grids/Cells/Cell.h

@@ -103,4 +103,3 @@ private:
 };
 
 #endif
-

src/server/game/Grids/Cells/CellImpl.h

@@ -166,4 +166,3 @@ inline void Cell::VisitCircle(TypeContainerVisitor<T, CONTAINER>& visitor, Map&
     }
 }
 #endif
-

src/server/game/Grids/Grid.h

@@ -120,4 +120,3 @@ private:
     //ActiveGridObjects m_activeGridObjects;
 };
 #endif
-

src/server/game/Grids/GridLoader.h

@@ -63,4 +63,3 @@ class GridLoader
 };
 */
 #endif
-