Commit Graph

5005 Commits

Author SHA1 Message Date
Benjamin Jackson 2bb45fcd30 fix(Scripts/BlackTemple): Adjust handling for Shared Rule spell. (#19770) 2024-08-30 09:04:08 -03:00
Tereneckla 1fd59e2831 feature(Core/Chat): allow fmt-chrono formatting (#19794) 2024-08-30 07:44:45 -03:00
daobashun e1692ae5b6 fix(scripts/npc_calvin_montague): Convert to SAI, Add emotes when completing quests (#18087)
* Magic uses sniffing IDs
Use the sniffer timer and factions

* Wait 3 minutes if the mission fails

* 1. When a task fails, it enters passive mode
2. Add 'quest_details' data to the database

* Remove spaces

* Delete blank lines

* Modify the code as required

* Update src/server/scripts/EasternKingdoms/zone_tirisfal_glades.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Remove curly braces

* Change the name of a private member variable

* Move the c ++ script to smart script

* Delete the C++ script
Re-add the deleted quest_details data

* del blank lines

* Delete the C++ script file

* Modify the annotation
Return to the home pointset phase to 0
Return to the home point to allow the SAI phase reset

* Remove spaces

* Delete functions that are not in use

* Update rev_1704025138911597700.sql

* fix merge error - delete zone file

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-08-28 21:05:40 +02:00
Gultask 8852f0c74c feat(Core/SmartScripts): Implement Scripted Spawn System (#19499)
* prespawn2

* pfta

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql

* Update rev_1717715555182000500.sql
2024-08-28 08:18:02 -03:00
Grimdhex 2f85097413 docs(Core): improve several functions documentation (#19677)
* initial release

* fix reviews

* fix some typo and add new documetations for MotionMaster

* new update and fix the cli-codestyle

* fix typo

* fix reviews
2024-08-28 08:17:24 -03:00
Anton Popovichenko 9144031ed9 fix(Core/Pool): Fix degradation of pools over time (#19750) 2024-08-28 08:14:08 -03:00
Benjamin Jackson b595586bf0 refactor(Core/SpellMgr): Remove nested ifs for binary evaluation. (#19762)
* Init.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Whitespace.

* Tiny nitpick.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Tiny nitpick.*

Today Bench learns the difference between break and continue.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Parentheses warnings.

* Apply suggestion.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-08-28 08:13:42 -03:00
Benjamin Jackson 5ffbfdd5d6 fix(Core/Creature): Fix grace period for can attack check. (#19763)
Init.
2024-08-28 08:13:06 -03:00
Andrew 7e2ffc2db8 feat(Scripts/Commands): Implement "pct" optional to the damage command (#19745) 2024-08-27 22:28:09 +02:00
Andrew 806d4962cf fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets (#19752)
* fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets

* Daily Nitpicks
2024-08-27 22:26:05 +02:00
Jelle Meeus 53e0779ae8 fix(Scripts/Spells): General's Heart trinket (#19756)
* handle aura with spell_gen_absorb0_hitlimit1

* refactor enscapsulate limit
2024-08-27 22:25:41 +02:00
Benjamin Jackson c76f2382d9 fix(Scripts/BlackTemple): Improve Illidari Council Empyreal Balance. (#19757) 2024-08-27 15:51:47 -03:00
Benjamin Jackson 8f335bbc2b fix(Core/SpellMgr): Remove binary attribute from Drain Soul. (#19760)
Init.
2024-08-27 15:17:54 -03:00
Andrew 126f3a31ee refactor(Scripts/BlackTemple): Update the Illidari Council script to the new registration method (#19744)
refactor(Scripts/BlackTemple): Update Illidari council to new model
2024-08-26 16:28:48 -03:00
Andrew 83f8871c31 refactor(Core/BossAI): Improve the ScheduleHealthCheck() code (#19743)
* refactor(Core/BossAI): Improve the ScheduleHealthCheck() code

* Update ScriptedCreature.cpp

---------

Co-authored-by: sudlud <sudlud@users.noreply.github.com>
2024-08-26 14:44:05 -03:00
Andrew 9ce2b23df3 refactor(Scripts/RuinsOfAhnQiraj): Clean up Ayamiss script (#19742) 2024-08-26 10:04:11 -03:00
Tereneckla f2ed6f791b fix (Core/Unit): add AutoRpeatSpell delay to Auto Shot as well (#19603)
Update Unit.cpp
2024-08-26 07:20:23 -03:00
Andrew 52cd493ad8 fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by dama… (#19730)
* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods

* Create rev_1724540286668312700.sql

* Update spell_generic.cpp

* update to new format
2024-08-26 01:25:10 -03:00
Saqra1 68402b6d91 fix(Core/Spell): Reset cd on some channeled spells (#19696)
If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
2024-08-25 23:43:01 -03:00
Kitzunu 1bfcc0e469 fix(Core/BG): Fix fmt issue for bg sent notifications (#19718)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19559
2024-08-25 19:22:37 -03:00
Andrew c5399509e6 refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script (#19736)
* refactor(Scripts/TempleOfAhnQiraj): Clean up Cthun script

* Update boss_cthun.cpp

* Update boss_cthun.cpp
2024-08-25 16:46:24 -03:00
Carriola-wotlk 4a14c61a90 fix(Scripts/BlackTemple) Gathios the Shatterer shouldnt use the same spell twice in a row (#19672)
* fix: SelectTargetMethod Random replaced with MaxThreat

* restore like origin

* fix: random spell casting replaced with alternating spells casting

* fix: alternating casting of aura, blessing and seal spells

* refactor: randomized toggle initialization refactored

---------

Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com>
2024-08-25 10:01:37 -03:00
Grimdhex 643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex 61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
sudlud 30a790117b fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldser… (#19702)
* fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldserver.conf.dist

* Update WorldSocketMgr.cpp
2024-08-23 06:38:00 +02:00
Tereneckla 3419f0246b fix (Core/Spells) partially revert #19529 (#19703)
Update Spell.cpp
2024-08-22 20:36:39 -03:00
Andrew c0b6eae0e1 fix(Core/Spells): Fix movement impairment auras not being removed (#19684) 2024-08-22 15:09:43 -03:00
Andrew dd41692a8e fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu (#19636)
* fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu

* Update instance_sethekk_halls.cpp

* Update instance_sethekk_halls.cpp

* Update rev_1723763212128826500.sql
2024-08-22 19:27:15 +02:00
Kitzunu eb410d6ab2 refactor(Core/Battleground): rewrite SpiritOfCompetitionEvent() (#19675)
* Use DoForAllPlayers

* Change to void - we don't need to return a value

* Better readability
2024-08-22 19:24:08 +02:00
Grimdhex db7183a573 chore(Debug/Scripting): improve debug errors during the unloading scripts (#19643)
* chore(Debug/Scripting): improve debug errors during script unloading

* add the script name to increase debug informations and ensure to derefence script pointers
2024-08-21 08:13:20 -03:00
Andrew ef4e0c0d4a fix(Core/Spells): Power of the Guardian should persist through death (#19638) 2024-08-21 06:36:05 -03:00
Andrew 82db30868b fix(Scripts/BlackTemple): Fatal Attraction (#19641)
* Fix it not being cast if no valid targets are available
* Apply Patch 2.2 nerfs
2024-08-19 23:17:17 -03:00
Saqra1 087acc58bf fix(Core/PetHandler): Allow PetAI to handle flags (#19446)
When a pet ability was cast, PetHandler reset all CharmInfo flags before
calling PetAI methods, setting the attack flag to true every time.
This commands the pet to go and chase the target which is not correct
when the state is COMMAND_STAY.

PetAI already handles the scenario, it just wasn't getting the actual
pet attack state.
2024-08-19 13:15:39 -03:00
Kitzunu 337135bf9e refactor(Core/Misc): Use NpcFlag helpers (#19676)
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag

* extend to all npcflag helpers
2024-08-19 10:17:02 +02:00
Carriola-wotlk 01c8344cc8 fix(Scripts/BlackTemple): Gathios the Shatterer shouldnt use Hammer of Justice on random players (#19653)
* fix: SelectTargetMethod Random replaced with MaxThreat

* restore like origin

* fix: cast Hammer Of Justice on current target instead random target

* refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored

* refactor: if statement splitted

* refactor: last space removed

* Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* fix redundant check and new line

---------

Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com>
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2024-08-18 21:06:45 -03:00
Tereneckla 79a653b13e fix (Core/Spells): remove object size for hit calculation of aoe aura spells that target enemies (#19529)
remove object size for aoe on enemy spells
2024-08-18 20:34:56 -03:00
Andrew 23f58016d0 fix(Core/Map): Exempt raids from the hourly limit (#19650) 2024-08-18 19:56:38 +02:00
Yunfan Li d436f97ea2 fix(Script/Vehicles): The next player entering Salvaged Siege Engine … (#19674)
fix(Script/Vehicles): The next player entering Salvaged Siege Engine should control turret if it's not occupied.
2024-08-18 14:28:56 -03:00
Grimdhex a0689fb4ef fix(Dep/Boost): corrects a warning about path changes in boost process (#19629) 2024-08-18 13:39:06 +02:00
Kitzunu e33a56d89b fix(Core/Creature): Nullcheck for questgreeting greeting (#19669)
* fix(Core/Creature): Nullcheck for questgreeting greeting

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19659

* Update GossipDef.cpp
2024-08-18 06:41:18 -03:00
Andrew 167e06e287 fix(Scripts/BlackTemple): Gathios Judgment spell should consume seals (#19640) 2024-08-18 05:57:32 -03:00
sudlud adc9f4e7ab fix(Core/Spell): check for player before dereferencing (#19666) 2024-08-18 05:57:02 -03:00
Benjamin Jackson adff3c3846 fix(Core/Spells): Revert ownership and follow logic adjustment for guardian summons. (#19664)
Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…"

This reverts commit cc2ef9d6dd.
2024-08-17 20:29:21 -03:00
Grimdhex 5cbe485785 fix(Core/PlayerUpdates): incorrect backslash in a debug_log (#19630) 2024-08-15 18:44:07 -03:00
Grimdhex 9dc20bc261 fix(Core/Entities): crash fix cause by a pointer change in #19622 (#19633)
* fix(Core/Entities): crash fix cause by a pointer change in #19622

* fix blank space for codestyle check
2024-08-15 16:28:50 -03:00
Grimdhex 7457aef78d refactor(Core/Entities): Cleanup Unit header file (#19622)
* move several enum definitions in a new files

* move more things

* remove the include comment

* move the related code to CharmInfo in this own file

*original idea of Ovahlord

Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* fix clang build errors and few blank lines

* missing forward declaration

* new tentative to fix gcc/clang build

* add several include could be necessary for gcc/clang compilation

* .

* revert some include since the last AC update

* fix some loop inconsistencies

* align all enums in UnitDefine.h

---------

Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-08-15 05:12:44 -03:00
Andrew 1565758da4 Revert "chore(Script/Misc): cleanup" (#19627)
Revert "chore(Script/Misc): cleanup (#19619)"

This reverts commit 7ff8f72397.
2024-08-15 05:43:11 +02:00
Kitzunu 7ff8f72397 chore(Script/Misc): cleanup (#19619)
* chore(Script/Misc): cleanup

* more cleanup

* cleanup
2024-08-14 16:29:50 -03:00
Kitzunu 030716421f feat(Core/LFG): Option to disable deserter (#19618)
* feat(Core/LFG): Option to disable deserter

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19569

* Update IWorld.h
2024-08-14 09:19:56 -03:00
Kitzunu 2e02c76399 fix(Core/Creature): quest_greeting_locale (#19615)
* fix(Core/Creature): quest_greeting_locale

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14845
2024-08-13 21:09:36 +02:00