9dc20bc261
fix(Core/Entities): crash fix cause by a pointer change in #19622 ( #19633 )
...
* fix(Core/Entities): crash fix cause by a pointer change in #19622
* fix blank space for codestyle check
2024-08-15 16:28:50 -03:00
7457aef78d
refactor(Core/Entities): Cleanup Unit header file ( #19622 )
...
* move several enum definitions in a new files
* move more things
* remove the include comment
* move the related code to CharmInfo in this own file
*original idea of Ovahlord
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* fix clang build errors and few blank lines
* missing forward declaration
* new tentative to fix gcc/clang build
* add several include could be necessary for gcc/clang compilation
* .
* revert some include since the last AC update
* fix some loop inconsistencies
* align all enums in UnitDefine.h
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-08-15 05:12:44 -03:00
a950a7f44e
fix(Core/Pets): Add option to revive pets with full mana ( #19383 )
...
* fix(Scripts/Spells): Revive pets with full mana in bgs
* Pets were incorrectly revived without restoring its mana
* Closes #15894
* ready for merge
---------
Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-17 12:38:10 +02:00
ee4d728573
fix(Core/Pets): Correct Pet size for pets 3 ( #19319 )
...
* revert
* override maxScale for some families
add more families
sort
* add turtle
2024-07-09 14:16:30 -03:00
37431cd7a6
fix(Core/Pets): Correct Pet size for bigger pets 2 ( #18867 )
...
* scale displayInfo, cap scale to maxScale
* prevent scaling with displayInfo if scale is already increasing the size
2024-07-04 16:34:14 -03:00
cf1185551d
fix(Core/Pet): prevent LoadPetFromDB to trigger a fake summon spell cast in most cases ( #19277 )
...
* add CategoryRecoveryTime check
* add RecoveryTime check
2024-07-04 14:20:24 -03:00
d6d49a9e45
refactor(Core/ObjectMgr): Implement display probabilities. ( #19068 )
...
* Init.
Cherry-picked from TC commits https://github.com/TrinityCore/TrinityCore/commit/9d210476e57949094fdd286001ef4900564edca5 and https://github.com/TrinityCore/TrinityCore/commit/c488fb219ab080031488593a0b86ac785a7d2cae
Co-Authored-By: Traesh <9392905+traesh@users.noreply.github.com >
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* Add brute data.
Needs validation against what existed before, i.e. Classic change prevention.
* Add validation info for brute data.
* Remove incomplete data queries.
* Requested changes.
* Whitespace.
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Resolve the funny merge conflicts.
I wonder why git blame doesn't work on a file with 20k lines in it that's odd huh champ.
* Remove unused parameter.
* Remove uses of unused parameter.
* Use unused parameter.
Hopefully?
* I will cry.
* Sobbing endlessly.
* Remove comment.
* Adjust table structure query.
Remove length parameters and allow null for build value.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Adjust column datatype and add check constraint.
---------
Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com >
Co-authored-by: Shauren <shauren.trinity@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-06-16 18:12:16 +02:00
f846d79478
fix(Core/Pet): Warlock pet handling ( #19054 )
...
* dismiss summoned non-hunter pets by removing them
* store createdbyspellid
* Revert "dismiss summoned non-hunter pets by removing them"
This reverts commit eb539e841d882a6c90f743792c91304b0d365a5c.
2024-06-13 10:31:35 -03:00
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
f9f71fff36
fix(Core/Player): Check if the player can summon the warlock pet on B… ( #18064 )
...
fix(Core/Player): Check if the player can summon the warlock pet on BG ress
2024-01-01 14:56:32 +01:00
eb1ecc38a5
feat(Core/Scripting): move all script objects to separated files ( #17860 )
...
* feat(Core/Scripts): move all script objects to separated files
* Apply 5bfeabde81
2023-12-02 21:13:20 +01:00
5bfeabde81
chore(Core/Misc): rename spellInfo pointers ( #17914 )
...
* Rename all
2023-12-02 06:03:15 -03:00
ca7eb956aa
feature(Core/Pet): Add pet talent rate config ( #17678 )
...
* feat: add pet talent rate config
* feat(Core/Pet): keep consistent with player talent config
* refactor(Core/Pet): delete empty line
2023-11-12 09:33:06 +01:00
f757e93da5
refactor(Core/Misc): Make DeathState enum class ( #17607 )
2023-10-28 10:54:03 +02:00
c7b7b7dc07
fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet ( #17342 )
...
* fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet
* Update src/server/game/Entities/Pet/Pet.cpp
2023-09-25 08:07:09 -03:00
5d01b700fd
refactor(Core): remove unused imports ( #17094 )
2023-08-28 13:39:43 +02:00
cf87a2d8fe
fix(Core/Pet): Correct (most) warlock pet scaling ( #16769 )
...
* create
* Update Pet.cpp
* remove unwanted change
* Update data/sql/updates/pending_db_world/rev_1689522771491547000.sql
* Update rev_1689522771491547000.sql
2023-08-20 21:38:49 -03:00
f6b77f9d64
fix(Core/Pets): Fix crash when pet tries to attack deleted object ( #17034 )
...
This situation occurs when, during a fight, a pet receives a command to apply a positive spell to an ally and then resume attacking its previous target.
2023-08-19 22:27:51 +02:00
026fe7c962
fix(Core/Pets): Hunter pet scaling ( #16959 )
...
* fix(Core/Pets): Hunter pet scaling
* Fix pet scaling to properly take DBC data
* Edge case for Devilsaur where the DBC data is whack, therefore we use Spirit Beast data instead
* updated scale calculation based on client function (https://github.com/The-Cataclysm-Preservation-Project/TrinityCore/commit/f09564b9d01ff372506f76f2345b99e3485738d5 )
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* fix gcc
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2023-08-08 19:11:41 -03:00
226408329a
fix(Core/Pets): Corret Pet size for normal and exotics & bigger pets ( #16910 )
...
* fix(Core/Pet)
Pet size fixed
* Update Pet.cpp
* Update Pet.cpp
2023-08-06 02:08:34 +02:00
f0a4612964
fix(Core/Pets) Pet scaling only being applied to pets with DB Entry ( #16401 )
2023-08-02 14:51:11 -03:00
30f475829a
fix(Core/Spells): Hunter snake trap damage ( #16326 )
2023-05-23 22:39:55 -03:00
d028a6253a
fix(Core/Pet): fix Pet::resetTalentsForAllPetsOf for stabled pets ( #15779 )
2023-04-02 14:48:03 +02:00
ac0581bd43
fix(Core/Pet): Fixed set hunter pet's speed on load. ( #15206 )
2023-03-04 17:41:10 -03:00
f039836a2f
chore(Core/Misc): Change all TODO to doxygen comment ( #14966 )
2023-02-12 10:05:34 -03:00
da70db415b
fix(Core/Config): Added new config to make pet's health be modified b… ( #14051 )
2023-02-11 00:08:28 -03:00
ed2997ab10
fix(Core/Creature): Check model increase only for Exotic creatures ( #14526 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14525
2023-01-07 20:36:39 +01:00
8d2dda24ed
fix(Core/Pets): Correct Pet size for bigger pets ( #14511 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14488
2023-01-06 03:23:21 +01:00
9e18b86311
fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… ( #14425 )
...
...multiplicatively
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-02 20:43:20 -03:00
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
79bef9a057
fix(Core/Pets): Save all spell cooldowns to db. ( #13809 )
...
Fixes #13539
2022-11-16 01:26:46 -03:00
670d5724cb
fix(Core/Pets): Tamed hunter pets should deal physical damage. ( #13522 )
...
Fixes #13497
2022-10-29 07:14:07 -03:00
1b0d76e6d2
fix(Core/Spells): Fixed applying Command aura to shaman Feral Spirits. ( #13000 )
2022-09-13 21:35:00 -03:00
d0d1671745
feat(Core/Debug): GetDebugInfo implementation ( #12705 )
...
Cherry-pick: https://github.com/TrinityCore/TrinityCore/commit/9a924fb9d557434c5a2e4020c80db6e6bfe466ad
Co-authored-by: jackpoz <giacomopoz@gmail.com >
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2022-08-15 09:43:41 -03:00
b81a14976c
fix(Scripts/Spells): Glyph of Felguard. ( #12497 )
...
* fix(Scripts/Spells): Glyph of Felguard.
Fixes #12432
* Update.
2022-07-24 13:38:03 -03:00
2c7b274bc5
refactor(Core): Improve struct alignment and codestyle ( #12335 )
...
refactor(Core): improve struct alignment and codestyle
2022-07-10 14:19:11 -04:00
255c5d8b72
fix(Core): Crashfix. ( #11903 )
...
* fix(Core): Crashfix.
Fixes #11650
* Update.
2022-06-26 04:50:22 -03:00
d6c95b4db8
fix(Core/Pets): Handle health-aurastates on pet loading. ( #11491 )
...
Fixes #11481
2022-04-23 11:32:46 -03:00
edb7cac19b
feat(Core/Unit): NPCFlags helpers ( #11286 )
...
* cherry-pick commit (TrinityCore/TrinityCore@d611925 )
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
2022-04-05 13:52:42 +02:00
535c7451a2
feat(Core/Unit): New helpers for DynamicFlags ( #11230 )
...
* feat(Core/Unit): New helpers for DynamicFlags
* cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/d611925dc7ab2b3f19c5ee9e0f75b8dfb6de1291 )
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* oopsie
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2022-04-01 07:14:29 -03:00
856aed6fc6
feat(Core/Unit): New helpers for UnitFlag and UnitFlag2 ( #11227 )
2022-03-30 07:59:42 -03:00
b275499de4
refactor(Core/Packet): Pet ( #9473 )
...
Co-authored-by: temperrr <temperrr@users.noreply.github.com >
2022-03-01 13:50:50 +01:00
455899dc75
fix(Core/Misc): Change const to be after type name ( #10591 )
2022-02-14 16:05:45 -03:00
13643c969c
refactor(Core/Spell): Use ApplySpellFix with SpellInfo ( #9938 )
2022-02-08 14:09:15 +01:00
de13bf426e
feat(Core/DBLayer): replace char const* to std::string_view ( #10211 )
...
* feat(Core/DBLayer): replace `char const*` to `std::string_view`
* CString
* 1
* chore(Core/Misc): code cleanup
* cl
* db fix
* fmt style sql
* to fmt
* py
* del old
* 1
* 2
* 3
* 1
* 1
2022-02-05 00:37:11 +01:00
5969df4e30
refactor(Core/Logging): switch to fmt style for LOG_ ( #10366 )
...
* feat(Core/Common): add support fmt style for ASSERT and ABORT
* correct CheckCompactArrayMaskOverflow
* 1
* Update src/server/game/Spells/Spell.cpp
* rework logging
* add fmt replace logs
* logging
* FMT_LOG_
* settings
* fix startup
* 1
* 2
* 3
* 4
* 5
* fmt::print
* to fmt
2022-01-27 16:44:41 +01:00
e8f34b2309
feat(Core/Common): add support fmt style for ASSERT and ABORT ( #10355 )
...
* feat(Core/Common): add support fmt style for ASSERT and ABORT
* correct CheckCompactArrayMaskOverflow
* 1
* Update src/server/game/Spells/Spell.cpp
2022-01-25 23:15:51 +01:00
8b7df23f06
feat(Core/Time): Implement saparated manager for game time ( #8630 )
2022-01-24 17:55:00 +07:00
2f8318fd58
fix(Scripts/Hunter): Bestial Wrath shoul not be castable on dead pets. ( #9896 )
...
Bestial Wrath should expire while pet is offline.
2022-01-23 23:45:24 -03:00
1cbf52fb3d
fix(Core/Spells): Fixed Revive Pet. ( #10324 )
...
Fixed #10267
2022-01-23 21:19:52 -03:00
Grimdhex