Commit Graph

793 Commits

Author SHA1 Message Date
Kitzunu 28f1dc5c0c refactor(Core): replace NULL with nullptr (#4593) 2021-03-02 01:34:20 +01:00
Kargatum dbefa17a53 feat(Core/Config): rework config and delete ACE inherited (#4608) 2021-02-28 14:37:03 +01:00
Kargatum b9e132a941 chore(Misc): correct double includes (#4647) 2021-02-26 17:44:08 +07:00
Kitzunu dbc0ff6554 refactor(Core): sort #includes alphabetically (#4579) 2021-02-24 22:34:42 +01:00
Francesco Borzì a4115862de feat(Core/Hooks): OnBattlegroundDesertion (#4619) 2021-02-21 22:12:25 +01:00
r0m1ntik 8dbdffab92 fix(Core/Spell): Divine Protection reduces fall damage (#4618) 2021-02-21 20:23:46 +01:00
Kitzunu 812a744371 fix(Core/SAI): Do not reset HP with SMART_ACTION_UPDATE_ENTRY (#4486)
Co-Authored-By: Wyrserth <43747507+Wyrserth@users.noreply.github.com>
2021-02-13 14:53:44 -05:00
Francesco Borzì a63e41e5b3 feat(Core/Conf): Rate.RewMoneyMaxLevel (#4546) 2021-02-12 16:20:31 +01:00
Walter Pagani 5106e8234b fix(Core): loot party (#4409) 2021-02-12 13:03:49 +01:00
Footman 695a7402ad fix(Core): creature movement bugs (#4544)
- fix UpdateEnvironmentIfNeeded was changing flying creature status all the time. closes: #4447
- fix hovering state was causing bugs at #4466
- add animation state priority: fly > hover > ground

Co-authored-by: Wotex <fm@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Patrick Lewis <pat@lo5t.com>
2021-02-12 11:42:41 +01:00
Footman 522eb9a7e4 fix(Core/Pathfinding): Creatures regen health, spells LOD (#4509) 2021-02-10 00:37:05 +01:00
Francesco Borzì 8915ab1362 feat(Hooks/PlayerScript): ShouldBeRewardedWithMoneyInsteadOfExp (#4445) 2021-02-09 14:09:41 -05:00
Kitzunu 82eb8b44d1 refactor(Core/Spell): Pascal Case some SpellEntry types (#4432) 2021-02-08 19:01:37 -05:00
Kitzunu 05a8217270 refactor(Core/Player): add helper method for PLAYER_FLAGS_DEVELOPER (#4395)
Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
2021-02-08 16:55:04 -05:00
Vox 94173dbbd9 fix(Core/Spell): Restore Stealth remove check (#4491) 2021-02-07 14:08:10 -05:00
LannyE 2741a3ea1c Fix Bug(cpp): SmartScriptMgr.cpp - Event Start and Stop not working (#4392) 2021-02-07 12:03:01 -05:00
Kitzunu 440d4191ae fix(Core/Spell): Restore SPELL_ATTR0_CU_AURA_CC (#4472) 2021-02-07 09:06:27 -05:00
Kitzunu d902411171 fix(Core/Spell): Clearcasting duration (#4422) 2021-02-06 21:06:30 -05:00
Footman e7bfbe7651 fix(Core/Pathfinding): pets chase & transport (#4451) 2021-02-06 20:22:15 -05:00
Kitzunu bfcc3c6f87 refactor(Core/Spell): Move some SpellImmune from script to db (#4381)
* refactor(Core/Spell): Move some SpellImmune from script to db
2021-02-05 18:57:51 -05:00
Kitzunu 9f47c83c11 fix(Core/Player): Prevent looting already looted items (#4420) 2021-02-05 06:38:44 -05:00
Kitzunu 9fd6f1079b fix(Core/Spell): SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER to face caster (#4351)
* fix(Core/Spell): SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER to face caster

* cherry-pick https://github.com/TrinityCore/TrinityCore/commit/28353e920b531b7dd221ac926049f5a68b75e7ec

Co-Authored-By: Meji <2695278+meji46@users.noreply.github.com>

* [[nodiscard]]

* return;

* fix last thing

* build

* Revert "build"

This reverts commit c892cc292f3592c5089840e393b525f74904779b.

* Update Object.h

* Update Object.h

* Update Object.h

Co-authored-by: Meji <2695278+meji46@users.noreply.github.com>
2021-02-03 17:06:37 +01:00
Kitzunu 6e1fb0d525 feat(Core/Creature): implement c_t->spell_school_immune_mask (#4358)
* feat(Core/Creature): implement spell_school_immune_mask

* https://github.com/TrinityCore/TrinityCore/commit/ae878e18ef121b7b1960f40f2b0f99debd2155d8

Co-Authored-By: Wyreth <32145860+Wyreth@users.noreply.github.com>

* Import from TC

* just capitalize sql keywords

* Update rev_1611769264588956600.sql

Co-authored-by: Wyreth <32145860+Wyreth@users.noreply.github.com>
2021-02-03 03:44:09 +01:00
55Honey 5a3c77a691 refactor(Core/Config): Change PlayerStart.AllSpells to .CustomSpells (#4345)
* Change PlayerStart.AllSpells to .CustomSpells

Remove wrong info regarding the  playercreateinfo_spell_custom table. Change the config flags name to match its purpose.

* Update src/server/worldserver/worldserver.conf.dist

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/World/World.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/World/World.cpp
2021-02-03 01:01:33 +01:00
Francesco Borzì f85cb30c99 feat(Core/Conf): toggle XP price (#4388) 2021-02-02 04:11:54 +01:00
Kitzunu 0d52b4ca4a feat(Core/Spell): Implement ValidateSpellInfo (#4323)
* feat(Core/Spell): Implement ValidateSpellInfo

* cherry-pick from https://github.com/TrinityCore/TrinityCore/commit/2b5d7eef3a091e67c27e853d43ac0bebbfa67531 & https://github.com/TrinityCore/TrinityCore/commit/a0a158b5b851db7e2c16819ec89e913d914a3aba

* sLog->outError

* cleanup

* convert to ValidateSpellInfo

* fix error log

* improve sLog->outError

* remove non related spells stuff from Validate

* remove the last

* build

* build x2
2021-02-01 18:57:25 +01:00
Kitzunu 683ddf6c8d fix(Core/Spell): Detect Undead (#4310) 2021-02-01 16:21:33 +01:00
Yehonal c8f43d8584 feat(Core/Movement): Improved pathfinding, collisions and movements (#4220)
Npc positioning
Implemented slope check to avoid unwanted climbing for some kind of movements (backwards, repositioning etc.)
Implemented backwards movement
Re-implemented circle repositioning algorithm (smartest than retail, but with the same feeling)
Fixed random position of summoned minions
Improved pet following movement. Also, they attack NPC from behind now. Thanks to @Footman

Swimming creatures
Fixed max_z coordinate for swimming creatures. Now only part of their body is allowed to be out of the water level
Fixed pathfinder for swimming creatures creating shortcuts for specific segments, now they swim underwater to reach the seashore instead of flying above the water level.
Creatures with water InhabitType but no swimming flag now, when not in combat, will walk on water depth instead of swimming. Thanks @jackpoz for the original code
UNIT_FLAG_SWIMMING in UpdateEnvironmentIfNeeded to show the swimming animation correctly when underwater
Implemented HasEnoughWater check to avoid swimming creatures to go where the water level is too low but also to properly enable swimming animation only when a creature has enough water to swim.

Walking creatures
Extended the DetourNavMeshQuery adding area cost based on walkability (slope angle + source height) to find better paths at runtime instead of completely remove them from mmaps
improve Z height in certain conditions (see #4205, #4203, #4247 )

Flying creatures
Rewriting of the hover system
Removed hacks and improved the UpdateEnvironmentIfNeeded. Now creatures can properly switch from flying to walk etc.
Spells
LOS on spell effect must be calculated on CollisionHeight and HitSpherePoint instead of position coords.
Improved position for object/creature spawned via spells
Improved checks for Fleeing movements (fear spells)

Other improvements
Implemented method to calculate the CollisionWidth from dbc (used by repositioning algorithm etc.)
Improved raycast and collision checks

Co-authored-by: Footman <p.alexej@freenet.de>
Co-authored-by: Helias <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-02-01 01:34:27 +01:00
Kitzunu fcad2b56ae refactor(Core/Spell): Define some unknown spell attributes (#4305)
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-31 23:03:44 +01:00
Kitzunu 628c75d67f fix(Core/SpellMgr): Add cooldown to some vehicle spells (#4300)
* fix(Core/SpellMgr): Add cooldown to some spells

* author and spellscript

Co-Authored-By: Wyrserth <43747507+Wyrserth@users.noreply.github.com>
2021-01-31 03:09:50 +01:00
Kitzunu c5ce3e4460 fix(Core/Spell): improve check in SPELL_EFFECT_CREATE_ITEM(_2) (#4296)
* fix(Core/Spell): items disappearing in Spell::CheckItems()

* https://github.com/TrinityCore/TrinityCore/commit/18b36734f6ac235dbb7a37ba46d1c8d09d8171ab

* remove GetFreeInventorySpace

* restore p_caster to make other PR needing to merge before this

* fix build

* fuck github conflicts
2021-01-31 02:41:49 +01:00
Kitzunu cf1eddf266 refactor(Core/LoginDatabase): LOGIN_DEL_ACCOUNT_MUTEDEL -> LOGIN_DEL_ACCOUNT_MUTED (#4281) 2021-01-30 13:37:41 +01:00
r0m1ntik 647ce5bed7 fix(Core/Quest): A Tangled Skein (#4237)
Co-authored-by: r0m1ntik <r.badanin94@yandex.ru–>
2021-01-29 20:29:04 +01:00
Kitzunu 520c4c6426 fix(Core/Spell): do not create new items when inventory is full (#4298) 2021-01-27 18:26:17 +01:00
r0m1ntik c9b46beae2 fix(Core/Spell): Glyph apply bonus (#4206) 2021-01-26 21:55:33 +01:00
Kitzunu 17d2560ffa fix(Core/Creature): Implement CREATURE_FLAG_EXTRA_NO_SELL_VENDOR (#4233) 2021-01-26 14:12:21 +01:00
Kitzunu 582a211ccd fix(Core/Creature): Move CREATURE_FLAG_EXTRA_IMMUNITY_KNOCKBACK (#4232) 2021-01-25 21:50:23 +01:00
Kitzunu 879468506f chore(Core/Global): Fix grouping of Worldserver initialization (#4130) 2021-01-25 20:50:53 +01:00
Kitzunu 3d60ce8e6e chore(Core/PathGenerator.h): Kill Malformed whitespace (#4289) 2021-01-24 21:21:48 -05:00
Francesco Borzì 13db145eec fix(gcc): type warning [1/2] (#4332) 2021-01-23 20:22:15 +01:00
Silker 0a8a7ef149 fix(Core): Activate creatures and objects during opening cinematics (#4045)
Co-authored-by: Si1ker <55638679+Sombranator@users.noreply.github.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-01-22 01:03:30 +01:00
Francesco Borzì ce4dbbce76 feat(Core/Config): allow initial (free) amount of Guild Bank tabs (#4290) 2021-01-20 11:19:09 +01:00
Francesco Borzì 8d5347b9ab fix(Core/QuestTracker): do not store quest if quest_id is null (#4027) 2021-01-20 01:14:04 +01:00
FALL1N1 0181b73bc2 feat(Core/Opcodes): Implement CMSG_CHANNEL_MODERATE (#4021)
* Core/Opcodes: Implement CMSG_CHANNEL_MODERATE

* Cleanup, prettify

* fix build

* whitespaces
2021-01-18 19:37:50 +01:00
Kitzunu eddde2198c fix(Core/Creature): Implement INHABIT_ROOT (#4141) 2021-01-18 12:22:33 +01:00
Degen 5a1bb5bc66 fix(Core/SpellMgr): Essence of Wintergrasp only applies if config is enabled (#4110) 2021-01-17 20:14:27 +01:00
Andrius Peleckas 2794842553 feat(Core/Warden): optimization + PQR detection (#3875)
* Update AuctionHouseHandler.cpp

* feat(warden): block PQR

* wip

* Update Warden.cpp

* Core/Warden: minor preperation

* Core/Misc: implemented some needed container wrapper functions

* Core/Warden: more preperations

* Core/Warden: more rework
* LUA checks now are splitted to seperate config
* LUA checks are always in front of queue
* Fixed "Other" checks
* Fixed PQR detection

* Core/Warden: adjusted and optimized

* Core/Warden: optimization

* Core/Warden: more optimization

* Core/Warden: use warden comments in ban reason

* Core/Warden: more warden work

* Core/Warden: more optimizations

* Core/Warden: more refactors

* Core/Warden: some more refactors + use default SHA definitions

* Core/Warden: more refactoring

* Core/Warden: fixed PQR detection again

* Core/Warden: improved detection logging

* Core/Misc: removed SmartEnums - we do not need it here + maybe should go as seperate commit

* Core/Warden: fixed some warnings

* Core/Warden: codestyle

* Core/Warden: include warden check comment to console logs

* Core/Warden: minor adjustment for previous commit

* Core/Warden: fixed static analysis warning

* Core/Warden: compilers, you're drunk this time... function is not unused...

* Core/Warden: minor correction for logs

* Core/Warden: one more improvement for logs

* Core/Warden: added missing overrides

* Core/Warden: some codestyle

* Core/Misc: more codestyle

* Core/Misc: more codestyle!

* Core/Warden: restored default config options... (if you change it, change in core source too)

* Core/Warden: addition to previous commit

* DB/Warden: added EWT and WOWPlus checks (provided by lineagedr)

* DB/Warden: addition to previous commit

* fix: codestyle

* Core/Warden: fixed build when extra logs are enabled in cmake

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2021-01-17 18:36:35 +01:00
Kitzunu 1cc5518147 fix(Core/Spell): Killing Spree range (#4097)
Co-authored-by: Keader <keader.android@gmail.com>
2021-01-17 00:40:30 +01:00
Silker 3f79f16960 fix(Core/SpellMgr): Death Plague stacks (#4299) 2021-01-16 12:52:06 -06:00
Kitzunu 43f59c4c82 feat(Core/Player): implement GetFreeInventorySpace() (#4297) 2021-01-16 17:33:30 +01:00