Commit Graph

196 Commits

Author SHA1 Message Date
Benjamin Jackson 67010623a0 fix(Core): Adjustments to summoning ritual object handling. (#19600)
* Init.

* Allow self-summoning.

* Revert unintended change.

Self-summoning still works fine without this being removed, I see no harm in putting it back.
2024-08-13 12:12:05 -03:00
Saqra1 ad411b49b7 fix(Core/Spell) Ritual spells cooldown on cancel (#19604)
https://github.com/cmangos/mangos-wotlk/commit/762f78b313cff195aadc0aab4b4ab9eaf2957892

Co-authored-by: killerwife <killerwife@gmail.com>
2024-08-13 12:05:12 -03:00
Saqra1 ed824de7b8 fix(Core): Ritual animations (#19602)
Channel the same spell as the original caster when clicking on a ritual
portal, but ignore the effects of the spell.

Co-authored-by: killerwife <killerwife@gmail.com>
2024-08-13 11:54:17 -03:00
Francesco Borzì 02a05fbd4c refactor(src/common): remove unused imports (#19506)
* refactor(src/common): remove unused imports

* fix: build

* chore: fix build

* chore: size_t -> std::size_t

* chore: fix fuckup from previous commit

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build with std::size_t

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build
2024-07-30 20:06:46 -03:00
avarishd ade4c2527f fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPEL… (#19102)
* fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed

https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959
Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* ocd

* correct animation and castbar staying

---------

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-07-17 09:14:06 -03:00
avarishd cf7c015ea4 fix(Core/Spell): Implement SPELL_ATTR6_NO_PUSHBACK (#19292)
fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK
2024-07-17 09:09:34 -03:00
Kitzunu 385d7fd515 chore(Core/DBC): define unused unknown dbc fields (#19262)
* chore(Core/DBC): define unused unknown dbc fields

* Name unused unknown dbc fields using WDBX and wowdev.wiki

* rename SpellShapeshiftEntry to SpellShapeshiftFormEntry to properly match the DBC used

* rename sSpellShapeshiftStore to sSpellShapeshiftFormStore to properly match the DBC used

* Comment out unused field for GlyphPropertiesEntry

* Comment out unused field for MapEntry

* forgot one

* SpellShapeshiftfmt to SpellShapeshiftFormfmt

* SpellShapeshiftFormEntryfmt
2024-07-04 14:23:25 -03:00
Kitzunu f96d4c8670 Revert "Add (core\db): Support for Homebind Orientation (#13389)" (#19257)
* Revert "Add (core\db): Support for Homebind Orientation (#13389)"

This reverts commit 2e6f6e26da.

 Changes to be committed:
	modified:   src/server/database/Database/Implementation/CharacterDatabase.cpp
	modified:   src/server/game/DungeonFinding/LFGScripts.cpp
	modified:   src/server/game/Entities/Player/Player.cpp
	modified:   src/server/game/Entities/Player/Player.h
	modified:   src/server/game/Entities/Player/PlayerStorage.cpp
	modified:   src/server/game/Entities/Player/PlayerUpdates.cpp
	modified:   src/server/game/Handlers/CharacterHandler.cpp
	modified:   src/server/game/Handlers/MiscHandler.cpp
	modified:   src/server/game/Handlers/MovementHandler.cpp
	modified:   src/server/game/Maps/Map.cpp
	modified:   src/server/game/Spells/Spell.cpp
	modified:   src/server/scripts/Commands/cs_misc.cpp
	modified:   src/server/scripts/Commands/cs_tele.cpp
	modified:   src/server/scripts/Northrend/VaultOfArchavon/instance_vault_of_archavon.cpp

 Untracked files:
	data/sql/updates/pending_db_world/rev_1719945200692175000.sql

* Revert "Add (core\db): Support for Homebind Orientation (#13389)"

* whoops
2024-07-02 22:02:15 +02:00
Jelle Meeus 75582eb34b fix(Core/Spell): implement taunt DR CREATURE_FLAG_EXTRA_OBEYS_TAUNT_DIMINISHING_RETURNS (#19128)
* skip other effects in case of taunt DR

* set flags_extra creature_template

https://github.com/TrinityCore/TrinityCore/commit/fe38b78c877fd30cc677913229d23bd6f5c15f0b

Co-authored-by: offl <offl@users.noreply.github.com>

* update query to only entries found in acore_world.creature_template

* add name as comment

* fix ci codestyle

---------

Co-authored-by: offl <offl@users.noreply.github.com>
2024-06-29 11:59:16 -03:00
Jelle Meeus 77d3eb52df fix(Core/Spell): Bladestorm remove reset swing and allow meleeSwingSpell during (#19093)
* remove reset swing

* allow meleeswingspell on PLAYER_ALLOW_ONLY_ABILITY
2024-06-26 22:23:09 +02:00
Benjamin Jackson af722d4e88 fix(Core/Spells): Partially revert spell cancel behavior change. (#19101)
Init.
2024-06-20 14:16:21 -03:00
avarishd 2cf95ca6cb fix(Core/Spells): Don't send SMSG_CAST_FAILED for interrupted spells … (#19082)
fix(Core/Spells): Don't send SMSG_CAST_FAILED for interrupted spells after they were launched or channelling was started (this clears cooldown on client)

https: //github.com/TrinityCore/TrinityCore/commit/63bc405faeb7afcf99de6f7531e4ea59065165f4

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-06-17 21:26:18 -03:00
Elmsroth 729a1ff539 fix(Crash/Quest/Spell) : The Boon of Remulos (#18379)
Fix the spell : https://www.wowhead.com/wotlk/spell=57678/emerald-acorn-effect
Used in quest : https://www.wowhead.com/wotlk/quest=13075/the-boon-of-remulos

The crashed was caused by a nullptr Excception. It also could be throuwn in another similar test that has also been fixed.
If the spell did not have a CastTimeEntry a nullptr Exception was not checked.
2024-02-22 22:40:26 -03:00
Nathan Handley df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Nathan Handley 425a490a7b feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293)
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-09 06:27:02 -03:00
3ster 000ec142a2 Check if triggered spell has cast time (#18231)
* Check if triggered spell has cast time

* Fix client crash upon manually cancelling finished spell
2024-02-03 11:52:34 +01:00
Kitzunu 69dc8804e6 feat(Core/Spell): Add helper for TriggeredCastFlag (#18227)
* feat(Core/Spell): Add helper for TriggeredCastFlag

* Lol

* fix build
2024-01-26 13:51:42 +01:00
Andrew 5a4fdc7de4 fix(Core/Spells): Banish should only be dispelled by Mass Dispel (#17703)
* fix(Core/Spells): Banish should only be dispelled by Mass Dispel

* Update Unit.cpp

* Update Unit.cpp
2023-11-14 16:27:37 +01:00
Kitzunu f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
avarishd 2cd4af9446 fix(Core/Spells): Allow casting ground mounts in water (#17481)
https: //github.com/TrinityCore/TrinityCore/pull/17488

Co-authored-by: SnapperRy <19622383+SnapperRy@users.noreply.github.com>
2023-10-10 20:23:45 -03:00
Kitzunu b84596fcab chore(Scripts/DK): Move CheckCast to spell_dk_raise_ally script (#17221)
* chore(Scripts/Spell): Move CheckCast to spell_dk_raise_ally script

* Update spell_dk.cpp

* Update spell_dk.cpp
2023-09-17 03:05:10 +02:00
Francesco Borzì 5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Synful-Syn 6b583089f3 fix(Core/Spell): Stop Blink from the falling player to move upward by 1y and stop moving backward when facing a wall (#16657)
* blink-bad-warps

* Change formatting of an if
2023-08-25 09:14:27 -03:00
M'Dic ab2c062f03 feat(core\dbc): item.dbc, sItemStore, item_dbc, item enforcement conf, subclass fix (#14675)
feat (core\log\db): item.dbc and enforcement

dbc enforcement partial pick from tc: https://github.com/TrinityCore/TrinityCore/commit/0c44bd33ee7b42c924859139a9f4b04cf2b91261

Custom Item for testing by menevia16a (SPP DEV VEIL)

feat (core\log\db): item.dbc and enforcement

Update Item.sql

Update DBCStores.cpp

Update World.cpp

Update ObjectMgr.cpp

further replacement from template to dbc lookup

further logging and implementation

cherry pick tc https://github.com/TrinityCore/TrinityCore/commit/fd26c3c87c5e75952d5af033a66c9a28c9af29b9

replace with db lookup

update (sql): Murder all the backticks

line break fixit

fix (item_template): fix incorrect subclass

fix incorrect subclass matching with dbc enforcement

update: log correction for sub class

update log correction for sub class

add subclass to dbc enforcement

add subclass dbc enforcement since it is part of the item.dbc item_dbc

update (log): additional log

Co-authored-by: blub <trinity.michael_vincent@gmx.eu>
Co-authored-by: Shocker <511388+shocker@users.noreply.github.com>
Co-authored-by: Veil <1913466+menevia16a@users.noreply.github.com>
Co-authored-by: Shocker <43253032+shockerqt@users.noreply.github.com>
2023-04-28 01:26:44 +02:00
Kitzunu 422db05290 fix(Core/Spell): Removed gathering failure chance from herbalism and … (#15423)
fix(Core/Spell): Removed gathering failure chance from herbalism and mining nodes

* cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/052dfe27fc324f13f8d4cc2af802f57963d8fe7c)

Co-authored-by: Tony Konzel <saxxonpike@gmail.com>
2023-03-17 10:24:36 +01:00
Kitzunu f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix 3fee40be7d fix(Core/Creatures): Spells casted by player should tap the creature … (#14725)
…only if in combat with it.
2023-01-26 04:38:16 -03:00
UltraNix 0e1e8f27de fix(Core/Spells): Every spell casted by player should tap the creature. (#14037)
Fixes #11888
2023-01-06 00:51:54 +01:00
Kitzunu 4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
UltraNix 4ef1010f37 fix(Core/Spells): Maelstrom Weapon should not reset attack timers. (#13504)
Fixes #13179
2022-10-29 07:13:09 -03:00
M'Dic 2e6f6e26da Add (core\db): Support for Homebind Orientation (#13389)
Add (core\db) Support for Homebind Orientation
2022-10-12 14:39:02 -04:00
UltraNix e390087efd feat(Core/Items): Implemented elemental weapon damage. Source: Trinit… (#13050)
...yCore.
2022-10-08 14:34:52 -03:00
Angelo Venturini ad4ce0895f fix: Qaston revert (#13320)
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
2022-10-05 21:53:20 +02:00
Angelo Venturini be423a91b5 fix: Crash (#13241) 2022-10-03 16:14:43 -03:00
Angelo Venturini 590525b86c fix: Crash (#13230) 2022-10-02 22:35:45 -03:00
IntelligentQuantum cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079)
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
2022-10-02 19:39:34 +02:00
M'Dic 33fcab0917 fix (core): Log correction (#13181)
fix (core): Commit LOG correction
2022-10-01 09:45:29 -04:00
UltraNix f658c8ea0c fix(Core/Spells): Fingers of Frost should always proc alongside with … (#13008)
...Frostbite.
2022-09-19 00:52:37 -03:00
ZhengPeiRu21 1ddd884d6a feat(Core): Implement SP Bonus Coefficients from DBC (#12562)
* cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/1826437c094966ae339a154844df8587b2122888)

* Co-authored by: ariel- <ariel-@users.noreply.github.com>

* feat(Core): Implement SP Bonus Coefficients from DBC

* Several coefficient corrections

* Fix spell_dru_lifebloom
2022-09-17 11:09:04 +02:00
UltraNix 577a0a1f3e fix(Core/Spells): Improved Blink in WSG near NE huts. (#13012) 2022-09-13 22:54:05 -03:00
UltraNix ea7f86ae64 fix(Core/Spells): Fixed ground destination of Blink. (#13009)
Fixes #11721
2022-09-13 22:51:40 -03:00
UltraNix 2ef8d2e1e2 fix(Core/Spells): Revive Pet cannot be cast if there is not pet to resurrect (#12818)
- Closes #12776
2022-09-12 03:01:53 +02:00
Maelthyr d0d1671745 feat(Core/Debug): GetDebugInfo implementation (#12705)
Cherry-pick: https://github.com/TrinityCore/TrinityCore/commit/9a924fb9d557434c5a2e4020c80db6e6bfe466ad

Co-authored-by: jackpoz <giacomopoz@gmail.com>

Co-authored-by: jackpoz <giacomopoz@gmail.com>
2022-08-15 09:43:41 -03:00
Nefertumm c806c62c62 fix(Core/Spells): Crashfix (#12609) 2022-08-03 09:05:24 -03:00
UltraNix 346150c92a fix(Scripts/ZulGurub): Hakkar's Blood Siphon (#12196) 2022-07-09 11:05:09 -03:00
UltraNix d41cf026e0 fix(Core/Spells): Fixed calculating LoS checks for spells casted by g… (#12091)
fix(Core/Spells): Fixed calculating LoS checks for spells casted by gameobjects.

Fixed #12066
2022-06-18 11:05:18 -04:00
UltraNix f28c678c14 fix(Core/Spells): Hunter traps should not be activated by targets not… (#11971)
fix(Core/Spells): Hunter traps should not be activated by targets not in LoS.

Fixes #11432
2022-06-06 09:03:24 -03:00
UltraNix 55720eedd3 fix(Scripts/Spells): Sweeping Strikes - improvements. (#11666)
* fix(Scripts/Spells): Sweeping Strikes - improvements.

Fixes #11594

* Buildfix.
2022-05-23 05:49:56 -03:00
UltraNix 99f1cd84e2 fix(Core/Spells): Improvements to Far Sight spell: (#11683)
* fix(Core/Spells): Improvements to Far Sight spell:

Far Sight should not interrupt while casting another spell.
Corrected setting Far Sight object as an active object.
Fixed grid activation range for active dynamic objects.
When Far Sight is over, the camera be reset to player.
Enable swapping camera between Far Sight and Sentry Totem.
Fixes #6368

* Update.

* Update.
2022-05-23 04:26:51 -03:00
天鹿 0c0a2eac3b fix (core): Build Fix (#11723)
* Update Spell.cpp
2022-05-12 10:43:07 -04:00