47f9d66874
feat(Core/Optimization): Create index for sSkillLineAbilityStore to speedup search by skillLine. ( #18622 )
...
* feat(Core/Optimization): Create index for sSkillLineAbilityStore to speedup search by skillLine.
* Remove whitespace.
2024-04-01 05:50:12 -03:00
aee2eefb92
feat(Core/Optimization): Reduce CPU consumption by allocating sendBuffer only when it is needed. ( #18628 )
...
* feat(Core/Optimization): Reduce CPU consumption by allocating the sendBuffer only when it is needed.
* Remove whitespaces.
2024-04-01 05:49:42 -03:00
a870173558
fix(Scripts/BossAI): add optional variable to BossAI class to make sure the boss calls for help ( #18630 )
...
init
2024-03-30 11:31:41 -03:00
73340b94e3
feat(Core/Compression): Move packets compression from map to network thread ( #18602 )
...
* feat(Code/Compression): Move packets compression from map to network thread.
* Code style fix
* Remove unicode letter
2024-03-28 08:57:29 -03:00
b1cf830009
chore(PlayerScript/Hook) : Add CanSetTradeItem Hook in PlayerScript ( #18583 )
...
* chore(PlayerScript/Hook) : Add CanSetTradeItem Hook in PlayerScript
* Allowing non traded slots
* Fix typo and codestyle
2024-03-26 21:28:37 -03:00
5b8bc792b8
feat(core): account delete hook ( #18605 )
...
Add account delete hook
2024-03-26 20:57:42 -03:00
1a537236a8
fix(Core/Spell): Fix spell 35329 (Vibrant Blood) ( #18587 )
2024-03-20 05:01:57 -03:00
33f951d742
fix(Core/Spells): Fixed work of sobering spells and other improvements for drunk system ( #18390 )
...
* fix(Core/Spells): Fix sobering spells and possible uint8 overflow/underflow in SPELL_EFFECT_INEBRIATE handler.
* fix(Core/Spells): Improvements for SPELL_AURA_MOD_FAKE_INEBRIATE handling
2024-03-20 01:45:01 -03:00
0c964dadae
fix (Core/Scripting): SMART_EVENT_NEAR_PLAYERS ( #18514 )
...
* FIX SMART_EVENT_NEAR_PLAYERS
* FIX SMART_EVENT_NEAR_PLAYERS (fix build)
2024-03-20 01:38:57 -03:00
b69df485cf
fix(DB/BlackTemple): Rework Black Temple ( #18569 )
...
* init
* more
* Update rev_1710358311839208100.sql
2024-03-18 22:31:05 +01:00
42c41525de
fix(Scripts/TheEye): increase dagger proc chance and make sure mind control only targets players ( #18563 )
2024-03-16 17:28:40 -03:00
64f372fca3
chore. Avoid failures in the tests of custom items ( #18519 )
...
* chore. Avoid failures in the tests of custom items
* Report error but continue with the rest of the item
* change LOG_ERROR for LOG_DEBUG
2024-03-15 20:09:10 -03:00
ab02c36e67
feat(Scripts/Commands): Implement ".reset items" command ( #18393 )
...
Syntax : .reset items equiped|bags|bank|keyring|currency|vendor_buyback|all|allbags #playername
Delete items in the player inventory (equiped, bank, bags etc...) depending on the chosen option.
#playername : Optionnal target player name (if player is online only). If not provided the command will execute on the selected target player.
Update src/server/scripts/Commands/cs_reset.cpp
Accepted
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
Update data/sql/updates/pending_db_world/rev_1708782048020249700.sql
Accepted
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
Update data/sql/updates/pending_db_world/rev_1708782048020249700.sql
Accepted
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
Update src/server/game/Miscellaneous/Language.h
Accepted
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
fix uint16 vs uint16_t
fix crash and code cleanup
Fix typo
sql fix
Missing typo
selected instead or selecter
AC code style fix
Re-Fix typos
MISSING typos
missing typos
2024-03-15 10:23:31 -03:00
3bcdc4d23e
fix(Core/Spells): Domination affect max 5 targets ( #18555 )
2024-03-15 08:20:51 +01:00
7a7ea27293
fix(SpellInfoCorrections) Raid buffs should ignore LoS ( #18518 )
2024-03-15 01:20:36 -03:00
307c1ab09d
refactor(Core): remove some unused variables ( #18538 )
...
- let's get rid of some compiler warnings
2024-03-13 06:52:43 -03:00
bf17d93727
fix(Core/PVP): Fix OutDoorPVP CustomSpell handling ( #18389 )
...
* fix(Core/PVP): Fix OutDoorPVP CustomSpell handling
- the function HandleCustomSpell() should only return
true if it actually handled a spell
* comment unused parameter
2024-03-10 15:35:29 +01:00
da453b2a8d
fix(Core/SmartScripts): LOS check spell for SmartScipts ( #18501 )
...
* Fix spell 35329 (Vibrant Blood)
* [PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35 )
* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35 )"
This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.
* Revert "Fix spell 35329 (Vibrant Blood)"
This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.
* Revert "Revert "Fix spell 35329 (Vibrant Blood)""
This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.
* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35 )""
This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.
* Revert "Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35 )"""
This reverts commit 0ced477c767b9087eefdf516d0e0fccf1567e6e3.
* Revert "Revert "Revert "Fix spell 35329 (Vibrant Blood)"""
This reverts commit a8da732cfb4369f218e96175fc8f33eafc1e69c9.
* Revert "Revert "Fix spell 35329 (Vibrant Blood)""
This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.
* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35 )""
This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.
* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35 )"
This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.
* Revert "Fix spell 35329 (Vibrant Blood)"
This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.
* FIX LOS SAI
2024-03-08 11:15:45 -03:00
1c8644b3bc
fix(Scripts/TheEye): make legendary TK dagger have 100% proc chance ( #18482 )
...
initial
2024-03-04 10:44:35 +01:00
6df652a8dd
fix(Core/Creature): Prevent combat movement disabled creatures from r… ( #18428 )
...
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary
* fixbuild
* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
34598bfccf
feat(Core/UpdateTime): Improve diff time measurement. ( #18387 )
...
* feat(Core/UpdateTime): Improve diff time measurement.
* Codestyle fixes
2024-02-25 12:08:15 -03:00
4fcd3402ca
fix(Core/SmartAI): implement param maxCount for SMART_TARGET_PLAYER_RANGE ( #18394 )
...
* init
* conditional
2024-02-25 11:50:07 -03:00
729a1ff539
fix(Crash/Quest/Spell) : The Boon of Remulos ( #18379 )
...
Fix the spell : https://www.wowhead.com/wotlk/spell=57678/emerald-acorn-effect
Used in quest : https://www.wowhead.com/wotlk/quest=13075/the-boon-of-remulos
The crashed was caused by a nullptr Excception. It also could be throuwn in another similar test that has also been fixed.
If the spell did not have a CastTimeEntry a nullptr Exception was not checked.
2024-02-22 22:40:26 -03:00
d94d10aa9f
fix(Core): Prevent gift wrapping of limited duration items ( #18334 )
...
fix(Core): Prevent gift wrapping of items with duration
- remaining duration is not beeing stored in character_gifts
- gift wrapping of items with duration preserved
them infinitely
2024-02-19 21:23:13 +01:00
7e419fba5a
fix(Core/Guild): Prevent swapping limited duration items into guild bank ( #18335 )
2024-02-19 21:22:51 +01:00
86bff27611
fix(Core/GameObject): Remove unneeded ClearGossipMenuFor call ( #18331 )
2024-02-18 11:21:52 +01:00
72e75982be
fix(Core/Taxi): Fixes crash when player logins and continues flight ( #18270 )
...
* fix(Core/Taxi): Fixes crash when player logins and continue flight
* Update WaypointMovementGenerator.cpp
2024-02-12 08:18:05 -03:00
1d8c4056b3
feat(Core/Hooks): Add the KillRewarder reference to the OnRewardKillRewarder hook. ( #18290 )
...
* Another hackfix attempt at warden payload forcechecks ban fix.
* Revert last commit, interrupt all forcechecks instead of just _dataSent ones.
* Add rewarder parameter to OnRewardKillRewarder hook.
* Undo old warden changes.
* Removed too much!
2024-02-10 21:58:49 +01:00
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
425a490a7b
feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType ( #18293 )
...
* Create HasActivePower for script intercept
* Replace relevant player-related getPowerType() comparators with HasActivePowerType
* Change OnPlayerHasActivePowerType to regular bool instead of optional
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-09 06:27:02 -03:00
1324f420f2
Fix(Core/CharacterHandler): Incorrect behavior using an equipment set… ( #18253 )
...
* Fix(Core/CharacterHandler): Incorrect behavior using an equipment set if it will result in a full inventory.
* Fixing the error message to -Equiment swap failed - inventory is full- like the Blizzlike error message
2024-02-03 14:34:33 +01:00
000ec142a2
Check if triggered spell has cast time ( #18231 )
...
* Check if triggered spell has cast time
* Fix client crash upon manually cancelling finished spell
2024-02-03 11:52:34 +01:00
b6c429c5a8
fix(Core/Quests): Create quest money reward config and adjust max level bonus reward function. ( #18222 )
...
* Init.
* Drop RewardBonusMoney column.
How's that for deprecation.
* Add formula source link.
* Remove deprecated info in conf.
* Newline.
2024-01-31 23:21:27 +01:00
69dc8804e6
feat(Core/Spell): Add helper for TriggeredCastFlag ( #18227 )
...
* feat(Core/Spell): Add helper for TriggeredCastFlag
* Lol
* fix build
2024-01-26 13:51:42 +01:00
c18bd64136
fix(Core/Misc): typo ( #18221 )
2024-01-23 21:38:32 +01:00
e447351b0f
fix(Core/Creature): Remove automated z spawn correction ( #18200 )
...
* fix(Core/Creature): Remove automated z spawn correction
* comment out unused parameter
* remove gridLoad parameter from Creature::LoadCreatureFromDB()
2024-01-21 07:33:00 -03:00
4cfad0ffac
fix (Core/Unit) Apply Capacitor cooldown on trigger proc instead of on stack add ( #18189 )
...
fix capacitor cooldown
2024-01-20 08:51:49 -03:00
2c7c3b6832
fix(CORE/OPvP): Halaa Mechanics not working properly ( #15634 )
2024-01-14 14:00:53 -03:00
1785df7117
fix(Core/Player): Fix Player not starting at full health ( #18136 )
...
* fix(Core/Player): Fix Player not starting at full health
* remove first call to UpdateMaxHealth() and SetFullHealth()
2024-01-14 11:07:52 -03:00
4321b8a4de
feat(Core/Scripting): Implement new hook OnBeforePlayerLogout() ( #18163 )
...
* new hook OnPlayerPreLogout
* Changed PreLogout to BeforeLogout per review
* Renamed OnPlayerBeforeLogout to OnBeforePlayerLogout per review
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-01-14 00:10:49 +01:00
a1891d8d8f
fix(Core/ThreatMgr): Remove temp threat on resetting threat list ( #18162 )
2024-01-13 05:45:43 -03:00
96d8d1d89a
fix(Core/Creature): Reduce z offset for automated spawn correction ( #18153 )
...
- this is necessary to correctly spawn creatures within small defines
- 0.42f is as good as 1.0f to detect and correct reasonable z errors
in DB spawn data
2024-01-11 11:15:41 -03:00
39ea396113
feat(Scripts/Commands): Implement gameobject respawn command ( #18129 )
2024-01-07 17:58:17 +01:00
bceb6173c2
fix(Core/Player): Sometimes Player whisper is sent as boss whisper ( #18128 )
...
* fix(Core/Player): Sometimes Player emot is sent as boss whisper
* actually change it to whisper as it is boss whisper
* Update Player.cpp
2024-01-07 12:14:20 -03:00
7a859da266
fix(Script/Spell): Vanish Purge behavior ( #18127 )
2024-01-07 12:03:53 -03:00
2558f25623
fix(Core/Quest): Calculate reward money with RATE_REWARD_BONUS_MONEY … ( #18104 )
...
* fix(Core/Quest): Calculate reward money with RATE_REWARD_BONUS_MONEY instead of RATE_DROP_MONEY
* Update worldserver.conf.dist
2024-01-04 18:57:53 +01:00
6202835cff
fix(Core/LFG): Hide XP from max players ( #18103 )
...
* Cherry-pick Player::IsMaxLevel from TrinityCore
* Correctly hide XP reward for max level players in LFG
* Closes #18101
2024-01-03 19:47:26 +01:00
8f127f9e21
Fix combat movement ( #18026 )
...
* Improve combat movement
- Removed a bunch of logic related to another attempt at fixing combat movement.
- Removed SMART_ACTION_SET_CASTER_COMBAT_DIST and updated smarts scripts accordingly.
- Cherry-picked https://github.com/TrinityCore/TrinityCore/commit/7fb74326205acbc5c0fa6b2aa9731d891e788d64
- Cherry-picked https://github.com/TrinityCore/TrinityCore/commit/63a6e1e0480df659e773a3df5e1acc2027ebcf15
Co-Authored-By: Ludovic Barbier <ludovic.barbier03@gmail.com >
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
* Some more cleanup + fix sql
* More fixes to caster chase/combat movement + some cherry picks because why not
- Fix casters always trying to chase to melee range
- Fix casters another case of casters sometimes walking back instead of stopping
- Cleaned up some code
- Cherry picked https://github.com/TrinityCore/TrinityCore/commit/ca25e8d0199730c0976ebc37317e9407aceccc34
- Cherry picked https://github.com/TrinityCore/TrinityCore/commit/96b289cadbf304e427ddbd281d1a6f592af612a7
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
* Added parentheses
* Fixed caster combat movement when target is rooted
- Made a few adjustments to chase range and stuff, but nothing set in stone.
* convert uint to int
---------
Co-authored-by: Ludovic Barbier <ludovic.barbier03@gmail.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2024-01-03 09:56:24 +01:00
f9f71fff36
fix(Core/Player): Check if the player can summon the warlock pet on B… ( #18064 )
...
fix(Core/Player): Check if the player can summon the warlock pet on BG ress
2024-01-01 14:56:32 +01:00
e3fd42f3d4
feat(Core/World): Implement DoForAllPlayers() helper for all online p… ( #18060 )
...
* feat(Core/World): Implement DoForAllPlayers() helper for all online players
* Update src/server/game/World/World.cpp
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com >
* Update src/server/game/World/World.cpp
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com >
* rename
* Update WorldMock.h
* Update WorldMock.h
---------
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com >
2024-01-01 13:57:57 +01:00
Anton Popovichenko