1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
7457aef78d
refactor(Core/Entities): Cleanup Unit header file ( #19622 )
...
* move several enum definitions in a new files
* move more things
* remove the include comment
* move the related code to CharmInfo in this own file
*original idea of Ovahlord
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* fix clang build errors and few blank lines
* missing forward declaration
* new tentative to fix gcc/clang build
* add several include could be necessary for gcc/clang compilation
* .
* revert some include since the last AC update
* fix some loop inconsistencies
* align all enums in UnitDefine.h
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-08-15 05:12:44 -03:00
a1891d8d8f
fix(Core/ThreatMgr): Remove temp threat on resetting threat list ( #18162 )
2024-01-13 05:45:43 -03:00
5d01b700fd
refactor(Core): remove unused imports ( #17094 )
2023-08-28 13:39:43 +02:00
df77b5f4f7
chore(core): cleanup code p3 ( #16073 )
...
* Update MMapMgr.cpp
* Update UpdateFetcher.cpp
* Update AuctionHouseMgr.cpp
* Update AuctionHouseMgr.h
* Update BattlegroundAV.cpp
* Update ChannelMgr.cpp
* Update ThreatMgr.h
* Update Player.h
* Update PlayerSettings.cpp
* Update ObjectMgr.cpp
* Update Guild.cpp
* Update Guild.h
* Update Map.cpp
* Update World.cpp
* Update boss_nefarian.cpp
* Update boss_prince_malchezaar.cpp
* Update boss_venoxis.cpp
* Update zone_elwynn_forest.cpp
* Update zulfarrak.cpp
* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
14f3b444ae
fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SU… ( #14054 )
...
* fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SUMMONER` summon flag.
Fixes #6674
* Update.
2023-01-06 00:52:05 +01:00
3024bee3ba
refactor(Core/UnitAI): Update target selector ( #13169 )
...
* refactor(Core/UnitAI): Update TargetSelector.
Cherry-pick:
*https://github.com/TrinityCore/TrinityCore/pull/19930
Co-authored-by: Treeston <treeston@users.noreply.github.com >
* fix GGC/CLang errors in scripts
* .
* missing a file and fix a script error
* .
* fix path changes dude to a miss click in the second commit
* .
Co-authored-by: Maelthyrr <lynethris@protonmail.ch >
Co-authored-by: Treeston <treeston@users.noreply.github.com >
2022-12-06 09:27:13 -03:00
ad4ce0895f
fix: Qaston revert ( #13320 )
...
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271 )"
This reverts commit e05f61d1b3#13292 )"
This reverts commit a818bcf3e2#13241 )"
This reverts commit be423a91b5#11079 )"
This reverts commit cbd3fd0967
2022-10-05 21:53:20 +02:00
cbd3fd0967
refactor(Core/Spells): Implement QAston Proc System ( #11079 )
...
* .
* sql
* .
* .
* 1
* 2
* 3
* 4
* 5
* 6
* 7
* 8
* 9
* 10
* 11
* 12
* 13
* 14
* 15
* Update spell_item.cpp
* Update Unit.cpp
* 16
* 17
* 18
* 19
* 20
* 21
* Update Unit.cpp
* REVERT UltraNIX Commit
* 22
* 23
* .
* .
* .
* warrior
* warlock
* shaman rogue priest paladin mage
* spell item
* hunter
* druid
* dk
* war
* error style
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* .
* DOND DEL ME WAD DO DO
* error 2
* .
* .
* .
* FIX
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
* .
* ja genau
* Update .gitignore
* .
* .
* .,
* .
* .
* .
* .
* Update Unit.cpp
2022-10-02 19:39:34 +02:00
1f472bddd3
refactor(Core/Combat): Code style and improvement of ThreatMgr ( #12992 )
2022-09-25 15:20:34 -03:00
801e68b1dd
fix(Core/Creatures): Added new AI function OnTeleportUnreacheablePlayer to teleport all unreachable players. ( #12193 )
...
* fix(Core/Creatures): Implemented CREATURE_FLAG_EXTRA_TELEPORT_UNREACHABLE_PLAYERS.
Fixed #11750
* Update.
* Update.
* Update.
2022-07-24 13:10:41 -03:00
ea24a7b231
fix(Scripts/ZulGurub): Mandokir's Threatening Gaze. ( #12095 )
...
* fix(Scripts/ZulGurub: Mandokir's Threatening Gaze.
Boss can melee attack while casting.
Boss charges after the debuff run out.
Guillotine is casted on hit rather than on launch.
Properly coded Threatening Gaze Charge (with dot/hot exceptions)
Whirlwind is removed during charge.
Fixes #11748
* Update
* missing
* Update
* Update.
* Update.
* Update.
* Update.
* Update.
2022-06-26 04:50:50 -03:00
dfc6adb081
refactor(Core/Combat): DeleteThreatLists() become ClearAllThreat() ( #11824 )
...
refactor(Chore/Combat): DeleteThreatLists() become ClearAllThreat()
2022-05-23 05:51:52 -03:00
c5368816fa
Core/Combat: rename getThreatMgr() to GetThreatMgr() ( #11758 )
2022-05-18 05:36:57 -03:00
5ede1177c5
refactor(Core/Combat): implement compatiblity layer for ResetAllThreat() ( #11778 )
...
* implement ResetAllThreat()
* .
2022-05-17 12:01:25 -03:00
db360f0cfb
Fix (Core\DB) Hostil to Hostile spelling fix ( #11399 )
...
* Fix (Core) Hostil to Hostile spelling fix
* sql cmd adjustment as well
* AliGnZ
* Further Hostil to Hostile Correction
Per @Si1ker Research via https://github.com/azerothcore/azerothcore-wotlk/pull/11399#issuecomment-1099506373
2022-04-16 11:00:38 -04:00
9dc88def35
refactor(Core): apply clang-tidy modernize-* ( #9975 )
...
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2022-01-17 14:35:07 +01:00
2d4e17fd16
refactor(Core/Creature): Remove Inhabit Type ( #9272 )
...
This is in reference to issue: https://github.com/azerothcore/azerothcore-wotlk/issues/4361
This is comprised of a cherry pick and partial tc cherry pick:
https://github.com/TrinityCore/TrinityCore/commit/592516ae69d89da3bcb0ede144644a3d2e0186e0
https://github.com/TrinityCore/TrinityCore/commit/dbadb6369cf0b6d394fffaa1dedc612dfb5cbe2a
https://github.com/TrinityCore/TrinityCore/commit/34cfa69efd1857540f1f44b118086bb02334c100
https://github.com/TrinityCore/TrinityCore/commit/12de860b4aefc02cc77b7487ef218fb584cdb552
https://github.com/TrinityCore/TrinityCore/commit/a22bc236ebc038c723774e5b38cd93e814ccc43d
2022-01-06 10:33:22 -03:00
a54c84f349
fix(Core/Players): Removed old and invalid Player::SetInWater funct… ( #9739 )
...
* fix(Core/Players): Removed old and invalid `Player::SetInWater` function.
Updates #8729
* buildfix.
2021-12-28 09:34:45 -03:00
801a20fce2
refactor(Core): Clean-up after FD ( #8586 )
2021-11-28 03:04:14 -03:00
f62664c987
refactor(Core/Misc): headers cleanup ( #9259 )
2021-11-22 17:24:39 +07:00
db0c27fe43
fix(Core/Combat): Removed some invalid code about auto-acquiring a nearby target if primary target is not detectable by creature. ( #8624 )
...
Spells with sanctuary always delete hostile references (if not during encounter).
Update visibility should be always forced in case of invisibility/stealth auras.
Restored old Shadowmeld code.
Fixes #4764
Fixes #7125
2021-10-21 15:54:36 -03:00
0e5eb1b0cf
fix(Core/Pets): Eye of Kilrogg should not put its owner in combat wit… ( #7193 )
...
- Closes #6627
2021-10-07 20:03:04 +02:00
0d411ec2c3
fix(Core/Crash): Evade after cleaning threat references. ( #8160 )
2021-10-06 01:26:03 -03:00
52aa0e9966
feat(License): add new headers information about license ( #7941 )
...
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com >
2021-09-30 13:40:52 +07:00
1bf4f54b32
fix(Core/Combat): Creatures should evade if its only victim is teleporting to other map ( #7975 )
2021-09-20 16:05:45 -06:00
2f449326e0
refactor(Core): Rename ...Manager to ...Mgr ( #6910 )
...
* Rename MapManager.h to MapMgr.h
* Rename BanManager.h to BanMgr.h
* Rename MapManager.cpp to MapMgr.cpp
* Rename BanManager.cpp to BanMgr.cpp
* Rename MapRefManager.h to MapRefMgr.h
* Rename ThreatManager.h to ThreatMgr.h
* Rename GridRefManager.h to GridRefMgr.h
* Rename ThreatManager.cpp to ThreatMgr.cpp
* Rename GroupRefManager.h to GroupRefMgr.h
* Rename HostileRefManager.h to HostileRefMgr.h
* Rename HostileRefManager.cpp to HostileRefMgr.cpp
* Rename MMapManager.h to MMapMgr.h
* Rename FollowerRefManager.h to FollowerRefMgr.h
* Rename VMapManager2.h to VMapMgr2.h
* Rename IVMapManager.h to IVMapMgr.h
* Rename MMapManager.cpp to MMapMgr.cpp
* Rename VMapManager2.cpp to VMapMgr2.cpp
* Rename RefManager.h to RefMgr.h
* Rename WaypointManager.h to WaypointMgr.h
* Rename WaypointManager.cpp to WaypointMgr.cpp
* Rename MPQManager.h to MPQMgr.h
* Rename MPQManager.cpp to MPQMgr.cpp
* Rename IMMAPManager.h to IMMAPMgr.h
* fix build
* Update Main.cpp
* chore(Core/Misc): Remove toxic language
* Revert "chore(Core/Misc): Remove toxic language"
* fix build
* build
2021-09-15 17:50:28 +02:00
7d9fe22e28
refactor(Core): code cleanup (part 1) ( #6361 )
2021-06-16 12:58:14 +02:00
e3a5727222
chore(Core): typo fixes ( #6272 )
...
Co-authored-by: Bogir <m-000@bk.ru >
2021-06-16 11:28:00 +02:00
897a02bb75
refactor(Core/Misc): acore to Acore ( #6043 )
2021-05-31 14:21:54 +02:00
f4c226423d
feat(Core/Misc): implement ObjectGuid class (port from TC) ( #4885 )
2021-04-25 22:18:03 +02:00
f6a17164be
fix(Core/License): issue with old files license ( #4762 )
2021-03-17 09:46:01 -06:00
28f1dc5c0c
refactor(Core): replace NULL with nullptr ( #4593 )
2021-03-02 01:34:20 +01:00
dbc0ff6554
refactor(Core): sort #includes alphabetically ( #4579 )
2021-02-24 22:34:42 +01:00
c8f43d8584
feat(Core/Movement): Improved pathfinding, collisions and movements ( #4220 )
...
Npc positioning
Implemented slope check to avoid unwanted climbing for some kind of movements (backwards, repositioning etc.)
Implemented backwards movement
Re-implemented circle repositioning algorithm (smartest than retail, but with the same feeling)
Fixed random position of summoned minions
Improved pet following movement. Also, they attack NPC from behind now. Thanks to @Footman
Swimming creatures
Fixed max_z coordinate for swimming creatures. Now only part of their body is allowed to be out of the water level
Fixed pathfinder for swimming creatures creating shortcuts for specific segments, now they swim underwater to reach the seashore instead of flying above the water level.
Creatures with water InhabitType but no swimming flag now, when not in combat, will walk on water depth instead of swimming. Thanks @jackpoz for the original code
UNIT_FLAG_SWIMMING in UpdateEnvironmentIfNeeded to show the swimming animation correctly when underwater
Implemented HasEnoughWater check to avoid swimming creatures to go where the water level is too low but also to properly enable swimming animation only when a creature has enough water to swim.
Walking creatures
Extended the DetourNavMeshQuery adding area cost based on walkability (slope angle + source height) to find better paths at runtime instead of completely remove them from mmaps
improve Z height in certain conditions (see #4205 , #4203 , #4247 )
Flying creatures
Rewriting of the hover system
Removed hacks and improved the UpdateEnvironmentIfNeeded. Now creatures can properly switch from flying to walk etc.
Spells
LOS on spell effect must be calculated on CollisionHeight and HitSpherePoint instead of position coords.
Improved position for object/creature spawned via spells
Improved checks for Fleeing movements (fear spells)
Other improvements
Implemented method to calculate the CollisionWidth from dbc (used by repositioning algorithm etc.)
Improved raycast and collision checks
Co-authored-by: Footman <p.alexej@freenet.de >
Co-authored-by: Helias <stefanoborzi32@gmail.com >
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2021-02-01 01:34:27 +01:00
da4edd547d
chore(core): remove malformed whitespaces ( #4244 )
...
* from https://www.codefactor.io/repository/github/azerothcore/azerothcore-wotlk/issues?category=Style&groupId=838&lang=5&page=75
2021-01-10 14:27:55 +01:00
ea93a5c1a1
feat(CI/Codestyle): added codestyle check ( #3668 )
2021-01-09 11:59:50 +01:00
c5a35efd7b
refactor(Core): apply clang-tidy modernize-use-default-member-init ( #3827 )
2020-12-07 13:34:06 -06:00
0b8ec1f6ee
refactor(Core): apply clang-tidy modernize-loop-convert ( #3822 )
2020-12-07 19:04:19 +01:00
cba126fa84
refactor(Core): apply clang-tidy modernize-use-nullptr ( #3819 )
2020-12-06 20:55:11 +01:00
161302252e
refactor(Core): apply clang-tidy modernize-use-nodiscard ( #3835 )
2020-12-06 19:39:48 +01:00
d4a58700d4
refactor(Core): apply clang-tidy modernize-use-override ( #3817 )
2020-12-06 18:04:55 +01:00
a2b26272d2
refactor(Core/Game): restyle game lib with astyle ( #3466 )
2020-10-12 10:08:15 +02:00
1f89282b22
refactor(Core): NULL -> nullptr ( #3275 )
...
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com >
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com >
2020-08-31 11:55:09 +02:00
32dcb3bf63
feat(Core/Spell): Header include optimization for files: SpellAura.h SpellAuraEffects.h ( #2632 )
2020-02-19 07:55:18 +01:00
e22d78ecd6
refactor(Core): rename namespaces and macros to acore ( #2454 )
2019-12-01 13:13:31 +01:00
c15206fc15
Revert "feat(core): Ensure that all actions are compared to fixed point in time ( #1236 ) ( #1458 )" ( #1471 )
...
This reverts commit 51b8773528
2019-02-15 15:14:49 -03:00
51b8773528
feat(core): Ensure that all actions are compared to fixed point in time ( #1236 ) ( #1458 )
...
i.e. world update start
2019-02-14 19:22:17 +01:00
dd300003e2
Update license links ( #783 )
2018-03-12 10:54:57 +01:00
Benjamin Jackson