Commit Graph

305 Commits

Author SHA1 Message Date
Anton Popovichenko 22f2a8f731 fix(Core/Spell): Fix crash in Rogue T10 4P Bonus (#18413) 2024-02-25 19:55:32 -03:00
Nathan Handley df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Nathan Handley 425a490a7b feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293)
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-09 06:27:02 -03:00
Andrew c863a8cfb5 fix(Scripts/Rogue): Fix Vanish not granting stealth (#18155) 2024-01-12 02:28:32 -03:00
Kitzunu 7a859da266 fix(Script/Spell): Vanish Purge behavior (#18127) 2024-01-07 12:03:53 -03:00
IntelligentQuantum 016bb86d3b refactor(Scripts): remove useless includes (#18004) 2023-12-22 18:41:28 +01:00
天鹿 bf87cc5230 fix(Core): Build (#17989)
Update spell_generic.cpp
2023-12-11 09:54:44 -03:00
Angelo Venturini 31b66ad80a fix(Core/SSC): Fix Lady Vashj summons (#17982) 2023-12-11 02:46:12 -03:00
Winfidonarleyan eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Kitzunu 5bfeabde81 chore(Core/Misc): rename spellInfo pointers (#17914)
* Rename all
2023-12-02 06:03:15 -03:00
avarishd 9c225fca58 fix(DB/SAI): Doomguard Commander - Crystal Prison (#17782)
* fix(DB/SAI): Doomguard Commander - Crystal Prison

* flags
2023-11-19 12:48:35 +01:00
Winfidonarleyan e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Grimgravy 6486f72740 fix(Script/Quest): Improve A Spirit Ally? (#16893)
* fix(db/Quest): Improve A Spirit Ally?

* Update spell_quest.cpp

* improvement in position
2023-11-12 17:52:49 +01:00
avarishd 67811a6369 fix(Script/Spell): Carinda's Scroll of Retribution usable on players (#17601) 2023-11-12 16:32:16 +01:00
avarishd 9c09ddc3df fix(DB/Creature): Hellfire Peninsula - Stonescythe mobs (#17604)
fix(DB/Creature): HFP - Stonescythe mobs
2023-11-02 08:54:11 -03:00
avarishd bc688c2a51 fix(Core/Spells): Script Choking Vines (#17615)
* fix(DB/Custom): Choking Vines should stack from different sources

* script spell

* comment
2023-11-02 08:53:45 -03:00
avarishd 0679789120 fix(Core/Spells): T5 Holy Paladin 2 set (#17566)
* fix(Core/Spells): T5 Holy Paladin 2 set

* thanks notepad (don't ask)
2023-10-29 23:36:27 +01:00
Kitzunu f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
avarishd 39bad395c2 fix(Core/Spells): Script Yeh'kinya's Bramble (#17516)
* fix(Core/Spells): Script Yeh'kinya's Bramble

* rogue screechers
2023-10-21 08:10:00 -03:00
avarishd 2c28cc0eb7 fix(DB/Items): Unhatched Jubling Egg obtaining + RP (#17478) 2023-10-20 20:39:04 -03:00
Dan c7324f3066 fix(Scripts/Paladin): ensure Judgements of the Just procs Seal of Vengeance/Corruption (#17470)
* initial

* no spaces

* add enum
2023-10-19 12:19:59 -03:00
avarishd a39175bc3b fix(Core/Spells): Demonic Knowledge missing 1% per rank (#17495) 2023-10-18 19:21:46 -03:00
avarishd 1ef50c31b3 fix(Scripts/Spells): Script Leggings of Beast Mastery. (#17428) 2023-10-18 19:15:49 -03:00
avarishd e30718db36 fix(Core/Spells): Script Scourge Banner (#17523)
* fix(Core/Spells): Script Scourge Banner

* correct statecheck
2023-10-16 23:13:54 +02:00
avarishd e4eb789e52 fix(Script/Spells): Script Priest Heal T4 4P Bonus (#17490)
* fix(Core/Spells): Script Priest Heal T4 4P Bonus

* RemoveAurasDueToSpell

* comment out unused stuff
2023-10-12 10:16:59 -03:00
avarishd 1753a8d0b9 fix(Core/Spells): Call of the Wild targeting other players (#17485)
* fix(Core/Spells): Call of the Wild targets

* comment
2023-10-11 17:09:53 -03:00
avarishd 5aca484574 fix(Core/Scripts): Venomhide Hatchling improvements (#17454) 2023-10-10 20:25:26 -03:00
avarishd e8b81430af fix(Core/Spells): Script Void Star Talisman resistances. (#17427)
* fix(Core/Spells): Script Void Star Talisman resistances.

* add check for armor

* change comment loc

* .

* fix(Core/Spells): Script Lord Valthalak's Amulet

* Revert "fix(Core/Spells): Script Lord Valthalak's Amulet"

This reverts commit 5a6a0a8e1fd596e0ffae906cfdac2f68fb1bc78d.

* Use spellInfo instead of hardcode
2023-10-10 13:12:11 -03:00
avarishd 4e5077ed80 fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus (#17424)
* fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus

* 🧙‍♂️✨
2023-10-08 09:31:54 -03:00
avarishd 91c6bdd540 fix(Core/Spells): Script Lord Valthalak's Amulet (#17431)
* fix(Core/Spells): Script Lord Valthalak's Amulet

* cs
2023-10-07 07:34:35 -03:00
Skjalf 547628fe70 fix(Scripts/Spells): Fix Dash applying bonuses in other forms (restor… (#17393)
fix(Scripts/Spells): Fix Dash applying bonuses in other forms (restores previous code functionality)
2023-09-30 17:59:15 -03:00
Skjalf e67a0b1a82 fix(Scripts/Spells): Fix Furious Howl not giving ranged attack power … (#17345) 2023-09-25 21:31:36 -03:00
Skjalf c7b7b7dc07 fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet (#17342)
* fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet

* Update src/server/game/Entities/Pet/Pet.cpp
2023-09-25 08:07:09 -03:00
Skjalf 4afc200f41 fix(Scripts/Spells): Druid Dash require Cat Form (#17343) 2023-09-25 08:06:01 -03:00
Skjalf cc60bc0c35 fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to… (#17348)
* fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to engineers

* Update SpellEffects.cpp

* Update spell_item.cpp
2023-09-25 06:10:23 -03:00
Kitzunu b84596fcab chore(Scripts/DK): Move CheckCast to spell_dk_raise_ally script (#17221)
* chore(Scripts/Spell): Move CheckCast to spell_dk_raise_ally script

* Update spell_dk.cpp

* Update spell_dk.cpp
2023-09-17 03:05:10 +02:00
Tereneckla edaf38c6c3 refactor(Scripts/Spells): Check for existence of AD debuff instead of adding a custom cooldown to heal (#17265)
* Update spell_paladin.cpp

* whitespace
2023-09-15 20:30:15 -03:00
Francesco Borzì 5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Walter Pagani 957ccdb845 fix(Script/Spells): Book of Fel Names (#17051) 2023-08-21 21:15:00 +02:00
Kitzunu 6185b1d73b fix(Core/Events): Implement Spirit of Competition event (#16963)
* fix(Core/Events): Implement Spirit of Competition event

Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* more stuff

* bye bye magic numbers

* fix dberrors

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* commoneers

* Update src/server/game/Battlegrounds/Battleground.cpp

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

* ci

* Update rev_1691529514989936100.sql

* unnecessary whitespace

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update Battleground.cpp

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2023-08-20 00:41:44 +02:00
Grimgravy edc92b4282 fix(Scripts/Quest): Improved Varedis Must Be Stopped (#16799)
* fix(Scripts/Quest): Varedis Must Be Stopped

* Update spell_quest.cpp

* Update data/sql/updates/pending_db_world/rev_1689813586760998100.sql

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-19 22:13:56 +02:00
avarishd 7c43738214 fix(Spells/Scripts): Gnomish Poultryizer (#15554)
fix(Spells/Scripts): Gnomish Poultryizer not breaking on damage
2023-08-10 14:37:14 -03:00
avarishd 66daf97144 fix(Core/Spells): Curse of Pain (#16844)
* fix(Core/Spells): Curse of Pain

* ocd
2023-07-29 21:51:15 +02:00
Grimgravy 721a1de241 fix(Scripts/Quest): improved Curing the Sick (#16798) 2023-07-26 08:48:57 -03:00
avarishd 998bb9d54b fix(Core/Spells): Shriveling Gaze (#15939)
* fix(Core/Spells): Shriveling Gaze

* comment out unused parameter

* again
2023-07-08 10:03:03 -03:00
Kitzunu ee18f55f63 fix(Scripts/Spells): Convert some Druid spells to SpellScript (#16414)
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-06-01 22:04:00 +02:00
M'Dic 7e58650cf5 revert(Core): ChrRace.dbc full implementation (#16114)
* revert (core): ChrRace.dbc full implementation

we revert this due to several issues arrising. Although the dbc reading is done in full and correctly. Azerothcore relied on the original handling (althought not propper) for so long that  there is

* revert

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql
2023-04-29 08:23:11 -03:00
M'Dic 3eae4c5713 fix(core/dbc): improve ChrRace DBC handling (#14843)
Cherry pick of https://github.com/TrinityCore/TrinityCore/pull/24508

Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
2023-04-28 01:29:33 +02:00
UltraNix 790417b1b1 fix(Core/Spells): Fixed somed Druid idols not being modified by spell… (#15452)
fix(Core/Spells): Fixed somed Druid idols not being modified by spell power coefficients.

Fixes #14479
2023-04-22 10:08:01 -03:00
天鹿 d75bcf0f67 chore(core): Cleanup code (#16012)
* Update SmartScript.cpp

* Update M2Stores.cpp

* Update PetHandler.cpp

* Update WaypointMovementGenerator.cpp

* Update WorldSession.cpp

* Update spell_item.cpp

* Update LoginDatabase.cpp
2023-04-19 21:34:48 -03:00