* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods
* Create rev_1724540286668312700.sql
* Update spell_generic.cpp
* update to new format
* fix(Scripts/Spells): Revive pets with full mana in bgs
* Pets were incorrectly revived without restoring its mana
* Closes#15894
* ready for merge
---------
Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
* remove seed of corruption handling in unit.cpp
* add generic and warlock aurascript
add warlock aurascript
add enum
add generic aurascript
add OnRemove
https://github.com/TrinityCore/TrinityCore/commit/2ff855054f52bf2dcf81aa7a7da7bab7f8a99686#diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec
detonation threshold scaling added in: https://github.com/TrinityCore/TrinityCore/commit/df5afca27859058f725c3dc9964d967aa89ff756
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* add LoS check to generic damage
* refactor 2 scripts to 1 with args
refactor const_cast to GetAura()->GetEffect(
refactor reduce a line
* fix detonation threshold scaling
changed SPELL_DIRECT_DAMAGE to DOT
* remove not needed IsExpired() check
removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE
* update comment
* refactor script with args to single spellscript, fix detonate by evade
* refactor
detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged
* refactor to 2 spell scripts again
* rename detonation spell from seed_of_corruption to seed_of_corruption_damage
avoids confusion with seed of corruption (with dot effect)
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
* refactor: remove _keepersGUID[4]
* make keeper auras only target players, remove apply scale immunity to well/keepers
include caster in cast
* update keeper flags
* summon and despawn gossip keepers
spawn only if fight done
add intro spell and handle outro
fix off by 1
fix casting simple teleport, only spawn after teleporting
remove empty line
* add teleport to shared ulduar.h
* each keeper triggers their own gossip spawn
* update is called in Reset(), no need to do it here
* add SpellHit override to Freya, Hodir
* Freya, Hodir: use scheduler to schedule post-fight teleport
* JustSummoned rename cr to summon
* sanity well summons are handled by freya instead of sara
* rename pCreature to creature
* keeper use RegisterUlduarCreatureAI
* Freya, Hodir, Thorim: increase despawn time
* despawn tentacles, sanity wells after fight
despawn tentacles after fight
* change order of teleport spells
* am missing header?
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
Benjamin Jackson