sindoring/open-wc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(M01): correct ADT filename coordinate axes

Browse Source 
Work-Package: M01-FND-COORD-TILE-AXIS-002
Agent: sindo-main-codex
Tests: coordinate mapper, M00 calibration, baseline manifest, coordination and documentation gates passed
Fidelity: Azeroth_31_49 raw MCNK origins and OpenRealm confirm filename X from world Y and filename Y from world X
This commit is contained in:
sindoring
2026-07-13 14:12:51 +04:00
parent f9c467b71f
commit a7072e3d14
5 changed files with 77 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tools/verify_coordinate_mapper.gd
+40 -6
View File
@@ -3,6 +3,7 @@ extends SceneTree
## Headless contract verification for M01 canonical coordinate value objects and
## [CoordinateMapper]. Uses synthetic boundaries plus five positions observed in
## the original WoW 3.3.5a build 12340 during the M00 paired renderer session.
## The Elwynn filename case regression-checks a raw `Azeroth_31_49.adt` corpus.
const CoordinateMapperScript = preload("res://src/domain/coordinates/coordinate_mapper.gd")
const CanonicalWowWorldPositionScript = preload("res://src/domain/coordinates/canonical_wow_world_position.gd")
@@ -24,6 +25,7 @@ func _initialize() -> void:
_verify_build_12340_golden_positions(failures)
_verify_server_and_adt_round_trips(failures)
_verify_tile_and_chunk_boundaries(failures)
_verify_recorded_raw_adt_chunk_axes(failures)
_verify_world_yaw_conversions(failures)
if not failures.is_empty():
@@ -32,7 +34,7 @@ func _initialize() -> void:
quit(1)
return
print("COORDINATE_MAPPER PASS golden_points=5 tile_boundaries=8 yaw_cases=5")
print("COORDINATE_MAPPER PASS golden_points=5 tile_boundaries=8 raw_mcnk=2 yaw_cases=5")
quit(0)
@@ -107,10 +109,10 @@ func _verify_tile_and_chunk_boundaries(failures: Array[String]) -> void:
_expect_tile(CoordinateMapperScript.canonical_to_adt_tile(CanonicalWowWorldPositionScript.new(-BOUNDARY_EPSILON_YARDS, -BOUNDARY_EPSILON_YARDS, 0.0)), 32, 32, true, "south-east of center boundary", failures)
_expect_tile(CoordinateMapperScript.canonical_to_adt_tile(CanonicalWowWorldPositionScript.new(-half_extent + BOUNDARY_EPSILON_YARDS, -half_extent + BOUNDARY_EPSILON_YARDS, 0.0)), 63, 63, true, "inside south-east extent", failures)
_expect_tile(CoordinateMapperScript.canonical_to_adt_tile(CanonicalWowWorldPositionScript.new(-half_extent, -half_extent, 0.0)), 64, 64, false, "exclusive south-east extent", failures)
_expect_tile(CoordinateMapperScript.canonical_to_adt_tile(CanonicalWowWorldPositionScript.new(tile_size, -tile_size, 0.0)), 31, 33, true, "whole-tile offsets", failures)
_expect_tile(CoordinateMapperScript.canonical_to_adt_tile(CanonicalWowWorldPositionScript.new(-9153.334, 386.666, 180.0)), 49, 31, true, "Elwynn golden tile", failures)
_expect_tile(CoordinateMapperScript.canonical_to_adt_tile(CanonicalWowWorldPositionScript.new(tile_size, -tile_size, 0.0)), 33, 31, true, "whole-tile offsets", failures)
_expect_tile(CoordinateMapperScript.canonical_to_adt_tile(CanonicalWowWorldPositionScript.new(-9153.334, 386.666, 180.0)), 31, 49, true, "raw Azeroth_31_49 filename", failures)
var tile_coordinate = AdtTileCoordinateScript.new(49, 31)
var tile_coordinate = AdtTileCoordinateScript.new(31, 49)
var local_position = CoordinateMapperScript.canonical_to_adt_tile_local(CanonicalWowWorldPositionScript.new(-9153.334, 386.666, 180.0))
var local_round_trip = CoordinateMapperScript.adt_tile_local_to_canonical(tile_coordinate, local_position)
_expect_canonical_position(local_round_trip, CanonicalWowWorldPositionScript.new(-9153.334, 386.666, 180.0), ROUND_TRIP_TOLERANCE_YARDS, "ADT tile-local round trip", failures)
@@ -123,11 +125,43 @@ func _verify_tile_and_chunk_boundaries(failures: Array[String]) -> void:
CoordinateMapperScript.ADT_CHUNK_SIZE_YARDS
)
var chunk_coordinate = CoordinateMapperScript.adt_tile_local_to_chunk(tile_coordinate, chunk_local_position)
_expect_equal(chunk_coordinate.chunk_x, 1, "exact south chunk boundary", failures)
_expect_equal(chunk_coordinate.chunk_y, 2, "exact east chunk boundary", failures)
_expect_equal(chunk_coordinate.chunk_x, 2, "exact east chunk boundary", failures)
_expect_equal(chunk_coordinate.chunk_y, 1, "exact south chunk boundary", failures)
_expect_true(chunk_coordinate.is_within_map_grid(), "chunk coordinate is inside map grid", failures)
func _verify_recorded_raw_adt_chunk_axes(failures: Array[String]) -> void:
var half_chunk_size_yards := CoordinateMapperScript.ADT_CHUNK_SIZE_YARDS * 0.5
var recorded_chunk_origins := [
{
"label": "raw MCNK 0,0",
"chunk_x": 0,
"chunk_y": 0,
"canonical_x_origin": -9066.666015625,
"canonical_y_origin": 533.333984375,
},
{
"label": "raw MCNK 15,15",
"chunk_x": 15,
"chunk_y": 15,
"canonical_x_origin": -9566.666015625,
"canonical_y_origin": 33.333984375,
},
]
for recorded_chunk_origin in recorded_chunk_origins:
var chunk_center = CanonicalWowWorldPositionScript.new(
float(recorded_chunk_origin.canonical_x_origin) - half_chunk_size_yards,
float(recorded_chunk_origin.canonical_y_origin) - half_chunk_size_yards,
0.0
)
var tile_coordinate = CoordinateMapperScript.canonical_to_adt_tile(chunk_center)
_expect_tile(tile_coordinate, 31, 49, true, String(recorded_chunk_origin.label), failures)
var local_position = CoordinateMapperScript.canonical_to_adt_tile_local(chunk_center)
var chunk_coordinate = CoordinateMapperScript.adt_tile_local_to_chunk(tile_coordinate, local_position)
_expect_equal(chunk_coordinate.chunk_x, int(recorded_chunk_origin.chunk_x), "%s chunk X" % recorded_chunk_origin.label, failures)
_expect_equal(chunk_coordinate.chunk_y, int(recorded_chunk_origin.chunk_y), "%s chunk Y" % recorded_chunk_origin.label, failures)
func _verify_world_yaw_conversions(failures: Array[String]) -> void:
var yaw_cases := [0.0, PI * 0.5, -PI * 0.5, PI, TAU + 0.25]
for yaw_radians in yaw_cases: