Merge branch 'master' into Playerbot

src/common/Configuration/Config.cpp

@@ -374,7 +374,7 @@ T ConfigMgr::GetValueDefault(std::string const& name, T const& def, bool showLog
         if (showLogs)
         {
             LOG_WARN("server.loading", "Missing property {} in config file {}, recovered with environment '{}' value.",
-                name.c_str(), _filename.c_str(), envVar->c_str());
+                name, _filename, envVar->c_str());
         }
 
         strValue = *envVar;
@@ -411,7 +411,7 @@ std::string ConfigMgr::GetValueDefault<std::string>(std::string const& name, std
             if (showLogs)
             {
                 LOG_WARN("server.loading", "Missing property {} in config file {}, recovered with environment '{}' value.",
-                    name.c_str(), _filename.c_str(), envVar->c_str());
+                    name, _filename, envVar->c_str());
             }
 
             return *envVar;

src/common/Cryptography/OpenSSLCrypto.cpp

@@ -16,7 +16,7 @@
  */
 
 #include "OpenSSLCrypto.h"
-#include <openssl/crypto.h>
+#include <openssl/crypto.h> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 
 #if defined(OPENSSL_VERSION_NUMBER) && OPENSSL_VERSION_NUMBER < 0x1010000fL
 #include <vector>

src/common/Logging/Log.cpp

@@ -29,7 +29,6 @@
 #include "Timer.h"
 #include "Tokenize.h"
 #include <chrono>
-#include <sstream>
 
 Log::Log() : AppenderId(0), highestLogLevel(LOG_LEVEL_FATAL)
 {

src/common/Logging/LogMessage.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "LogMessage.h"
-#include "StringFormat.h"
 #include "Timer.h"
 
 LogMessage::LogMessage(LogLevel _level, std::string const& _type, std::string_view _text)

src/common/Utilities/Util.cpp

@@ -25,7 +25,6 @@
 #include <boost/core/demangle.hpp>
 #include <cctype>
 #include <cstdarg>
-#include <ctime>
 #include <sstream>
 #include <string>
 #include <utf8.h>

src/server/apps/worldserver/CommandLine/CliRunnable.cpp

@@ -21,7 +21,6 @@
 
 #include "CliRunnable.h"
 #include "Config.h"
-#include "Errors.h"
 #include "ObjectMgr.h"
 #include "World.h"
 #include <fmt/core.h>

src/server/apps/worldserver/Main.cpp

@@ -392,6 +392,15 @@ int main(int argc, char** argv)
 
     sScriptMgr->OnStartup();
 
+// Be kind and warn people of EOL deprecation :)
+#if !defined(MARIADB_VERSION_ID)
+    if (MySQL::GetLibraryVersion() < 80000)
+        LOG_WARN("server", "WARNING: You are using MySQL version 5.7 which is soon EOL!\nThis version will be deprecated. Consider upgrading to MySQL 8.0 or 8.1!");
+#endif
+#if OPENSSL_VERSION_NUMBER < 0x30000000L
+    LOG_WARN("server", "WARNING: You are using OpenSSL version 1.1 which is soon EOL!\nThis version will be deprecated. Consider upgrading to OpenSSL 3.0 or 3.1!");
+#endif
+
     // Launch CliRunnable thread
     std::shared_ptr<std::thread> cliThread;
 #if AC_PLATFORM == AC_PLATFORM_WINDOWS

src/server/game/AI/CoreAI/TotemAI.cpp

@@ -20,11 +20,16 @@
 #include "Creature.h"
 #include "DBCStores.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "ObjectAccessor.h"
 #include "SpellMgr.h"
 #include "Totem.h"
 
+/// @todo: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 int32 TotemAI::Permissible(Creature const* creature)
 {
     if (creature->IsTotem())

src/server/game/AI/CoreAI/UnitAI.cpp

@@ -21,7 +21,6 @@
 #include "Player.h"
 #include "Spell.h"
 #include "SpellAuraEffects.h"
-#include "SpellAuras.h"
 #include "SpellInfo.h"
 #include "SpellMgr.h"
 

src/server/game/AI/CreatureAI.cpp

@@ -26,7 +26,6 @@
 #include "Player.h"
 #include "Vehicle.h"
 #include "ScriptMgr.h"
-#include "Language.h"
 #include "ZoneScript.h"
 
 //Disable CreatureAI when charmed

src/server/game/AI/CreatureAISelector.cpp

@@ -22,7 +22,6 @@
 #include "MovementGenerator.h"
 
 #include "GameObject.h"
-#include "GameObjectAIFactory.h"
 
 #include "ScriptMgr.h"
 

src/server/game/AI/ScriptedAI/ScriptedCreature.cpp

@@ -15,17 +15,21 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "AreaBoundary.h"
 #include "ScriptedCreature.h"
 #include "Cell.h"
 #include "CellImpl.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "ObjectMgr.h"
 #include "Spell.h"
 #include "TemporarySummon.h"
 
+/// @todo: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 // Spell summary for ScriptedAI::SelectSpell
 struct TSpellSummary
 {

src/server/game/AI/SmartScripts/SmartAI.cpp

@@ -19,7 +19,6 @@
 #include "CellImpl.h"
 #include "GridDefines.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "ObjectDefines.h"
 #include "ObjectMgr.h"

src/server/game/AI/SmartScripts/SmartScript.cpp

@@ -24,7 +24,6 @@
 #include "GossipDef.h"
 #include "GridDefines.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "InstanceScript.h"
 #include "Language.h"
@@ -37,6 +36,12 @@
 #include "SpellMgr.h"
 #include "Vehicle.h"
 
+/// @todo: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 SmartScript::SmartScript()
 {
     go = nullptr;

src/server/game/AI/SmartScripts/SmartScriptMgr.cpp

@@ -21,8 +21,6 @@
 #include "DatabaseEnv.h"
 #include "GameEventMgr.h"
 #include "GridDefines.h"
-#include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "InstanceScript.h"
 #include "ObjectDefines.h"
 #include "ObjectMgr.h"

src/server/game/AuctionHouse/AuctionHouseMgr.cpp

@@ -16,8 +16,6 @@
  */
 
 #include "AuctionHouseMgr.h"
-#include "AccountMgr.h"
-#include "AsyncAuctionListing.h"
 #include "Common.h"
 #include "DBCStores.h"
 #include "DatabaseEnv.h"

src/server/game/Battlefield/Battlefield.cpp

@@ -22,7 +22,6 @@
 #include "GameGraveyard.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "GroupMgr.h"
 #include "Map.h"
@@ -33,6 +32,12 @@
 #include "Transport.h"
 #include "WorldPacket.h"
 
+/// @todo: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 Battlefield::Battlefield()
 {
     m_Timer = 0;

src/server/game/Battlegrounds/Battleground.cpp

@@ -18,7 +18,6 @@
 #include "Battleground.h"
 #include "ArenaSpectator.h"
 #include "ArenaTeam.h"
-#include "ArenaTeamMgr.h"
 #include "BattlegroundBE.h"
 #include "BattlegroundDS.h"
 #include "BattlegroundMgr.h"

src/server/game/Battlegrounds/Zones/BattlegroundAB.cpp

@@ -19,7 +19,6 @@
 #include "BattlegroundMgr.h"
 #include "Creature.h"
 #include "GameGraveyard.h"
-#include "Language.h"
 #include "Player.h"
 #include "Util.h"
 #include "WorldPacket.h"

src/server/game/Battlegrounds/Zones/BattlegroundAV.cpp

@@ -26,7 +26,6 @@
 #include "Player.h"
 #include "SpellAuras.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 
 void BattlegroundAVScore::BuildObjectivesBlock(WorldPacket& data)
 {

src/server/game/Battlegrounds/Zones/BattlegroundDS.cpp

@@ -16,15 +16,12 @@
  */
 
 #include "BattlegroundDS.h"
-#include "ArenaScore.h"
 #include "Creature.h"
 #include "GameObject.h"
-#include "Language.h"
 #include "Log.h"
 #include "ObjectAccessor.h"
 #include "Player.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 
 BattlegroundDS::BattlegroundDS()
 {

src/server/game/Battlegrounds/Zones/BattlegroundEY.cpp

@@ -20,7 +20,6 @@
 #include "Creature.h"
 #include "GameGraveyard.h"
 #include "GameTime.h"
-#include "Language.h"
 #include "ObjectMgr.h"
 #include "Player.h"
 #include "Util.h"

src/server/game/Battlegrounds/Zones/BattlegroundIC.cpp

@@ -20,14 +20,12 @@
 #include "GameGraveyard.h"
 #include "GameObject.h"
 #include "GameTime.h"
-#include "Language.h"
 #include "ObjectMgr.h"
 #include "Player.h"
 #include "ScriptedCreature.h"
 #include "Transport.h"
 #include "Vehicle.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 
 void BattlegroundICScore::BuildObjectivesBlock(WorldPacket& data)
 {

src/server/game/Battlegrounds/Zones/BattlegroundRL.cpp

@@ -16,8 +16,6 @@
  */
 
 #include "BattlegroundRL.h"
-#include "ArenaScore.h"
-#include "Language.h"
 #include "Log.h"
 #include "Player.h"
 #include "WorldPacket.h"

src/server/game/Battlegrounds/Zones/BattlegroundRV.cpp

@@ -19,13 +19,11 @@
 #include "ArenaScore.h"
 #include "Battleground.h"
 #include "GameObject.h"
-#include "Language.h"
 #include "Log.h"
 #include "ObjectAccessor.h"
 #include "Pet.h"
 #include "Player.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 
 static constexpr Milliseconds BG_RV_PILLAR_SWITCH_TIMER  = 25s;
 static constexpr Milliseconds BG_RV_FIRE_TO_PILLAR_TIMER = 20s;

src/server/game/Battlegrounds/Zones/BattlegroundWS.cpp

@@ -19,7 +19,6 @@
 #include "BattlegroundMgr.h"
 #include "GameGraveyard.h"
 #include "GameObject.h"
-#include "Language.h"
 #include "Object.h"
 #include "ObjectMgr.h"
 #include "Player.h"

src/server/game/Chat/Hyperlinks.cpp

@@ -18,7 +18,6 @@
 #include "Hyperlinks.h"
 #include "Common.h"
 #include "DBCStores.h"
-#include "Errors.h"
 #include "ObjectMgr.h"
 #include "QuestDef.h"
 #include "SharedDefines.h"

src/server/game/Combat/ThreatMgr.cpp

@@ -21,7 +21,6 @@
 #include "Map.h"
 #include "ObjectAccessor.h"
 #include "Player.h"
-#include "SpellAuras.h"
 #include "SpellInfo.h"
 #include "SpellMgr.h"
 #include "Unit.h"

src/server/game/DataStores/M2Stores.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "DBCStores.h"
-#include "Common.h"
 #include "Containers.h"
 #include "Log.h"
 #include "M2Structure.h"
@@ -25,7 +24,6 @@
 #include <boost/filesystem/path.hpp>
 #include <fstream>
 #include <iostream>
-#include <iomanip>
 
 typedef std::vector<FlyByCamera> FlyByCameraCollection;
 std::unordered_map<uint32, FlyByCameraCollection> sFlyByCameraStore;

src/server/game/Entities/Creature/Creature.cpp

@@ -29,7 +29,6 @@
 #include "GridNotifiers.h"
 #include "Group.h"
 #include "GroupMgr.h"
-#include "InstanceScript.h"
 #include "Log.h"
 #include "LootMgr.h"
 #include "MapMgr.h"

src/server/game/Entities/Creature/TemporarySummon.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "TemporarySummon.h"
-#include "CreatureAI.h"
 #include "GameObject.h"
 #include "GameObjectAI.h"
 #include "Log.h"

src/server/game/Entities/DynamicObject/DynamicObject.cpp

@@ -18,7 +18,6 @@
 #include "SpellAuraEffects.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "ObjectAccessor.h"
 #include "Opcodes.h"
 #include "ScriptMgr.h"

src/server/game/Entities/Item/Item.cpp

@@ -27,7 +27,6 @@
 #include "SpellInfo.h"
 #include "SpellMgr.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 #include "Tokenize.h"
 #include "StringConvert.h"
 

src/server/game/Entities/Pet/Pet.cpp

@@ -18,11 +18,9 @@
 #include "Pet.h"
 #include "ArenaSpectator.h"
 #include "Common.h"
-#include "CreatureAI.h"
 #include "DatabaseEnv.h"
 #include "GameTime.h"
 #include "Group.h"
-#include "InstanceScript.h"
 #include "Log.h"
 #include "ObjectMgr.h"
 #include "PetPackets.h"

src/server/game/Entities/Player/CinematicMgr.cpp

@@ -16,11 +16,9 @@
  */
 
 #include "CinematicMgr.h"
-#include "Map.h"
 #include "M2Stores.h"
 #include "MotionMaster.h"
 #include "Player.h"
-#include "TemporarySummon.h"
 
 CinematicMgr::CinematicMgr(Player* playerref)
 {

src/server/game/Entities/Player/Player.cpp

@@ -79,7 +79,6 @@
 #include "Transport.h"
 #include "UpdateData.h"
 #include "UpdateFieldFlags.h"
-#include "UpdateMask.h"
 #include "Util.h"
 #include "Vehicle.h"
 #include "Weather.h"

src/server/game/Entities/Player/PlayerStorage.cpp

@@ -24,14 +24,12 @@
 #include "Battleground.h"
 #include "BattlegroundAV.h"
 #include "BattlegroundMgr.h"
-#include "CellImpl.h"
 #include "Channel.h"
 #include "CharacterDatabaseCleaner.h"
 #include "Chat.h"
 #include "Common.h"
 #include "ConditionMgr.h"
 #include "Config.h"
-#include "CreatureAI.h"
 #include "DatabaseEnv.h"
 #include "DisableMgr.h"
 #include "GameEventMgr.h"
@@ -43,7 +41,6 @@
 #include "GroupMgr.h"
 #include "Guild.h"
 #include "InstanceSaveMgr.h"
-#include "InstanceScript.h"
 #include "LFGMgr.h"
 #include "Language.h"
 #include "Log.h"

src/server/game/Entities/Unit/Unit.cpp

@@ -39,7 +39,6 @@
 #include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "InstanceSaveMgr.h"
-#include "InstanceScript.h"
 #include "Log.h"
 #include "MapMgr.h"
 #include "MoveSpline.h"

src/server/game/Entities/Vehicle/Vehicle.cpp

@@ -17,7 +17,6 @@
 
 #include "Vehicle.h"
 #include "BattlefieldWG.h"
-#include "CreatureAI.h"
 #include "Log.h"
 #include "MoveSplineInit.h"
 #include "ObjectMgr.h"

src/server/game/Events/GameEventMgr.cpp

@@ -30,7 +30,6 @@
 #include "ScriptMgr.h"
 #include "Transport.h"
 #include "UnitAI.h"
-#include "Util.h"
 #include "World.h"
 #include "WorldStatePackets.h"
 #include <time.h>

src/server/game/Globals/ObjectAccessor.cpp

@@ -21,10 +21,8 @@
 #include "DynamicObject.h"
 #include "GameObject.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Log.h"
 #include "Map.h"
-#include "MapInstanced.h"
 #include "MapMgr.h"
 #include "ObjectDefines.h"
 #include "ObjectMgr.h"

src/server/game/Globals/ObjectMgr.cpp

@@ -43,12 +43,10 @@
 #include "ReputationMgr.h"
 #include "ScriptMgr.h"
 #include "Spell.h"
-#include "SpellAuras.h"
 #include "SpellMgr.h"
 #include "SpellScript.h"
 #include "Transport.h"
 #include "Unit.h"
-#include "UpdateMask.h"
 #include "Util.h"
 #include "Vehicle.h"
 #include "World.h"

src/server/game/Grids/Notifiers/GridNotifiers.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Map.h"
 #include "ObjectAccessor.h"
 #include "SpellInfo.h"

src/server/game/Grids/ObjectGridLoader.cpp

@@ -20,7 +20,6 @@
 #include "Corpse.h"
 #include "GridNotifiers.h"
 #include "Creature.h"
-#include "CreatureAI.h"
 #include "DynamicObject.h"
 #include "GameObject.h"
 #include "ObjectMgr.h"

src/server/game/Guilds/Guild.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "Guild.h"
-#include "AccountMgr.h"
 #include "Bag.h"
 #include "CalendarMgr.h"
 #include "CharacterCache.h"

src/server/game/Handlers/LFGHandler.cpp

@@ -68,7 +68,7 @@ void WorldSession::HandleLfgJoinOpcode(WorldPackets::LFG::LFGJoin& packet)
     }
 
     LOG_DEBUG("network", "CMSG_LFG_JOIN [{}] roles: {}, Dungeons: {}, Comment: {}",
-                 GetPlayerInfo().c_str(), packet.Roles, newDungeons.size(), packet.Comment.c_str());
+                 GetPlayerInfo(), packet.Roles, newDungeons.size(), packet.Comment);
 
     sLFGMgr->JoinLfg(GetPlayer(), uint8(packet.Roles), newDungeons, packet.Comment);
 }

src/server/game/Handlers/MiscHandler.cpp

@@ -22,7 +22,6 @@
 #include "CharacterPackets.h"
 #include "Chat.h"
 #include "Common.h"
-#include "CreatureAI.h"
 #include "DBCEnums.h"
 #include "DatabaseEnv.h"
 #include "GameObjectAI.h"
@@ -30,7 +29,6 @@
 #include "GossipDef.h"
 #include "Group.h"
 #include "GuildMgr.h"
-#include "InstanceScript.h"
 #include "Language.h"
 #include "Log.h"
 #include "LootMgr.h"

src/server/game/Handlers/PetitionsHandler.cpp

@@ -19,7 +19,6 @@
 #include "ArenaTeamMgr.h"
 #include "Guild.h"
 #include "GuildMgr.h"
-#include "Language.h"
 #include "Log.h"
 #include "ObjectMgr.h"
 #include "Opcodes.h"

src/server/game/Instances/InstanceSaveMgr.cpp

@@ -20,7 +20,6 @@
 #include "Config.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "InstanceScript.h"
 #include "Log.h"

src/server/game/Instances/InstanceScript.cpp

@@ -17,7 +17,6 @@
 
 #include "InstanceScript.h"
 #include "Creature.h"
-#include "CreatureAI.h"
 #include "DatabaseEnv.h"
 #include "GameObject.h"
 #include "Group.h"

src/server/game/Maps/AreaBoundary.cpp

@@ -17,7 +17,6 @@
 
 #include "AreaBoundary.h"
 #include "Unit.h"
-#include "TemporarySummon.h"
 
 // ---== RECTANGLE ==---
 RectangleBoundary::RectangleBoundary(float southX, float northX, float eastY, float westY, bool isInverted) :

src/server/game/Maps/Map.cpp

@@ -24,7 +24,6 @@
 #include "GameTime.h"
 #include "Geometry.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "InstanceScript.h"
 #include "LFGMgr.h"
@@ -39,7 +38,6 @@
 #include "ScriptMgr.h"
 #include "Transport.h"
 #include "VMapFactory.h"
-#include "VMapMgr2.h"
 #include "Vehicle.h"
 #include "Weather.h"
 

src/server/game/Maps/MapMgr.cpp

@@ -21,7 +21,6 @@
 #include "GridDefines.h"
 #include "Group.h"
 #include "InstanceSaveMgr.h"
-#include "InstanceScript.h"
 #include "LFGMgr.h"
 #include "Language.h"
 #include "Log.h"

src/server/game/OutdoorPvP/OutdoorPvP.cpp

@@ -18,7 +18,6 @@
 #include "OutdoorPvP.h"
 #include "CellImpl.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "Map.h"
 #include "MapMgr.h"

src/server/game/Scripting/MapScripts.cpp

@@ -18,7 +18,6 @@
 #include "CellImpl.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Map.h"
 #include "MapMgr.h"
 #include "MapRefMgr.h"

src/server/game/Server/WorldSession.cpp

@@ -26,7 +26,6 @@
 #include "Common.h"
 #include "DatabaseEnv.h"
 #include "GameTime.h"
-#include "Group.h"
 #include "Guild.h"
 #include "GuildMgr.h"
 #include "Hyperlinks.h"

src/server/game/Spells/Auras/SpellAuraEffects.cpp

@@ -22,7 +22,6 @@
 #include "Common.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"
-#include "InstanceScript.h"
 #include "Log.h"
 #include "ObjectAccessor.h"
 #include "ObjectMgr.h"

src/server/game/Spells/Spell.cpp

@@ -28,7 +28,6 @@
 #include "GameObjectAI.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "InstanceScript.h"
 #include "Log.h"
@@ -56,6 +55,12 @@
 #include "World.h"
 #include "WorldPacket.h"
 
+/// @todo: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 extern pEffect SpellEffects[TOTAL_SPELL_EFFECTS];
 
 SpellDestination::SpellDestination()

src/server/game/Spells/SpellMgr.cpp

@@ -2716,11 +2716,11 @@ void SpellMgr::LoadSpellInfoStore()
 
         for (SpellEffectInfo const& spellEffectInfo : mSpellInfoMap[spellIndex]->GetEffects())
         {
-            //ASSERT(effect.EffectIndex < MAX_SPELL_EFFECTS, "MAX_SPELL_EFFECTS must be at least %u", effect.EffectIndex + 1);
-            ASSERT(spellEffectInfo.Effect < TOTAL_SPELL_EFFECTS, "TOTAL_SPELL_EFFECTS must be at least %u", spellEffectInfo.Effect + 1);
-            ASSERT(spellEffectInfo.ApplyAuraName < TOTAL_AURAS, "TOTAL_AURAS must be at least %u", spellEffectInfo.ApplyAuraName + 1);
-            ASSERT(spellEffectInfo.TargetA.GetTarget() < TOTAL_SPELL_TARGETS, "TOTAL_SPELL_TARGETS must be at least %u", spellEffectInfo.TargetA.GetTarget() + 1);
-            ASSERT(spellEffectInfo.TargetB.GetTarget() < TOTAL_SPELL_TARGETS, "TOTAL_SPELL_TARGETS must be at least %u", spellEffectInfo.TargetB.GetTarget() + 1);
+            //ASSERT(effect.EffectIndex < MAX_SPELL_EFFECTS, "MAX_SPELL_EFFECTS must be at least {}", effect.EffectIndex + 1);
+            ASSERT(spellEffectInfo.Effect < TOTAL_SPELL_EFFECTS, "TOTAL_SPELL_EFFECTS must be at least {}", spellEffectInfo.Effect + 1);
+            ASSERT(spellEffectInfo.ApplyAuraName < TOTAL_AURAS, "TOTAL_AURAS must be at least {}", spellEffectInfo.ApplyAuraName + 1);
+            ASSERT(spellEffectInfo.TargetA.GetTarget() < TOTAL_SPELL_TARGETS, "TOTAL_SPELL_TARGETS must be at least {}", spellEffectInfo.TargetA.GetTarget() + 1);
+            ASSERT(spellEffectInfo.TargetB.GetTarget() < TOTAL_SPELL_TARGETS, "TOTAL_SPELL_TARGETS must be at least {}", spellEffectInfo.TargetB.GetTarget() + 1);
         }
     }
 

src/server/game/Texts/CreatureTextMgr.cpp

@@ -22,7 +22,6 @@
 #include "Common.h"
 #include "DatabaseEnv.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "MiscPackets.h"
 #include "ObjectMgr.h"
 

src/server/game/Weather/WeatherMgr.cpp

@@ -25,7 +25,6 @@
 #include "ObjectMgr.h"
 #include "Player.h"
 #include "Weather.h"
-#include "WorldPacket.h"
 #include "WorldSession.h"
 #include <memory>
 

src/server/game/World/World.cpp

@@ -56,7 +56,6 @@
 #include "InstanceSaveMgr.h"
 #include "ItemEnchantmentMgr.h"
 #include "LFGMgr.h"
-#include "Language.h"
 #include "Log.h"
 #include "LootItemStorage.h"
 #include "LootMgr.h"

src/server/scripts/Commands/cs_account.cpp

@@ -35,7 +35,6 @@ EndScriptData */
 #include "SecretMgr.h"
 #include "StringConvert.h"
 #include "TOTP.h"
-#include <openssl/rand.h>
 #include <unordered_map>
 
 #if AC_COMPILER == AC_COMPILER_GNU

src/server/scripts/Commands/cs_cast.cpp

@@ -29,7 +29,6 @@ EndScriptData */
 #include "ScriptMgr.h"
 #include "SpellInfo.h"
 #include "SpellMgr.h"
-#include "WorldSession.h"
 
 using namespace Acore::ChatCommands;
 

src/server/scripts/Commands/cs_debug.cpp

@@ -29,7 +29,6 @@
 #include "Chat.h"
 #include "GossipDef.h"
 #include "GridNotifiersImpl.h"
-#include "InstanceScript.h"
 #include "Language.h"
 #include "Log.h"
 #include "MapMgr.h"

src/server/scripts/Commands/cs_list.cpp

@@ -35,7 +35,6 @@ EndScriptData */
 #include "Random.h"
 #include "ScriptMgr.h"
 #include "SpellAuraEffects.h"
-#include "WorldSession.h"
 
 using namespace Acore::ChatCommands;
 

src/server/scripts/Commands/cs_message.cpp

@@ -24,7 +24,6 @@ EndScriptData */
 
 #include "Channel.h"
 #include "Chat.h"
-#include "DBCStores.h"
 #include "DatabaseEnv.h"
 #include "Language.h"
 #include "ObjectAccessor.h"

src/server/scripts/Commands/cs_pet.cpp

@@ -24,7 +24,6 @@
 #include "ScriptMgr.h"
 #include "SpellInfo.h"
 #include "SpellMgr.h"
-#include "WorldSession.h"
 
 using namespace Acore::ChatCommands;
 

src/server/scripts/EasternKingdoms/Karazhan/boss_moroes.cpp

@@ -209,10 +209,36 @@ struct boss_moroes : public BossAI
         return Acore::Containers::SelectRandomContainerElement(guestList);
     }
 
+    bool CheckGuestsInRoom()
+    {
+        bool guestsInRoom = true;
+        summons.DoForAllSummons([&guestsInRoom](WorldObject* summon)
+        {
+            if ((summon->ToCreature()->GetPositionX()) < -11028.f || (summon->ToCreature()->GetPositionY()) < -1955.f) //boundaries of the two doors
+            {
+                guestsInRoom = false;
+                return false;
+            }
+            return true;
+        });
+
+        return guestsInRoom;
+    }
+
     void UpdateAI(uint32 diff) override
     {
         scheduler.Update(diff);
 
+        if (!CheckGuestsInRoom())
+        {
+            EnterEvadeMode();
+            summons.DoForAllSummons([](WorldObject* summon)
+            {
+                summon->ToCreature()->AI()->EnterEvadeMode();
+            });
+            return;
+        }
+
         if (!UpdateVictim())
             return;
 

src/server/scripts/Events/love_in_air.cpp

@@ -18,9 +18,7 @@
 #include "Cell.h"
 #include "CellImpl.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
-#include "LFGMgr.h"
 #include "PassiveAI.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"

src/server/scripts/Events/pilgrims_bounty.cpp

@@ -19,7 +19,6 @@
 #include "PassiveAI.h"
 #include "Player.h"
 #include "ScriptMgr.h"
-#include "ScriptedCreature.h"
 #include "SpellAuraEffects.h"
 #include "SpellScript.h"
 #include "Vehicle.h"

src/server/scripts/Kalimdor/CavernsOfTime/TheBlackMorass/the_black_morass.cpp

@@ -20,7 +20,6 @@
 #include "SmartAI.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
-#include "ScriptedGossip.h"
 
 enum medivhMisc
 {

src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp

@@ -31,7 +31,6 @@ EndContentData */
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
 #include "SpellScript.h"
-#include "WorldSession.h"
 
 /*######
 ## npc_zelfrax

src/server/scripts/Kalimdor/zone_feralas.cpp

@@ -26,7 +26,6 @@ EndScriptData */
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
-#include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
 #include "SpellScript.h"
 

src/server/scripts/Kalimdor/zone_tanaris.cpp

@@ -36,7 +36,6 @@ EndContentData */
 #include "ScriptedEscortAI.h"
 #include "ScriptedFollowerAI.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 /*######
 ## npc_aquementas

src/server/scripts/Kalimdor/zone_winterspring.cpp

@@ -33,7 +33,6 @@ EndContentData */
 #include "ScriptedCreature.h"
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 // Theirs
 /*######

src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp

@@ -25,7 +25,6 @@
 #include "ScriptedCreature.h"
 #include "SpellScript.h"
 #include "Vehicle.h"
-#include "WorldSession.h"
 #include "eye_of_eternity.h"
 
 enum MovementInformPoints

src/server/scripts/Northrend/Ulduar/Ulduar/boss_flame_leviathan.cpp

@@ -23,7 +23,6 @@
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "ScriptedEscortAI.h"
-#include "ScriptedGossip.h"
 #include "Spell.h"
 #include "SpellAuraEffects.h"
 #include "SpellAuras.h"

src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp

@@ -22,7 +22,6 @@
 #include "Transport.h"
 #include "Vehicle.h"
 #include "WorldPacket.h"
-#include "WorldSession.h"
 #include "ulduar.h"
 
 class instance_ulduar : public InstanceMapScript

src/server/scripts/Outland/Auchindoun/ShadowLabyrinth/boss_grandmaster_vorpil.cpp

@@ -15,7 +15,6 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "Player.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "shadow_labyrinth.h"

src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/instance_shattered_halls.cpp

@@ -17,7 +17,6 @@
 
 #include "CreatureTextMgr.h"
 #include "InstanceScript.h"
-#include "ScriptedCreature.h"
 #include "ScriptMgr.h"
 #include "shattered_halls.h"
 

src/server/scripts/Outland/zone_hellfire_peninsula.cpp

@@ -22,7 +22,6 @@
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
 #include "SpellScript.h"
-#include "WorldSession.h"
 
 // Ours
 

src/server/scripts/Outland/zone_shadowmoon_valley.cpp

@@ -40,7 +40,6 @@ EndContentData */
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
-#include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
 #include "SpellScript.h"
 

src/server/scripts/Spells/spell_generic.cpp

@@ -32,7 +32,6 @@
 #include "GameTime.h"
 #include "GridNotifiers.h"
 #include "Group.h"
-#include "InstanceScript.h"
 #include "Pet.h"
 #include "ReputationMgr.h"
 #include "ScriptMgr.h"

src/server/scripts/World/npcs_special.cpp

@@ -19,7 +19,6 @@
 #include "Chat.h"
 #include "CombatAI.h"
 #include "CreatureTextMgr.h"
-#include "DBCStructure.h"
 #include "GameEventMgr.h"
 #include "GameTime.h"
 #include "GridNotifiers.h"

src/server/scripts/World/server_mail.cpp

@@ -17,7 +17,6 @@
 
 #include "Player.h"
 #include "ScriptMgr.h"
-#include "Mail.h"
 #include "ObjectMgr.h"
 #include "QueryResult.h"
 

src/server/shared/Packets/ByteBuffer.cpp

@@ -20,7 +20,6 @@
 #include "Log.h"
 #include "MessageBuffer.h"
 #include "Timer.h"
-#include "Util.h"
 #include <ctime>
 #include <sstream>
 #include <utf8.h>