Commit Graph

144 Commits

Author SHA1 Message Date
AG 79b39f9655 fix(Core/Grid): Implement missing GridUnload setting (#17569)
* Implement GridUnload setting

* Minor fixes

- Use GetOption instead of deprecated GetBoolDefault.
- Added a missing check for instances in LoadMap
- Replaced some numbers with global defines

* Possible crashfix + minor improvements

- Initialized initialOrientation which I had forgotten (likely cause of crash)
- Readded a previous check in UpdateSplineMovement
- Made i_objectsToRemove and i_worldObjects tos sets as they were previously, instead of unordered_set.

* Update worldserver.conf.dist

* Fix high CPU usage with preload grid enabled.

This should be it.
2023-10-26 19:32:15 -03:00
AG 60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
AG 2779833768 feat(Core/Grids): Implement visibility notifier (#15919)
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Anton Popovichenko 52d07bbfae fix(Core/InstanceMap): Stop using deleted player in RemovePlayerFromMap (#17069) 2023-09-05 06:36:34 -03:00
Francesco Borzì 5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
天鹿 df77b5f4f7 chore(core): cleanup code p3 (#16073)
* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
Kitzunu a0c51a45fb fix(Core/Player): Send player's own auras before all visible objects (#15445)
* fix(Core/Player): Send player's own auras before all visible objects

* cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/c6cd272505cdca5d21935ba346df82b8c767fb13)

Co-Authored-By: Mikhail Redko <13364438+r4d1sh@users.noreply.github.com>

* Update Map.cpp

* Update src/server/game/Entities/Player/Player.cpp

* Update src/server/game/Entities/Player/Player.cpp

* Update src/server/game/Maps/Map.cpp

---------

Co-authored-by: Mikhail Redko <13364438+r4d1sh@users.noreply.github.com>
2023-04-02 15:30:26 -03:00
Kitzunu f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix 131e69d691 fix(Core/Maps): Increased visibility distance inside Ahn'Qiraj Temple… (#14271) 2023-01-28 11:01:30 +01:00
55Honey e9b040e3d2 feat: getter for the used instance IDs (#14677)
* feat: getter for the used instance IDs

* doxygen
2023-01-15 15:47:49 +01:00
UltraNix 14f3b444ae fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SU… (#14054)
* fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SUMMONER` summon flag.

Fixes #6674

* Update.
2023-01-06 00:52:05 +01:00
M'Dic 8f19bcddf4 Add (core\logging): Log sync db queries in mapupdater (#13638)
This will Log sync db queries in World::Update() loop for the mapupdater when building in debug.
Originally part of TC Commit https://github.com/TrinityCore/TrinityCore/pull/25174
Apparently azerothcore never cherrypicked it entirely for whatever reason and is needed when running a debugger in debug build for me to find and address some recent crash issues that been posted on the issues to fully verify the issue.

Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
2022-11-01 19:00:42 -04:00
M'Dic 2e6f6e26da Add (core\db): Support for Homebind Orientation (#13389)
Add (core\db) Support for Homebind Orientation
2022-10-12 14:39:02 -04:00
M'Dic 967f8ce6d6 update (core): Startup console capitalizations (#13195) 2022-10-01 13:09:34 -04:00
UltraNix caf310f4ab fix(Core/Maps): Fixed getting liquid data near depths. (#12814) 2022-09-06 15:22:58 -03:00
Skjalf ca9c19ffd4 feat(Core/GameObject): Add an overload to SummonGameObject() to accep… (#12821)
feat(Core/GameObject): Add an overload to SummonGameObject() to accept positions
2022-08-21 19:48:34 -03:00
Maelthyr d0d1671745 feat(Core/Debug): GetDebugInfo implementation (#12705)
Cherry-pick: https://github.com/TrinityCore/TrinityCore/commit/9a924fb9d557434c5a2e4020c80db6e6bfe466ad

Co-authored-by: jackpoz <giacomopoz@gmail.com>

Co-authored-by: jackpoz <giacomopoz@gmail.com>
2022-08-15 09:43:41 -03:00
Skjalf cd3151df40 fix(Scripts/RuinsOfAhnQiraj): Implement Rajaxx waves (#12513) 2022-07-25 12:12:08 -03:00
ZhengPeiRu21 631686be7e fix(Core): Instance Reset Exploit Fix (#12459)
* fix(Core): Fix Instance Reset Exploit

* Whitespace fix

* Remove unnecessary include

* Check player instance save IDs when adding to map

* Only compare playerBind during login
2022-07-24 14:37:42 -03:00
UltraNix 39c0f1a700 feat(Core/Players): Enabled resurrecting players from opposite factio… (#12012)
* feat(Core/Players): Enabled resurrecting players from opposite faction in crossfactioned raids.

Fixes #8600

* Update
2022-06-18 13:49:35 -04:00
Skjalf b658ba582e feat(Core/Map): Allow disabling the blizzlike PvP line of sight checks (#11692) 2022-05-11 13:06:56 -03:00
UltraNix 0d4adf5a3e fix(Core/Spells): Blink. (#11663)
* fix(Core/Spells): Blink.

Fixes #6427
Fixes #7571

* Update.
2022-05-10 22:37:53 +02:00
IntelligentQuantum a31a30566e feat(Tools/Mapextractor): Implemented liquid object detection (#11402)
* .

* .

* .

* .

* .

* .

* .

* Delete Utils.cpp
2022-05-08 23:38:22 +02:00
acidmanifesto cc6528ad7b Fix (core) water level and ground level correction (#11552)
We do not need to excessively have ground level be -2 below the player when underwater. ground level is ground level. no need for a lower adjustment. Most likely left over from from when the shallow water calculations was wrong entirely that lead to false hits with water walking detection due to core side calculations.
2022-05-01 08:44:03 -04:00
IntelligentQuantum 090cc5e2c6 fix(Tools/Mapextractor): Fix water height redundancy algorithm ignoring "no water" (#10947) 2022-04-24 15:14:20 -03:00
acidmanifesto ad520391d0 fix (core): Water Calculation Corrections (#11516) 2022-04-24 09:58:22 -04:00
Kitzunu 1501445b0a chore(Core/Misc): nullptr cleanup (#11467) 2022-04-21 19:17:20 +02:00
acidmanifesto c283883aea fix (core): Shallow Water Calulation Correction (#11419)
Shallow water calculation (in water and water walking value) is in correct and were matching. not right at all. this corrects the issue.
2022-04-16 16:38:57 -04:00
IntelligentQuantum ab4ee71762 feat(Core/Maps): AreaBoundary (#10525)
* cherry-picked commit (https://github.com/TrinityCore/TrinityCore/commit/2da458c56d024aac04468ce2af454a83ad790bf6)
2022-04-15 14:10:41 +02:00
UltraNix 47790c9714 fix(Core/Vmaps): Stop M2s from occluding for spellcast LoS. Original autho… (#11341)
* Core/Vmaps: Stop M2s from occluding for spellcast LoS. Original authors: @Shauren & @HelloKitty

Fixes #11293

* buildfix.

Co-Authored-By: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
2022-04-10 09:24:35 -03:00
IntelligentQuantum 6e2e73d6ae feat(Scripts/Commands): debug objectcount 2022-04-01 06:57:26 -03:00
IntelligentQuantum cc5f26db7f feat(Core/Vmaps): Changed error message when loading outdated vmaps (#10490) 2022-04-01 06:56:04 -03:00
UltraNix 3c9e8d4eb1 fix(Core): Crash related to reset instances (#11003) 2022-03-18 19:32:28 -03:00
Bogir[rus] 75439773d0 fix and bringing to a unified style warnings of server loading logs to be more visible at server startup (#10970) 2022-03-12 04:57:26 -03:00
UltraNix 09df444187 fix(Core/Maps): Dead players should not be allowed to enter dungeon if exceeded max number of instances. Thx to @DepTypes (#10831)
Fixed #10799
2022-03-06 12:19:31 -05:00
acidmanifesto 69e2f2e3aa fix/feat: (Core/PacketIO): updated sound and creature addon (#10813)
* fix\feat: (Core/PacketIO): updated sound and creature addon

updated SMSG_PLAY_SOUND, SMSG_PLAY_MUSIC and SMSG_PLAY_OBJECT_SOUND via tc cherry pick
https://github.com/TrinityCore/TrinityCore/pull/2363 and https://github.com/TrinityCore/TrinityCore/commit/0f1f7ef4017ac32df669ceee120489321da680aa by @joschiwald  and @ForesterDev
This so far a attempt to align atleast with sound with tc, and correct a potentional issue of hearing creature sounds that is not in visible range. I notice PlaySound was being defined in some weird dependency as it isnt with tc so I renamed it to Playsound. Notice a isLarge still being used in the creature addon when it was depreciated, so i removed that a that seem to of interfered with visibilitydistanceType.

Co-Authored-By: joschiwald <736792+joschiwald@users.noreply.github.com>
Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
2022-02-26 10:05:58 -05:00
Kitzunu 455899dc75 fix(Core/Misc): Change const to be after type name (#10591) 2022-02-14 16:05:45 -03:00
Kitzunu cf65cd6baf refactor(Core/Misc): sqrt/log/exp() to std::sqrt/log/exp() (#9792) 2022-02-09 11:59:30 +01:00
IntelligentQuantum 93520f6466 feat(Core/Position): own file (#10505) 2022-02-08 05:12:42 -03:00
Kargatum de13bf426e feat(Core/DBLayer): replace char const* to std::string_view (#10211)
* feat(Core/DBLayer): replace `char const*` to `std::string_view`

* CString

* 1

* chore(Core/Misc): code cleanup

* cl

* db fix

* fmt style sql

* to fmt

* py

* del old

* 1

* 2

* 3

* 1

* 1
2022-02-05 00:37:11 +01:00
Nefertumm aa6ecec2ab feat(Core/Map): add DoForAllPlayers method (#10371) 2022-02-04 18:54:29 +01:00
acidmanifesto 8207e3ffb5 fix (core) : TransportMgr Load up time (#10388)
* fix (core) : TransportMgr Load up time

* white space fix

* merge fix

* merge fix again

* Update TransportMgr.cpp

* Update TransportMgr.cpp

* Update TransportMgr.cpp

* fix conflich with preload grids for continent static transports
2022-01-29 10:44:19 -05:00
Kargatum 5969df4e30 refactor(Core/Logging): switch to fmt style for LOG_ (#10366)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp

* rework logging

* add fmt replace logs

* logging

* FMT_LOG_

* settings

* fix startup

* 1

* 2

* 3

* 4

* 5

* fmt::print

* to fmt
2022-01-27 16:44:41 +01:00
Kargatum 8b7df23f06 feat(Core/Time): Implement saparated manager for game time (#8630) 2022-01-24 17:55:00 +07:00
Francesco Borzì 9dc88def35 refactor(Core): apply clang-tidy modernize-* (#9975)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-01-17 14:35:07 +01:00
Malcrom dfac47a562 feat(Core/Creature): Allow 3 ids per spawn point. TESTING (#10169)
* feat(Core/Creature): Allow 3 ids per spawn point.

* Move GetRandomId to a function

* Update id to id1

* Fixed some errors crashing core and text

* Set ids to lowercase for GetRandomId function

* Update src/server/database/Database/Implementation/WorldDatabase.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

Co-authored-by: acidmanifesto <joshua.lee.betts@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-01-14 19:21:50 -04:00
Kitzunu d1cc65b1c7 refactor(Core/Misc): isEmpty to IsEmpty (#10011) 2022-01-13 21:43:15 -05:00
acidmanifesto 4330e44ad0 fix (Core/CodeReduction) TC_ removal (#10162)
TC_ remove from any commit out TC_LOG in the event when we do need to run debug logging, we can just remove the // instead of // TC_
2022-01-13 14:39:54 -05:00
Cláudio Costa 5d45c52c3e fix(Core/Creature): Fire Elemental Invasion changes (#9372)
* fix(DB): Blazing elemental invasion event

- Fixed Elemental Invader's SmartAI;
- Re-arranged Elemental Rifts SmartAI for controlled spawning of
  Invaders.

* SmartAI: SetCounter to be able to subtract

* Target unit or summoner changed for worldobjects

* extra checks and last sql file

* Codestyle

* codestyle

* adding Baron to elemental invasions

* changed owner or summoner target (SmartAI)

* codestyle
2022-01-06 19:30:23 +01:00
IntelligentQuantum fb249836e9 Core\Packet\Misc: Weather (#9648) 2022-01-04 13:52:13 -05:00