Commit Graph

135 Commits

Author SHA1 Message Date
UltraNix adf627cb65 feat(Core/Spells): Implemented SPELL_AURA_DETECT_AMORE. (#4850) 2021-03-21 15:18:55 +01:00
Petric 5aed4dd193 fix(Core/Commands): .cheat god lowering hp to 1 and .cheat power not refilling power (#3299) 2021-03-21 15:15:00 +01:00
Cláudio Costa aea4ce3094 fix(scripts/Ulduar): Improve Hodir (#4703) 2021-03-20 08:36:30 -06:00
Stefano Borzì d82d2041b4 fix(Core/SpellEffect): Increase speed of cat charge (#4795) 2021-03-19 22:54:25 -06:00
Francesco Borzì f6a17164be fix(Core/License): issue with old files license (#4762) 2021-03-17 09:46:01 -06:00
Cláudio Costa 99c2efe3c2 fix(Core): Rogue - Premeditation fix (#4695) 2021-03-16 16:58:56 -06:00
r0m1ntik b24ee3fc10 fix(Core/Spells): Warlock Death Coil shouldn't be able to crit (#4629) 2021-03-12 15:12:43 +01:00
Stefano Borzì 7988717eef fix(Code/Fishing): improve timing of fishing (#4733) 2021-03-07 13:13:29 +01:00
Kitzunu 28f1dc5c0c refactor(Core): replace NULL with nullptr (#4593) 2021-03-02 01:34:20 +01:00
Kitzunu dbc0ff6554 refactor(Core): sort #includes alphabetically (#4579) 2021-02-24 22:34:42 +01:00
Kitzunu 82eb8b44d1 refactor(Core/Spell): Pascal Case some SpellEntry types (#4432) 2021-02-08 19:01:37 -05:00
Vox 94173dbbd9 fix(Core/Spell): Restore Stealth remove check (#4491) 2021-02-07 14:08:10 -05:00
Kitzunu 440d4191ae fix(Core/Spell): Restore SPELL_ATTR0_CU_AURA_CC (#4472) 2021-02-07 09:06:27 -05:00
Kitzunu d902411171 fix(Core/Spell): Clearcasting duration (#4422) 2021-02-06 21:06:30 -05:00
Kitzunu 9fd6f1079b fix(Core/Spell): SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER to face caster (#4351)
* fix(Core/Spell): SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER to face caster

* cherry-pick https://github.com/TrinityCore/TrinityCore/commit/28353e920b531b7dd221ac926049f5a68b75e7ec

Co-Authored-By: Meji <2695278+meji46@users.noreply.github.com>

* [[nodiscard]]

* return;

* fix last thing

* build

* Revert "build"

This reverts commit c892cc292f3592c5089840e393b525f74904779b.

* Update Object.h

* Update Object.h

* Update Object.h

Co-authored-by: Meji <2695278+meji46@users.noreply.github.com>
2021-02-03 17:06:37 +01:00
Kitzunu 0d52b4ca4a feat(Core/Spell): Implement ValidateSpellInfo (#4323)
* feat(Core/Spell): Implement ValidateSpellInfo

* cherry-pick from https://github.com/TrinityCore/TrinityCore/commit/2b5d7eef3a091e67c27e853d43ac0bebbfa67531 & https://github.com/TrinityCore/TrinityCore/commit/a0a158b5b851db7e2c16819ec89e913d914a3aba

* sLog->outError

* cleanup

* convert to ValidateSpellInfo

* fix error log

* improve sLog->outError

* remove non related spells stuff from Validate

* remove the last

* build

* build x2
2021-02-01 18:57:25 +01:00
Kitzunu 683ddf6c8d fix(Core/Spell): Detect Undead (#4310) 2021-02-01 16:21:33 +01:00
Yehonal c8f43d8584 feat(Core/Movement): Improved pathfinding, collisions and movements (#4220)
Npc positioning
Implemented slope check to avoid unwanted climbing for some kind of movements (backwards, repositioning etc.)
Implemented backwards movement
Re-implemented circle repositioning algorithm (smartest than retail, but with the same feeling)
Fixed random position of summoned minions
Improved pet following movement. Also, they attack NPC from behind now. Thanks to @Footman

Swimming creatures
Fixed max_z coordinate for swimming creatures. Now only part of their body is allowed to be out of the water level
Fixed pathfinder for swimming creatures creating shortcuts for specific segments, now they swim underwater to reach the seashore instead of flying above the water level.
Creatures with water InhabitType but no swimming flag now, when not in combat, will walk on water depth instead of swimming. Thanks @jackpoz for the original code
UNIT_FLAG_SWIMMING in UpdateEnvironmentIfNeeded to show the swimming animation correctly when underwater
Implemented HasEnoughWater check to avoid swimming creatures to go where the water level is too low but also to properly enable swimming animation only when a creature has enough water to swim.

Walking creatures
Extended the DetourNavMeshQuery adding area cost based on walkability (slope angle + source height) to find better paths at runtime instead of completely remove them from mmaps
improve Z height in certain conditions (see #4205, #4203, #4247 )

Flying creatures
Rewriting of the hover system
Removed hacks and improved the UpdateEnvironmentIfNeeded. Now creatures can properly switch from flying to walk etc.
Spells
LOS on spell effect must be calculated on CollisionHeight and HitSpherePoint instead of position coords.
Improved position for object/creature spawned via spells
Improved checks for Fleeing movements (fear spells)

Other improvements
Implemented method to calculate the CollisionWidth from dbc (used by repositioning algorithm etc.)
Improved raycast and collision checks

Co-authored-by: Footman <p.alexej@freenet.de>
Co-authored-by: Helias <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-02-01 01:34:27 +01:00
Kitzunu fcad2b56ae refactor(Core/Spell): Define some unknown spell attributes (#4305)
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-31 23:03:44 +01:00
Kitzunu 628c75d67f fix(Core/SpellMgr): Add cooldown to some vehicle spells (#4300)
* fix(Core/SpellMgr): Add cooldown to some spells

* author and spellscript

Co-Authored-By: Wyrserth <43747507+Wyrserth@users.noreply.github.com>
2021-01-31 03:09:50 +01:00
Kitzunu c5ce3e4460 fix(Core/Spell): improve check in SPELL_EFFECT_CREATE_ITEM(_2) (#4296)
* fix(Core/Spell): items disappearing in Spell::CheckItems()

* https://github.com/TrinityCore/TrinityCore/commit/18b36734f6ac235dbb7a37ba46d1c8d09d8171ab

* remove GetFreeInventorySpace

* restore p_caster to make other PR needing to merge before this

* fix build

* fuck github conflicts
2021-01-31 02:41:49 +01:00
r0m1ntik 647ce5bed7 fix(Core/Quest): A Tangled Skein (#4237)
Co-authored-by: r0m1ntik <r.badanin94@yandex.ru–>
2021-01-29 20:29:04 +01:00
Kitzunu 520c4c6426 fix(Core/Spell): do not create new items when inventory is full (#4298) 2021-01-27 18:26:17 +01:00
Kitzunu 879468506f chore(Core/Global): Fix grouping of Worldserver initialization (#4130) 2021-01-25 20:50:53 +01:00
Degen 5a1bb5bc66 fix(Core/SpellMgr): Essence of Wintergrasp only applies if config is enabled (#4110) 2021-01-17 20:14:27 +01:00
Kitzunu 1cc5518147 fix(Core/Spell): Killing Spree range (#4097)
Co-authored-by: Keader <keader.android@gmail.com>
2021-01-17 00:40:30 +01:00
Silker 3f79f16960 fix(Core/SpellMgr): Death Plague stacks (#4299) 2021-01-16 12:52:06 -06:00
Kitzunu 43f59c4c82 feat(Core/Player): implement GetFreeInventorySpace() (#4297) 2021-01-16 17:33:30 +01:00
Stefano Borzì df600f9946 fix(Core/CreatureAI): revert NPC repositioning and path system (temporarily) (#4274) 2021-01-14 19:17:34 +01:00
Kitzunu fd3505411d chore(Core/SpellAuraEffects): Comment out empty if (#4246) 2021-01-11 14:48:07 +01:00
Kitzunu da4edd547d chore(core): remove malformed whitespaces (#4244)
* from https://www.codefactor.io/repository/github/azerothcore/azerothcore-wotlk/issues?category=Style&groupId=838&lang=5&page=75
2021-01-10 14:27:55 +01:00
Kargatum ea93a5c1a1 feat(CI/Codestyle): added codestyle check (#3668) 2021-01-09 11:59:50 +01:00
r0m1ntik b35d3a8fb8 fix(Core/Spell): [Potion] Elixir of Minor Fortitude effect disappear (#4217) 2021-01-08 23:26:17 +01:00
Stefano Borzì b2761626fe feat(Core/CreatureAI): improve npc position during the combat (#3369)
+ tangent equation to find correct angle and distance when moving

+ implemented proper backward

* Improved performance + random angle margin

* chore: add tollerance calculation in instance

* improved LOS checks with movements

* implemented collisions using raycast (imported by TC)

+ improved collision detection for CanReachPositionAndGetCoords

+ improved collision check

+ set correct flags for the backward movement

+ first implementation of slope angle (to improve)

Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
2021-01-04 20:23:08 +01:00
Stefano Borzì e7dc6df31e fix(Core/GO): failed attempt (#4036)
Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
2020-12-28 11:05:37 +01:00
Kitzunu 269482778d chore(Core/SpellMgr): Indentation (#4028) 2020-12-26 20:58:22 -06:00
WiZZy d710057a31 fix(scripts/Ulduar): Expedition Base Camp (#3558) 2020-12-25 09:56:32 -06:00
Kitzunu 672057316a fix(Core/Spell): Clicking lock portal cost mana (#4013) 2020-12-22 21:24:52 +00:00
Francesco Borzì c5a35efd7b refactor(Core): apply clang-tidy modernize-use-default-member-init (#3827) 2020-12-07 13:34:06 -06:00
Francesco Borzì 161302252e refactor(Core): apply clang-tidy modernize-use-nodiscard (#3835) 2020-12-06 19:39:48 +01:00
Francesco Borzì d4a58700d4 refactor(Core): apply clang-tidy modernize-use-override (#3817) 2020-12-06 18:04:55 +01:00
Kitzunu 5a8b60361a refactor(Core/SpellMgr): simplify dbc data corrections (#3709)
* refactor(Core/SpellMgr): simplify dbc data corrections

* I hate failing builds... so guess sleep isnt neccessary

* only works when you actually fill out them all

* blankspace

* step 1 - rename

* This takes so long Q.Q

* Update SpellMgr.cpp

* Revert "Update SpellMgr.cpp"

This reverts commit e1de9712a52fd6547761c3ccd70c17a7d4aa8036.

* Revert "Revert "Update SpellMgr.cpp""

This reverts commit e9253c2846b83bfe2760e71a0fc52d2d9fbed853.

* revert

* DONE

* cleanup

* cleanup

* New error so good, why try to correct spells that dont exist :)

* brackets

* Github merge conflict fix SUCKS
2020-11-21 17:03:19 +01:00
Kitzunu 973dcbf47c fix(Core/SpellMgr): Thorns should not miss (#3695) 2020-11-18 10:06:41 -06:00
Andrius Peleckas d7becdae27 feat(Core/Spells): Functions will return cast result (#3635) 2020-11-13 08:00:07 -06:00
Shard e7f1ab4a6a fix(Core/Logs): Fix arguments in function call (#3672) 2020-11-09 08:56:19 -06:00
kubeeek 6574007e48 fix(Scripts/Ulduar): Supercharge stack issue fix (#3586) 2020-11-04 14:10:20 +01:00
kubeeek 2e298e7fc9 fix(Core/Ulduar): Stone Nova stacks [25 mode] 2020-11-03 08:38:16 -06:00
Silker 4a2c4f0f5f fix(Spell): Expose weakness (#3588)
This change allows the spell Expose Weakness (heroic encounters) to stack from additional sources.
Co-authored-by: Si1ker <55638679+Sombranator@users.noreply.github.com>
2020-10-31 00:19:51 -06:00
Kargatum a2b26272d2 refactor(Core/Game): restyle game lib with astyle (#3466) 2020-10-12 10:08:15 +02:00
Stefano Borzì 91f4671d07 fix(Core/Spells): prevent client crash on use spell Neural Needle + ESC (#3383) 2020-09-27 16:31:41 +02:00