A mouse command run from a key binding or a handler picked and clicked only after the record's walk returned. So a body `CameraOrSelectOrMoveStart(); CameraOrSelectOrMoveStop(); print(UnitName("target"))` printed the old target. In 1.12.1 `ArmClick` picks inside the Start's call (`0x5141ae` → `0x514810` → `0x481f00`), at the cursor stored from the last mouse event (`0x481f1d`), and the Stop dispatches inside its own.
The records' walk now lends a tracer beside the call host, so an arm picks inside its call at its record's cursor: one trace per arm, and no new schedule ambiguity. The pick traces the world alone (`0x481190`), never a nameplate. The GameObject pick set is now one resource, kept every frame ahead of the input.
Tests cover a key body, an `OnClick` body, the target event in the handler, a key-armed pick under a plate, and a chest clicked by mouse and by key.
Fixes#2749
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three mail getters differed from 1.12.1.
- **#2739.** `GetSendMailItem` asked nothing on a missing record. Now, with the attachment's object present (`0x4ae5e1`), it asks with the callback `0x4ae710`, which signals `MAIL_SEND_INFO_UPDATE` once per call on arrival.
- **#2740.** The usable stationery list was rebuilt every frame. Now it is rebuilt (`0x4ad970`) only at the world-enter init (`0x4acbd7`), at the last missing paper's answer (`0x4acbf8`), and at `GetNumStationeries` with nothing awaited (`0x4ae202`). The getters read it as last rebuilt. With no player a rebuild keeps the list (`0x4ad9aa`), and leaving the world cancels the paper waits (`0x4acc00`).
- **#2741.** `GetSelectedStationeryTexture` reads the Stationery store by id (`0x4ae3f0`), not the usable list.
Each fix has a test that fails without it.
Fixes#2739Fixes#2740Fixes#2741
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The auction window reached the interface through a per-frame feed. Its events fired ahead of the frame's other packets, its getters read a pushed copy, and a result's list request went out before its line's listeners. In 1.12.1 the auction handlers signal inside their packet, and the getters read the house at the call.
- **Live reads.** The getters read the house through the host: rows, the browse throttle (`0x4cfbb0`) and the deposit rate (`0x4ce170`).
- **The house lane.** `AUCTION_HOUSE_SHOW` fires in the hello (`0x4cd5e6`). A notice waiting on an item record shows when the record arrives (`0x4cd190`). A nested close acts on the session it closes.
- **Line first.** A started, bid-placed or outbid result shows its line first and does the rest after its listeners (`0x4cc4cc`, `0x4ccfd5`).
- `LatchCloses` is removed; nothing read it.
Each change has a test that fails without it.
Fixes#2426
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After a disconnect, a game object's name, an item name, a page of text or an NPC's text whose query was in flight at the drop stayed blank until restart. Only some saved caches cleared their lost asks, from four scattered places, and no `Deviation:` line recorded the rule.
In 1.12.1 a saved cache's ask stays "asked" for the rest of the process. `DBCacheClearUnsaved` (`0x555740`) wipes only the unsaved caches. The maintainer ruled that benilla asks again after a reconnect.
One disconnect handler now clears the in-flight asks of all eight saved caches (creatures, game objects, item names, items, NPC text, quests, page text and mail bodies). It keeps their records and refusals, under one `Deviation:` line, and the scattered clears are gone. Test: an ask in flight in each store at a disconnect is asked again after the re-login.
Fixes#2744
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
An event handler that unregistered the next listener ended the dispatch, as a `Deviation:` on the grounds that 1.12.1 then reads a freed node. That read is settled at the bytes. `SignalEvent` saves the successor before each handler (`0x703ee8`). The unlink zeroes the node's links (`0x70559d`, `0x7055a3`), and the free writes only the block header (`0x645eb0`), so the object survives. The unregistered listener runs once more, then the zero link ends the walk, and the listeners after it miss the event.
The dispatch now does the same, and the `Deviation:` is gone. A self-unregister still reaches its successor. A listener unregistered further on is skipped. One registered during the signal is reached unless the running listener is last. Each case has a test; the two changed ones fail on main.
Fixes#2743
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The world click's legs ran after the record's walk returned, so Lua after `CameraOrSelectOrMoveStop` in the same binding body, or a hook around it, read the world as the click found it. In 1.12.1 the release dispatches inside its call (`0x514b70` → `0x481f60`), and the router calls each leg directly, deferring nothing.
- The release's click now runs in the call host through a click applier, in the reference's leg order. On a unit that is trade, pet feed, greeting, then select (`0x49278e`, `0x4927e8`, `0x4927ff`, `0x49280c`). On a right click, the select comes before the interact dispatch (`0x492870`, `0x492881`).
- The press pick is traced ahead of each world press's binding (`0x481f00`).
- A charmed player's click acts on nothing (`0x481f98`), for every leg.
Each change has a test that fails without it.
Fixes#1988
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In 1.12.1, `GetContainerItemInfo`'s slot mapping bounds the backpack, the bank (base `+0x27`, `0x4f98ae`) and the keyring (base `+0x51`, `0x4f98c0`) only by the player list's count (`0x4f990f`). An index past a container's own size reads the next container's slots: `GetContainerItemInfo(-1, 25)` reads the first bank bag's slot.
benilla bounds all three by their own slots, but the recorded deviation named only the backpack. The maintainer ruled that the bank and the keyring take the same deviation for the same reason, a reference bug. The `Deviation:` line now covers all three. No behaviour changes.
Fixes#2617
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A path ends with the unit turned to the packet's final facing, as 1.12.1 leaves it.
- A monster move that installs a path stores its final facing on the spline (`0x618840`-`0x6188a0`). Only a move with no path turns the unit on arrival.
- At the path's end, `0x61a882` writes the facing in this order:
- Angle, as sent;
- Target, the heading to where that unit stands (`0x61a8c1`), from the deck-local end on a transport;
- Spot, through `0x47f220`.
- The turn runs through the facing smoother (`0x600cd0`), never a snap. The display facing resets only at create and reactivate.
- `heading_between` ports `0x47f220`'s fixed headings for a point under the unit.
Each change has a test that fails without it.
First diagnosed and drafted by @kalistoking in #2695.
Co-authored-by: kalistoking <148718830+kalistoking@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The mail window reached the interface through a per-frame feed. Its events fired ahead of the frame's other packets, and its getters read a pushed copy. In 1.12.1 the mail handlers signal inside their packet, and the getters read the session at the call.
- The getters read the session through the host (`MailLive`). Every mail event goes on a mail lane, stamped in the handler that raises it.
- Each answered record lookup signals one `MAIL_INBOX_UPDATE`, only when the record is found (`0x4af080`, `0x4af0a0`, `0x4af340`, `0x4af5b0`, `0x4ad010`).
- The pending step runs after the frame's packets and after the walk-away check (`0x4818c0`, `0x4818d0`).
- A close in its open's frame no longer fires `MAIL_CLOSED` without `MAIL_SHOW`, or sends its query ahead of earlier events.
Each change has a test that fails without it. Part of #2168 and #2217.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The trade window reached the interface through a per-frame feed, so its events fired ahead of the frame's other packets and its getters read a VM copy. In 1.12.1 the trade status handler (`0x4bfa08`'s cases) signals inside the packet, and the getters read the session at the call.
- The getters read the session through the host. Every trade signal goes on a trade lane, stamped in its handler.
- A request's checks run inside BEGIN_TRADE, with the ignore list ahead of the object lookup (`0x4bf750`).
- Our slots 1-6 raise no TRADE_PLAYER_ITEM_CHANGED from the status (`0x4bf2b0`).
- A close waits behind the open it closes, cancel included (`0x4bf527`, `0x493365`).
- Status 12 prints its line before the close (`0x4bf88e`).
- A chat-kind line raised in a Lua call fires inside it (`0x496842` → `0x49a870`).
Each change has a test that fails without it. Part of #2168 and #2217.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Aura and pet state reached the interface from per-frame feeds, so a listener at one packet read the frame's final state. In 1.12.1 each is written where its packet or call makes it.
- **Pet GCD.** A pet cast's global cooldown is armed in the pet bar at the send (`0x6e58fb`), inside the cast.
- **Happiness.** `UNIT_HAPPINESS` fires from the field watch (`0x515e7a`) inside its packet.
- **Unit auras.** The aura getters read the unit's store live.
- **Dispel list.** It is kept from the learn (`0x4b26a2`-`0x4b26ee`), so an unlearn leaves it.
- **World entry.** The cascade rebuilds the buff cache at `0x490983`, so `PLAYER_AURAS_CHANGED` follows `PLAYER_ENTERING_WORLD` and comes ahead of the bag updates.
Each fix has a test that fails without it. Part of #2168 and #2217.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The world click was resolved in the look session, frames after the mouse command that made it. In 1.12.1, `CameraOrSelectOrMoveStart` and `TurnOrActionStart` arm it inside their call: `ArmClick 0x514810` picks under the press (`PickAtCursor 0x481190`), and the last primary's release dispatches it (`0x514b70` → `0x481f60`). The VM now keeps the command bits, and the click applies at the record whose binding made it.
Changes:
- The world frame's right-press hook `0x492c20` now runs whole, ahead of the binding (`0x483c62`, `0x483c93`): it cancels targeting, clears a pending wrap, and ends repair mode. It does not run on a press `0x492b50` eats.
- The loading cover, a bindingless right release, and a reload's cascade (`0x49093c` → `0x5144c0`) free the bits.
- The release counts its own frame's travel.
Tests cover each. The click's legs still run after the walk, not inside the call: part of #1988.
Fixes#2729
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bag and item reads now answer as of the listener's own packet, not the frame's end, and the logout reads what 1.12.1 has there.
- The bag getters read the player's bags, the bank and the keyring live. Item and container writes go into the view log, so a listener sees its packet's slots, stacks and bags.
- The loot close's two unlocks fire at its packet (`0x48f2bd`, `0x4c1d36`). A wrong-bag refusal names the bag its packet found (`0x5e3a1e` → `0x5ede00`).
- At logout the object manager goes before PLAYER_LOGOUT fires (`0x46771e`, `0x490c2a`). The inventory getters then answer nothing with no active player (`0x4944a0` → `0x4c8c56`). `UnitName("player")` keeps the character's name.
- The item tooltip feed follows record changes by cursor. The suffix template is copied after the frame's Lua.
Each change has a test that fails without it. flip_readiness falls to 92 rows.
Fixes#2725
Refs #2168
Refs #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The census that finds Lua verbs whose work outruns their signals now sweeps the whole suite. It also counts state a lend writes while a handler is held, which a late listener would read and no send shows.
- Over 12,964 tests, one verb sends ahead of its signals: `UseAction`, V2's.
- An accepted item swap is in order: its send (`0x5e0fdb`) comes before the cursor clear (`0x5e0fe7`).
- One write after a held signal: a target clear's strike-cancel report waits behind the action bar's usable refresh (`0x493a08`, `0x493a18`, `0x493a69`, `0x493a73`). It is now listed, with its test.
All of it is test-only; the player build is unchanged.
Refs #2271
Refs #2202🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Transports' props animate and cull with their ship, as in 1.12.1.
- A carried prop's world sphere comes from its host's pose every frame. The tick re-poses a transport's doodad defs before the cull (`0x6709a0` → `0x698f50` → `0x6a2070` → `0x6a81d0`), so a ship's parts stay drawn wherever it is.
- A transport's props play the ship's phase (`0x5f52f9` → `0x6709f0` → `0x6a24b0` → `0x6a20f0`), with window ends chained through `0x5f49b0`. A carried play cross-fades over its sequence's blend time (`0x6a2128`). The zeppelin's engine `$DSL` keys sit in its moving sequences (0xa2, 0xa3), so its engine is heard now. Before, its props looped Stand.
- The transport and lift loaders guard the reference's own faults as `Deviation:` lines: unwritten leg lengths, an unbounded append, a zero divide (`0x5f62a4`), an endless seek.
- A whole-period test of the Booty Bay–Ratchet path.
Each change has a test that fails without it.
Fixes#1210Fixes#1221
Refs #1220🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Our player's create now does its own writes inside the update packet, at the end of its create step (`0x5dec7b`), as 1.12.1's PostInit does:
- SelfPlayer is tagged in the create's own commands, so a later packet in the same frame finds us tagged and in control.
- The control flag and its two signals (`0x5deb56`), gated on `+0xc8` (`0x5deb49`).
- `CMSG_SET_ACTIVE_MOVER`, sent only when the mover changes (`0x6006ee`-`0x6006fb`). The mover clears at world entry, at the unit's destructor, at a release and at a control stop.
- The cascade message (`0x5deb60`), then the class family (`0x5debcc`).
The movement lock moves to its own resource. Only the arrival writes it, so a `/reload` while feared or possessing leaves it alone, since 1.12.1's reload runs only `0x4908c0`.
Each change has a test that fails without it. flip_readiness falls to 96 rows.
Refs #2168
Refs #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mouse moves and wheel turns are input records, run in arrival order among the keys and clicks, as 1.12.1 queues them. Kinds 0xa and 0xb dispatch 0xc and 0x10 (`0x424031`, `0x42417e`).
- Each move runs the hover walk (`0x7660d0`), so a frame crossed and left within one frame gets OnEnter and OnLeave.
- A wheel turn sweeps at the saved cursor (`0x766524`), and the world frame's binding runs inside it (`0x483d20`). One message is one step, from its sign alone (`0x76c1a9`). A trackpad's pixel carry is kept as a `Deviation:`, at most one step per event.
- During a long teleport's frozen frame the window stream waits. Released records take the live cursor, as each takes `GetCursorPos` when handled (`0x42dd00`).
- The pick order is reused until a frame changes: 2 µs a walk, 0.034 ms a frame at 1000 Hz polling.
Each change has a test that fails without it.
Fixes#2430🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three fixes, each with a test that fails without it.
- ShowHelm and ShowCloak send their toggle only while the live PLAYER_FLAGS bit says the opposite (`0x5ee6c4`, `0x5ee783`), and ShowingHelm/ShowingCloak read that bit (`0x48dd8b`). On the native display the call re-dresses the model at once. A display rebuild, a head or back visible-item change, or an item record landing dresses by the flag again (`0x604990`, `0x5e2541`, `0x5ed880`). The mannequin clones what the model shows (`0x476cb0`).
- Account-data readers register through `0x5afe50`. Each section is read when it settles, and its saves are skipped while it is pending. Bindings read set 1 and set 2 apart (`0x4b6240`, `0x4b64b0`), and macros merge by id (`0x4f0600`).
- The login burst is held until the entry UI has loaded, Pong excepted (`0x537b56`), as 1.12.1 loads before it logs in (`0x46c272`).
Fixes#2602Fixes#2448Fixes#2715🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every write to the player's selection now signals where 1.12.1 does, inside its packet or call, not from a per-frame diff.
- The attacked and cast-at acquires select inside their packets (`0x6259fe`, `0x6e799c`). SetSelection keeps its order: the usable refresh (`0x493892`), then `PLAYER_TARGET_CHANGED` (`0x49389c`).
- Deselects (`0x493910`) run at their packet's end, on their lane, or inside the call. `CloseLoot` deselects a dead source after the loot session ends (`0x48f33d`, `0x48f369`).
- The server's swing stop and the refusal latch apply inside their packet (`0x625ab8`).
- The control flag is stored in its handler, then LOST or GAINED, then the refresh (`0x4958e0`).
- The feeds' own raises are gone, and a world-less clear fires nothing (`0x4939df`).
Each change has a test that fails without it. flip_readiness falls to 98 rows.
Refs #2168
Refs #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ten fixes, each with a test that fails without it.
- Status lines are cut at 255 bytes (`0x41a049`), banners too (`0x419f19`), and an empty line is dropped without raising the severity (`0x41a05f`).
- A message frame's `bytes=N` holds N−1 bytes. A negative N empties its lines, since `0x771692` tests only zero.
- The reward panel after a progress panel plays the completion chime (`0xbe081c`, `0x500d36`).
- A panel opens only for a held unit, game object or item (`0x500c16`-`0x500c35`).
- Readable pages are rewritten into their language for the reader (`0x49b560`).
- A page of 1024 bytes or more reads empty, as `0x4191b0` does at capacity 0x400.
- World entry wipes only the four unsaved caches (`0x555740`)., keeping saved asks.
- Two comments cite the right addresses.
Fixes#2580Fixes#2690Fixes#2692Fixes#2694Fixes#2696Fixes#2700Fixes#2701Fixes#2710Fixes#2711Fixes#2712🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The next piece of the event-core move (#2168, #2217). The update handler's field callbacks now run inside the packet's dispatch, as the reference's notify pass does.
- A new end-of-update handler runs each changed field's callbacks in the order the pass wrote them, inside the dispatch:
- the aura, stack and loyalty lines;
- the death;
- the form release and service closes;
- the pet rename.
- The form release comes right after its own block's signals (`0x5de010`, then `0x5de07f`), so a window closes between UPDATE_BONUS_ACTIONBAR and the next packet's events.
- The stack line reads the live descriptor at notify (`0x62b822`).
- An XP award hides a death line only when it arrived in an earlier packet (`0x62c232`).
Placed-queue readers outside the dispatch go from 5 to 0. A two-packet test fails on main's order.
Part of #2168
Part of #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fifteen UI API fixes.
- **Text and names.** FontString text, buttons, tooltips, names and bubbles apply the `|1`/`|2` grammar escapes (`0x7716f0`). Rank names count code points.
- **Raid.** The raid roster selection stores the member's guid, survives a /reload, and clears at world login.
- **World states.** Each world-state packet fires WORLD_MAP_UPDATE then UPDATE_WORLD_STATES at its place.
- **Events.** DISPLAY_SIZE_CHANGED fires below scale 0.64. UPDATE_CHAT_COLOR carries the caller's name.
- **CVars.** Four refuse what 1.12.1 refuses, and anisotropic and ErrorLevel print its console lines.
- **Calls.** GuildSetLeaderByName("target") sends no name. Repair costs read by row position. Quest reward slots count to the first empty one. OfferPetition checks its eight guards.
- **Glue and errors.** The glue VM has the file calls. Widget methods share one wrong-receiver text.
Fixes#2507Fixes#2557Fixes#2559Fixes#2567Fixes#2568Fixes#2581Fixes#2588Fixes#2593Fixes#2599Fixes#2606Fixes#2615Fixes#2623Fixes#2630Fixes#2687Fixes#2688🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1.12.1 builds a frame one inherited level at a time, template first (`0x769820`). Each level runs:
- its geometry (`0x767800`);
- its flags;
- one child loop in document order;
- its type's own part.
An XML anchor to a frame not yet built is logged, "Couldn't find relative frame", and dropped. benilla instead merged the levels and retried missed anchors later. That hid order bugs, such as Button labels built before their state textures.
- The loader now builds level by level, every frame type's part included, and the retry queue is gone.
- `<Frames>` and `<ScrollChild>` take their first element only.
- Each TitleRegion and ButtonText makes a fresh object.
- A tooltip finds its lines after OnLoad, and Minimap models read the instance's own node.
All 4,140 anchors in FrameXML and the 12 Blizzard addons resolve in this order. A test holds that.
Fixes#2574🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thirteen fixes to the cursor, world arrival, loot and chat.
- Losing control (`0x495901`) or a world port drops the cursor and the cast, inside the packet.
- Every arrival clears the target (`0x490927`), just before the world-entry events.
- A resolved roll frees its loot row, and a group coin loot prints its share line.
- A boss whisper becomes a whisper, and channel chat carries its instance number.
- The delete confirm names an uncached item.
- Bag books send CMSG_READ_ITEM and handle both replies.
- The spellbook pickup and drop sounds play.
- The quest log's gold guide arrow shows, cleared first on each select (`0x4def39`).
- A cleared loot row records its `Deviation:`.
Each change has a test that fails without it.
Fixes#2573Fixes#2576Fixes#2446Fixes#2578Fixes#2584Fixes#2577Fixes#2558Fixes#2564Fixes#2562Fixes#2563Fixes#2627Fixes#2679Fixes#2680🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The XML loader and the SavedVariables writer follow 1.12.1.
- **Broken handlers.** One that fails to compile replaces the template's, reports nothing and keeps input on (`0x704c9f`).
- **Script files.** A `<Script file>` with a body runs both (`0x6ee0d4`).
- **FrameXML.log.** Load faults reach it in the client's wording. A failing script file logs at severity 2 (`0x704ae0`), and inline bodies log nothing.
- **Template levels.** Flags are read one inherited level at a time, and handlers come before a Slider's or StatusBar's values.
- **Fonts, gradients, names.** Unnamed fonts are logged, heights of a screen or more are refused, gradients take their last colours, and empty names stay unnamed.
- **Size changes.** A NaN size change fires OnSizeChanged.
- **SavedVariables.** They write bool and fractional keys, and the client's comments for skipped entries.
Fixes#2555Fixes#2556Fixes#2560Fixes#2561Fixes#2565Fixes#2566Fixes#2570Fixes#2572Fixes#2678Fixes#2683Fixes#2684🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seven issues from the UI core pass.
- Sorted particle emitters, with file flag 0x2 (`0x70fd1d`, `0x7b5d00`), now draw back to front. They use the reference's view-depth heap, so ties pop in its order (`0x7b3a5b`). Every other emitter keeps list order. (#2676)
- A party member leaving view snapshots the committed zone, `0xb4e314`, and their position at the call, as `0x5f0880` does. (#2677)
- GetDefaultLanguage answers nothing during a login's load (`0x49fcf0`). (#2665)
- GetGamma, the video getters and flat SavedVariables numbers read the CVar record's float (`0x63e135`). (#2673, #2672)
- The engine's counted and gendered text calls the Lua GetText and GetPluralIndex (`0x703bf0`, `0x703cf0`). Part of #2666.
- The pet cooldown test no longer depends on wall-clock time. (#2670)
Each change has a test that fails without it.
Fixes#2676Fixes#2677Fixes#2665Fixes#2673Fixes#2672Fixes#2670🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The next piece of the event core (#2168): two more unit feeds that pushed frame-end copies into the VM are gone.
- The held-unit chain and the by-name candidates are now read live through the call host.
- The by-name searches and the emote lookup take the player's and each unit's position at the call, so a unit that moved this frame is measured where it stands.
- The object, name and record getters ask a thin held-unit query instead of building a full unit state. With the host lent, `UnitHealth("target")` drops from 3.26 µs to 1.20 µs.
- A guid that is not held as a unit is no longer a name candidate.
The frame-final feeds go from 45 to 43. `ui_unit::feed_units` stays for the next piece. Each change has a test that fails without it.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What differed from 1.12.1:
- **Ticket results** show their lines: create and update codes 1, 3 and 5, a fetch status of 0 and a failed delete (`0x5e4432`, `0x5e44ff`). Update text is cut at 1999 bytes (`0x5efacd`).
- **UPDATE_TICKET** clamps a negative age to 0 and passes the client's NaN and denormal bits for the no-ticket answer. Arguments the client fills from stack residue are a `Deviation:`.
- **Ticket status** 2 sends the no-ticket answer; status 3 fires GMSURVEY_DISPLAY (`0x5e78f0`).
- **Casting** reads the cursor first: a held spell goes through pickup, and anything else is cleared (`0x4b3310`).
- **Hover:** Disable fires OnLeave first, Enable fires OnEnter after (`0x779160`).
- **Gossip:** leaving the world resets the gossip lists (`0x4e1f60`).
- **Nameplates:** a name flashes red for 5 seconds on damage (`0x7cba77`).
Each fix has a test.
Fixes#2462Fixes#2472Fixes#2476Fixes#2478Fixes#2481Fixes#2484Fixes#2536🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Lua numerals and the sscanf ports used Rust's correctly rounded parse. 1.12.1's C runtime rounds its own way: `__RoundMan` rounds up only when the round bit and some bit two past it are set (`0x40fb43`), so ties truncate and `6e23` reads one ulp low. It flushes results below 2^-1022 to +0 (`0x741ed3`) and keeps 24 digits (`0x41157f`). benilla-re holds these at proof two.
One port of that conversion now lives in benilla-lua (`strtod.rs`, `ld12.rs`). It serves `str2d` and `%f`, which rounds once to float (`0x40feef`) and consumes a digitless exponent marker (`0x7451a5`). `%d` wraps in 32 bits (`0x7456c9`). The time zone is read once per process (`0x414568`), and two client faults are written as Deviations.
A table of 3487 cases generated from benilla-re's transcription, and the exe's fixed cases, pin it.
Fixes#2647Fixes#2648Fixes#2649Fixes#2650Fixes#2651Fixes#2652🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A script error reached the `seterrorhandler` function once per frame, from a queue, after every other listener had run. In 1.12.1 the handler is the error function of the pcall each script runner makes (`0x704e4f`-`0x704e79`; the error function `0x703b40`). So it runs at the raise, inside the failing script: `this`, `event` and `arg1` are still the failing handler's, `debugstack()` shows the failing call, and the event's next listener has not run yet.
Every benilla runner now passes that error function: handlers, OnLoad, file chunks, RunScript, key bindings and slash commands. It returns the handler's result, as `0x703b40` does. The queue is gone.
A handler body that fails to compile reaches no handler (`0x704c70`). benilla's host log keeps each original fault, and `/errors` replays the ones raised before benilla's layer loaded.
Tests cover the raise-time globals, the stack, the listener order, OnUpdate and chunks.
Fixes#2656🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Frame layout mechanics that differed from 1.12.1:
- **Drag raise.** A dragged toplevel window rises once it overlaps another. A pass after the update recomputes each toplevel's overlap bit (`0x7657d0`). A rect change during a move raises unforced (`0x764a4c`).
- **EnableMouse.** Re-enabling a visible frame enters it behind its equals in the mouse list (`0x764b2d`).
- **Anchors.** SetPoint and SetAllPoints refuse a target that depends on the receiver (`0x768010`) and check the relative point last.
- **Scale.** An effective scale of 0 is refused before it is stored (`0x768366`), so the layout stands. GetEffectiveScale answers the stored value.
- **Draw place.** A region takes the last place in its layer each time it registers: Show after Hide, a new layer, or a frame show (`0x77fcb0`).
A scan of stock FrameXML finds nothing that visibly flips. Each fix has a test.
Fixes#2657Fixes#2658Fixes#2659Fixes#2661Fixes#2662Fixes#2668🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What differed from 1.12.1:
- **Channel notices.** Moderator and voice changes print their notices (`0x49e8a0`).
- **Copy.** Copying from an edit box strips link, colour and `||` codes (`0x5c2590`, mask 0x500).
- **Links.** A `|H` token ends at the first `|`, which must be `|h` with a byte after it.
- **SimpleHTML.** A resize rebuilds the links (`0x78a320`).
- **Secure add-ons.** Their `.url` file is read at registration.
- **Font size.** A FontString refuses any scaled size of 0 or below, 1 or above, or NaN (`0x5c1afe`).
- **Message frames.** Justify lives on the frame's font, CENTER by default (`0x783a87`).
- **Script names.** Each widget type takes only its own scripts: SetScript and GetScript raise `doesn't have a "%s" script`, and HasScript answers nil.
Each fix has a test.
Fixes#2483Fixes#2488Fixes#2489Fixes#2490Fixes#2491Fixes#2494Fixes#2543Fixes#2553🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The next piece of the event core (#2168): six of the unit feeds that pushed frame-end copies into the VM. Their getters now read the world live through the call host:
- the relation verbs, UnitIsPVP and the tooltip gates (`0x5167e0`-`0x516c50`);
- the reach behind CheckInteractDistance, CanInspect and the slot getters, with each position computed at the call;
- the item-use control exemption;
- the languages (`0x5ec720`, `0x5ec890`).
PLAYER_FARSIGHT_FOCUS_CHANGED fires from its field watch (`0x5dda45`). LANGUAGE_LIST_CHANGED fires at the learn handlers (`0x4b2641`) and once per language spell at arrival. The client interleaves those with the form events in wire order, the same gap #2217 records for forms.
GetNumLaguages returns nothing with no player (`0x49fb5e`).
The frame-final feeds go from 51 to 45. Each change has a test that fails without it.
Fixes#2664🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lua getters that answered what 1.12.1 never does now read what their handlers read:
- **Bind area.** GetBindLocation and the `$z` spell token fall back to HOME_INN (`0x507f3a`).
- **Craft.** GetCraftName answers the trade-skill slot by craft type (`0x4f601c`).
- **Trainer.** The skill line and requirement come from the service's spell (`0x4d9261`, `0x4d94d6`).
- **Map.** GetPlayerMapPosition takes any unit token; GetMapInfo answers its sizes.
- **Mail.** GetInboxItem gates by quality and misses uncached items (`0x4af721`).
- **Pets.** Stabled pets pack in list order, the summoned one by its byte's bit 1 (`0x4cabe3`). UnitCreatureFamily reads any unit's record.
- **Gates.** HasFullControl and UseAction gate as the client's do; ItemTextGetItem answers nil with no text open.
Each fix has a test.
Fixes#2475Fixes#2497Fixes#2499Fixes#2508Fixes#2509Fixes#2510Fixes#2511Fixes#2513Fixes#2514Fixes#2515Fixes#2516Fixes#2519Fixes#2523Fixes#2524Fixes#2525Fixes#2528🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lua 5.0 behaviours of the client that an addon can observe, which benilla-lua's 5.1 base got differently:
- string.sub and string.find keep a position's low 32 bits (`0x7fbd55`).
- An escaped byte at or above 0x80 matches nothing (`0x7fcbc6`).
- `error()` checks its argument (`0x702993`) and adds the position at any level but 0 (`0x7029a8`).
- `__unm` gets the operand and nil (`0x6f8edc`).
- `__index` chains reach 102 tables and `__newindex` 101.
- math.deg multiplies by 180/pi (`0x7fb14d`).
The bare aliases run as their own `compat.lua` chunk (`0x703b21`), each on the client's line. Its closures keep a local `math`, so their error lines match and replacing the global `math` leaves them working.
`seterrorhandler` keeps the top value, and nil clears it (`0x702930`).
Each fix has a test.
Fixes#2632Fixes#2633Fixes#2634Fixes#2635Fixes#2636Fixes#2637Fixes#2638Fixes#2639Fixes#2640Fixes#2654🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Widget methods called with a wrong argument returned quietly or did the wrong thing. In 1.12.1 they raise the client's usage line, or clear and read back, as the bytes show. This batch covers EditBox, FontString, Button, Slider, StatusBar, ScrollFrame, Model, PlayerModel and the Frame verbs.
Every method gates and reads back as its handler does at the address its commit cites. Examples: a missing frame name prints `(null)` (`0x6f5bc6`), and colours read back through f32 (`0x79ab3a`). Slider:GetMinMaxValues answers min plus the stored span.
Each fix has a test that fails without it. The tests that asserted the old behaviour now assert the reference.
Fixes#2533Fixes#2534Fixes#2535Fixes#2537Fixes#2538Fixes#2539Fixes#2540Fixes#2541Fixes#2550Fixes#2551Fixes#2552Fixes#2554🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GameTooltip setters accepted links, slots and indices that 1.12.1 refuses, and showed what it would not. Each one now checks and answers as its handler does.
- SetHyperlink takes only `item:` or `enchant:` (case-folded, `0x5320b1`), checks for an already-held link before the id, and raises `Unknown link type` on anything else.
- SetAction clears first. An Attack slot shows one white ATTACK line (`0x5323ad`).
- The trade skill, craft and trainer setters raise their lines on a bad index; a craft header clears and hides.
- Merchant and trade subtract 1.0 before truncating (`0x534159`).
- Any region can own the tooltip. A Font owner raises, written as a `Deviation:` (the client's `0x5313c9` is undefined there).
- Every setter checks `this` before its index.
Each fix has a test that fails without it.
Fixes#2544Fixes#2545Fixes#2546Fixes#2547Fixes#2548Fixes#2549🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Logging in or reloading dead and unreleased left the body on the ground with a Release button. 1.12.1 releases it instead. The world-enter cascade's last test reads health (`0x490a2d`-`0x490a38`) and sends CMSG_REPOP_REQUEST (`0x490a3c` → `0x5e0ae0`). A /reload runs the same cascade (`0x490168`). The server makes the player a ghost at the graveyard (vmangos `MiscHandler.cpp:48-67`).
Changes:
- benilla sends the repop at the end of every cascade with health ≤ 0, and drops both deviations.
- UI_Init zeroes the release timer (`0x490131`), so a reload reads 0.
- The arrival fires PLAYER_DEAD or PLAYER_ALIVE once, after the cascade (`0x5deb65` → `0x495850`). A reload fires neither.
Tests cover the send order, a dead and a live body, the reload's zero timer and its silence.
Fixes#2620🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comments that cited the wrong client address, or stated a fact the bytes contradict. Each one was re-read at the bytes and corrected. Comments only: no code changes.
Citations: the MCLQ cell read is `0x68b21f`, not the WMO group reader. The portrait bake has one caller, `0x713540`. Camera mode 0 keeps facing the target. The survey id call is `0x474064`, the macro setter `0x494f80`, and the empty party list jump `0x49e08e`. The clock constructor sets six fields to -1 and one to 0. A statusbar reads a numeric string as its number.
Deviation comments: each now gives the reference fact its ruling rests on, with every ruling kept. Examples: SavedVariables are kept as .bak (`0x51f794`), only flag-0x10 emitters sort (`0x7b3a1b`), the buff expiry cache clears at game entry (`0x4e40c0`), and SetTexture keeps the previous image (`0x7702ac`).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lua arguments are read the way the client reads them:
- numeric strings go through the VM's own number coercion instead of Rust's parse, truncating through `_ftol` where the bytes do (SetGuildRecruitmentMode `0x4a008f`, SetWorldDetail `0x488e0a`, the compare-item and model verbs)
- `debugstack` takes numeric-string levels, ports the level window's wrapping arithmetic, prints `(tail call): ?` below level 0, and joins leftover arguments top-down (`0x703760`)
- SendAddonMessage returns first with no player object (`0x49f94b`)
- the four sell-cursor verbs gate on targeting and repair mode before their arguments (`0x4fbab7`, `0x4fbac9`)
- SetPortraitTexture checks the token after blanking; 13 unit predicates take any value, and three more check the token
Each fix has a test that fails without it.
Fixes#2501Fixes#2502Fixes#2527Fixes#2529Fixes#2530Fixes#2532🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lua verbs that raised benilla's own text, or nothing, now raise the client's usage line or message, in the client's gate order (each address read in the commits):
- chat, channel and emote verbs take their argument through the usage gate, and send "" and padded names as given
- `SetChatWindowName` stores an empty or padded name as given, and "" for a non-string
- `GuildInviteByName` shows ERR_COMMAND_NEEDS_TARGET for nil or ""; `SetGuildInfoText` raises its usage line
- `NotifyInspect`: usage, then the player, then the token
- GM ticket verbs gate type, text, then the player; -1 goes out as u32::MAX
- `PickupPetAction` truncates through `_ftol`, so 4294967297 is slot 1
Each fix has a test that fails without it.
Fixes#2500Fixes#2503Fixes#2504Fixes#2512Fixes#2517Fixes#2520Fixes#2521Fixes#2522Fixes#2531🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The quest giver's getters read the panel's cells live, as 1.12.1 reads its globals (`0x501a20`-`0x501a70`), and its events fire on a lane at their packets instead of from a frame-final copy:
- each of the six texts has its own buffer; only a greeting clears them (`0x500c3b`)
- titles beside levels, nil past the pool (`0x501b05`)
- item info, link and counts read off the item cache at the call; IsQuestCompletable also checks the held counts (`0x501230`)
- QUEST_ITEM_UPDATE fires at the item answer (`0x5018c0`); a GameObject objective's name comes from its template
- a world entry and a /reload reset the cells (`0x500af0`)
- QuestLogPushQuest reads the first party slot at the call (`0x4e13a6`)
`feed_quest` is gone; the frame-final ceilings drop to 51 rows and 268 inputs. Tests cover each getter, the reset and the lane order.
Fixes#2474Fixes#2498Fixes#2505Fixes#2506Fixes#2518Fixes#2526🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Four cursor and button defects, each with a test that fails on main:
- RegisterForClicks stops at the first non-string (`0x78268f`).
- The pickup verbs (`0x4f9b87`, `0x4c7345`, `0x4f9fdb`) and every cursor setter gate on player control as the reference does (the item setter also allows a taxi flight). While feared, a player can no longer drag, split or buy into bags.
- Both destroy paths read the item record's flags at the call. Bit 0x20 refuses with ERR_ITEM_CANT_BE_DESTROYED, and an uncached record raises no popup (`0x495370`, `0x4953ac`).
- The ammo slot takes a drop. Projectiles load by entry, other items auto-equip, and an empty hand lifts the loaded ammo and sends SET_AMMO 0 (`0x4c73a6`–`0x4c7646`).
Also, the merchant toggle-off matches a held preview by entry (`0x4fb811`), and previews play the item display's grab and put-down sounds (`0x495154`, `0x49526a`).
Fixes#2468Fixes#2469Fixes#2470Fixes#2471🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bank, gossip, purse and repair-cost getters read frame-final copies, and their events fired from feeds after the drain.
Now they read live as of each packet:
- the purse, as GetMoney does (`0x518160`)
- the repair costs per slot (`0x4faf30`)
- GetNumBankSlots and GetBankSlotCost, from the player's own field with no banker test (`0x4f85b0`, `0x4f8630`)
- gossip's slots and text (`0x4e28d0`, `0x4e28c0`)
A bank lane carries OPENED (`0x4f8522`) and the refusal lines. PLAYERBANKBAGSLOTS_CHANGED fires at its field (`0x4f8460`). A gossip lane pushes SHOW at the draw (`0x4e22b5`), and asks the NPC's name there. A gossip draw with no player or no NPC held writes nothing and fires nothing (`0x4e20bb`), so a late greeting no longer reopens a closed window.
Four feeds are gone. Tests in `bank_live_tests.rs` and `gossip_live_tests.rs` fail on main. READS_FRAME_FINAL 56 → 52.
Part of #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The item requirement state, lock openers and set blocks were read from frame-final copies pushed by feeds, so a listener saw the frame's last level, skills and bags, not its own packet's.
Now the requirement checks (`0x5eaae0`, `0x5ea930`), the known-spell test (`0x60c740`), the lock openers (`0x5da5e0`) and the set blocks (`0x52d8a0`) read the player and bags live, as of each packet. With no player held, the getters answer the reference's fixed values: GetQuestGreenRange 0 (`0x4e17f8`), GetComboPoints 0 (`0x51a261`), and the item tooltip hidden (`0x52b699`). The tooltip build asks for its creator, charter and set-member names inside the build (`0x52e204`, `0x52b93b`, `0x52df4b`). The merchant's buyback and repair reads are as of the packet too.
Four feeds are gone, including feed_player_req. Tests in `lanes/requirement_live_tests.rs` fail on main. READS_FRAME_FINAL 60 → 56.
Part of #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Walking into some stairs stalled the player until they jumped, such as the Stormwind auction house's street door. The movement code classified the floor by parry's contact normal. At a stair nosing that normal blends the faces meeting there (ny 0.38), so the tread read as steep.
1.12.1 classifies by the hit face record's own normal against cos 50° (`0x80dffc`). It does so in the step probe (`0x636592`), the ground classify (`0x636ecf`) and the step trigger (`0x6334e6`). The casts now return the hit triangle's face normal (`collision::BodyHit`), and all four sites read it. A mover with no direction or fall bit runs no resolver (`0x634100`), so a body stopped on a nosing stands there and sends no FallLand.
Tests on the real Stormwind WMO cover the climb, short taps, and a stop at every frame of it.
Fixes#755🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pet bar, menu, stats and book getters read frame-final copies. A reaction or Stay/Follow press raised PET_BAR_UPDATE from the VM's copy, even when the press was refused.
Now the pet's getters read live through the call host: PetHasActionBar (`0x4bdc20`), GetPetActionsUsable (`0x4bcf70`), GetPetActionInfo (`0x4bdc50`), HasPetUI (`0x4be670`), PetCanBeAbandoned/Renamed (`0x4be500`/`0x4be580`), HasPetSpells (`0x4b4410`) and the rest. A press writes the state word and signals inside the call, after the gate (`0x4bd1f2`) and before the send (`0x4bd444`). A stunned pet's press stays silent. The pet-teach "already known" line and CreateMacro/EditMacro read the pet's book live. `GameTooltip:SetPetAction(0)` answers nil (`0x532812`).
The bar, menu and book feeds are gone. Tests in `lanes/pet_live_tests.rs` fail on main. READS_FRAME_FINAL 63 → 60.
Part of #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`benilla-blp`'s `parse_header` refused any BLP shorter than the 256-entry palette window, whatever its compression. So small DXT or raw textures failed to load, such as AtlasLoot's 516-byte `gold.blp` highlight.
1.12.1's parse (`0x5a83b0`) copies the 1172-byte header with no length check (`0x5a83da`). It fails only on the magic and the type, and only the paletted path reads the palette.
Now the palette window is required for compression 1 only. Test: `dxt_without_a_palette_decodes`, a 4x4 DXT5 with no palette.
From chairmanpow's benilla-octo `660cf760`, carried on Thorsten42/benilla@78f7362.
Fixes#2464🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The trainer, stable, tabard and charter getters read frame-final copies, and their events fired from feeds after the drain.
Now they read live through the call host, matching their reference reads: the trainer's rows (`0x4d9096`, `0x4d9d07`, `0x4d97c8`), the stable's records (`0xb72058`) and display (`0x4cb99e`), and the charter's five getters (`0x4f43d0`…`0x4f5230`). Each family's events fire on its own lane at its handlers. TRAINER_UPDATE fires at each `0x4d7d40` caller: twice for a superseded rank (`0x5e63a4`, `0x5e64f1`), and between the skill line and the profession rebuild (`0x5de42d`). A close in the same frame no longer swallows a queued SHOW. That also fixes the merchant, whose CLOSED could fire before its SHOW. A /reload keeps the trainer's rows.
The four feeds are gone. Each family's tests fail on main. READS_FRAME_FINAL 67 → 63.
Part of #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dialog getters read frame-final copies, and their events fired from frame-final feeds after the drain, so a listener saw them out of packet order.
Now CheckBinderDist (`0x5dff50`), CheckPetUntrainerDist (`0x5dfd30`), the boot, spirit healer, meeting stone, summon and instance getters read live through the call host. Their events fire on a dialogs lane stamped at each handler. The duel, binder, dialog verb, meeting stone, summon and instance feeds are gone.
Fixes on the way:
- The binder and pet unlearn questions pass the range gate first (`0x5dfe3c`, `0x5dfc2d`), the innkeeper click included.
- The boot timer's delay is signed (`0x496340`).
- The duel checks the player's own challenge before ignore, and its timer runs before packets (`0x420d0c`).
- A deleted ticket signals UPDATE_TICKET (`0x5e461d`).
Tests in `lanes/dialog_live_tests.rs` fail on main. READS_FRAME_FINAL 75 → 67.
Part of #2217🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sam Sung