Commit Graph

385 Commits

Author SHA1 Message Date
Sam Sung 24cd215ba6 The cast getters read live; a refused reagent line shows at its answer (#2818)
The cast state's getters read a copy a feed pushed once a frame, and a refused cast line that missed the item cache retried at frame time, so both lagged their packets.

**Reference**
- IsCurrentAction, IsAutoRepeatAction, SpellIsTargeting, SpellStopCasting and the targeting word's checks read the cast state at the call (`0x4e54c1`, `0x6e48e0`, `0xcecac0`).
- A reagent or totem refusal that misses the cache registers `ShowItemCastFailure` (`0x6e1e82`-`0x6e1ea4`, `0x6e29b0`). The item's answer shows it, with UNKNOWN on a refusal (`0x6e2a49`). With no item word no line ever shows (`0x55be5d`).

**Changed**
- The getters read through the host, and `feed_cast_reports` is gone.
- The refused line rides the item cache's callback list.
- The "Missing reagent" fallback that 1.12.1 never shows is removed.

**Tests:** the line between its neighbours for a record and for a refusal, the getters between packets, no line with no item word.

Part of #2168 and #2217.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 00:06:35 +07:00
Sam Sung 7e66ef52a0 The bar's state feed goes; macro faces, reload seed and staged buttons (#2817)
The bar's last per-frame feed is gone, along with four mismatches with 1.12.1 its audit found.

**Reference**
- A macro or item slot's texture runs the attack and ranged face tests on its spell first (`0x4e6ab2`, `0x4e6acb`, `0x4e5a50`).
- A `/reload` keeps the bar in the engine, so the new interface reads it from its first file.
- SMSG_ACTION_BUTTONS only stages its words (`0x5e6680`), and the arrival loads them, skipping unknown spells (`0x5deaf5`).
- The usable walk asks with the bar's callback, behind its player and count gates (`0x4e5b30`, `0x4e5080`, `0x4e50ab`).

**Changed**
- Each of those, and a worldport's book no longer reruns the rank pass over loaded words.
- `feed_action_state` is deleted, and its tests read live.

**Tests:** an Attack macro's weapon icon, the bar during a reload's load, an unknown spell's empty slot, the walk's ask, the worldport's book.

Fixes #2810. Fixes #2811. Fixes #2812. Fixes #2813. Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 23:26:36 +07:00
Sam Sung e8e9969f91 The bar's icons, counts, aura notifies and SetAction read live (#2809)
The bar's icon, count and consumable getters, its aura notifies and GameTooltip:SetAction read a copy a feed resolved once a frame, so a call between two packets read the frame's last state.

**Reference**
- GetActionTexture, GetActionCount and IsConsumableAction read at the call (`0x4e6a50`, `0x4e6c70`, `0x4e5250`), with the counts at `0xbc6390` zeroed at game entry (`0x4e4f50`).
- An item answer runs the bar's callback (`0x4e5b80` → `0x4e5c70`), firing ACTIONBAR_SLOT_CHANGED per slot.
- An aura add or removal notifies its slot around its log line (`0x4e5de0`).
- SetAction runs the cooldown query and attack test at the call (`0x5323a6`, `0x5323b4`).

**Changed**
- The getters and SetAction read through the host.
- The callback rides the item cache's list.
- The aura handlers notify in place.
- `feed_actions` keeps only the engine's refusals and a new VM's seed.

**Tests:** an item answer's slot event between its packets, the seed's counts, the aura notifies, SetAction inside its packet.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 20:10:15 +07:00
Sam Sung bf8c54b1fe The vendor sale and the map's landmarks signal in place, not at the tick (#2808)
Five engine calls queued their event for the VM's next tick, behind every packet, where the reference signals in place.

**Reference**
- A vendor sale clears the cursor and signals CURSOR_UPDATE inside the click (`0x5df5f0`, `0x494b60` → `0x495190`), unless the player lost control (`0x494b8d`).
- The landmarks rebuild and signal WORLD_MAP_UPDATE (`0x4a67a0`, `0x4a6ce4`) at the gossip marker's set, at its deadline, and at an arrival tested on a moved update (`0x6dac93`, `0x6d9411`, `0x6d9a4c`).
- World entry drops the marker but keeps its deadline (`0x6d8fb0`).
- The catalog's load signals nothing (`0x4a5d00`).

**Changed**
- The sale signals in its click.
- The landmarks signal on their own lane.
- World entry and `/reload` drop the marker.
- The seeds are silent.
- The world map's Deviation keeps only the world-enter sync.

**Tests:** the sale before the binding's next line, the gossip set between its packets, the deadline, a reload's marker.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 18:53:00 +07:00
Sam Sung b4ea5df281 Debug builds check every event raise's origin at run time (#2805)
The guards' source scan misses a raise reached through a helper in another module, so a frame-time feed could raise outside every lane unseen.

**Changed**
- In debug builds, every raise into the VM goes through one check: the immediate fire (`tick::fire_event_into`) and the queue (`Model::queue_event`, now its only push).
- A raise outside a script call, a lane or the VM's tick fails with the event and its caller chain, unless an allow entry names its guard row or reference place.
- The app's tests fail hard. A live run warns once per site.
- Its first run found `feed_char` raising UPDATE_INVENTORY_ALERTS at frame time, where the item field watchers signal it in the packet (`0x4c8085`). That is now a guard row.

**Tests:** a frame-time raise fails naming its caller, the same raise in a lane passes, and a live run reports each site once.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 18:18:28 +07:00
Sam Sung 65c83b1883 A follow ends at the packet that ends it, with AUTOFOLLOW_END there (#2803)
A follow ended at frame time, in `steer_follow`, and AUTOFOLLOW_END fired there, out of order with the packets that ended it.

**Reference:** `StopAutoMove` (`0x60fb60`) ends a follow inside the packet that ends it: our death, the attack-state swing, the taxi flag, a mover switch or release, a near teleport, a knockback, feign death, a stun, a monster move on us and far sight. It signals AUTOFOLLOW_END (`0x60fb84`), then releases forward and autorun. A near teleport and a knockback also close the loot window (`0x60e990`).

**Changed**
- One stop runs at each of those handlers, with END on the notice lane and the autorun clear behind its listeners.
- The loot window closes on a near teleport and a knockback.
- Each unit holds its client-controlled bit (`0x5fa636`).
- `feed_follow` is gone.

**Tests:** each end fires END between its neighbouring packets' events, and death's END comes before PLAYER_DEAD.

Part of #2168 and #2217.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:39:03 +07:00
Sam Sung 3d7383b710 The bar's usable pairs store at each write; refreshes run in place (#2802)
The bar's usable pairs were stored by a per-frame diff, and EditMacro's and a bag update's refresh fired at frame end, so ACTIONBAR_UPDATE_USABLE and a slot's IsUsableAction lagged their cause.

**Reference**
- Each slot write stores its pair (`0x4e58e0`, `0x4e590a`).
- The refresh `0x4e5c00` runs at world entry, inside EditMacro (`0x4f132e`) and in the item watcher's run before BAG_UPDATE (`0x4f9374`).
- Game entry zeroes the cache (`0x4e4f50`).
- The reactive list keeps learn order (`0x5dea86`, `0x4b27b3`).

**Changed**
- Every writer stores its pair, and the refreshes run in place.
- The cache zeroes at game entry.
- The reactive list moves to its own resource, in wire order.
- The per-frame diff and its event queue are gone.

**Tests:** EditMacro's update inside the call, a bag run's between its packets, PlaceAction's listener reading its pair, the reactive order.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 16:07:53 +07:00
Sam Sung b686ad253b The Craft window reads live and signals at its packets (#2801)
The Craft window answered from a copy a feed refreshed once a frame, and rebuilt and signalled there.

**Reference**
- The build (`0x4f60c0`) zeroes its counts and, with no craft type open or no player, leaves before CRAFT_UPDATE (`0x4f661a`). The open, SMSG_PET_SPELLS, the record callback, learn and unlearn, and the item watchers rebuild it.
- The getters read at the call (`0x4f6c3b`, `0x4f6d52`, `0x4f6fe6`, `0x4f76b2`, `0x4f7a3c`).
- GetCraftDescription falls back to the taught spell's text (effect 36 or 57), with the pet flag (`0x4f7b53`).

**Changed**
- The build and the getters read through the host, and a build with no player empties silently.
- The description takes the fallback and the pet flag; the VM fills its templates in the call.
- `feed_craft` is gone; the trainer and the window share one token helper.

**Tests:** each getter read between two packets, CRAFT_UPDATE between its neighbours, the silent build, the description fallback.

Part of #2168 and #2217.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 15:43:25 +07:00
Sam Sung 3d730699e7 A packet's select binds the cursor's pick; the go's swing is validated (#2800)
With the targeting cursor up, a unit a packet selected was parked and bound to the cursor a frame later. A spell's deferred swing at its go also skipped the attack validator.

**Reference**
- `SelectTarget` with the cursor up binds at once (`0x4935d5` → `0x6e5b40`) and selects nothing. The loot response, the two acquires and the go each reach it at their packet.
- The go's swing runs the validator `0x612df0` (`0x6131aa`): the actor checks, the select, then the reload from the selection (`0x6130c1`), with ERR_NO_ATTACK_TARGET or ERR_INVALID_ATTACK_TARGET.

**Changed**
- Each handler binds in place.
- The melee probe and the pet bind inside their press.
- The go runs the Attack action's validator and swings at the selection as reloaded.

**Tests:** the loot response binds between its neighbours, a stunned caster's go sends no swing, and with a cursor up the go binds one unit and swings at the selection.

Fixes #2113. Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 14:53:28 +07:00
Sam Sung 4b6ef4b2c6 The profession window reads live and signals at its packets (#2799)
The profession window answered from a copy a feed refreshed once a frame, and rebuilt and signalled there, so a getter or TRADE_SKILL_UPDATE between two packets read the frame's last state.

**Reference**
- An item answer runs the getter's or the build's record callback (`0x4fdc30`, `0x4fc8e0`), which rebuilds and signals at its packet.
- The build reads the book at its call (`0x4fca20`), and with no player it empties the list and signals nothing (`0x4fca52`, `0x4fcb1b` → `0x4fd170`).
- GetTradeSkillLine reads the open line at the call (`0x4fdd40`).

**Changed**
- The callbacks go on the item cache's list.
- The build and the getters read through the host.
- A build with no player empties the book silently.
- `feed_trade_skill` is gone.

**Tests:** the line getter between two packets, a reagent's answer between two falls, a learn banded at its packet, a product answer after `/reload`, and the silent empty build.

Part of #2168 and #2217.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 13:48:12 +07:00
Sam Sung 4efe834bb6 Error and info lines show at the handler that raises them (#2798)
The error and info lines a packet raises showed from a per-frame feed, ahead of every lane's events, so they sat out of order against their own packets' signals.

**Reference:** each handler shows its line where it runs, through `DisplayError` (`0x496720`): a chat row, or UI_ERROR_MESSAGE or UI_INFO_MESSAGE by the message's kind.

**Changed**
- The lines ride a stamped lane, pushed at their handlers.
- Five orders now match the bytes: the guild event and invite, learn and rank-up, the party disband and the ready check.
- A rank-up shows its line with no player held (`0x5e6363`).
- A missing tame string shows ".", as `0x703bf0` does.
- A world session that ends before entry no longer leaves its lines for the next.

**Tests:** each line between its neighbouring packets' events, the rank-up line without a player, and the session that ends before entry.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 13:12:28 +07:00
Sam Sung b52f2bf110 The movement verbs and DropItemOnUnit apply in their calls (#2797)
The movement verbs and DropItemOnUnit queued their work for frame time, so a cast a movement press should cancel was still running on the script's next line.

**Reference**
- Every movement verb goes through `SetCommands` (`0x515090`). It sets the bit, and a new press in mask 0x10f0, or the press completing both mouse bits, cancels the cast inside the call (`0x51512a` → `0x6e4940`), then the channel, then runs the tick.
- ToggleAutoRun reads the bit at the call (`0x513de7`).
- DropItemOnUnit fills the trade or starts one in its call (`0x48da50`, `0x48da62`).

**Changed**
- With a host lent, the 23 movement verbs and Jump apply in the call.
- The autorun bit flips there.
- DropItemOnUnit applies in the call.
- The mouselook verbs still queue.

**Tests:** a press mid-cast cancels before the next line, two toggles in a frame cancel once, and a drop on a player trades in its call.

Part of #2202.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 12:29:30 +07:00
Sam Sung d12054da65 Death, logout and the taxi flag read live and signal at their packets (#2796)
Three windows still answered from a copy a feed refreshed once a frame, and fired their events there.

**Reference**
- The cursor's control gate reads our unit's taxi bit at the call (`0x494b97`-`0x494ba6`).
- PLAYER_CAMPING, PLAYER_QUITING, LOGOUT_CANCEL and the logout-failed line are raised by their packets' handlers (`0x5aaf17`, `0x5aaf72`, `0x5aaf26`).
- The death signals fire at their packets, and the corpse range is checked each frame (`0x492130`).

**Changed**
- The taxi gate reads the flag off our object.
- The logout replies go on the notice lane at their handlers.
- The death getters (GetCorpseRecoveryDelay and the rest) read live, and the death signals fire at their packets.
- `feed_on_taxi`, `feed_logout` and `feed_death` are gone.

The fake world server logs a session before answering its authentication, which a loaded test run read behind.

**Tests:** each getter read between two feeds, and each event between its neighbouring packets' events.

Part of #2168 and #2217.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 11:55:07 +07:00
Sam Sung 5d1f7ad395 The bar's state getters and cooldown queries read live at the call (#2793)
The action bar's state getters and cooldown queries answered from a copy the feed refreshed once a frame, so a call made between feeds read the last frame's state.

Reference: each getter reads its slot at the call. A cooldown query that misses the item cache registers a callback on the record (`0x6e2f70`) and answers when the record arrives. A pet spell list derives its macros where it loads (`0x4bdae0` → `0x4f0ce0`). The go handler sweeps both cooldown lists every 120 s (`0x6e1910`); the insert sweeps nothing.

Changed: the bar getters (IsUsableAction, GetActionCooldown and the rest) resolve and read live. The cooldown query uses the record's callback list. The pet list derives its macros in its place. The sweep moves to the go.

Tests: each getter read between two feeds, the callback answered at the record, the macros derived after UPDATE_MACROS, and the swept GCD.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 11:17:12 +07:00
Sam Sung db8a28ec2c Try-ons, slash targets, RestartGx and the video verbs apply in the call (#2790)
Several verbs did their work in a later drain: try-ons, the chat input's /target, /assist and /follow, RestartGx, and the engine CVar verbs (SetGamma, the video pairs, SetMultisampleFormat, the minimap zoom, the glue writes). A script's next line read the old state. LoadBindings also switched the current set, so a Character Specific tick then Cancel left the character set live.

Reference: a try-on reads the cache and lands or refuses in its call (`0x504540`, `0x504b2d`). RestartGx runs gxRestart synchronously (`0x48dab0` → `0x63ce00`), and SetMultisampleFormat restarts in its call (`0x48c79b`). LoadBindings never writes the current set (`0x4b8249`-`0x4b8252`).

Changed: those verbs apply in the call, and the slash commands call the stock verbs. The drains left at the frame each name why; SaveBindings only marks its set until shutdown (`0x4b6310`, `0x4b65e0`).

Tests: per verb, a same-chunk read of its effect.

Part of #2202.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 09:19:04 +07:00
Sam Sung 0259668162 Tutorials trigger where they happen, on a stamped lane (#2789)
Tutorials were judged once a frame by a feed. A tutorial a packet raised fired behind every packet's events. Looting fired at a corpse's first sight, even one already dead at login, and Backpack fired before its item's record arrived.

Reference: each trigger fires in the handler or input that raises it.
- the vendor and trainer lists (`0x4fad32`, `0x4d74ae`);
- Looting on the dynamic flags' bit 0 rising (`0x600482`-`0x60049b`);
- the item tutorials after the received line, once the record is known (`0x491cec`);
- Raid Groups at the roster rebuild (`0x4ba60d`).

Changed: tutorials are a stamped lane, and each site triggers where it happens. TutorialsEnabled reads live. `feed_tutorials`, `judge_selections`, `watch_windows` and `TutorialEvent` go.

Tests: a packet's tutorial falls between neighbouring packets' events, and a ClearTutorials in an earlier listener stops a later trigger.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 08:41:10 +07:00
Sam Sung 76874a1510 Profession books open in their cast's call; Create All recasts at the go (#2788)
A profession's book opened from a frame feed, after the cast verb had returned, and its "Create All" repeat recast from a drain. A listener read the book shut inside the call that opened it, and a repeat on a recipe with a cooldown refused its own recast.

Reference: `TryCastSpell` opens the book inside the call (`0x6e4bce` → `ToggleTradeSkill` `0x4fc910` / `ToggleCraftWindow` `0x4f6000`). `HandleSpellGo` runs the repeat hook (`0x6e81e7`) before its cooldown inserts (`0x6e8425`). The repeat disarms only at a failure report, a failed cancel, or the close (`0x4fd790`'s four callers).

Changed:
- the toggles run in the call;
- the repeat runs in the go ahead of the cooldowns;
- `drain_trade_skill` and `open_trade_skill` go.

Tests:
- a listener's CastSpellByName shows the book between two packets;
- Create All recasts at the go, also with a cooldown.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:45:43 +07:00
Sam Sung 2f9bd96fc2 The spell packets clear and replace bar slots at their handler (#2787)
The bar's slot clears, rank-ups and learned-ability latches were rewritten once a frame by feeds. A listener inside an unlearn or a supersede read the old bar, and ACTIONBAR_SLOT_CHANGED fired ahead of every packet event.

Reference: the unlearn handler clears the spell's slots after the book removal (`0x4e5e20` at `0x5ea253`). The supersede's `0x4e5e60` clears then sets each slot, with a send and an ACTIONBAR_SLOT_CHANGED for each (`0x4e58e0`). The learn and unlearn set the latches (`0x4b262c`, `0x4b2c83`). Each game entry zeroes the bar (`0x48f5a4`).

Changed: those writes run in their handlers, with the signals on the notice lane. The rank pass's Deviation: now runs only where login slots arrive. The bar empties at game entry.

Tests: an unlearn's listener reads the slot cleared; a supersede sends clear then set; a relog sends nothing for the last character's bar.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 07:10:23 +07:00
Sam Sung 4b322073b4 SetCVar runs its callback in the call; the view verbs seat in theirs (#2785)
SetCVar ran its change callback and its effect in the frame's later sync, and SetView, SaveView and ResetView queued their camera writes for a drain. A script that read the effect on its next line saw the old value.

Reference: `CVar::Set` (`0x63df50`) runs the row's callback inside the call (`0x63df7d`), and a refusal drops the set. CVAR_UPDATE follows from `SetCVar` (`0x488cad`). SetView writes `cameraView` in its call (`0x512f17`), and SaveView writes its view there too (`0x50fa09`).

Changed:
- the 23 callbacks, once observers, are plain functions the host runs in the call;
- the knobs they write became host state, with their readers ordered around the VM pass;
- `drain_view_requests` is gone.

Tests: SetCVar("deselectOnClick","0"), then a click on empty world on the chunk's next line, keeps the target. A view verb's CVar reads on the next line.

Part of #2202.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 05:35:50 +07:00
Sam Sung eee9d1441c An item record's answer walks its callback list at the packet (#2784)
An item record's answer ran its callbacks from hand-placed hooks. The equip replays ran in the drain, the quest log's refire at the frame's end, and the tooltip rebuilds at the tick, so a replay's send followed later packets' sends. A refused record also replayed every frame.

Reference: `ItemCacheReceive` (`0x55bdb0`) stores the record, then walks one callback list per record, oldest first, filled by each lookup's miss (`0x55ba30`). A refusal calls each callback with found 0 and frees the list (`0x55bea8`, `0x55bed2`).

Changed:
- `Items` keeps that list, registered at each miss and walked at the answer's handler;
- a deferred stretch's calls apply at once and its signals park.

The late callbacks stay named in the `Items` row.

Tests: an equip replay sends before a later packet's send; two parked swaps keep their order; a refused record sends nothing.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 05:10:21 +07:00
Sam Sung e41ddb36d3 Party, raid and pet tokens and the roster read live at their packets (#2783)
The party, raid and pet tokens read copies pushed once a frame, and so did the roster copy, the event-token walk and the dungeon latch. A listener inside a member's update read the last frame's party.

Reference:
- the tokens look their member or pet record up by guid at the call (`0x496400`, `0x496420`);
- the event-token walk names player, pet, target, party row, raid row, npc, mouseover (`0x515c50`);
- the dungeon latch is set at the port's new object manager (`0x401c22` → `0x495d10`), and at login with the character list's map (`0x4015f3`);
- a ready check closes at the raid rebuild's end (`0x4bac5a`).

Changed: the tokens, the token walk, the roster, the group predicates and the relations read live, and the latch moves to those places. The frame-final party and pet pushes go.

Tests: a member listener reads party1 and raid3 from its own packet, through a same-frame roster swap.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 04:27:08 +07:00
Sam Sung cdebda36fb Loot roll getters read live; roll signals fire at their packets (#2781)
The loot-roll getters read a copy pushed once a frame, and START_LOOT_ROLL, CANCEL_LOOT_ROLL and the roll lines fired from that feed. A vote also deleted its roll, where the reference keeps it listed until the result.

Reference: START fires at the start packet with the item cached, or at the item answer (`0x61b44d`, `0x61b7a7`). A vote sets only the closed byte after its CANCEL (`0x61bf2a`, `0x61bf32`). A win's line waits for the winner's name (`0x61b96a`). Time left is an unclamped 32-bit difference (`0x61b404`).

Changed: the getters read live, the rolls get their own lane, and each signal fires at the handler whose lookup lands last. One Deviation: a refused record closes the roll, where 1.12.1 leaves a dead frame.

Tests: a listener reads the live roll; START falls between neighbouring packets' events; a start and a win in one frame leave nothing listed.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 01:50:05 +07:00
Sam Sung 77cea16e72 Closes run their engine half at the packet and signal at its place (#2779)
A close that a packet handler ran fired at once when its own lane was empty, ahead of earlier packets' events on other lanes. benilla also closed the binder, pet-untrain and talent-wipe confirms itself when you walked away.

Reference: each close core releases, clears its cell and sends in the handler, then signals. The stock OnHide's close verb re-enters it: trade's release re-enters at `0x493365`, so a latched partner gets three CMSG_CANCEL_TRADE. The confirms' latches are never cleared (`0x5dfa21`); StaticPopup.lua hides them.

Changed:
- the engine half of every close runs at the handler, and the signals park behind the lane;
- one shared guard keeps a re-entered close verb off a newer session, replacing auction's own;
- the range-close systems go, and the polls test range at the call.

Tests: quest detail Accept sends its NPC, and the trade cancels and Begin go in order.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 00:18:47 +07:00
Sam Sung e23368a777 The item-text reader reads live and signals at its packets (#2778)
The book, letter and plaque reader read a copy pushed once a frame, and opened on its lane. A bank or gossip open in the same frame lost to the book, and a listener read the last frame's page.

Reference: the open, the page and record answers and the turn each run in their handler. ITEM_TEXT_BEGIN (`0x4e349f`), READY and TRANSLATION are signalled there, and a waiting open finishes in its record's callback (`0x4e3280`, `0x5f59d0`).

Changed: the getters read live, each step runs in its handler, the events go on the lane. A nested close acts only on its read. Deviation: 1.12.1's reopen closes the book when an uncached page or a letter's author lands, and benilla keeps the book open.

Tests: a listener reads its packet's page, a same-frame bank open wins, and a book read before its template arrives opens when it lands.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 23:46:11 +07:00
Sam Sung 68176302d5 A worldport frees the cooldowns and cancels open loot rolls (#2775)
A cross-map worldport kept the old cooldowns and left open loot rolls up in the new world.

Reference: the worldport's teardown timer `0x401bc0` frees every cooldown after the objects' walk (`ClearItemAndSpellCooldowns` `0x6e9ad0` at `0x401c17`). That covers the player's and the pet's lists and the item table, with no flush. Then it cancels every open roll (`CancelAllLootRolls` `0x61b290` at `0x401c2c`), signalling CANCEL_LOOT_ROLL for each one not queued, before the map load.

Changed: two legs after the objects' leg of the worldport timer, in that order. The legs run once per load.

Tests:
- a port cancels the open rolls in the next frame;
- a port empties the cooldowns, and the server's resend seeds only what it lists;
- a same-map teleport touches neither.

Fixes #2769
Fixes #2770

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-28 23:00:52 +07:00
Sam Sung e0329532cc Played time, pings, broadcasts, the clock and channels fire at packets (#2774)
/played, PLAYER_SKINNED, the game clock, members' minimap pings, world broadcasts and the chat channel list came from feeds that ran once a frame. A listener inside a packet read the last frame, and two /played answers in one frame kept only one.

Reference:
- TIME_PLAYED_MSG and PLAYER_SKINNED signal inside their handlers (`0x4018df`, `0x48f412`);
- `GetGameTime` reads the clock at the call (`0x515ee0`);
- the ping handler stores the point and signals MINIMAP_PING at its packet (`0x4ee48d`);
- the broadcast handlers add their chat lines themselves (`0x49dcc0`).

Changed: each fires on its lane at its handler. The clock and the channel getters read through the host, and the five feeds go.

Tests: per family, a neighbouring packet's listener reads the live value; each fails on main.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:37:11 +07:00
Sam Sung 6b50b9dd6a A worldport's teardown runs at the next frame's start, as one unit (#2773)
A worldport tore the old world down inside its packet: the despawn, the world handle and LOGOUT_CANCEL there, then PLAYER_LEAVING_WORLD before the frame's earlier packets' events had fired.

Reference: `SMSG_NEW_WORLD` (`0x401b00`) posts its teardown `0x401bc0` as a zero-delay timer, and a tick runs its timers before its packets. So the next tick:
- zeroes the world handle (LOGOUT_CANCEL);
- walks the objects (`0x467800`);
- sweeps at the local player's turn (`0x5dd543`).

Changed: the packet only posts the load. Three legs at the next frame's start run the connection's half, the sweep and the objects' teardown. The sweep runs ahead of the objects, so the target is still there in PLAYER_LEAVING_WORLD.

Tests:
- the port frame's events precede the leave, and its listeners still see the old world;
- a port alone leaves in the next frame;
- the leave listener sees the target.

Fixes #2763

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-28 21:47:03 +07:00
Sam Sung cb949ba1a5 Player scalars and the unit tokens read live; the unit feed goes (#2771)
The player's combo points, action-bar toggles and zone PvP masks, and the four unit tokens, read copies pushed once a frame by `feed_units`. A listener inside a packet saw the last frame's values.

Reference:
- `GetComboPoints` reads the player's count and banked target at the call (`0x51a190`);
- the bar toggles read `+0x102a` (`0x4e7660`);
- `GetZonePVPInfo` reads its masks at the call (`0x48d540`);
- the tooltip's health bar is redrawn by the health field's watcher (`0x52a08d` → `0x529560`).

Changed: those getters ask the live player, and `feed_units` is gone. Health notices redraw the tooltip bar. The senders' player checks read the player object. The unit-frame and world-entry harnesses run the host-lent path.

Tests:
- the scalars read as written;
- the tooltip bar follows each health packet;
- the senders gate on the player object;
- the login's XP check runs through the host.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 20:43:57 +07:00
Sam Sung 3242ef72cc Quest text, quest lines and shares fire at their packets (#2768)
The quest log's text, its turn-in and accept lines, and the share verdicts came from feeds that ran once a frame. A listener inside a quest packet read the last frame's text, and an accept line was lost when a later packet in the frame emptied its slot.

Reference: `GetQuestLogQuestText` expands its `$` macros at the call (`0x4dff89` → `0x506f70`). The slot watcher `0x5ddd80` shows the accept line inside the update packet. The turn-in lines are `0x5dc400`'s.

Changed:
- the text expands at the call;
- the log reads names and records through the host;
- the accept line, the turn-in lines and the share verdicts fire on their lanes at their packets;
- the share line's bounded name wait is kept as on main.

Tests: a listener reads its own packet's quest text, and the accept line shows at the packet that fills the slot.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 19:49:41 +07:00
Sam Sung 289b0ec5f6 Tooltips, spell targeting and the mouseover read live at the call (#2767)
Spell and aura tooltips, `SpellCanTargetUnit` and the `"mouseover"` getters read a copy pushed once a frame. A listener inside a packet saw the last frame's values, and `GetRaidTargetIndex("mouseover")` was always nil.

Reference: the setters build the view at the call (`0x52e610`, `0x52f880`). `SpellCanTargetUnit` reads the unit and range at the call (`0x6e6d00` → `0x6e6460`). A reagent's record answer rebuilds a shown spell tooltip (`0x52f820`).

Changed:
- the setters build through the call host;
- the frame feed and its re-push machinery are gone;
- targeting and the mouseover read live;
- a reagent's answer rebuilds the shown tooltip.

The hover's guard rows cite the cache callbacks that rebuild it inside packets.

Tests: a trainer listener's `SetSpell` reads its own packet's cost. Also covered: `SpellCanTargetUnit` out of range, the mouseover mark, the reagent rebuild, and the pet and aura views.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:54:06 +07:00
Sam Sung b4d0987ab0 The loot window reads live and signals at its packets (#2765)
The loot window's getters read a copy the feed pushed once a frame, and its events fired from that feed. An addon reading the window inside a loot event saw the last frame's rows.

Reference: the loot response handler fills the window and signals LOOT_OPENED at its packet. A removal signals LOOT_SLOT_CLEARED (`0x4c1f77`) and then closes an emptied window (`0x4c1f7f`). The master-loot list (`0x61c550`) names its candidates from the name cache alone.

Changed: the getters read the live window, and each event goes on the loot lane at the packet that raises it. A listener's close sends one release. A refused master-loot list frees its push (`0x491ee0`). A removal with no window open still signals its clear.

Tests: loot tests cover the order around a close, a lockbox, auto-loot and master loot.

Part of #2168.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 18:01:49 +07:00
Sam Sung 12ec14d6b9 World entry fires as one item at the create, in the cascade's order (#2762)
World entry was spread over the frame's systems, so `PLAYER_ENTERING_WORLD` fired before every lane item of its frame, and its cascade's resets landed out of order. In 1.12.1 the arrival `0x5dea50` runs inside the create (`PostInit 0x5debe0`) and calls the cascade `0x4908c0` in order.

- The arrival is one item on an `arrival` lane, stamped at the create. It runs its legs in order: the book replay, then each form's UPDATE_SHAPESHIFT_FORMS against the stored list, the slot pass, the cascade with its resets and corpse step, the death state and `LOGOUT_CANCEL`. A /reload pushes the cascade alone.
- System chat is held behind the display latch `0x8435fc` until the cascade releases it (`0x490974`). The leave sweep sets it, and the name and text are composed at the packet.
- The party catch-up fires after PEW.

Each change has a test that fails without it. Part of #2168 and #2217.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 16:44:55 +07:00
Sam Sung 831310c1f2 The auction sell slot asks for a missing record, redrawing when it lands (#2760)
An item put in the auction sell slot before its record was cached showed a price and deposit of 0 until something else redrew the frame. In 1.12.1, `CalculateAuctionDeposit` and `GetAuctionSellItemInfo` ask for the record with the callback `0x4ce2f0` (`0x4ce25e`, `0x4ce5e3`). It signals `NEW_AUCTION_UPDATE` when the record is found (`0x4ce2ff`).

Both getters now ask, gated on the item's object (`0x468460`), with the item's own guid (`0x4ce263`, `0x4ce5e8`). Each asking call keeps its callback, and the event goes on the house lane. On a miss they return the reference's empty shape: a deposit of 0, and `nil, nil, 1, -1, nil, 0` (`0x4ce726`). The deposit does no lookup with no house (`0x4ce1f7`). With a host, the name, icon, quality and price read live.

Tests: a record that lands later fires the event once per call and then answers; a gone object asks nothing.

Fixes #2747

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-28 14:22:53 +07:00
Sam Sung 53bc8245b7 Every item action sends ahead of its cursor clear's and lock's signals (#2759)
Every item action queued its packet for after its Lua call, so the cursor clear's and the lock's listeners ran before the packet went out. In 1.12.1 each sends first, then clears or locks. Examples: `AutoEquipCursorItem` (send at `0x5e1757`, clear at `0x5e1763`), the split (`0x4f9e43`, then `0x4f9e4f`), `DeleteCursorItem` (`0x4898a3`, `0x4898af`), the bank and sale arms (`0x4fa305`, then the lock at `0x4fa312`), and the merchant sell (`0x4fb7a7`, `0x4fb7b3`).

Every item send now goes to the host in place, ahead of its clear's or lock's signals, and `Model::item_calls` is gone. The projectile unlock is decided once, from the item's record (`0x5d9f30`). A set refused with no control plays no pickup sound (`0x494b8d`).

Tests cover 16 paths, in the order each sends and signals. Each fails on main.

Fixes #2752

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 14:01:42 +07:00
Sam Sung 91dbe0666e A world click's arm picks inside its call, from a key or a handler too (#2758)
A mouse command run from a key binding or a handler picked and clicked only after the record's walk returned. So a body `CameraOrSelectOrMoveStart(); CameraOrSelectOrMoveStop(); print(UnitName("target"))` printed the old target. In 1.12.1 `ArmClick` picks inside the Start's call (`0x5141ae` → `0x514810` → `0x481f00`), at the cursor stored from the last mouse event (`0x481f1d`), and the Stop dispatches inside its own.

The records' walk now lends a tracer beside the call host, so an arm picks inside its call at its record's cursor: one trace per arm, and no new schedule ambiguity. The pick traces the world alone (`0x481190`), never a nameplate. The GameObject pick set is now one resource, kept every frame ahead of the input.

Tests cover a key body, an `OnClick` body, the target event in the handler, a key-armed pick under a plate, and a chest clicked by mouse and by key.

Fixes #2749

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 13:45:10 +07:00
Sam Sung 07ba2b0e8b Mail send item, stationery list and texture read as 1.12.1 reads them (#2757)
Three mail getters differed from 1.12.1.

- **#2739.** `GetSendMailItem` asked nothing on a missing record. Now, with the attachment's object present (`0x4ae5e1`), it asks with the callback `0x4ae710`, which signals `MAIL_SEND_INFO_UPDATE` once per call on arrival.
- **#2740.** The usable stationery list was rebuilt every frame. Now it is rebuilt (`0x4ad970`) only at the world-enter init (`0x4acbd7`), at the last missing paper's answer (`0x4acbf8`), and at `GetNumStationeries` with nothing awaited (`0x4ae202`). The getters read it as last rebuilt. With no player a rebuild keeps the list (`0x4ad9aa`), and leaving the world cancels the paper waits (`0x4acc00`).
- **#2741.** `GetSelectedStationeryTexture` reads the Stationery store by id (`0x4ae3f0`), not the usable list.

Each fix has a test that fails without it.

Fixes #2739
Fixes #2740
Fixes #2741

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 12:37:13 +07:00
Sam Sung 62399b7a05 Auction getters read the house live; its events fire at their packet (#2754)
The auction window reached the interface through a per-frame feed. Its events fired ahead of the frame's other packets, its getters read a pushed copy, and a result's list request went out before its line's listeners. In 1.12.1 the auction handlers signal inside their packet, and the getters read the house at the call.

- **Live reads.** The getters read the house through the host: rows, the browse throttle (`0x4cfbb0`) and the deposit rate (`0x4ce170`).
- **The house lane.** `AUCTION_HOUSE_SHOW` fires in the hello (`0x4cd5e6`). A notice waiting on an item record shows when the record arrives (`0x4cd190`). A nested close acts on the session it closes.
- **Line first.** A started, bid-placed or outbid result shows its line first and does the rest after its listeners (`0x4cc4cc`, `0x4ccfd5`).
- `LatchCloses` is removed; nothing read it.

Each change has a test that fails without it.

Fixes #2426

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 10:50:02 +07:00
Sam Sung 78e360a25b Every saved cache asks again after a disconnect, under one deviation (#2751)
After a disconnect, a game object's name, an item name, a page of text or an NPC's text whose query was in flight at the drop stayed blank until restart. Only some saved caches cleared their lost asks, from four scattered places, and no `Deviation:` line recorded the rule.

In 1.12.1 a saved cache's ask stays "asked" for the rest of the process. `DBCacheClearUnsaved` (`0x555740`) wipes only the unsaved caches. The maintainer ruled that benilla asks again after a reconnect.

One disconnect handler now clears the in-flight asks of all eight saved caches (creatures, game objects, item names, items, NPC text, quests, page text and mail bodies). It keeps their records and refusals, under one `Deviation:` line, and the scattered clears are gone. Test: an ask in flight in each store at a disconnect is asked again after the re-login.

Fixes #2744

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-28 09:54:02 +07:00
Sam Sung fd3639babe A listener unregistered by the one before runs once, then the walk ends (#2750)
An event handler that unregistered the next listener ended the dispatch, as a `Deviation:` on the grounds that 1.12.1 then reads a freed node. That read is settled at the bytes. `SignalEvent` saves the successor before each handler (`0x703ee8`). The unlink zeroes the node's links (`0x70559d`, `0x7055a3`), and the free writes only the block header (`0x645eb0`), so the object survives. The unregistered listener runs once more, then the zero link ends the walk, and the listeners after it miss the event.

The dispatch now does the same, and the `Deviation:` is gone. A self-unregister still reaches its successor. A listener unregistered further on is skipped. One registered during the signal is reached unless the running listener is last. Each case has a test; the two changed ones fail on main.

Fixes #2743

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 09:19:46 +07:00
Sam Sung 15cf220df9 The world click's legs run inside the mouse commands' calls (#2748)
The world click's legs ran after the record's walk returned, so Lua after `CameraOrSelectOrMoveStop` in the same binding body, or a hook around it, read the world as the click found it. In 1.12.1 the release dispatches inside its call (`0x514b70` → `0x481f60`), and the router calls each leg directly, deferring nothing.

- The release's click now runs in the call host through a click applier, in the reference's leg order. On a unit that is trade, pet feed, greeting, then select (`0x49278e`, `0x4927e8`, `0x4927ff`, `0x49280c`). On a right click, the select comes before the interact dispatch (`0x492870`, `0x492881`).
- The press pick is traced ahead of each world press's binding (`0x481f00`).
- A charmed player's click acts on nothing (`0x481f98`), for every leg.

Each change has a test that fails without it.

Fixes #1988

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:53:21 +07:00
Sam Sung 62088a624a The container bound's deviation covers the bank and the keyring (#2746)
In 1.12.1, `GetContainerItemInfo`'s slot mapping bounds the backpack, the bank (base `+0x27`, `0x4f98ae`) and the keyring (base `+0x51`, `0x4f98c0`) only by the player list's count (`0x4f990f`). An index past a container's own size reads the next container's slots: `GetContainerItemInfo(-1, 25)` reads the first bank bag's slot.

benilla bounds all three by their own slots, but the recorded deviation named only the backpack. The maintainer ruled that the bank and the keyring take the same deviation for the same reason, a reference bug. The `Deviation:` line now covers all three. No behaviour changes.

Fixes #2617

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:26:53 +07:00
Sam Sung 194b7ee766 A path ends with the unit turned to the packet's final facing (#2745)
A path ends with the unit turned to the packet's final facing, as 1.12.1 leaves it.

- A monster move that installs a path stores its final facing on the spline (`0x618840`-`0x6188a0`). Only a move with no path turns the unit on arrival.
- At the path's end, `0x61a882` writes the facing in this order:
  - Angle, as sent;
  - Target, the heading to where that unit stands (`0x61a8c1`), from the deck-local end on a transport;
  - Spot, through `0x47f220`.
- The turn runs through the facing smoother (`0x600cd0`), never a snap. The display facing resets only at create and reactivate.
- `heading_between` ports `0x47f220`'s fixed headings for a point under the unit.

Each change has a test that fails without it.

First diagnosed and drafted by @kalistoking in #2695.

Co-authored-by: kalistoking <148718830+kalistoking@users.noreply.github.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:07:42 +07:00
Sam Sung 1a78118fcb Mail getters read the session live; its events fire at their packet (#2742)
The mail window reached the interface through a per-frame feed. Its events fired ahead of the frame's other packets, and its getters read a pushed copy. In 1.12.1 the mail handlers signal inside their packet, and the getters read the session at the call.

- The getters read the session through the host (`MailLive`). Every mail event goes on a mail lane, stamped in the handler that raises it.
- Each answered record lookup signals one `MAIL_INBOX_UPDATE`, only when the record is found (`0x4af080`, `0x4af0a0`, `0x4af340`, `0x4af5b0`, `0x4ad010`).
- The pending step runs after the frame's packets and after the walk-away check (`0x4818c0`, `0x4818d0`).
- A close in its open's frame no longer fires `MAIL_CLOSED` without `MAIL_SHOW`, or sends its query ahead of earlier events.

Each change has a test that fails without it. Part of #2168 and #2217.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 07:37:27 +07:00
Sam Sung c1507a281c Trade getters read the session live; its events fire at their packet (#2736)
The trade window reached the interface through a per-frame feed, so its events fired ahead of the frame's other packets and its getters read a VM copy. In 1.12.1 the trade status handler (`0x4bfa08`'s cases) signals inside the packet, and the getters read the session at the call.

- The getters read the session through the host. Every trade signal goes on a trade lane, stamped in its handler.
- A request's checks run inside BEGIN_TRADE, with the ignore list ahead of the object lookup (`0x4bf750`).
- Our slots 1-6 raise no TRADE_PLAYER_ITEM_CHANGED from the status (`0x4bf2b0`).
- A close waits behind the open it closes, cancel included (`0x4bf527`, `0x493365`).
- Status 12 prints its line before the close (`0x4bf88e`).
- A chat-kind line raised in a Lua call fires inside it (`0x496842` → `0x49a870`).

Each change has a test that fails without it. Part of #2168 and #2217.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 05:37:22 +07:00
Sam Sung d9039e6db9 Pet cooldowns, happiness and unit auras are written at their packet (#2734)
Aura and pet state reached the interface from per-frame feeds, so a listener at one packet read the frame's final state. In 1.12.1 each is written where its packet or call makes it.

- **Pet GCD.** A pet cast's global cooldown is armed in the pet bar at the send (`0x6e58fb`), inside the cast.
- **Happiness.** `UNIT_HAPPINESS` fires from the field watch (`0x515e7a`) inside its packet.
- **Unit auras.** The aura getters read the unit's store live.
- **Dispel list.** It is kept from the learn (`0x4b26a2`-`0x4b26ee`), so an unlearn leaves it.
- **World entry.** The cascade rebuilds the buff cache at `0x490983`, so `PLAYER_AURAS_CHANGED` follows `PLAYER_ENTERING_WORLD` and comes ahead of the bag updates.

Each fix has a test that fails without it. Part of #2168 and #2217.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 04:56:23 +07:00
Sam Sung fcc83ee96b The mouse commands arm and release the world click at their record (#2732)
The world click was resolved in the look session, frames after the mouse command that made it. In 1.12.1, `CameraOrSelectOrMoveStart` and `TurnOrActionStart` arm it inside their call: `ArmClick 0x514810` picks under the press (`PickAtCursor 0x481190`), and the last primary's release dispatches it (`0x514b70` → `0x481f60`). The VM now keeps the command bits, and the click applies at the record whose binding made it.

Changes:
- The world frame's right-press hook `0x492c20` now runs whole, ahead of the binding (`0x483c62`, `0x483c93`): it cancels targeting, clears a pending wrap, and ends repair mode. It does not run on a press `0x492b50` eats.
- The loading cover, a bindingless right release, and a reload's cascade (`0x49093c` → `0x5144c0`) free the bits.
- The release counts its own frame's travel.

Tests cover each. The click's legs still run after the walk, not inside the call: part of #1988.

Fixes #2729

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 04:30:42 +07:00
Sam Sung 09c276fe97 Bag and item reads answer as of their packet; logout reads no player (#2728)
Bag and item reads now answer as of the listener's own packet, not the frame's end, and the logout reads what 1.12.1 has there.

- The bag getters read the player's bags, the bank and the keyring live. Item and container writes go into the view log, so a listener sees its packet's slots, stacks and bags.
- The loot close's two unlocks fire at its packet (`0x48f2bd`, `0x4c1d36`). A wrong-bag refusal names the bag its packet found (`0x5e3a1e` → `0x5ede00`).
- At logout the object manager goes before PLAYER_LOGOUT fires (`0x46771e`, `0x490c2a`). The inventory getters then answer nothing with no active player (`0x4944a0` → `0x4c8c56`). `UnitName("player")` keeps the character's name.
- The item tooltip feed follows record changes by cursor. The suffix template is copied after the frame's Lua.

Each change has a test that fails without it. flip_readiness falls to 92 rows.

Fixes #2725
Refs #2168
Refs #2217

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 01:52:03 +07:00
Sam Sung 7c7a7f3e7c The verb census sweeps the whole suite and counts writes after a signal (#2726)
The census that finds Lua verbs whose work outruns their signals now sweeps the whole suite. It also counts state a lend writes while a handler is held, which a late listener would read and no send shows.

- Over 12,964 tests, one verb sends ahead of its signals: `UseAction`, V2's.
- An accepted item swap is in order: its send (`0x5e0fdb`) comes before the cursor clear (`0x5e0fe7`).
- One write after a held signal: a target clear's strike-cancel report waits behind the action bar's usable refresh (`0x493a08`, `0x493a18`, `0x493a69`, `0x493a73`). It is now listed, with its test.

All of it is test-only; the player build is unchanged.

Refs #2271
Refs #2202

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-28 01:29:40 +07:00
Sam Sung 39de572fc1 Transport props animate and cull with their ship, engine sound included (#2724)
Transports' props animate and cull with their ship, as in 1.12.1.

- A carried prop's world sphere comes from its host's pose every frame. The tick re-poses a transport's doodad defs before the cull (`0x6709a0` → `0x698f50` → `0x6a2070` → `0x6a81d0`), so a ship's parts stay drawn wherever it is.
- A transport's props play the ship's phase (`0x5f52f9` → `0x6709f0` → `0x6a24b0` → `0x6a20f0`), with window ends chained through `0x5f49b0`. A carried play cross-fades over its sequence's blend time (`0x6a2128`). The zeppelin's engine `$DSL` keys sit in its moving sequences (0xa2, 0xa3), so its engine is heard now. Before, its props looped Stand.
- The transport and lift loaders guard the reference's own faults as `Deviation:` lines: unwritten leg lengths, an unbounded append, a zero divide (`0x5f62a4`), an endless seek.
- A whole-period test of the Booty Bay–Ratchet path.

Each change has a test that fails without it.

Fixes #1210
Fixes #1221
Refs #1220

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 00:00:49 +07:00
Sam Sung 6ee671bcca Our player's create does its own writes inside its packet (#2723)
Our player's create now does its own writes inside the update packet, at the end of its create step (`0x5dec7b`), as 1.12.1's PostInit does:

- SelfPlayer is tagged in the create's own commands, so a later packet in the same frame finds us tagged and in control.
- The control flag and its two signals (`0x5deb56`), gated on `+0xc8` (`0x5deb49`).
- `CMSG_SET_ACTIVE_MOVER`, sent only when the mover changes (`0x6006ee`-`0x6006fb`). The mover clears at world entry, at the unit's destructor, at a release and at a control stop.
- The cascade message (`0x5deb60`), then the class family (`0x5debcc`).

The movement lock moves to its own resource. Only the arrival writes it, so a `/reload` while feared or possessing leaves it alone, since 1.12.1's reload runs only `0x4908c0`.

Each change has a test that fails without it. flip_readiness falls to 96 rows.

Refs #2168
Refs #2217

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 23:41:24 +07:00